@toptal/davinci-engine 10.5.5 → 10.5.6

package/src/commands/size.js

@@ -7,10 +7,8 @@ import globby from 'globby'
 import bytes from 'bytes'
 
 import { paths } from '../configs/paths.js'
-
 const successExitCode = 0
 const errorExitCode = 1
-
 const calcPercentageChange = (limit, size) => {
   if (size === 0) {
     return limit * 100
@@ -21,16 +19,13 @@ const calcPercentageChange = (limit, size) => {
 
   return ((size - limit) / limit) * 100
 }
-
 const formatChange = limit => Math.abs(Math.floor(limit))
-
 const checkBundleSize = async (files, limitInBytes) => {
   const result = await sizeLimit([filePlugin], files)
 
   if (!result) {
     panic('Unable to check bundle size')
   }
-
   const size = result[0].size
 
   if (size > limitInBytes) {
@@ -39,7 +34,6 @@ const checkBundleSize = async (files, limitInBytes) => {
     print.success(generateMessage(size, limitInBytes))
   }
 }
-
 const checkSizeOfEachChunk = async (files, maxChunksLimitInBytes) => {
   const chunksExceedingLimit = []
 
@@ -53,7 +47,6 @@ const checkSizeOfEachChunk = async (files, maxChunksLimitInBytes) => {
       })
     }
   }
-
   if (chunksExceedingLimit.length > 0) {
     chunksExceedingLimit.forEach(chunk => {
       print.red(
@@ -64,14 +57,12 @@ const checkSizeOfEachChunk = async (files, maxChunksLimitInBytes) => {
     })
     process.exit(errorExitCode)
   }
-
   print.success(
     `All chunks are ok. Each of them is smaller than ${bytes(
       maxChunksLimitInBytes
     )} limit.`
   )
 }
-
 const generateMessage = (size, limit, isLarger) => {
   const change = formatChange(calcPercentageChange(limit, size))
 
@@ -81,15 +72,12 @@ const generateMessage = (size, limit, isLarger) => {
     limit
   )} limit.\nTo perform a more in-depth analysis of your bundle run "davinci-engine analyze"`
 }
-
 const panic = message => {
   print.red(message)
   process.exit(errorExitCode)
 }
-
 const sizeCommand = async ({ limit, maxChunkSize }) => {
   print.header('Checking bundle size')
-
   const limitInBytes = typeof limit === 'number' ? limit : bytes(limit)
   const maxChunksLimitInBytes =
     typeof maxChunkSize === 'number' ? limit : bytes(maxChunkSize)
@@ -99,44 +87,38 @@ const sizeCommand = async ({ limit, maxChunkSize }) => {
       `Build directory ${paths.appBuild} appears to be empty. Please build your app before running this command.`
     )
   }
-
   const files = await globby(path.join(paths.appBuild, '**/*.js'))
 
   if (!limit && !maxChunkSize) {
     print.grey(`No limit provided. Skipping size check.\n`)
     process.exit(successExitCode)
   }
-
   try {
     if (limit) {
       await checkBundleSize(files, limitInBytes)
     }
-
     if (maxChunkSize) {
       await checkSizeOfEachChunk(files, maxChunksLimitInBytes)
     }
-
     process.exit(successExitCode)
   } catch (e) {
     panic(`${e.stack || e}\n`)
   }
 }
 
-const sizeCommandCreator = {
-  action: sizeCommand,
-  command: 'size',
-  description:
-    'Checks the bundle size against provided limit — fails if limit is exceeded.',
-  options: [
-    {
-      label: 'limit to check the size against: 2.5Mb, 1337Kb, etc',
-      name: '--limit <limit>',
-    },
-    {
-      label: 'max allowed chunk size: 100Kb, 1Mb, etc',
-      name: '--maxChunkSize <maxChunkSize>',
-    },
-  ],
+export const createSizeCommand = program => {
+  return program
+    .createCommand('size')
+    .description(
+      'Checks the bundle size against provided limit — fails if limit is exceeded.'
+    )
+    .action(sizeCommand)
+    .option(
+      '--limit <limit>',
+      'limit to check the size against: 2.5Mb, 1337Kb, etc'
+    )
+    .option(
+      '--maxChunkSize <maxChunkSize>',
+      'max allowed chunk size: 100Kb, 1Mb, etc'
+    )
 }
-
-export default sizeCommandCreator

package/src/commands/size.test.js

@@ -1,7 +1,24 @@
-import sizeCommandCreator from './size.js'
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { jest } from '@jest/globals'
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Command } from 'commander'
 
-describe('sizeCommandCreator', () => {
-  it('has the correct command structure', () => {
-    expect(sizeCommandCreator).toMatchSnapshot()
+const { createSizeCommand } = await import('./size.js')
+
+describe('createSizeCommand', () => {
+  let program
+
+  beforeEach(() => {
+    program = new Command()
+  })
+
+  afterEach(() => {
+    jest.clearAllMocks()
+  })
+
+  it('creates a command with the correct parameters', () => {
+    const command = createSizeCommand(program)
+
+    expect(JSON.stringify(command, null, 2)).toMatchSnapshot()
   })
 })

package/src/index.js

@@ -1,11 +1,11 @@
 import { createStartCommand } from './commands/start.js'
-import buildCommandCreator from './commands/build.js'
-import compilePackageCommandCreator from './commands/compile-package.js'
-import publishPackageCommandCreator from './commands/publish-package.js'
-import releasePackageCommandCreator from './commands/release-package.js'
-import analyzeCommandCreator from './commands/analyze.js'
-import sizeCommandCreator from './commands/size.js'
-import sentryUploadSourceMaps from './commands/sentry-upload-sourcemaps.js'
+import { createBuildCommand } from './commands/build.js'
+import { createCompilePackageCommand } from './commands/compile-package.js'
+import { createPublishPackageCommand } from './commands/publish-package.js'
+import { createReleasePackageCommand } from './commands/release-package.js'
+import { createAnalyzeCommand } from './commands/analyze.js'
+import { createSizeCommand } from './commands/size.js'
+import { createSentryUploadSourceMapsCommand } from './commands/sentry-upload-sourcemaps.js'
 import createWebpackConfig from './configs/webpack-config/index.js'
 import { getWorkspaceRoot, getEnvVariables } from './utils/index.js'
 import jscOptions from './configs/swc/.swcrc.js'
@@ -20,13 +20,13 @@ export { default as createWebpackConfig } from './configs/webpack-config/index.j
 
 export const commands = [
   createStartCommand,
-  buildCommandCreator,
-  compilePackageCommandCreator,
-  publishPackageCommandCreator,
-  releasePackageCommandCreator,
-  analyzeCommandCreator,
-  sizeCommandCreator,
-  sentryUploadSourceMaps,
+  createBuildCommand,
+  createCompilePackageCommand,
+  createPublishPackageCommand,
+  createReleasePackageCommand,
+  createAnalyzeCommand,
+  createSizeCommand,
+  createSentryUploadSourceMapsCommand,
 ]
 
 export default {