@toptal/davinci-cli-shared 2.3.1-alpha-CRT-5891-create-coverage-command-3e3ae146.46 → 2.3.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Change Log
 
+## 2.3.1
+
+### Patch Changes
+
+- [#2021](https://github.com/toptal/davinci/pull/2021) [`97abce92`](https://github.com/toptal/davinci/commit/97abce922d3a0720e0806ae9cd2f2866f355a1bc) Thanks [@dmaklygin](https://github.com/dmaklygin)!
+
+---
+
+- remove legacy command builder
+
 ## 2.3.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-cli-shared",
-  "version": "2.3.1-alpha-CRT-5891-create-coverage-command-3e3ae146.46+3e3ae146",
+  "version": "2.3.1",
   "description": "Shared CLI code and CLI engine for davinci",
   "publishConfig": {
     "access": "public"
@@ -23,21 +23,20 @@
   "dependencies": {
     "analytics-node": "^6.2.0",
     "chalk": "^4.1.2",
-    "commander": "^10.0.0",
     "execa": "^5.1.1",
     "find-yarn-workspace-root": "^2.0.0",
-    "gradient-string": "^2.0.0",
     "inquirer": "^8.2.0",
     "isomorphic-git": "^1.21.0",
     "js-yaml": "^4.1.0",
     "lodash": "^4.17.21",
-    "ora": "^5.4.1",
     "proper-lockfile": "^4.1.2",
     "read-pkg-up": "7.0.1",
-    "semver": "^7.3.7"
+    "semver": "^7.3.7",
+    "commander": "^10.0.0",
+    "gradient-string": "^2.0.0",
+    "ora": "^5.4.1"
   },
   "devDependencies": {
     "@jest/globals": "^29.4.2"
-  },
-  "gitHead": "3e3ae146eca363a09b91658e20d7295f9934b977"
+  }
 }

package/src/lib/command.js

@@ -1,4 +1,4 @@
-import { Argument, Command } from 'commander'
+import { Command } from 'commander'
 
 import { createMetricsSidecar } from '../utils/metrics/sidecar.js'
 
@@ -54,51 +54,10 @@ class DavinciCommand extends Command {
     return new DavinciCommand(name, this._packageName)
   }
 
-  /**
-   * Creates a new command from legacy data.
-   *
-   * @param {Object} data The legacy data for the new command
-   * @returns {DavinciCommand} The newly created `DavinciCommand` instance
-   */
-  createCommandFromLegacy({
-    command,
-    description = '',
-    args = [],
-    options = [],
-    allowUnknownOptions = false,
-    action,
-    isDefault = false,
-  }) {
-    const currentCommand = this.command(command, { isDefault })
-
-    args.forEach(argument => {
-      if (argument instanceof Argument) {
-        currentCommand.addArgument(argument)
-      } else {
-        currentCommand.argument(...argument)
-      }
-    })
-
-    options.forEach(option =>
-      currentCommand.option(option.name, option.label, option.default)
-    )
-
-    if (allowUnknownOptions) {
-      currentCommand.allowUnknownOption()
-    }
-
-    currentCommand.description(description).action(action)
-
-    return currentCommand
-  }
-
   createCommands(commandCreators) {
     commandCreators.forEach(commandCreator => {
       if (typeof commandCreator === 'function') {
         this.addCommand(commandCreator(this))
-      } else if (!(commandCreator instanceof Command)) {
-        // legacy
-        this.createCommandFromLegacy(commandCreator)
       } else {
         this.addCommand(commandCreator)
       }

package/src/lib/command.test.js

@@ -1,5 +1,4 @@
 import { jest } from '@jest/globals'
-import { createArgument } from 'commander'
 
 jest.unstable_mockModule('../utils/metrics/sidecar.js', () => ({
   createMetricsSidecar: jest.fn(),
@@ -78,30 +77,4 @@ describe('DavinciCommand', () => {
       expect(childCommand.getPackageName()).toBe('foo')
     })
   })
-
-  describe('createCommandFromLegacy', () => {
-    it('creates a new command from legacy data', () => {
-      const parentCommand = new DavinciCommand('parent')
-      const command = parentCommand.createCommandFromLegacy({
-        command: 'child',
-        description: 'description',
-        args: [
-          createArgument('<templateName>', 'Name of template').choices([
-            'component',
-            'page',
-          ]),
-          [
-            '<appName>',
-            'Application Name: folder name for the new application',
-          ],
-        ],
-        options: [{ name: '-f, --flag', label: 'description', default: false }],
-        allowUnknownOptions: true,
-        action: jest.fn(),
-        isDefault: true,
-      })
-
-      expect(command).toMatchSnapshot()
-    })
-  })
 })

package/src/lib/__snapshots__/command.test.js.snap

@@ -1,166 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`DavinciCommand createCommandFromLegacy creates a new command from legacy data 1`] = `
-DavinciCommand {
-  "_actionHandler": [Function],
-  "_addImplicitHelpCommand": undefined,
-  "_aliases": [],
-  "_allowExcessArguments": true,
-  "_allowUnknownOption": true,
-  "_args": [
-    Argument {
-      "_name": "templateName",
-      "argChoices": [
-        "component",
-        "page",
-      ],
-      "defaultValue": undefined,
-      "defaultValueDescription": undefined,
-      "description": "Name of template",
-      "parseArg": [Function],
-      "required": true,
-      "variadic": false,
-    },
-    Argument {
-      "_name": "appName",
-      "argChoices": undefined,
-      "defaultValue": undefined,
-      "defaultValueDescription": undefined,
-      "description": "Application Name: folder name for the new application",
-      "parseArg": undefined,
-      "required": true,
-      "variadic": false,
-    },
-  ],
-  "_argsDescription": undefined,
-  "_combineFlagAndOptionalValue": true,
-  "_defaultCommandName": null,
-  "_description": "description",
-  "_enablePositionalOptions": false,
-  "_events": {
-    "option:flag": [Function],
-  },
-  "_eventsCount": 1,
-  "_executableDir": null,
-  "_executableFile": null,
-  "_executableHandler": false,
-  "_exitCallback": null,
-  "_hasHelpOption": true,
-  "_helpCommandDescription": "display help for command",
-  "_helpCommandName": "help",
-  "_helpCommandnameAndArgs": "help [command]",
-  "_helpConfiguration": {},
-  "_helpDescription": "display help for command",
-  "_helpFlags": "-h, --help",
-  "_helpLongFlag": "--help",
-  "_helpShortFlag": "-h",
-  "_hidden": false,
-  "_lifeCycleHooks": {},
-  "_maxListeners": undefined,
-  "_name": "child",
-  "_optionValueSources": {
-    "flag": "default",
-  },
-  "_optionValues": {
-    "flag": false,
-  },
-  "_outputConfiguration": {
-    "getErrHelpWidth": [Function],
-    "getOutHelpWidth": [Function],
-    "outputError": [Function],
-    "writeErr": [Function],
-    "writeOut": [Function],
-  },
-  "_packageName": null,
-  "_passThroughOptions": false,
-  "_scriptPath": null,
-  "_showHelpAfterError": false,
-  "_showSuggestionAfterError": true,
-  "_storeOptionsAsProperties": false,
-  "_summary": "",
-  "args": [],
-  "commands": [],
-  "options": [
-    Option {
-      "argChoices": undefined,
-      "conflictsWith": [],
-      "defaultValue": false,
-      "defaultValueDescription": undefined,
-      "description": "description",
-      "envVar": undefined,
-      "flags": "-f, --flag",
-      "hidden": false,
-      "implied": undefined,
-      "long": "--flag",
-      "mandatory": false,
-      "negate": false,
-      "optional": false,
-      "parseArg": undefined,
-      "presetArg": undefined,
-      "required": false,
-      "short": "-f",
-      "variadic": false,
-    },
-  ],
-  "parent": DavinciCommand {
-    "_actionHandler": null,
-    "_addImplicitHelpCommand": undefined,
-    "_aliases": [],
-    "_allowExcessArguments": true,
-    "_allowUnknownOption": false,
-    "_args": [],
-    "_argsDescription": undefined,
-    "_combineFlagAndOptionalValue": true,
-    "_defaultCommandName": "child",
-    "_description": "",
-    "_enablePositionalOptions": false,
-    "_events": {},
-    "_eventsCount": 0,
-    "_executableDir": null,
-    "_executableFile": null,
-    "_executableHandler": false,
-    "_exitCallback": null,
-    "_hasHelpOption": true,
-    "_helpCommandDescription": "display help for command",
-    "_helpCommandName": "help",
-    "_helpCommandnameAndArgs": "help [command]",
-    "_helpConfiguration": {},
-    "_helpDescription": "display help for command",
-    "_helpFlags": "-h, --help",
-    "_helpLongFlag": "--help",
-    "_helpShortFlag": "-h",
-    "_hidden": false,
-    "_lifeCycleHooks": {},
-    "_maxListeners": undefined,
-    "_name": "parent",
-    "_optionValueSources": {},
-    "_optionValues": {},
-    "_outputConfiguration": {
-      "getErrHelpWidth": [Function],
-      "getOutHelpWidth": [Function],
-      "outputError": [Function],
-      "writeErr": [Function],
-      "writeOut": [Function],
-    },
-    "_packageName": null,
-    "_passThroughOptions": false,
-    "_scriptPath": null,
-    "_showHelpAfterError": false,
-    "_showSuggestionAfterError": true,
-    "_storeOptionsAsProperties": false,
-    "_summary": "",
-    "args": [],
-    "commands": [
-      [Circular],
-    ],
-    "options": [],
-    "parent": null,
-    "processedArgs": [],
-    "rawArgs": [],
-    Symbol(kCapture): false,
-  },
-  "processedArgs": [],
-  "rawArgs": [],
-  Symbol(kCapture): false,
-}
-`;