@toptal/davinci-ci 5.0.2-alpha-fx-4452-add-tailwindcss-in-davinci-01ccaca7.4 → 6.0.1-alpha-fx-4497-storybook-1c02d54a.1

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Change Log
 
+## 6.0.0
+
+### Major Changes
+
+- [#2208](https://github.com/toptal/davinci/pull/2208) [`0243e42b`](https://github.com/toptal/davinci/commit/0243e42bc12c18acb6c225db73b78729c0b6b422) Thanks [@augustobmoura](https://github.com/augustobmoura)!
+
+### davinci-ci danger
+
+- remove support for conventional commits
+
+### Patch Changes
+
+- [#2215](https://github.com/toptal/davinci/pull/2215) [`7736531e`](https://github.com/toptal/davinci/commit/7736531ebe7d77990f096136f1662c446362428b) Thanks [@TomasSlama](https://github.com/TomasSlama)!
+- bump davinci-cli-shared
+
 ## 5.0.1
 
 ### Patch Changes

package/README.md

@@ -16,8 +16,6 @@ Use it by installing `yarn add @toptal/davinci-ci` in your project.
 
 - `davinci-ci danger` - checks if the PR title and and commit messages comply with [Toptal's standards](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality)
 
-- `davinci-ci danger --conventionalCommits` - checks if the PR title and and commit messages comply with [ConventionalCommits](https://www.conventionalcommits.org/en/v1.0.0/)
-
 To check commit message quality locally just add `--local` argument
 
 `davinci-ci danger --local`
@@ -47,7 +45,6 @@ master:
   deploy_staging: false
   deploy_storybook_staging: false
   deploy: false
-  conventional_commits: false # danger check will require each commit to follow convential commits
   require_assignee: false # danger check will require each PR to have assignee
   require_assignee_whitelist: ['dependabot-preview[bot]', 'dependabot[bot]']
 

package/package.json

@@ -1,18 +1,17 @@
 {
   "name": "@toptal/davinci-ci",
-  "version": "5.0.2-alpha-fx-4452-add-tailwindcss-in-davinci-01ccaca7.4+01ccaca7",
-  "description": "Continuos integrations tools for frontend projects",
-  "publishConfig": {
-    "access": "public"
-  },
+  "version": "6.0.1-alpha-fx-4497-storybook-1c02d54a.1+1c02d54a",
   "keywords": [
-    "jenkins",
+    "ci",
     "docker",
-    "ci"
+    "jenkins"
   ],
+  "description": "Continuos integrations tools for frontend projects",
+  "repository": "toptal/davinci.git",
   "author": "Toptal",
-  "homepage": "https://github.com/toptal/davinci/tree/master/packages/ci#readme",
   "license": "SEE LICENSE IN LICENSE.MD",
+  "bugs": "https://github.com/toptal/davinci/issues",
+  "homepage": "https://github.com/toptal/davinci/tree/master/packages/ci#readme",
   "bin": {
     "davinci-ci": "./bin/davinci-ci.js"
   },
@@ -25,25 +24,22 @@
     "src",
     "CHANGELOG.md"
   ],
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/toptal/davinci.git"
-  },
   "scripts": {
     "test": "NODE_OPTIONS='--experimental-vm-modules --no-warnings' yarn jest"
   },
-  "bugs": {
-    "url": "https://github.com/toptal/davinci/issues"
-  },
   "dependencies": {
     "@commitlint/cli": "^17.6.7",
     "@commitlint/config-conventional": "^17.1.0",
-    "@toptal/davinci-cli-shared": "2.3.8-alpha-fx-4452-add-tailwindcss-in-davinci-01ccaca7.35+01ccaca7",
+    "@toptal/davinci-cli-shared": "2.3.10-alpha-fx-4497-storybook-1c02d54a.8+1c02d54a",
+    "chalk": "^4.1.2",
     "danger": "^11.2.2",
     "markdown-table": "^2.0.0"
   },
   "devDependencies": {
-    "@jest/globals": "^29.4.2"
+    "@jest/globals": "^29.7.0"
+  },
+  "publishConfig": {
+    "access": "public"
   },
-  "gitHead": "01ccaca72ef6505aee5d52146938a1b15d33e18f"
+  "gitHead": "1c02d54a78ae5071678a0fed9a7eb172291ce0fe"
 }

package/src/commands/danger.js

@@ -5,25 +5,27 @@ import {
   convertToCLIParameters,
   files,
 } from '@toptal/davinci-cli-shared'
+import chalk from 'chalk'
 
 export const dangerCommand = options => {
   print.header('Running danger check')
   const { local, dangerfile, ...rest } = options
-  const conventionalCommitsDangerfilePath = files.getPackageFilePath(
-    '@toptal/davinci-ci',
-    'src/configs/danger/conventional-commits/dangerfile.cjs'
-  )
-  const toptalCommitsDangerfilePath = files.getPackageFilePath(
-    '@toptal/davinci-ci',
-    'src/configs/danger/toptal/dangerfile.cjs'
-  )
-  let dangerfilePath = dangerfile
+  const dangerfilePath =
+    dangerfile ??
+    files.getPackageFilePath(
+      '@toptal/davinci-ci',
+      'src/configs/danger/toptal/dangerfile.cjs'
+    )
 
-  if (!dangerfilePath) {
-    dangerfilePath = davinciProjectConfig.master.conventionalCommits
-      ? conventionalCommitsDangerfilePath
-      : toptalCommitsDangerfilePath
+  if (davinciProjectConfig.master.conventionalCommits) {
+    console.log(`\
+${chalk.red(
+  '[UNSUPPORTED]'
+)} Since https://toptal-core.atlassian.net/wiki/x/YQFawQ
+Convention commits are now discouraged, support for it on davinci have been removed. Please use toptal commits instead.`)
+    process.exit(10)
   }
+
   runSync(
     'yarn',
     [

package/src/index.cjs

@@ -1,11 +1,16 @@
+const chalk = require('chalk')
+
 const toptalPlugins = require('./configs/danger/toptal/plugins/index.cjs')
-const conventionalCommitsPlugins = require('./configs/danger/conventional-commits/plugins/index.cjs')
 
 module.exports = {
   plugins: {
-    conventionalCommit: {
-      PRTitle: conventionalCommitsPlugins.conventionalPRTitle,
-      commits: conventionalCommitsPlugins.conventionalCommits,
+    get conventionalCommit() {
+      console.log(`\
+${chalk.red(
+  '[UNSUPPORTED]'
+)} Since https://toptal-core.atlassian.net/wiki/x/YQFawQ
+Convention commits are now discouraged, support for it on davinci have been removed. Please use toptal commits instead.`)
+      throw Error('conventionalCommit is not supported anymore')
     },
     toptal: {
       PRTitle: toptalPlugins.toptalPRTitle,

package/src/configs/danger/conventional-commits/dangerfile.cjs

@@ -1,23 +0,0 @@
-const { schedule } = require('danger')
-const {
-  config: davinciProjectConfig,
-} = require('@toptal/davinci-cli-shared/config')
-
-const {
-  conventionalCommits,
-} = require('./plugins/conventional-commits/index.cjs')
-const {
-  conventionalPRTitle,
-} = require('./plugins/conventional-pr-title/index.cjs')
-const { checkAssigneeExist } = require('../plugins/empty-assignee.cjs')
-
-schedule(conventionalCommits)
-schedule(conventionalPRTitle)
-
-const {
-  master: { requireAssignee },
-} = davinciProjectConfig
-
-if (requireAssignee) {
-  schedule(checkAssigneeExist)
-}

package/src/configs/danger/conventional-commits/plugins/conventional-commits/index.cjs

@@ -1,52 +0,0 @@
-/* globals danger, fail */
-/* eslint-disable import/no-extraneous-dependencies */
-const { default: load } = require('@commitlint/load')
-const { default: lint } = require('@commitlint/lint')
-/* eslint-enable */
-const table = require('markdown-table')
-
-const { WHITELISTED_USERS } = require('../../../toptal/config.cjs')
-
-const conventionalCommits = async () => {
-  if (
-    danger.github &&
-    WHITELISTED_USERS.includes(danger.github.pr.user.login)
-  ) {
-    return
-  }
-
-  const { commits } = danger.git
-  const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional'],
-  })
-
-  commits.forEach(async commit => {
-    const result = await lint(
-      commit.message,
-      rules,
-      parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
-    )
-
-    if (!result.valid) {
-      if (result.errors.length > 0) {
-        let message = `The commit - ${commit.sha.trim()} doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n`
-
-        message += table([
-          ['Message'],
-          ...result.errors.map(error => [error.message]),
-        ])
-
-        message +=
-          '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
-        message +=
-          '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
-
-        fail(message)
-      }
-    }
-  })
-}
-
-module.exports = {
-  conventionalCommits,
-}

package/src/configs/danger/conventional-commits/plugins/conventional-pr-title/index.cjs

@@ -1,53 +0,0 @@
-/// <reference types="danger" />
-/* globals danger, fail */
-/* eslint-disable import/no-extraneous-dependencies */
-const { default: load } = require('@commitlint/load')
-const { default: lint } = require('@commitlint/lint')
-/* eslint-enable */
-const table = require('markdown-table')
-
-const { WHITELISTED_USERS } = require('../../../toptal/config.cjs')
-
-const conventionalPRTitle = async () => {
-  if (!danger.github) {
-    return
-  }
-
-  if (WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
-    return
-  }
-
-  const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional'],
-  })
-  const { title } = danger.github.pr
-
-  const result = await lint(
-    title,
-    rules,
-    parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
-  )
-
-  if (!result.valid) {
-    if (result.errors.length > 0) {
-      let message =
-        "PR title doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n"
-
-      message += table([
-        ['Message'],
-        ...result.errors.map(error => [error.message]),
-      ])
-
-      message +=
-        '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
-      message +=
-        '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
-
-      fail(message)
-    }
-  }
-}
-
-module.exports = {
-  conventionalPRTitle,
-}

package/src/configs/danger/conventional-commits/plugins/index.cjs

@@ -1,7 +0,0 @@
-const { conventionalCommits } = require('./conventional-commits/index.cjs')
-const { conventionalPRTitle } = require('./conventional-pr-title/index.cjs')
-
-module.exports = {
-  conventionalCommits,
-  conventionalPRTitle,
-}