@toptal/davinci-ci 2.0.8 → 2.0.9-alpha-fx-2996-add-error-message-for-missing-engine.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-ci",
-  "version": "2.0.8",
+  "version": "2.0.9-alpha-fx-2996-add-error-message-for-missing-engine.15+227d5ea7",
   "description": "Continuos integrations tools for frontend projects",
   "publishConfig": {
     "access": "public"
@@ -32,8 +32,9 @@
   "dependencies": {
     "@commitlint/cli": "^17.0.2",
     "@commitlint/config-conventional": "^17.0.3",
-    "@toptal/davinci-cli-shared": "1.6.0",
+    "@toptal/davinci-cli-shared": "1.6.1-alpha-fx-2996-add-error-message-for-missing-engine.21+227d5ea7",
     "danger": "^11.0.7",
     "markdown-table": "^2.0.0"
-  }
+  },
+  "gitHead": "227d5ea750c2b2ce9f4abd1ff33bbe1838ae9d28"
 }

package/src/configs/jobs/deploy-helm-run/Jenkinsfile

@@ -138,7 +138,7 @@ pipeline {
               -e SENTRY_PROJECT=${REPOSITORY_NAME} \
               -e SENTRY_AUTH_TOKEN=${SENTRY_AUTH_TOKEN} \
               gcr.io/toptal-hub/${REPOSITORY_NAME}:${TAG} \
-              yarn davinci engine sentry-upload-source-maps
+              yarn davinci-engine sentry-upload-source-maps
             """
           } else {
             info "Your current davinci version is not supporting uploading source maps to Sentry. Please update davinci package version in your app."

package/src/configs/jobs/master-main/Jenkinsfile

@@ -273,7 +273,7 @@ pipeline {
       steps {
         script {
           PWD = sh(returnStdout: true, script: 'pwd').trim()
-          releasePackageCommand = 'yarn davinci engine release-package'
+          releasePackageCommand = 'yarn davinci-engine release-package'
 
           def outputVersionParamExistsInDavinci = hasParamInDavinciCommand(
             command: 'engine release-package',

package/src/configs/jobs/publish-alpha-package/Jenkinsfile

@@ -126,7 +126,7 @@ pipeline {
             -v ${PWD}/.git:/app/.git \
             gcr.io/toptal-hub/${repositoryName}:${commitId} \
             /bin/bash -c "yarn ${params.BUILD_PACKAGE_SCRIPT_NAME} && \
-            yarn davinci engine publish-package \
+            yarn davinci-engine publish-package \
             --alpha \
             --outputVersion /artifacts/.version \
             --branch ${sourceBranch}"

package/dist-package/package.json

@@ -1,39 +0,0 @@
-{
-  "name": "@toptal/davinci-ci",
-  "version": "2.0.8",
-  "description": "Continuos integrations tools for frontend projects",
-  "publishConfig": {
-    "access": "public"
-  },
-  "keywords": [
-    "jenkins",
-    "docker",
-    "ci"
-  ],
-  "author": "Toptal",
-  "homepage": "https://github.com/toptal/davinci/tree/master/packages/ci#readme",
-  "license": "ISC",
-  "bin": {
-    "davinci-ci": "./bin/davinci-ci.js"
-  },
-  "main": "./src/index.js",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/toptal/davinci.git"
-  },
-  "scripts": {
-    "build:package": "../../bin/build-package.js",
-    "prepublishOnly": "../../bin/prepublish.js",
-    "test": "echo \"Error: run tests from root\" && exit 1"
-  },
-  "bugs": {
-    "url": "https://github.com/toptal/davinci/issues"
-  },
-  "dependencies": {
-    "@commitlint/cli": "^17.0.2",
-    "@commitlint/config-conventional": "^17.0.3",
-    "@toptal/davinci-cli-shared": "1.6.0",
-    "danger": "^11.0.7",
-    "markdown-table": "^2.0.0"
-  }
-}

package/src/configs/danger/toptal/plugins/toptal-commits/toptal-commits.test.js

@@ -1,128 +0,0 @@
-const { toptalCommits } = require('.')
-
-const prepareCommitsWithMessages = (messages = []) => ({
-  commits: messages.map(message => ({
-    message,
-    sha: '123',
-  })),
-})
-
-describe('commit danger plugin', () => {
-  beforeEach(() => {
-    global.fail = jest.fn()
-    global.danger = {
-      github: {
-        pr: {
-          user: {
-            login: 'user',
-          },
-        },
-      },
-    }
-  })
-
-  afterEach(() => {
-    global.fail = undefined
-    global.danger = undefined
-  })
-
-  it('commit with title only', () => {
-    global.danger.git = prepareCommitsWithMessages(['Hello world'])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with title and body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Hello world\n\nSome commit body here.',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with multi-line body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Hello world\n\nFirst line of commit body\nSecond line of commit body',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with title longer than allowed', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'This commit message is a teeny tiny bit longer than allowed length of 79 characters',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit with body lines longer than allowed', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Short commit title\n\nBut this body line commit message is a bit longer than allowed length of 79 characters\nAnd this one is fine again.',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit message not starting with an uppercase letter', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      '23432 starts with a number',
-      'starts with a lowercase letter',
-      '* starts with a symbol',
-      ' starts with a space',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(4)
-  })
-
-  it('commit message ending with a period in title', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Commit title ending with period.',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit without a blank line between title and body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Commit title\nBody without a blank line after title',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('valid commit titles', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Regular commit title',
-      'Commit with sentence. But does not end with a full-stop',
-      '[FOO-1234] Commit with prefix',
-      '[FOO] Prefix numbers can be omitted',
-      '[FOO][BAR] Prefixes can couple',
-      '[FOO-1234][BAR] Mixed prefixes',
-      '[FOO-1234][BAR-123][BAZ] Everything. Together',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('invalid commit title prefixes', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      '[FOO-1234] commit with lowercase',
-      '[FOO-BAR] Prefix with letter after dash',
-      '[FOO] [BAR] Prefixes with space between',
-      '[FOO]Prefix without space',
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(4)
-  })
-})

package/src/configs/danger/toptal/plugins/toptal-pr-title/toptal-pr-title.test.js

@@ -1,68 +0,0 @@
-const { toptalPRTitle } = require('.')
-const {
-  MISSING_TICKET_CODE_ERROR_MESSAGE,
-  DEFAULT_PR_TITLE_ERROR_MESSAGE,
-} = require('../../config')
-
-const VALID_PR_TITLE = '[ASD-123] Hello world'
-const INVALID_PR_TITLE = '[ASD-123] hello world'
-const NO_TICKET_CODE_PR_TITLE = 'Hello world'
-
-describe('commit danger plugin', () => {
-  beforeEach(() => {
-    global.fail = jest.fn()
-    global.danger = {
-      github: {
-        issue: {
-          labels: [{ name: 'My Team' }],
-        },
-        pr: {
-          title: '',
-          user: {
-            login: 'user',
-          },
-        },
-      },
-    }
-  })
-
-  afterEach(() => {
-    global.fail = undefined
-    global.danger = undefined
-  })
-
-  it('should pass valid PR title', () => {
-    global.danger.github.pr.title = VALID_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('should fail PR title with missing ticket code', () => {
-    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-    expect(global.fail).toHaveBeenCalledWith(MISSING_TICKET_CODE_ERROR_MESSAGE)
-  })
-
-  it('should pass valid PR title with missing ticket code and no-jira label', () => {
-    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
-    global.danger.github.issue.labels = [{ name: 'no-jira' }]
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('should fail invalid PR title', () => {
-    global.danger.github.pr.title = INVALID_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-    expect(global.fail).toHaveBeenCalledWith(DEFAULT_PR_TITLE_ERROR_MESSAGE)
-  })
-})