@toptal/davinci-ci 2.0.15-alpha-fx-3248-update-davinci-to-the-latest-version-containing-metrics-in-talent-portal-frontend-ad7c96d7.8 → 2.1.1-alpha-fix-skeleton-script-a66044fa.2

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # Change Log
 
+## 2.1.0
+
+### Minor Changes
+
+- [#1774](https://github.com/toptal/davinci/pull/1774) [`ca7a20f2`](https://github.com/toptal/davinci/commit/ca7a20f248784371af9db64df31e05ada1e69179) Thanks [@TomasSlama](https://github.com/TomasSlama)! - ---
+
+  ### davinci.yaml (config)
+
+  - add new options to the config
+
+  ```yaml
+  master:
+    # danger check will require every PR
+    # created by not whitelisted user to have an assignee
+    require_assignee: false
+    require_assignee_whitelist: ['dependabot-preview[bot]', 'dependabot[bot]']
+  ```
+
+### Patch Changes
+
+- Updated dependencies [[`ca7a20f2`](https://github.com/toptal/davinci/commit/ca7a20f248784371af9db64df31e05ada1e69179)]:
+  - @toptal/davinci-cli-shared@1.10.0
+
 ## 2.0.14
 
 ### Patch Changes

package/README.md

@@ -47,6 +47,9 @@ master:
   deploy_staging: false
   deploy_storybook_staging: false
   deploy: false
+  conventional_commits: false # danger check will require each commit to follow convential commits
+  require_assignee: false # danger check will require each PR to have assignee
+  require_assignee_whitelist: ['dependabot-preview[bot]', 'dependabot[bot]']
 
 # Customize Slack channel where the notifications will get posted
 slack_channel: 'custom-slack-channel'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-ci",
-  "version": "2.0.15-alpha-fx-3248-update-davinci-to-the-latest-version-containing-metrics-in-talent-portal-frontend-ad7c96d7.8+ad7c96d7",
+  "version": "2.1.1-alpha-fix-skeleton-script-a66044fa.2+a66044fa",
   "description": "Continuos integrations tools for frontend projects",
   "publishConfig": {
     "access": "public"
@@ -32,9 +32,9 @@
   "dependencies": {
     "@commitlint/cli": "^17.0.2",
     "@commitlint/config-conventional": "^17.1.0",
-    "@toptal/davinci-cli-shared": "1.9.1-alpha-fx-3248-update-davinci-to-the-latest-version-containing-metrics-in-talent-portal-frontend-ad7c96d7.8+ad7c96d7",
+    "@toptal/davinci-cli-shared": "1.10.1-alpha-fix-skeleton-script-a66044fa.2+a66044fa",
     "danger": "^11.0.7",
     "markdown-table": "^2.0.0"
   },
-  "gitHead": "ad7c96d778f967e6a6e534b315922f8208cc249c"
+  "gitHead": "a66044fa5edea35b6cc1385f0a11233feaa571d5"
 }

package/src/configs/danger/conventional-commits/dangerfile.js

@@ -1,7 +1,17 @@
 const { schedule } = require('danger')
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
 
 const { conventionalCommits } = require('./plugins/conventional-commits')
 const { conventionalPRTitle } = require('./plugins/conventional-pr-title')
+const { checkAssigneeExist } = require('../plugins/empty-assignee')
 
 schedule(conventionalCommits)
 schedule(conventionalPRTitle)
+
+const {
+  master: { requireAssignee },
+} = davinciProjectConfig
+
+if (requireAssignee) {
+  schedule(checkAssigneeExist)
+}

package/src/configs/danger/plugins/empty-assignee.js

@@ -0,0 +1,24 @@
+/// <reference types="danger" />
+/* globals danger, fail */
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
+
+const {
+  master: { requireAssigneeWhiteList = [] },
+} = davinciProjectConfig
+
+const WHITELISTED_USERS = requireAssigneeWhiteList
+const checkAssigneeExist = () => {
+  const isLocalRun = !danger.github
+
+  if (isLocalRun || WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
+    return
+  }
+
+  if (!danger.github.pr.assignee || danger.github.pr.assignees.length === 0) {
+    fail('Please assign someone to this PR before merging.')
+  }
+}
+
+module.exports = {
+  checkAssigneeExist,
+}

package/src/configs/danger/toptal/dangerfile.js

@@ -1,7 +1,17 @@
 const { schedule } = require('danger')
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
 
 const { toptalCommits } = require('./plugins/toptal-commits')
 const { toptalPRTitle } = require('./plugins/toptal-pr-title')
+const { checkAssigneeExist } = require('../plugins/empty-assignee')
 
 schedule(toptalCommits)
 schedule(toptalPRTitle)
+
+const {
+  master: { requireAssignee },
+} = davinciProjectConfig
+
+if (requireAssignee) {
+  schedule(checkAssigneeExist)
+}

package/src/configs/jobs/deploy-helm-run/Jenkinsfile

@@ -13,7 +13,7 @@ def hasCommandInDavinci(args) {
       docker run \
       --rm \
       -u 469:469 \
-      gcr.io/toptal-hub/${repoName}:${tag} \
+      us-central1-docker.pkg.dev/toptal-hub/containers/${repoName}:${tag} \
       yarn davinci help
     """,
     returnStdout: true
@@ -109,7 +109,7 @@ pipeline {
               HELM_OPTS='\
               $set_params_env \
               --set image.tag=${params.TAG} \
-              --set image.repository=gcr.io/toptal-hub/${params.REPOSITORY_NAME}-release' \
+              --set image.repository=us-central1-docker.pkg.dev/toptal-hub/containers/${params.REPOSITORY_NAME}-release' \
               make $chart $release dep_build upgrade
               """
             }
@@ -137,7 +137,7 @@ pipeline {
               -e SENTRY_ORG=${sentryOrg} \
               -e SENTRY_PROJECT=${REPOSITORY_NAME} \
               -e SENTRY_AUTH_TOKEN=${SENTRY_AUTH_TOKEN} \
-              gcr.io/toptal-hub/${REPOSITORY_NAME}:${TAG} \
+              us-central1-docker.pkg.dev/toptal-hub/containers/${REPOSITORY_NAME}:${TAG} \
               yarn davinci-engine sentry-upload-source-maps
             """
           } else {

package/src/configs/jobs/master-main/Jenkinsfile

@@ -91,7 +91,7 @@ def hasParamInDavinciCommand(args) {
       docker run \
       --rm \
       -u 469:469 \
-      gcr.io/toptal-hub/${repoName}:${tag} \
+      us-central1-docker.pkg.dev/toptal-hub/containers/${repoName}:${tag} \
       yarn davinci help ${command}
     """,
     returnStdout: true
@@ -205,7 +205,7 @@ pipeline {
             -u 469:469 \
             -v ${jenkinsTestsCoverageDirectory}:/app/${testsCoverageDirectory} \
             -v ${jenkinsTestsPactContractsDirectory}:/app/${testsPactsDirectory} \
-            gcr.io/toptal-hub/${repositoryName}:${commitId} \
+            us-central1-docker.pkg.dev/toptal-hub/containers/${repositoryName}:${commitId} \
             yarn test --ci
           """
         }
@@ -231,7 +231,7 @@ pipeline {
             -e GIT_BRANCH=${branch} \
             -e GIT_СOMMIT=${commitId} \
             -v ${jenkinsTestsPactContractsDirectory}:/app/${testsPactsDirectory} \
-            gcr.io/toptal-hub/${repositoryName}:${commitId} \
+            us-central1-docker.pkg.dev/toptal-hub/containers/${repositoryName}:${commitId} \
             yarn publish-pact
           """
         }
@@ -316,7 +316,7 @@ pipeline {
             -v $SSH_AUTH_SOCK:/ssh-agent \
             -e SSH_AUTH_SOCK=/ssh-agent \
             -v ${PWD}/.git:/app/.git \
-            gcr.io/toptal-hub/${repositoryName}:${commitId} \
+            us-central1-docker.pkg.dev/toptal-hub/containers/${repositoryName}:${commitId} \
             ${releasePackageCommand}
           """
         }
@@ -380,7 +380,7 @@ pipeline {
             sh """
               docker run \
               --user="root" \
-              --rm gcr.io/toptal-hub/${repositoryName}:${commitId} /bin/bash -c "apt update && apt-get -y install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb  && yarn cypress install > /dev/null && yarn test:$testCommand:ci"
+              --rm us-central1-docker.pkg.dev/toptal-hub/containers/${repositoryName}:${commitId} /bin/bash -c "apt update && apt-get -y install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb  && yarn cypress install > /dev/null && yarn test:$testCommand:ci"
             """
         }
       } //steps

package/src/configs/jobs/publish-alpha-package/Jenkinsfile

@@ -124,7 +124,7 @@ pipeline {
             -v $SSH_AUTH_SOCK:/ssh-agent \
             -e SSH_AUTH_SOCK=/ssh-agent \
             -v ${PWD}/.git:/app/.git \
-            gcr.io/toptal-hub/${repositoryName}:${commitId} \
+            us-central1-docker.pkg.dev/toptal-hub/containers/${repositoryName}:${commitId} \
             /bin/bash -c "yarn ${params.BUILD_PACKAGE_SCRIPT_NAME} && \
             yarn davinci-engine publish-package \
             --alpha \