@toptal/davinci-ci 2.0.1 → 2.0.2-alpha-fx-2755-interactive-workflow-generation.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-ci",
-  "version": "2.0.1",
+  "version": "2.0.2-alpha-fx-2755-interactive-workflow-generation.4+46405792",
   "description": "Continuos integrations tools for frontend projects",
   "publishConfig": {
     "access": "public"
@@ -32,8 +32,9 @@
   "dependencies": {
     "@commitlint/cli": "^16.2.4",
     "@commitlint/config-conventional": "^16.0.0",
-    "@toptal/davinci-cli-shared": "1.5.2",
+    "@toptal/davinci-cli-shared": "1.5.3-alpha-fx-2755-interactive-workflow-generation.4+46405792",
     "danger": "^11.0.5",
     "markdown-table": "^2.0.0"
-  }
+  },
+  "gitHead": "46405792bfc49fdb4b954b2ca9ddbb9ce8660801"
 }

package/src/commands/danger.js

@@ -3,18 +3,18 @@ const {
   runSync,
   print,
   convertToCLIParameters,
-  files
+  files,
 } = require('@toptal/davinci-cli-shared')
 
 const commandOptions = [
   {
     label: 'check only, without fixing the code',
-    name: '--check'
+    name: '--check',
   },
   {
     label: 'checks commit message quality locally',
-    name: '--local'
-  }
+    name: '--local',
+  },
 ]
 
 const dangerCommand = ({ options }) => {
@@ -43,7 +43,7 @@ const dangerCommand = ({ options }) => {
       local ? '--failOnErrors' : undefined,
       '--dangerfile',
       `${dangerfilePath}`,
-      ...convertToCLIParameters(rest)
+      ...convertToCLIParameters(rest),
     ].filter(Boolean)
   )
 }
@@ -53,7 +53,7 @@ const dangerCommandCreator = {
   allowUnknownOptions: true,
   command: 'danger',
   description: 'Run danger check',
-  options: commandOptions
+  options: commandOptions,
 }
 
 module.exports = dangerCommandCreator

package/src/configs/danger/conventional-commits/plugins/conventional-commits/index.js

@@ -17,7 +17,7 @@ const conventionalCommits = async () => {
 
   const { commits } = danger.git
   const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional']
+    extends: ['@commitlint/config-conventional'],
   })
 
   commits.forEach(async commit => {
@@ -33,7 +33,7 @@ const conventionalCommits = async () => {
 
         message += table([
           ['Message'],
-          ...result.errors.map(error => [error.message])
+          ...result.errors.map(error => [error.message]),
         ])
 
         message +=
@@ -48,5 +48,5 @@ const conventionalCommits = async () => {
 }
 
 module.exports = {
-  conventionalCommits
+  conventionalCommits,
 }

package/src/configs/danger/conventional-commits/plugins/conventional-pr-title/index.js

@@ -18,7 +18,7 @@ const conventionalPRTitle = async () => {
   }
 
   const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional']
+    extends: ['@commitlint/config-conventional'],
   })
   const { title } = danger.github.pr
 
@@ -35,7 +35,7 @@ const conventionalPRTitle = async () => {
 
       message += table([
         ['Message'],
-        ...result.errors.map(error => [error.message])
+        ...result.errors.map(error => [error.message]),
       ])
 
       message +=
@@ -49,5 +49,5 @@ const conventionalPRTitle = async () => {
 }
 
 module.exports = {
-  conventionalPRTitle
+  conventionalPRTitle,
 }

package/src/configs/danger/conventional-commits/plugins/index.js

@@ -3,5 +3,5 @@ const { conventionalPRTitle } = require('./conventional-pr-title')
 
 module.exports = {
   conventionalCommits,
-  conventionalPRTitle
+  conventionalPRTitle,
 }

package/src/configs/danger/toptal/config.js

@@ -1,7 +1,7 @@
 const WHITELISTED_USERS = [
   'dependabot-preview[bot]',
   'dependabot[bot]',
-  'toptal-devbot'
+  'toptal-devbot',
 ]
 const VALID_PR_CODE_REGEX = /\[[A-Z]{1,5}-.*]\s/
 // Valid commit titles:
@@ -26,5 +26,5 @@ module.exports = {
   MISSING_TICKET_CODE_ERROR_MESSAGE,
   VALID_COMMIT_TITLE_REGEX,
   VALID_PR_CODE_REGEX,
-  WHITELISTED_USERS
+  WHITELISTED_USERS,
 }

package/src/configs/danger/toptal/plugins/index.js

@@ -3,5 +3,5 @@ const { toptalPRTitle } = require('./toptal-pr-title')
 
 module.exports = {
   toptalCommits,
-  toptalPRTitle
+  toptalPRTitle,
 }

package/src/configs/danger/toptal/plugins/toptal-commits/index.js

@@ -2,7 +2,7 @@
 const {
   MAX_COMMIT_LINE_LENGTH,
   VALID_COMMIT_TITLE_REGEX,
-  WHITELISTED_USERS
+  WHITELISTED_USERS,
 } = require('../../config')
 
 const validateCommitMessage = message => {
@@ -61,7 +61,7 @@ const toptalCommits = () => {
       fail(
         [
           `Commit ${commit.sha.trim()} does not meet requirements of [Commit Message Quality](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality):`,
-          ...validationErrors
+          ...validationErrors,
         ].join('\n')
       )
     }
@@ -69,5 +69,5 @@ const toptalCommits = () => {
 }
 
 module.exports = {
-  toptalCommits
+  toptalCommits,
 }

package/src/configs/danger/toptal/plugins/toptal-pr-title/index.js

@@ -4,7 +4,7 @@ const {
   VALID_PR_CODE_REGEX,
   WHITELISTED_USERS,
   DEFAULT_PR_TITLE_ERROR_MESSAGE,
-  MISSING_TICKET_CODE_ERROR_MESSAGE
+  MISSING_TICKET_CODE_ERROR_MESSAGE,
 } = require('../../config')
 
 const getTicketCode = text => {
@@ -58,5 +58,5 @@ const toptalPRTitle = () => {
 }
 
 module.exports = {
-  toptalPRTitle
+  toptalPRTitle,
 }

package/src/index.js

@@ -7,11 +7,11 @@ module.exports = {
   plugins: {
     conventionalCommit: {
       PRTitle: conventionalCommitsPlugins.conventionalPRTitle,
-      commits: conventionalCommitsPlugins.conventionalCommits
+      commits: conventionalCommitsPlugins.conventionalCommits,
     },
     toptal: {
       PRTitle: toptalPlugins.toptalPRTitle,
-      commits: toptalPlugins.toptalCommits
-    }
-  }
+      commits: toptalPlugins.toptalCommits,
+    },
+  },
 }

package/dist-package/package.json

@@ -1,39 +0,0 @@
-{
-  "name": "@toptal/davinci-ci",
-  "version": "2.0.1",
-  "description": "Continuos integrations tools for frontend projects",
-  "publishConfig": {
-    "access": "public"
-  },
-  "keywords": [
-    "jenkins",
-    "docker",
-    "ci"
-  ],
-  "author": "Toptal",
-  "homepage": "https://github.com/toptal/davinci/tree/master/packages/ci#readme",
-  "license": "ISC",
-  "bin": {
-    "davinci-code": "./bin/davinci-ci.js"
-  },
-  "main": "./src/index.js",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/toptal/davinci.git"
-  },
-  "scripts": {
-    "build:package": "../../bin/build-package.js",
-    "prepublishOnly": "../../bin/prepublish.js",
-    "test": "echo \"Error: run tests from root\" && exit 1"
-  },
-  "bugs": {
-    "url": "https://github.com/toptal/davinci/issues"
-  },
-  "dependencies": {
-    "@commitlint/cli": "^16.2.4",
-    "@commitlint/config-conventional": "^16.0.0",
-    "@toptal/davinci-cli-shared": "1.5.2",
-    "danger": "^11.0.5",
-    "markdown-table": "^2.0.0"
-  }
-}

package/src/configs/danger/toptal/plugins/toptal-commits/toptal-commits.test.js

@@ -1,128 +0,0 @@
-const { toptalCommits } = require('.')
-
-const prepareCommitsWithMessages = (messages = []) => ({
-  commits: messages.map(message => ({
-    message,
-    sha: '123'
-  }))
-})
-
-describe('commit danger plugin', () => {
-  beforeEach(() => {
-    global.fail = jest.fn()
-    global.danger = {
-      github: {
-        pr: {
-          user: {
-            login: 'user'
-          }
-        }
-      }
-    }
-  })
-
-  afterEach(() => {
-    global.fail = undefined
-    global.danger = undefined
-  })
-
-  it('commit with title only', () => {
-    global.danger.git = prepareCommitsWithMessages(['Hello world'])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with title and body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Hello world\n\nSome commit body here.'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with multi-line body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Hello world\n\nFirst line of commit body\nSecond line of commit body'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('commit with title longer than allowed', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'This commit message is a teeny tiny bit longer than allowed length of 79 characters'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit with body lines longer than allowed', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Short commit title\n\nBut this body line commit message is a bit longer than allowed length of 79 characters\nAnd this one is fine again.'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit message not starting with an uppercase letter', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      '23432 starts with a number',
-      'starts with a lowercase letter',
-      '* starts with a symbol',
-      ' starts with a space'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(4)
-  })
-
-  it('commit message ending with a period in title', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Commit title ending with period.'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('commit without a blank line between title and body', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Commit title\nBody without a blank line after title'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-  })
-
-  it('valid commit titles', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      'Regular commit title',
-      'Commit with sentence. But does not end with a full-stop',
-      '[FOO-1234] Commit with prefix',
-      '[FOO] Prefix numbers can be omitted',
-      '[FOO][BAR] Prefixes can couple',
-      '[FOO-1234][BAR] Mixed prefixes',
-      '[FOO-1234][BAR-123][BAZ] Everything. Together'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('invalid commit title prefixes', () => {
-    global.danger.git = prepareCommitsWithMessages([
-      '[FOO-1234] commit with lowercase',
-      '[FOO-BAR] Prefix with letter after dash',
-      '[FOO] [BAR] Prefixes with space between',
-      '[FOO]Prefix without space'
-    ])
-    toptalCommits()
-
-    expect(global.fail).toHaveBeenCalledTimes(4)
-  })
-})

package/src/configs/danger/toptal/plugins/toptal-pr-title/toptal-pr-title.test.js

@@ -1,68 +0,0 @@
-const { toptalPRTitle } = require('.')
-const {
-  MISSING_TICKET_CODE_ERROR_MESSAGE,
-  DEFAULT_PR_TITLE_ERROR_MESSAGE
-} = require('../../config')
-
-const VALID_PR_TITLE = '[ASD-123] Hello world'
-const INVALID_PR_TITLE = '[ASD-123] hello world'
-const NO_TICKET_CODE_PR_TITLE = 'Hello world'
-
-describe('commit danger plugin', () => {
-  beforeEach(() => {
-    global.fail = jest.fn()
-    global.danger = {
-      github: {
-        issue: {
-          labels: [{ name: 'My Team' }]
-        },
-        pr: {
-          title: '',
-          user: {
-            login: 'user'
-          }
-        }
-      }
-    }
-  })
-
-  afterEach(() => {
-    global.fail = undefined
-    global.danger = undefined
-  })
-
-  it('should pass valid PR title', () => {
-    global.danger.github.pr.title = VALID_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('should fail PR title with missing ticket code', () => {
-    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-    expect(global.fail).toHaveBeenCalledWith(MISSING_TICKET_CODE_ERROR_MESSAGE)
-  })
-
-  it('should pass valid PR title with missing ticket code and no-jira label', () => {
-    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
-    global.danger.github.issue.labels = [{ name: 'no-jira' }]
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(0)
-  })
-
-  it('should fail invalid PR title', () => {
-    global.danger.github.pr.title = INVALID_PR_TITLE
-
-    toptalPRTitle()
-
-    expect(global.fail).toHaveBeenCalledTimes(1)
-    expect(global.fail).toHaveBeenCalledWith(DEFAULT_PR_TITLE_ERROR_MESSAGE)
-  })
-})