@topconsultnpm/sdkui-react 6.19.0-dev1.45 → 6.19.0-dev1.46

package/lib/components/editors/TMMetadataValues.js

@@ -402,38 +402,56 @@ const TMMetadataValues = ({ showCheckBoxes = ShowCheckBoxesMode.Never, checkPerm
         return (_jsx("div", { style: { width: '100%' }, children: dsAttachsData.length > 0 && _jsx(TMAccordion, { title: SDKUI_Localizator.Attachment, children: dsAttachsData.map(item => renderMetadataItem(item, isReadOnly)) }) }));
     }, [metadataValues, showCheckBoxes, showNullValueCheckBoxes, isReadOnly, dynDataListsToBeRefreshed, validationItems, selectedMID, isOpenDistinctValues, openChooserBySingleClick, metadataValuesOrig]);
     const layoutCustom = useMemo(() => {
+        console.log('Rendering custom layout with layout:', layout);
         if (!layout || !layout.items || layout.items.length === 0) {
             return metadataValues.map((item) => renderMetadataItem(item));
         }
-        // Build a map of items by ID for quick lookup
+        // Build a map of items by ID for quick lookup (include negative/zero IDs)
         const itemsById = new Map();
         layout.items.forEach(item => {
-            if (item.layoutItemID) {
+            if (item.layoutItemID !== undefined && item.layoutItemID !== null) {
                 itemsById.set(item.layoutItemID, item);
             }
         });
-        // Find root items (items without parent or parent === 0)
-        const rootItems = layout.items.filter(item => item.type === LayoutItemTypes.LayoutRoot);
-        // Recursive function to get children of an item
+        // Determine root items. Prefer explicit LayoutRoot items if present;
+        // otherwise fall back to items with no parent (parentID undefined or -1).
+        const hasExplicitRoot = layout.items.some(item => item.type === LayoutItemTypes.LayoutRoot);
+        const rootItems = hasExplicitRoot
+            ? layout.items.filter(item => item.type === LayoutItemTypes.LayoutRoot)
+            : layout.items.filter(item => item.parentID === undefined || item.parentID === -1);
+        // Recursive function to get children of an item. Handle parentID === -1 and undefined
+        // because some layouts use -1 for root while children use undefined.
         const getChildren = (parentID) => {
+            if (parentID === -1) {
+                return layout.items?.filter(item => item.parentID === -1 || item.parentID === undefined) || [];
+            }
+            if (parentID === undefined) {
+                return layout.items?.filter(item => item.parentID === undefined) || [];
+            }
             return layout.items?.filter(item => item.parentID === parentID) || [];
         };
         // Recursive function to render layout items with depth tracking for indentation
-        const renderLayoutItem = (layoutItem, depth = 0) => {
+        // Prevent infinite recursion by tracking visited layoutItemIDs (handles malformed layouts where an item
+        // may reference itself as a child or cycles exist).
+        const renderLayoutItem = (layoutItem, depth = 0, visited = new Set()) => {
+            const id = layoutItem.layoutItemID ?? 0;
+            if (visited.has(id))
+                return null;
+            visited.add(id);
             // Check if this is a LayoutRoot - just render its children
             if (layoutItem.type === LayoutItemTypes.LayoutRoot) {
-                const children = getChildren(layoutItem.layoutItemID ?? 0);
-                return (_jsx(React.Fragment, { children: children.map(child => renderLayoutItem(child, depth)) }, `root-${layoutItem.layoutItemID}`));
+                const children = getChildren(layoutItem.layoutItemID);
+                return (_jsx(React.Fragment, { children: children.map(child => renderLayoutItem(child, depth, visited)) }, `root-${layoutItem.layoutItemID}`));
             }
             // Check if this is a LayoutGroup
             else if (layoutItem.type === LayoutItemTypes.LayoutGroup && layoutItem.lgd) {
-                const children = getChildren(layoutItem.layoutItemID ?? 0);
+                const children = getChildren(layoutItem.layoutItemID);
                 const groupDescriptor = layoutItem.lgd;
                 const groupTitle = groupDescriptor.caption || `Group ${layoutItem.layoutItemID}`;
                 const isCollapsed = false; // LayoutGroupDescriptor doesn't have collapsed property
                 // Apply indentation only to subgroups (depth > 0), not to root groups
                 const indentationPx = depth > 0 ? depth * 10 : 0;
-                return (_jsx("div", { style: { paddingLeft: `${indentationPx}px` }, children: _jsx(TMAccordion, { title: groupTitle, defaultCollapsed: isCollapsed, children: children.map(child => renderLayoutItem(child, depth + 1)) }) }, `group-wrapper-${layoutItem.layoutItemID}`));
+                return (_jsx("div", { style: { paddingLeft: `${indentationPx}px` }, children: _jsx(TMAccordion, { title: groupTitle, defaultCollapsed: isCollapsed, children: children.map(child => renderLayoutItem(child, depth + 1, visited)) }) }, `group-wrapper-${layoutItem.layoutItemID}`));
             }
             // Check if this is a LayoutControlItem (metadata field)
             else if (layoutItem.type === LayoutItemTypes.LayoutControlItem && layoutItem.lcid) {
@@ -455,7 +473,10 @@ const TMMetadataValues = ({ showCheckBoxes = ShowCheckBoxesMode.Never, checkPerm
             }
             return null;
         };
-        return (_jsx("div", { style: { width: '100%' }, children: rootItems.map(item => renderLayoutItem(item, 0)) }));
+        return (_jsx("div", { style: { width: '100%' }, children: (() => {
+                const visited = new Set();
+                return rootItems.map(item => renderLayoutItem(item, 0, visited));
+            })() }));
     }, [layout, metadataValues, showCheckBoxes, showNullValueCheckBoxes, isReadOnly, dynDataListsToBeRefreshed, validationItems, selectedMID, isOpenDistinctValues, openChooserBySingleClick, metadataValuesOrig]);
     const renderForm = useMemo(() => {
         // Se currentDTD non è ancora stato caricato, non renderizzare nulla

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@topconsultnpm/sdkui-react",
-    "version": "6.19.0-dev1.45",
+    "version": "6.19.0-dev1.46",
     "description": "",
     "scripts": {
         "test": "echo \"Error: no test specified\" && exit 1",