@toolpath/tool-scraper 2.2.0 → 2.3.0

package/dist/conventions.d.ts

@@ -40,9 +40,19 @@
  * confidently wrong rather than obviously broken. See `records.GEOMETRY_FIELDS`
  * for the canonical side of that line.
  */
+import type { UnitSystem } from '@toolpath/tool-support';
 import type { BrandName } from './identity.js';
-/** Which unit system a family's dimensional columns are published in. */
-export type UnitSystem = 'millimeters' | 'inches';
+/**
+ * Which unit system a family's dimensional columns are published in.
+ *
+ * `@toolpath/tool-support`'s, re-exported under the name this package has
+ * always published. The same two strings were declared here and spelled two
+ * other ways downstream — `'metric' | 'inch'`, and a display unit `'mm' | 'in'`
+ * — with a lookup table between them on ingest, which is where a metric family
+ * quietly becomes an inch one. This spelling won because a scrape originates
+ * the fact.
+ */
+export type { UnitSystem } from '@toolpath/tool-support';
 /**
  * The suffix a dimensional column carries, per unit system.
  *

package/dist/measure.d.ts

@@ -41,16 +41,22 @@
  * writes `1 1/2` and admits no hyphen at all. What it hands here is
  * {@link Measured}, which is the part they have in common.
  *
- * **`MM_PER_INCH` lives here and not in a vendor.** It was declared and
- * exported twice — `vendors/harvey/value.ts` and `vendors/regofix/scrape.ts`
- * — so `@toolpath/tool-scraper/vendors/harvey` and `.../vendors/regofix` each
- * published their own copy of 25.4. That is exactly what `conventions.CAD_COLUMN`
- * was moved up for, and what `tests/vendor-boundary.test.ts` now refuses by name.
+ * **`MM_PER_INCH` and `convertLength` are `@toolpath/tool-support`'s**, and are
+ * re-exported here under the names this package has always published.
+ *
+ * They were declared and exported twice inside this package alone —
+ * `vendors/harvey/value.ts` and `vendors/regofix/scrape.ts` — so
+ * `@toolpath/tool-scraper/vendors/harvey` and `.../vendors/regofix` each
+ * published their own copy of 25.4. `tests/vendor-boundary.test.ts` refuses that
+ * by name and moving the constant up here fixed it *within* this package, while
+ * a third copy went on standing in the application downstream. The domain
+ * package is where a constant every consumer shares can only be declared once,
+ * and `@toolpath/tool-support`'s own boundary test now holds the whole tree to
+ * one `25.4`.
  */
-import type { UnitSystem } from './conventions.js';
+import { convertLength, MM_PER_INCH, type UnitSystem } from '@toolpath/tool-support';
 import { type Warn } from './scrape.js';
-/** Exact by definition: the inch has been 25.4 mm since 1959. */
-export declare const MM_PER_INCH = 25.4;
+export { convertLength, MM_PER_INCH };
 /**
  * `.250` -> 0.25, `3/4` -> 0.75, `1-1/2` -> 1.5, `2` -> 2.
  *
@@ -63,8 +69,6 @@ export declare const MM_PER_INCH = 25.4;
  * that guessed would be the mistake `conventions.UNIT_SUFFIX` exists to prevent.
  */
 export declare function fractionValue(token: string): number | null;
-/** `value`, converted from `from` to `to`. A no-op when they agree. */
-export declare function convertLength(value: number, from: UnitSystem, to: UnitSystem): number;
 /**
  * What a value states about itself: a length system, or degrees.
  *

package/dist/measure.js

@@ -41,15 +41,22 @@
  * writes `1 1/2` and admits no hyphen at all. What it hands here is
  * {@link Measured}, which is the part they have in common.
  *
- * **`MM_PER_INCH` lives here and not in a vendor.** It was declared and
- * exported twice — `vendors/harvey/value.ts` and `vendors/regofix/scrape.ts`
- * — so `@toolpath/tool-scraper/vendors/harvey` and `.../vendors/regofix` each
- * published their own copy of 25.4. That is exactly what `conventions.CAD_COLUMN`
- * was moved up for, and what `tests/vendor-boundary.test.ts` now refuses by name.
+ * **`MM_PER_INCH` and `convertLength` are `@toolpath/tool-support`'s**, and are
+ * re-exported here under the names this package has always published.
+ *
+ * They were declared and exported twice inside this package alone —
+ * `vendors/harvey/value.ts` and `vendors/regofix/scrape.ts` — so
+ * `@toolpath/tool-scraper/vendors/harvey` and `.../vendors/regofix` each
+ * published their own copy of 25.4. `tests/vendor-boundary.test.ts` refuses that
+ * by name and moving the constant up here fixed it *within* this package, while
+ * a third copy went on standing in the application downstream. The domain
+ * package is where a constant every consumer shares can only be declared once,
+ * and `@toolpath/tool-support`'s own boundary test now holds the whole tree to
+ * one `25.4`.
  */
+import { convertLength, MM_PER_INCH } from '@toolpath/tool-support';
 import { consoleWarn } from './scrape.js';
-/** Exact by definition: the inch has been 25.4 mm since 1959. */
-export const MM_PER_INCH = 25.4;
+export { convertLength, MM_PER_INCH };
 /**
  * A decimal, a simple fraction or a mixed number — and nothing else.
  *
@@ -80,12 +87,6 @@ export function fractionValue(token) {
     const value = (whole === undefined ? 0 : Number(whole)) + part;
     return Number.isFinite(value) ? value : null;
 }
-/** `value`, converted from `from` to `to`. A no-op when they agree. */
-export function convertLength(value, from, to) {
-    if (from === to)
-        return value;
-    return to === 'inches' ? value / MM_PER_INCH : value * MM_PER_INCH;
-}
 /**
  * A read cell as a length in `unit`, or null where it publishes none.
  *

package/dist/profiles.d.ts

@@ -34,6 +34,7 @@
  * **Collets get no profile.** They publish no CAD model and are not drawn: a
  * collet sits inside the nut, which the holder's own envelope already includes.
  */
+import type { ProfileDatum, ProfilePoint } from '@toolpath/tool-support';
 import type { HolderRecord } from './holding.js';
 import type { BrandName } from './identity.js';
 /** Bumped when {@link ProfilesDocument}'s shape changes in a way a consumer must handle. */
@@ -117,8 +118,12 @@ export interface MeasuredHolder {
     readonly kernelVersion: string;
     readonly options: ImportOptions;
 }
-/** One vertex of a silhouette: `[z, r]`, both in millimetres. */
-export type ProfilePoint = readonly [z: number, r: number];
+/**
+ * One vertex of a silhouette: `[z, r]`, both in millimetres.
+ *
+ * `@toolpath/tool-support`'s, re-exported under this package's own name.
+ */
+export type { ProfilePoint } from '@toolpath/tool-support';
 /**
  * What `z = 0` means on a profile.
  *
@@ -132,8 +137,13 @@ export type ProfilePoint = readonly [z: number, r: number];
  * implementation put it. One `datum` over a batch is only true while every
  * holder in it has a taper, and the first Capto or straight-shank holder makes
  * the document's own header wrong about some of its entries.
+ *
+ * `@toolpath/tool-support`'s, re-exported under this package's own name. It was
+ * declared here, in the drawing package, and in the application between them —
+ * three copies of two strings, one of which decides whether a consumer may
+ * print a gauge length at all.
  */
-export type ProfileDatum = 'gage-line' | 'nose';
+export type { ProfileDatum } from '@toolpath/tool-support';
 /** One holder's measured silhouette, and how far it agrees with the vendor. */
 export interface HolderProfile {
     readonly catalogNumber: string;

package/dist/provenance.d.ts

@@ -44,6 +44,7 @@
  * is shaped `YYYY-MM-DD` — and `cite: ''` would otherwise satisfy the
  * compiler while citing nothing.
  */
+import { type Provenance } from '@toolpath/tool-support';
 /** What a per-family constant can be. */
 export type FactValue = string | number | boolean;
 /**
@@ -53,9 +54,16 @@ export type FactValue = string | number | boolean;
  * before the guesses and finishes on the ones only a person stands behind —
  * `derived` first, then `assumed`. (`vendor-stated` leads the order but is
  * filtered out of that document entirely; see {@link assumptions}.)
+ *
+ * **`@toolpath/tool-support`'s `PROVENANCE`**, re-exported under this package's
+ * own name. The order is load-bearing here and is the shared list's, so the
+ * ordering that document is read in cannot drift from the vocabulary a drawing
+ * marks a derived dimension by. Three identical declarations of these three
+ * strings stood before it — this one, the drawing's `Provenance`, and the
+ * application's.
  */
 export declare const SOURCES: readonly ["vendor-stated", "derived", "assumed"];
-export type FactSource = (typeof SOURCES)[number];
+export type FactSource = Provenance;
 /**
  * One per-family constant, with its provenance.
  *

package/dist/provenance.js

@@ -44,6 +44,7 @@
  * is shaped `YYYY-MM-DD` — and `cite: ''` would otherwise satisfy the
  * compiler while citing nothing.
  */
+import { PROVENANCE } from '@toolpath/tool-support';
 import { ScraperConfigError } from './errors.js';
 import { compare } from './order.js';
 /**
@@ -53,8 +54,15 @@ import { compare } from './order.js';
  * before the guesses and finishes on the ones only a person stands behind —
  * `derived` first, then `assumed`. (`vendor-stated` leads the order but is
  * filtered out of that document entirely; see {@link assumptions}.)
+ *
+ * **`@toolpath/tool-support`'s `PROVENANCE`**, re-exported under this package's
+ * own name. The order is load-bearing here and is the shared list's, so the
+ * ordering that document is read in cannot drift from the vocabulary a drawing
+ * marks a derived dimension by. Three identical declarations of these three
+ * strings stood before it — this one, the drawing's `Provenance`, and the
+ * application's.
  */
-export const SOURCES = ['vendor-stated', 'derived', 'assumed'];
+export const SOURCES = PROVENANCE;
 const DATE = /^\d{4}-\d{2}-\d{2}$/;
 /** What a note has to say, per source kind. */
 const WANTED = {

package/dist/records.d.ts

@@ -42,9 +42,33 @@
  * always a copy is not a second measurement. An adapter that could supply them
  * separately could supply a tool that claims a holder it does not have.
  */
-import { type UnitSystem } from './conventions.js';
+import { type UnitSystem } from '@toolpath/tool-support';
 import { type BrandName } from './identity.js';
 import type { FactSource } from './provenance.js';
+/**
+ * One canonical geometry name: what it measures, and whose name it is.
+ *
+ * **Declared here rather than re-exported from `@toolpath/tool-support`**, even
+ * though the dictionary's entries are the shared ones. The shared
+ * `GeometryField` carries a required `unit` and is `readonly` throughout, and
+ * this type has been published since 1.0: adopting it outright would stop a
+ * consumer that builds one of these — `{ definition, iso }` — from compiling,
+ * for no gain the values below do not already give. The entries *satisfy* the
+ * shared shape, so a field renamed upstream is still a compile error here.
+ */
+export interface GeometryField {
+    /**
+     * What the field measures, phrased so it can be quoted back at whoever
+     * mapped a column to the wrong one.
+     */
+    definition: string;
+    /**
+     * The ISO 13399 code for this measurement, or `null` where the standard's
+     * counterpart has not been pinned against the dictionary. Equal to the
+     * canonical name itself on every field that *is* the standard's code.
+     */
+    iso: string | null;
+}
 /** The kinds of cutting tool this package maps. */
 export type ToolKind = 'drill' | 'tap' | 'endmill';
 /**
@@ -87,20 +111,6 @@ export declare const UNSPECIFIED = "unspecified";
  * type so that the vocabularies cannot drift apart.
  */
 export type MaterialGroupsSource = FactSource | typeof UNSPECIFIED;
-/** One canonical geometry name: what it measures, and whose name it is. */
-export interface GeometryField {
-    /**
-     * What the field measures, phrased so it can be quoted back at whoever
-     * mapped a column to the wrong one.
-     */
-    definition: string;
-    /**
-     * The ISO 13399 code for this measurement, or `null` where the standard's
-     * counterpart has not been pinned against the dictionary. Equal to the
-     * canonical name itself on every field that *is* the standard's code.
-     */
-    iso: string | null;
-}
 /**
  * Canonical geometry fields an adapter may supply, and what each means.
  *
@@ -109,6 +119,26 @@ export interface GeometryField {
  * so the vocabulary's source is readable from the code rather than from a plan
  * document.
  *
+ * ## What each entry says, and what this table says
+ *
+ * The definitions and ISO codes are `@toolpath/tool-support`'s — that is the
+ * dictionary, and it is shared because a code has to mean one thing in every
+ * package that reads one. **This is not that dictionary.** It is the narrower
+ * question only a scraper asks: which of those names an *adapter may map a
+ * vendor column to*.
+ *
+ * The two are not the same list and must not become one. The dictionary knows
+ * `LBH` and `LD`, which are derived from a tool and a holder downstream and
+ * which no vendor publishes; an adapter permitted to map a column to `LBH`
+ * could supply a tool that claims a stickout nobody set. It also knows `LSCN`,
+ * ISO's clamping-length minimum, which is a real vendor column the day a vendor
+ * prints one — and which is deliberately absent below until that day, because
+ * the load-time check's job is to refuse a name no scrape can fill.
+ *
+ * So each entry is an explicit pick out of the shared table rather than a
+ * spread of it: a name dropped from the dictionary is a compile error here, and
+ * a name added to the dictionary does not silently become mappable.
+ *
  * **Seven of the ten are the standard's codes with the standard's meanings.**
  * The three that are not are Autodesk's, and each has an ISO counterpart
  * Autodesk did not use:
@@ -127,43 +157,53 @@ export interface GeometryField {
  */
 export declare const GEOMETRY_FIELDS: {
     readonly DC: {
+        readonly unit: "mm";
         readonly definition: "cutting diameter";
         readonly iso: "DC";
     };
     readonly SFDM: {
-        readonly definition: "shank diameter";
+        readonly unit: "mm";
+        readonly definition: "shank diameter \u2014 what the holder grips";
         readonly iso: "DMM";
     };
     readonly OAL: {
-        readonly definition: "overall length";
+        readonly unit: "mm";
+        readonly definition: "overall length, tip to the end of the shank";
         readonly iso: "OAL";
     };
     readonly LCF: {
-        readonly definition: "flute length — the length of the cutting edge";
+        readonly unit: "mm";
+        readonly definition: "flute length \u2014 the length of the cutting edge";
         readonly iso: "LCF";
     };
     readonly RE: {
+        readonly unit: "mm";
         readonly definition: "corner radius; 0 on a square-end tool";
         readonly iso: "RE";
     };
     readonly TP: {
-        readonly definition: "thread pitch, in the tool’s own unit system";
+        readonly unit: "mm";
+        readonly definition: "thread pitch, in the tool\u2019s own unit system";
         readonly iso: "TP";
     };
     readonly NOF: {
+        readonly unit: "count";
         readonly definition: "number of flutes";
         readonly iso: "NOF";
     };
     readonly SIG: {
+        readonly unit: "deg";
         readonly definition: "point angle, degrees included";
         readonly iso: "SIG";
     };
     readonly 'shoulder-length': {
+        readonly unit: "mm";
         readonly definition: "usable length below the full shank";
         readonly iso: null;
     };
     readonly 'shoulder-diameter': {
-        readonly definition: "diameter at the shoulder — the neck, where necked";
+        readonly unit: "mm";
+        readonly definition: "diameter at the shoulder \u2014 the neck, where necked";
         readonly iso: null;
     };
 };

package/dist/records.js

@@ -42,6 +42,7 @@
  * always a copy is not a second measurement. An adapter that could supply them
  * separately could supply a tool that claims a holder it does not have.
  */
+import { GEOMETRY_FIELDS as DICTIONARY } from '@toolpath/tool-support';
 import { dimensionalColumn } from './conventions.js';
 import { ScraperConfigError } from './errors.js';
 import { recordGuid } from './identity.js';
@@ -81,6 +82,26 @@ export const UNSPECIFIED = 'unspecified';
  * so the vocabulary's source is readable from the code rather than from a plan
  * document.
  *
+ * ## What each entry says, and what this table says
+ *
+ * The definitions and ISO codes are `@toolpath/tool-support`'s — that is the
+ * dictionary, and it is shared because a code has to mean one thing in every
+ * package that reads one. **This is not that dictionary.** It is the narrower
+ * question only a scraper asks: which of those names an *adapter may map a
+ * vendor column to*.
+ *
+ * The two are not the same list and must not become one. The dictionary knows
+ * `LBH` and `LD`, which are derived from a tool and a holder downstream and
+ * which no vendor publishes; an adapter permitted to map a column to `LBH`
+ * could supply a tool that claims a stickout nobody set. It also knows `LSCN`,
+ * ISO's clamping-length minimum, which is a real vendor column the day a vendor
+ * prints one — and which is deliberately absent below until that day, because
+ * the load-time check's job is to refuse a name no scrape can fill.
+ *
+ * So each entry is an explicit pick out of the shared table rather than a
+ * spread of it: a name dropped from the dictionary is a compile error here, and
+ * a name added to the dictionary does not silently become mappable.
+ *
  * **Seven of the ten are the standard's codes with the standard's meanings.**
  * The three that are not are Autodesk's, and each has an ISO counterpart
  * Autodesk did not use:
@@ -98,25 +119,16 @@ export const UNSPECIFIED = 'unspecified';
  * recognises it.
  */
 export const GEOMETRY_FIELDS = {
-    DC: { definition: 'cutting diameter', iso: 'DC' },
-    SFDM: { definition: 'shank diameter', iso: 'DMM' },
-    OAL: { definition: 'overall length', iso: 'OAL' },
-    LCF: {
-        definition: 'flute length — the length of the cutting edge',
-        iso: 'LCF',
-    },
-    RE: { definition: 'corner radius; 0 on a square-end tool', iso: 'RE' },
-    TP: { definition: 'thread pitch, in the tool’s own unit system', iso: 'TP' },
-    NOF: { definition: 'number of flutes', iso: 'NOF' },
-    SIG: { definition: 'point angle, degrees included', iso: 'SIG' },
-    'shoulder-length': {
-        definition: 'usable length below the full shank',
-        iso: null,
-    },
-    'shoulder-diameter': {
-        definition: 'diameter at the shoulder — the neck, where necked',
-        iso: null,
-    },
+    DC: DICTIONARY.DC,
+    SFDM: DICTIONARY.SFDM,
+    OAL: DICTIONARY.OAL,
+    LCF: DICTIONARY.LCF,
+    RE: DICTIONARY.RE,
+    TP: DICTIONARY.TP,
+    NOF: DICTIONARY.NOF,
+    SIG: DICTIONARY.SIG,
+    'shoulder-length': DICTIONARY['shoulder-length'],
+    'shoulder-diameter': DICTIONARY['shoulder-diameter'],
 };
 /**
  * The canonical names that are **not** ISO 13399's own codes, derived rather

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toolpath/tool-scraper",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "Scrape cutting-tool geometry from vendor catalogs into records and CSVs",
   "license": "MIT",
   "engines": {
@@ -82,7 +82,8 @@
     "README.md"
   ],
   "dependencies": {
-    "htmlparser2": "12.0.0"
+    "htmlparser2": "12.0.0",
+    "@toolpath/tool-support": "^0.1.0"
   },
   "devDependencies": {
     "@types/node": "24.10.1",