@tonyclaw/agent-inspector 2.0.31 → 2.0.32

package/src/components/groups/GroupsDialog.tsx

@@ -1,11 +1,21 @@
 import { type JSX, useCallback, useEffect, useMemo, useState } from "react";
-import { Check, Copy, Download, ExternalLink, Layers, Loader2, RefreshCw } from "lucide-react";
+import {
+  Check,
+  Copy,
+  Download,
+  ExternalLink,
+  Layers,
+  Loader2,
+  RefreshCw,
+  Trash2,
+} from "lucide-react";
 import { Button } from "../ui/button";
 import { Badge } from "../ui/badge";
 import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogTrigger } from "../ui/dialog";
 import { cn } from "../../lib/utils";
 import { parseJsonResponse, readApiError } from "../../lib/apiClient";
 import {
+  DeleteInspectorGroupResponseSchema,
   GroupEvidenceExportResultSchema,
   type GroupEvidenceReadResponse,
   type GroupEvidenceExportResult,
@@ -36,6 +46,11 @@ type GroupMemberRow = {
   exportMember: InspectorGroupExportMember | null;
 };
 
+export function groupDeletePath(groupId: string, deleteEvidence: boolean): string {
+  const path = `/api/groups/${encodeURIComponent(groupId)}`;
+  return deleteEvidence ? `${path}?deleteEvidence=1` : path;
+}
+
 export function summarizeGroup(group: InspectorGroup): GroupSummary {
   let completedMembers = 0;
   let failedMembers = 0;
@@ -218,6 +233,10 @@ export function GroupsDialog(): JSX.Element {
   const [exportingGroupId, setExportingGroupId] = useState<string | null>(null);
   const [exportError, setExportError] = useState<string | null>(null);
   const [exportResult, setExportResult] = useState<GroupEvidenceExportResult | null>(null);
+  const [deleteTarget, setDeleteTarget] = useState<InspectorGroup | null>(null);
+  const [deleteEvidence, setDeleteEvidence] = useState(false);
+  const [deletingGroupId, setDeletingGroupId] = useState<string | null>(null);
+  const [deleteError, setDeleteError] = useState<string | null>(null);
   const { groups, isLoading, error, mutate } = useGroups();
 
   const selectedGroup = useMemo(
@@ -280,74 +299,140 @@ export function GroupsDialog(): JSX.Element {
     [mutate, mutateEvidence],
   );
 
-  return (
-    <Dialog open={open} onOpenChange={setOpen}>
-      <DialogTrigger asChild>
-        <Button
-          type="button"
-          variant="ghost"
-          size="icon"
-          className="relative size-8"
-          aria-label="Evaluation groups"
-          title="Evaluation groups"
-        >
-          <Layers className="size-4" />
-          {isLoading ? (
-            <Loader2 className="absolute -right-0.5 -top-0.5 size-3 animate-spin text-muted-foreground" />
-          ) : groups.length > 0 ? (
-            <span className="absolute -right-1 -top-1 min-w-4 rounded-full bg-primary px-1 text-[10px] leading-4 text-primary-foreground">
-              {groups.length}
-            </span>
-          ) : null}
-          <span className="sr-only">Evaluation groups</span>
-        </Button>
-      </DialogTrigger>
-      <DialogContent className="flex max-h-[85vh] max-w-5xl flex-col overflow-hidden">
-        <DialogHeader>
-          <DialogTitle className="flex items-center gap-2 pr-8">
-            <Layers className="size-5 text-muted-foreground" />
-            <span>Groups</span>
-            <Badge variant="outline">{formatNumber(groups.length)}</Badge>
-          </DialogTitle>
-        </DialogHeader>
+  const handleRequestDelete = useCallback((group: InspectorGroup) => {
+    setDeleteTarget(group);
+    setDeleteEvidence(false);
+    setDeleteError(null);
+  }, []);
+
+  const handleDeleteDialogOpenChange = useCallback(
+    (nextOpen: boolean) => {
+      if (nextOpen || deletingGroupId !== null) return;
+      setDeleteTarget(null);
+      setDeleteEvidence(false);
+      setDeleteError(null);
+    },
+    [deletingGroupId],
+  );
 
-        <div className="flex min-h-0 items-center justify-between gap-3 border-b border-border pb-3">
-          <p className="text-xs text-muted-foreground">
-            Evaluation batches, model runs, and exported evidence packs.
-          </p>
+  const handleDelete = useCallback(async () => {
+    const group = deleteTarget;
+    if (group === null) return;
+
+    setDeletingGroupId(group.id);
+    setDeleteError(null);
+
+    try {
+      const response = await fetch(groupDeletePath(group.id, deleteEvidence), {
+        method: "DELETE",
+      });
+
+      if (!response.ok) {
+        setDeleteError(
+          await readApiError(response, `Delete failed with status ${String(response.status)}`),
+        );
+        return;
+      }
+
+      await parseJsonResponse(response, DeleteInspectorGroupResponseSchema);
+      setExportResult((current) =>
+        current !== null && current.group.id === group.id ? null : current,
+      );
+      setSelectedGroupId((current) => (current === group.id ? null : current));
+      setDeleteTarget(null);
+      setDeleteEvidence(false);
+      await mutate();
+      await mutateEvidence();
+    } catch (err) {
+      setDeleteError(err instanceof Error ? err.message : String(err));
+    } finally {
+      setDeletingGroupId(null);
+    }
+  }, [deleteEvidence, deleteTarget, mutate, mutateEvidence]);
+
+  return (
+    <>
+      <Dialog open={open} onOpenChange={setOpen}>
+        <DialogTrigger asChild>
           <Button
             type="button"
-            variant="outline"
-            size="sm"
-            className="shrink-0"
-            onClick={handleRefresh}
+            variant="ghost"
+            size="icon"
+            className="relative size-8"
+            aria-label="Evaluation groups"
+            title="Evaluation groups"
           >
-            <RefreshCw className="size-3.5" />
-            Refresh
+            <Layers className="size-4" />
+            {isLoading ? (
+              <Loader2 className="absolute -right-0.5 -top-0.5 size-3 animate-spin text-muted-foreground" />
+            ) : groups.length > 0 ? (
+              <span className="absolute -right-1 -top-1 min-w-4 rounded-full bg-primary px-1 text-[10px] leading-4 text-primary-foreground">
+                {groups.length}
+              </span>
+            ) : null}
+            <span className="sr-only">Evaluation groups</span>
           </Button>
-        </div>
+        </DialogTrigger>
+        <DialogContent className="flex max-h-[85vh] max-w-5xl flex-col overflow-hidden">
+          <DialogHeader>
+            <DialogTitle className="flex items-center gap-2 pr-8">
+              <Layers className="size-5 text-muted-foreground" />
+              <span>Groups</span>
+              <Badge variant="outline">{formatNumber(groups.length)}</Badge>
+            </DialogTitle>
+          </DialogHeader>
+
+          <div className="flex min-h-0 items-center justify-between gap-3 border-b border-border pb-3">
+            <p className="text-xs text-muted-foreground">
+              Evaluation batches, model runs, and exported evidence packs.
+            </p>
+            <Button
+              type="button"
+              variant="outline"
+              size="sm"
+              className="shrink-0"
+              onClick={handleRefresh}
+            >
+              <RefreshCw className="size-3.5" />
+              Refresh
+            </Button>
+          </div>
 
-        <div className="grid min-h-0 flex-1 gap-4 md:grid-cols-[260px_minmax(0,1fr)]">
-          <GroupList
-            groups={groups}
-            selectedGroupId={selectedGroup?.id ?? null}
-            isLoading={isLoading}
-            error={error}
-            onSelect={setSelectedGroupId}
-          />
-          <GroupDetails
-            group={selectedGroup}
-            exportResult={selectedExportResult}
-            evidenceResponse={evidenceResponse}
-            evidenceLoading={evidenceLoading}
-            evidenceError={evidenceError}
-            exportError={exportError}
-            exportingGroupId={exportingGroupId}
-            onExport={handleExport}
-          />
-        </div>
-      </DialogContent>
-    </Dialog>
+          <div className="grid min-h-0 flex-1 gap-4 md:grid-cols-[260px_minmax(0,1fr)]">
+            <GroupList
+              groups={groups}
+              selectedGroupId={selectedGroup?.id ?? null}
+              isLoading={isLoading}
+              error={error}
+              onSelect={setSelectedGroupId}
+            />
+            <GroupDetails
+              group={selectedGroup}
+              exportResult={selectedExportResult}
+              evidenceResponse={evidenceResponse}
+              evidenceLoading={evidenceLoading}
+              evidenceError={evidenceError}
+              exportError={exportError}
+              deleteError={deleteError}
+              exportingGroupId={exportingGroupId}
+              deletingGroupId={deletingGroupId}
+              onExport={handleExport}
+              onRequestDelete={handleRequestDelete}
+            />
+          </div>
+        </DialogContent>
+      </Dialog>
+      <DeleteGroupDialog
+        group={deleteTarget}
+        open={deleteTarget !== null}
+        deleteEvidence={deleteEvidence}
+        isDeleting={deleteTarget !== null && deletingGroupId === deleteTarget.id}
+        error={deleteError}
+        onDeleteEvidenceChange={setDeleteEvidence}
+        onOpenChange={handleDeleteDialogOpenChange}
+        onConfirm={() => void handleDelete()}
+      />
+    </>
   );
 }
 
@@ -431,8 +516,11 @@ function GroupDetails({
   evidenceLoading,
   evidenceError,
   exportError,
+  deleteError,
   exportingGroupId,
+  deletingGroupId,
   onExport,
+  onRequestDelete,
 }: {
   group: InspectorGroup | null;
   exportResult: GroupEvidenceExportResult | null;
@@ -440,8 +528,11 @@ function GroupDetails({
   evidenceLoading: boolean;
   evidenceError: Error | undefined;
   exportError: string | null;
+  deleteError: string | null;
   exportingGroupId: string | null;
+  deletingGroupId: string | null;
   onExport: (group: InspectorGroup) => Promise<void>;
+  onRequestDelete: (group: InspectorGroup) => void;
 }): JSX.Element {
   if (group === null) {
     return (
@@ -457,6 +548,7 @@ function GroupDetails({
   const evidence = evidenceFor(group, exportResult);
   const rows = buildGroupMemberRows(group, exportResult);
   const isExporting = exportingGroupId === group.id;
+  const isDeleting = deletingGroupId === group.id;
 
   return (
     <div className="min-h-0 overflow-y-auto pr-1">
@@ -475,21 +567,39 @@ function GroupDetails({
               <span>updated {formatTimestamp(group.updatedAt)}</span>
             </div>
           </div>
-          <Button
-            type="button"
-            variant="default"
-            size="sm"
-            className="shrink-0"
-            disabled={isExporting}
-            onClick={() => void onExport(group)}
-          >
-            {isExporting ? (
-              <Loader2 className="size-3.5 animate-spin" />
-            ) : (
-              <Download className="size-3.5" />
-            )}
-            Export evidence
-          </Button>
+          <div className="flex shrink-0 items-center gap-2">
+            <Button
+              type="button"
+              variant="outline"
+              size="icon"
+              className="size-8 text-red-600 hover:text-red-700"
+              aria-label="Delete group"
+              title="Delete group"
+              disabled={isDeleting}
+              onClick={() => onRequestDelete(group)}
+            >
+              {isDeleting ? (
+                <Loader2 className="size-3.5 animate-spin" />
+              ) : (
+                <Trash2 className="size-3.5" />
+              )}
+            </Button>
+            <Button
+              type="button"
+              variant="default"
+              size="sm"
+              className="shrink-0"
+              disabled={isExporting || isDeleting}
+              onClick={() => void onExport(group)}
+            >
+              {isExporting ? (
+                <Loader2 className="size-3.5 animate-spin" />
+              ) : (
+                <Download className="size-3.5" />
+              )}
+              Export evidence
+            </Button>
+          </div>
         </div>
 
         {group.task !== null && group.task.trim().length > 0 && (
@@ -529,12 +639,115 @@ function GroupDetails({
           </div>
         )}
 
+        {deleteError !== null && (
+          <div className="rounded-md border border-red-200 bg-red-50 px-3 py-2 text-xs text-red-700">
+            {deleteError}
+          </div>
+        )}
+
         <MemberTable rows={rows} />
       </div>
     </div>
   );
 }
 
+function DeleteGroupDialog({
+  group,
+  open,
+  deleteEvidence,
+  isDeleting,
+  error,
+  onDeleteEvidenceChange,
+  onOpenChange,
+  onConfirm,
+}: {
+  group: InspectorGroup | null;
+  open: boolean;
+  deleteEvidence: boolean;
+  isDeleting: boolean;
+  error: string | null;
+  onDeleteEvidenceChange: (deleteEvidence: boolean) => void;
+  onOpenChange: (open: boolean) => void;
+  onConfirm: () => void;
+}): JSX.Element {
+  const title = group?.title ?? "this group";
+  const hasEvidence = group?.evidence !== null && group?.evidence !== undefined;
+  const evidencePath = group?.evidence?.markdownPath ?? "No evidence pack exported.";
+
+  return (
+    <Dialog open={open} onOpenChange={onOpenChange}>
+      <DialogContent className="max-w-md">
+        <DialogHeader>
+          <DialogTitle className="flex items-center gap-2 pr-8">
+            <Trash2 className="size-5 text-red-600" />
+            <span>Delete group</span>
+          </DialogTitle>
+        </DialogHeader>
+
+        <div className="space-y-3">
+          <p className="text-sm text-muted-foreground">
+            Delete <span className="font-medium text-foreground">{title}</span>? Session logs and
+            run records stay intact.
+          </p>
+
+          <label
+            className={cn(
+              "flex items-start gap-3 rounded-md border border-border bg-muted/20 px-3 py-2 text-sm",
+              hasEvidence ? "cursor-pointer" : "opacity-60",
+            )}
+          >
+            <input
+              type="checkbox"
+              className="mt-0.5 size-4"
+              checked={deleteEvidence}
+              disabled={!hasEvidence || isDeleting}
+              onChange={(event) => onDeleteEvidenceChange(event.currentTarget.checked)}
+            />
+            <span className="min-w-0">
+              <span className="block font-medium">Also delete exported evidence files</span>
+              <code className="mt-1 block truncate font-mono text-[11px] text-muted-foreground">
+                {evidencePath}
+              </code>
+            </span>
+          </label>
+
+          {error !== null && (
+            <div className="rounded-md border border-red-200 bg-red-50 px-3 py-2 text-xs text-red-700">
+              {error}
+            </div>
+          )}
+        </div>
+
+        <div className="flex justify-end gap-2 pt-1">
+          <Button
+            type="button"
+            variant="outline"
+            size="sm"
+            disabled={isDeleting}
+            onClick={() => onOpenChange(false)}
+          >
+            Cancel
+          </Button>
+          <Button
+            type="button"
+            variant="destructive"
+            size="sm"
+            disabled={isDeleting || group === null}
+            onClick={onConfirm}
+          >
+            {isDeleting ? (
+              <Loader2 className="size-3.5 animate-spin" />
+            ) : (
+              <Trash2 className="size-3.5" />
+            )}
+            Delete
+          </Button>
+        </div>
+      </DialogContent>
+    </Dialog>
+  );
+}
+
 function SummaryStat({ label, value }: { label: string; value: number }): JSX.Element {
   return (
     <div className="rounded-md border border-border bg-muted/20 px-3 py-2">

package/src/lib/groupContract.ts

@@ -92,6 +92,17 @@ export const GroupEvidenceExportOptionsSchema = z
   })
   .optional();
 
+export const DeleteInspectorGroupOptionsSchema = z.object({
+  deleteEvidence: z.boolean().optional(),
+});
+
+export const DeleteInspectorGroupResponseSchema = z.object({
+  groupId: z.string(),
+  deleted: z.boolean(),
+  evidenceDeleted: z.boolean(),
+  evidencePath: z.string().nullable(),
+});
+
 export const InspectorGroupExportMemberSchema = z.object({
   member: InspectorGroupMemberSchema,
   run: InspectorRunSchema.nullable(),
@@ -141,6 +152,8 @@ export type CreateInspectorGroupInput = z.infer<typeof CreateInspectorGroupInput
 export type UpdateInspectorGroupInput = z.infer<typeof UpdateInspectorGroupInputSchema>;
 export type AddInspectorGroupSessionInput = z.infer<typeof AddInspectorGroupSessionInputSchema>;
 export type GroupEvidenceExportOptions = z.infer<typeof GroupEvidenceExportOptionsSchema>;
+export type DeleteInspectorGroupOptions = z.infer<typeof DeleteInspectorGroupOptionsSchema>;
+export type DeleteInspectorGroupResponse = z.infer<typeof DeleteInspectorGroupResponseSchema>;
 export type InspectorGroupExportMember = z.infer<typeof InspectorGroupExportMemberSchema>;
 export type InspectorGroupEvidenceSummary = z.infer<typeof InspectorGroupEvidenceSummarySchema>;
 export type GroupEvidenceReadResponse = z.infer<typeof GroupEvidenceReadResponseSchema>;

package/src/mcp/server.ts

@@ -28,6 +28,7 @@ import {
 } from "@modelcontextprotocol/server";
 import {
   AddInspectorGroupSessionInputSchema,
+  DeleteInspectorGroupOptionsSchema,
   GroupEvidenceExportOptionsSchema,
   InspectorGroupSchema,
   InspectorGroupStatusSchema,
@@ -48,6 +49,7 @@ import {
   createGroupImpl,
   createRunImpl,
   createSessionKnowledgeImpl,
+  deleteGroupImpl,
   exportEvidenceImpl,
   exportGroupEvidenceImpl,
   getGroupImpl,
@@ -661,6 +663,19 @@ function registerTools(server: McpServer): void {
     (args) => safeCall(() => updateGroupImpl(callApi, args)),
   );
 
+  server.registerTool(
+    "inspector_delete_group",
+    {
+      title: "Delete an Inspector group",
+      description:
+        "Deletes one declared Inspector group from <dataDir>/groups.json. By default this keeps exported evidence files; set deleteEvidence=true only when the local evidence pack should also be removed.",
+      inputSchema: DeleteInspectorGroupOptionsSchema.extend({
+        groupId: z.string().min(1).describe("The Inspector group id."),
+      }),
+    },
+    (args) => safeCall(() => deleteGroupImpl(callApi, args)),
+  );
+
   server.registerTool(
     "inspector_add_group_session",
     {
@@ -1224,6 +1239,7 @@ export const TOOL_NAMES = [
   "inspector_create_group",
   "inspector_get_group",
   "inspector_update_group",
+  "inspector_delete_group",
   "inspector_add_group_session",
   "inspector_export_group_evidence",
   "inspector_list_models",

package/src/mcp/toolHandlers.ts

@@ -18,11 +18,13 @@ import { z } from "zod";
 import { LoopbackTimeoutError, type CallApiOptions } from "./loopback";
 import { extractLastUserMessagePreview, extractResponsePreview } from "./previewExtractor";
 import {
+  DeleteInspectorGroupResponseSchema,
   GroupEvidenceExportResultSchema,
   InspectorGroupSchema,
   InspectorGroupsListResponseSchema,
   type AddInspectorGroupSessionInput,
   type CreateInspectorGroupInput,
+  type DeleteInspectorGroupOptions,
   type UpdateInspectorGroupInput,
 } from "../lib/groupContract";
 import {
@@ -446,6 +448,26 @@ export async function updateGroupImpl(
   return textJson(parsed.data);
 }
 
+export type DeleteGroupArgs = {
+  groupId: string;
+} & DeleteInspectorGroupOptions;
+
+export async function deleteGroupImpl(
+  callApi: CallApiFn,
+  args: DeleteGroupArgs,
+): Promise<ToolResult> {
+  const query = args.deleteEvidence === true ? "?deleteEvidence=1" : "";
+  const path = `/api/groups/${encodeURIComponent(args.groupId)}${query}`;
+  const res = await callApi(path, { method: "DELETE" });
+  if (!res.ok) return toolError(`DELETE ${path} returned ${res.status}`);
+  const rawBody: unknown = await res.json();
+  const parsed = DeleteInspectorGroupResponseSchema.safeParse(rawBody);
+  if (!parsed.success) {
+    return toolError("DELETE /api/groups/{groupId} returned an unparseable delete result");
+  }
+  return textJson(parsed.data);
+}
+
 export type AddGroupSessionArgs = {
   groupId: string;
 } & AddInspectorGroupSessionInput;

package/src/proxy/groupStore.ts

@@ -1,14 +1,17 @@
 import { randomUUID } from "node:crypto";
-import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
-import { dirname, join } from "node:path";
+import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { dirname, isAbsolute, join, relative, resolve } from "node:path";
 import { z } from "zod";
 import {
   AddInspectorGroupSessionInputSchema,
   CreateInspectorGroupInputSchema,
+  DeleteInspectorGroupOptionsSchema,
   InspectorGroupSchema,
   UpdateInspectorGroupInputSchema,
   type AddInspectorGroupSessionInput,
   type CreateInspectorGroupInput,
+  type DeleteInspectorGroupOptions,
+  type DeleteInspectorGroupResponse,
   type InspectorGroup,
   type InspectorGroupEvidence,
   type InspectorGroupMember,
@@ -88,6 +91,33 @@ function sortedGroups(groups: readonly InspectorGroup[]): InspectorGroup[] {
   return [...groups].sort((left, right) => right.updatedAt.localeCompare(left.updatedAt));
 }
 
+function isPathInside(parentPath: string, childPath: string): boolean {
+  const relativePath = relative(parentPath, childPath);
+  return (
+    relativePath === "" ||
+    (relativePath.length > 0 && !relativePath.startsWith("..") && !isAbsolute(relativePath))
+  );
+}
+
+function evidenceDirectoryFor(group: InspectorGroup): string | null {
+  if (group.evidence === null) return null;
+
+  const root = resolve(getDataDir(), "evidence", "groups");
+  const evidenceDir = resolve(dirname(group.evidence.jsonPath));
+  return isPathInside(root, evidenceDir) ? evidenceDir : null;
+}
+
+function removeEvidenceDirectory(evidencePath: string | null, deleteEvidence: boolean): boolean {
+  if (!deleteEvidence || evidencePath === null || !existsSync(evidencePath)) return false;
+
+  try {
+    rmSync(evidencePath, { recursive: true, force: true });
+    return !existsSync(evidencePath);
+  } catch {
+    return false;
+  }
+}
+
 export function listGroups(): InspectorGroup[] {
   return sortedGroups(readGroups());
 }
@@ -153,6 +183,26 @@ export function updateGroup(
   return updatedGroup;
 }
 
+export function deleteGroup(
+  groupId: string,
+  options: DeleteInspectorGroupOptions = {},
+): DeleteInspectorGroupResponse | null {
+  const parsed = DeleteInspectorGroupOptionsSchema.parse(options);
+  const groups = readGroups();
+  const group = groups.find((candidate) => candidate.id === groupId);
+  if (group === undefined) return null;
+
+  const evidencePath = evidenceDirectoryFor(group);
+  writeGroups(groups.filter((candidate) => candidate.id !== groupId));
+
+  return {
+    groupId: group.id,
+    deleted: true,
+    evidenceDeleted: removeEvidenceDirectory(evidencePath, parsed.deleteEvidence === true),
+    evidencePath,
+  };
+}
+
 function matchesExistingMember(
   member: InspectorGroupMember,
   memberId: string,