@tomflow/proflow-task-store-sqlite 0.1.13 → 0.1.14

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @tomflow/proflow-task-store-sqlite
 
+## 0.1.14
+
+### Patch Changes
+
+- fix(task-store): make task evidence non-destructive
+
 ## 0.1.13
 
 ### Patch Changes

package/dist/deployment/adapter.d.ts

@@ -7,7 +7,7 @@ export declare const behaviorAdapter: {
             ok: true;
             status: "SUCCEEDED";
             moduleRef: "task-store-sqlite";
-            moduleVersion: "0.1.13";
+            moduleVersion: "0.1.14";
             data: {
                 databasePath: string;
             };
@@ -20,7 +20,7 @@ export declare const behaviorAdapter: {
             readonly ok: true;
             readonly status: "SUCCEEDED";
             readonly moduleRef: "task-store-sqlite";
-            readonly moduleVersion: "0.1.13";
+            readonly moduleVersion: "0.1.14";
         };
         observedEffects: never[];
     }>;
@@ -30,7 +30,7 @@ export declare const behaviorAdapter: {
             ok: true;
             status: "SUCCEEDED";
             moduleRef: "task-store-sqlite";
-            moduleVersion: "0.1.13";
+            moduleVersion: "0.1.14";
             data: {
                 setupStatus: "FAILED" | "READY";
                 runtimeStatus: "NOT_APPLICABLE";
@@ -51,11 +51,11 @@ export declare const behaviorAdapter: {
             readonly ok: true;
             readonly status: "SUCCEEDED";
             readonly moduleRef: "task-store-sqlite";
-            readonly moduleVersion: "0.1.13";
+            readonly moduleVersion: "0.1.14";
         } | {
             contract: "deployment.result.v1";
             moduleRef: "task-store-sqlite";
-            moduleVersion: "0.1.13";
+            moduleVersion: "0.1.14";
             ok: false;
             status: "FAILED";
             error: {
@@ -72,7 +72,7 @@ export declare const behaviorAdapter: {
             ok: true;
             status: "SUCCEEDED";
             moduleRef: "task-store-sqlite";
-            moduleVersion: "0.1.13";
+            moduleVersion: "0.1.14";
             data: {
                 docs: string;
             };
@@ -85,7 +85,7 @@ export declare const behaviorAdapter: {
             readonly ok: true;
             readonly status: "SUCCEEDED";
             readonly moduleRef: "task-store-sqlite";
-            readonly moduleVersion: "0.1.13";
+            readonly moduleVersion: "0.1.14";
         };
         observedEffects: never[];
     }>;
@@ -95,7 +95,7 @@ export declare const behaviorAdapter: {
             readonly ok: true;
             readonly status: "SUCCEEDED";
             readonly moduleRef: "task-store-sqlite";
-            readonly moduleVersion: "0.1.13";
+            readonly moduleVersion: "0.1.14";
         };
         observedEffects: never[];
     }>;

package/dist/deployment/descriptor.d.ts

@@ -3,7 +3,7 @@ export declare const descriptor: {
     readonly contractVersion: "1.0.0";
     readonly moduleRef: "task-store-sqlite";
     readonly packageName: "@tomflow/proflow-task-store-sqlite";
-    readonly moduleVersion: "0.1.13";
+    readonly moduleVersion: "0.1.14";
     readonly kind: "library";
     readonly templateVersion: "1.0.0";
     readonly platformCompatibility: ">=1.0.0 <2.0.0";

package/dist/deployment/descriptor.js

@@ -3,7 +3,7 @@ export const descriptor = {
     contractVersion: "1.0.0",
     moduleRef: "task-store-sqlite",
     packageName: "@tomflow/proflow-task-store-sqlite",
-    moduleVersion: "0.1.13",
+    moduleVersion: "0.1.14",
     kind: "library",
     templateVersion: "1.0.0",
     platformCompatibility: ">=1.0.0 <2.0.0",

package/dist/src/index.js

@@ -1,4 +1,5 @@
 import { DatabaseSync } from "node:sqlite";
+import { taskDocumentRef } from "@tomflow/proflow-task-orchestration";
 import { createPhase4Repositories } from "./phase4-repositories.js";
 export {} from "./migrations.js";
 export { taskMigrations } from "./phase4-migrations.js";
@@ -92,10 +93,19 @@ function history(row) {
     };
 }
 function document(row) {
+    const taskId = String(row.task_id);
+    const documentType = String(row.document_type);
     return {
-        taskId: String(row.task_id),
-        documentType: String(row.document_type),
+        documentRef: taskDocumentRef(taskId, documentType),
+        taskId,
+        documentType,
         sourceNodeId: text(row.source_node_id),
+        sourceNodeRunNo: row.source_node_run_no === null ? null : number(row.source_node_run_no),
+        revision: number(row.revision),
+        sourceDocumentRef: text(row.source_document_ref),
+        sourceDocumentRevision: row.source_document_revision === null
+            ? null
+            : number(row.source_document_revision),
         filePath: String(row.file_path),
         contentHash: String(row.content_hash),
         updatedByRef: String(row.updated_by_ref),
@@ -230,7 +240,17 @@ export class SqliteTaskStore {
                     return row ? document(row) : undefined;
                 },
                 upsert: (v) => {
-                    db.prepare("INSERT INTO task_documents VALUES (?,?,?,?,?,?,?) ON CONFLICT(task_id,document_type) DO UPDATE SET source_node_id=excluded.source_node_id,file_path=excluded.file_path,content_hash=excluded.content_hash,updated_by_ref=excluded.updated_by_ref,updated_at=excluded.updated_at").run(v.taskId, v.documentType, v.sourceNodeId, v.filePath, v.contentHash, v.updatedByRef, v.updatedAt);
+                    if (v.documentRef !== taskDocumentRef(v.taskId, v.documentType))
+                        throw new Error("TASK_DOCUMENT_IDENTITY_CONFLICT");
+                    if (!Number.isSafeInteger(v.revision) || v.revision < 1)
+                        throw new Error("TASK_DOCUMENT_REVISION_CONFLICT");
+                    if (v.revision === 1) {
+                        db.prepare("INSERT INTO task_documents(task_id,document_type,source_node_id,file_path,content_hash,updated_by_ref,updated_at,source_node_run_no,revision,source_document_ref,source_document_revision) VALUES (?,?,?,?,?,?,?,?,?,?,?)").run(v.taskId, v.documentType, v.sourceNodeId, v.filePath, v.contentHash, v.updatedByRef, v.updatedAt, v.sourceNodeRunNo, v.revision, v.sourceDocumentRef, v.sourceDocumentRevision);
+                        return;
+                    }
+                    const result = db.prepare("UPDATE task_documents SET source_node_id=?,file_path=?,content_hash=?,updated_by_ref=?,updated_at=?,source_node_run_no=?,revision=?,source_document_ref=?,source_document_revision=? WHERE task_id=? AND document_type=? AND revision=?").run(v.sourceNodeId, v.filePath, v.contentHash, v.updatedByRef, v.updatedAt, v.sourceNodeRunNo, v.revision, v.sourceDocumentRef, v.sourceDocumentRevision, v.taskId, v.documentType, v.revision - 1);
+                    if (Number(result.changes) !== 1)
+                        throw new Error("TASK_DOCUMENT_REVISION_CONFLICT");
                 },
                 listByTask: (taskId) => all("SELECT * FROM task_documents WHERE task_id=? ORDER BY document_type", taskId).map(document),
             },

package/dist/src/phase4-migrations.js

@@ -19,6 +19,21 @@ const phase4TaskColumns = [
     "source_product_intent_ref",
     "campaign_ref",
 ];
+const legacyTaskDocumentColumns = [
+    "task_id",
+    "document_type",
+    "source_node_id",
+    "file_path",
+    "content_hash",
+    "updated_by_ref",
+    "updated_at",
+];
+const evidenceTaskDocumentColumns = [
+    "source_node_run_no",
+    "revision",
+    "source_document_ref",
+    "source_document_revision",
+];
 const phase4Tables = [
     "product_campaigns",
     "product_intents",
@@ -39,16 +54,25 @@ if (!legacyV3)
 const v3Compatible = {
     ...legacyV3,
     verify: (database) => {
-        const issues = [...(legacyV3.verify?.(database) ?? [])];
-        if (!tableExists(database, "tasks"))
-            return issues;
-        const columns = tableColumns(database, "tasks");
-        const phase4ShapePresent = columns.size === legacyTaskColumns.length + phase4TaskColumns.length &&
-            legacyTaskColumns.every((column) => columns.has(column)) &&
-            phase4TaskColumns.every((column) => columns.has(column));
-        return phase4ShapePresent
-            ? issues.filter((issue) => issue !== "tasks:column_shape_mismatch")
-            : issues;
+        let issues = [...(legacyV3.verify?.(database) ?? [])];
+        if (tableExists(database, "tasks")) {
+            const columns = tableColumns(database, "tasks");
+            const phase4ShapePresent = columns.size === legacyTaskColumns.length + phase4TaskColumns.length &&
+                legacyTaskColumns.every((column) => columns.has(column)) &&
+                phase4TaskColumns.every((column) => columns.has(column));
+            if (phase4ShapePresent)
+                issues = issues.filter((issue) => issue !== "tasks:column_shape_mismatch");
+        }
+        if (tableExists(database, "task_documents")) {
+            const columns = tableColumns(database, "task_documents");
+            const evidenceShapePresent = columns.size ===
+                legacyTaskDocumentColumns.length + evidenceTaskDocumentColumns.length &&
+                legacyTaskDocumentColumns.every((column) => columns.has(column)) &&
+                evidenceTaskDocumentColumns.every((column) => columns.has(column));
+            if (evidenceShapePresent)
+                issues = issues.filter((issue) => issue !== "task_documents:column_shape_mismatch");
+        }
+        return issues;
     },
 };
 const phase4Migration = {
@@ -273,9 +297,61 @@ END;
         return issues;
     },
 };
+const taskDocumentEvidenceIntegrityMigration = {
+    version: 7,
+    name: "task_document_evidence_integrity",
+    identity: "task_document_evidence_integrity.20260928",
+    sql: [
+        "ALTER TABLE task_documents ADD COLUMN source_node_run_no INTEGER CHECK (source_node_run_no IS NULL OR source_node_run_no >= 1);",
+        "ALTER TABLE task_documents ADD COLUMN revision INTEGER NOT NULL DEFAULT 1 CHECK (revision >= 1);",
+        "ALTER TABLE task_documents ADD COLUMN source_document_ref TEXT;",
+        "ALTER TABLE task_documents ADD COLUMN source_document_revision INTEGER CHECK (source_document_revision IS NULL OR source_document_revision >= 1);",
+        "CREATE TRIGGER trg_task_documents_insert_evidence BEFORE INSERT ON task_documents BEGIN "
+            + "SELECT CASE WHEN NEW.revision <> 1 THEN RAISE(ABORT, 'TASK_DOCUMENT_REVISION_CONFLICT') END; "
+            + "SELECT CASE WHEN (NEW.source_node_id IS NULL) <> (NEW.source_node_run_no IS NULL) OR (NEW.source_document_ref IS NULL) <> (NEW.source_document_revision IS NULL) OR (NEW.source_node_id IS NOT NULL AND NEW.source_document_ref IS NOT NULL) THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_node_id IS NULL AND NOT EXISTS (SELECT 1 FROM tasks AS task WHERE task.task_id=NEW.task_id AND task.status='PENDING') THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_node_id IS NOT NULL AND NOT EXISTS (SELECT 1 FROM nodes AS node JOIN tasks AS task ON task.task_id=node.task_id WHERE node.node_id=NEW.source_node_id AND node.task_id=NEW.task_id AND node.run_no=NEW.source_node_run_no AND node.status='IN_PROGRESS' AND node.worker_ref IS NOT NULL AND task.status='ACTIVE' AND task.current_node_id=node.node_id AND NEW.updated_by_ref='worker:' || node.worker_ref AND EXISTS (SELECT 1 FROM json_each(node.output_documents_json) WHERE value=NEW.document_type)) THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_document_ref IS NOT NULL AND NOT EXISTS (SELECT 1 FROM product_documents AS source JOIN product_intents AS intent ON intent.intent_ref=source.intent_ref WHERE source.document_ref=NEW.source_document_ref AND source.revision=NEW.source_document_revision AND source.file_path=NEW.file_path AND source.content_hash=NEW.content_hash AND source.updated_by_ref=NEW.updated_by_ref AND intent.materialized_task_id=NEW.task_id) THEN RAISE(ABORT, 'TASK_DOCUMENT_SOURCE_MISMATCH') END; END;",
+        "CREATE TRIGGER trg_task_documents_update_evidence BEFORE UPDATE ON task_documents BEGIN "
+            + "SELECT CASE WHEN NEW.task_id IS NOT OLD.task_id OR NEW.document_type IS NOT OLD.document_type THEN RAISE(ABORT, 'TASK_DOCUMENT_IDENTITY_CONFLICT') END; "
+            + "SELECT CASE WHEN NEW.revision <> OLD.revision + 1 THEN RAISE(ABORT, 'TASK_DOCUMENT_REVISION_CONFLICT') END; "
+            + "SELECT CASE WHEN (NEW.source_node_id IS NULL) <> (NEW.source_node_run_no IS NULL) OR (NEW.source_document_ref IS NULL) <> (NEW.source_document_revision IS NULL) OR (NEW.source_node_id IS NOT NULL AND NEW.source_document_ref IS NOT NULL) THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_node_id IS NULL AND NOT EXISTS (SELECT 1 FROM tasks AS task WHERE task.task_id=NEW.task_id AND task.status='PENDING') THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_node_id IS NOT NULL AND NOT EXISTS (SELECT 1 FROM nodes AS node JOIN tasks AS task ON task.task_id=node.task_id WHERE node.node_id=NEW.source_node_id AND node.task_id=NEW.task_id AND node.run_no=NEW.source_node_run_no AND node.status='IN_PROGRESS' AND node.worker_ref IS NOT NULL AND task.status='ACTIVE' AND task.current_node_id=node.node_id AND NEW.updated_by_ref='worker:' || node.worker_ref AND EXISTS (SELECT 1 FROM json_each(node.output_documents_json) WHERE value=NEW.document_type)) THEN RAISE(ABORT, 'TASK_DOCUMENT_EVIDENCE_INVALID') END; "
+            + "SELECT CASE WHEN NEW.source_document_ref IS NOT NULL AND NOT EXISTS (SELECT 1 FROM product_documents AS source JOIN product_intents AS intent ON intent.intent_ref=source.intent_ref WHERE source.document_ref=NEW.source_document_ref AND source.revision=NEW.source_document_revision AND source.file_path=NEW.file_path AND source.content_hash=NEW.content_hash AND source.updated_by_ref=NEW.updated_by_ref AND intent.materialized_task_id=NEW.task_id) THEN RAISE(ABORT, 'TASK_DOCUMENT_SOURCE_MISMATCH') END; END;",
+        "CREATE TRIGGER trg_product_document_transferred_immutable BEFORE UPDATE OF revision,file_path,content_hash,updated_by_ref ON product_documents WHEN EXISTS (SELECT 1 FROM task_documents WHERE source_document_ref=OLD.document_ref) BEGIN SELECT RAISE(ABORT, 'PRODUCT_DOCUMENT_ALREADY_TRANSFERRED'); END;",
+        "CREATE TRIGGER trg_task_documents_delete_evidence BEFORE DELETE ON task_documents BEGIN SELECT RAISE(ABORT, 'TASK_DOCUMENT_DELETE_FORBIDDEN'); END;",
+        "CREATE TRIGGER trg_product_document_transferred_delete_forbidden BEFORE DELETE ON product_documents WHEN EXISTS (SELECT 1 FROM task_documents WHERE source_document_ref=OLD.document_ref) BEGIN SELECT RAISE(ABORT, 'PRODUCT_DOCUMENT_DELETE_FORBIDDEN'); END;",
+    ].join("\n"),
+    verify: (database) => {
+        const issues = [];
+        if (!tableExists(database, "task_documents"))
+            return ["task_documents:missing"];
+        const columns = tableColumns(database, "task_documents");
+        for (const column of evidenceTaskDocumentColumns)
+            if (!columns.has(column))
+                issues.push("task_documents." + column + ":missing");
+        for (const trigger of [
+            "trg_task_documents_insert_evidence",
+            "trg_task_documents_update_evidence",
+            "trg_product_document_transferred_immutable",
+            "trg_task_documents_delete_evidence",
+            "trg_product_document_transferred_delete_forbidden",
+        ])
+            if (!triggerExists(database, trigger))
+                issues.push(trigger + ":missing");
+        const invalidRevision = database
+            .prepare("SELECT COUNT(*) AS count FROM task_documents WHERE revision < 1")
+            .get();
+        if (Number(invalidRevision.count) !== 0)
+            issues.push("task_documents.revision:invalid");
+        return issues;
+    },
+};
 export const taskMigrations = [
     ...legacyTaskMigrations.map((migration) => migration.version === 3 ? v3Compatible : migration),
     phase4Migration,
     gapReviewMigration,
     taskProductLinkIntegrityMigration,
+    taskDocumentEvidenceIntegrityMigration,
 ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomflow/proflow-task-store-sqlite",
-  "version": "0.1.13",
+  "version": "0.1.14",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -21,7 +21,7 @@
   ],
   "dependencies": {
     "@tomflow/proflow-module-contract": "^0.1.13",
-    "@tomflow/proflow-task-orchestration": "^0.1.13"
+    "@tomflow/proflow-task-orchestration": "^0.1.14"
   },
   "devDependencies": {
     "@tomflow/proflow-task-migration-runner": "^0.1.11"

package/proflow.module.json

@@ -3,7 +3,7 @@
 	"contractVersion": "1.0.0",
 	"moduleRef": "task-store-sqlite",
 	"packageName": "@tomflow/proflow-task-store-sqlite",
-	"moduleVersion": "0.1.13",
+	"moduleVersion": "0.1.14",
 	"kind": "library",
 	"templateVersion": "1.0.0",
 	"platformCompatibility": ">=1.0.0 <2.0.0",