@tomei/rental 0.17.4-dev.2 → 0.17.4-dev.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomei/rental",
-  "version": "0.17.4-dev.2",
+  "version": "0.17.4-dev.3",
   "description": "Tomei Rental Package",
   "main": "dist/index.js",
   "scripts": {

package/src/components/rental-hirer-change-request/rental-hirer-change-request.ts

@@ -445,6 +445,7 @@ export class RentalHirerChangeRequest
       }
 
       // 2. Prepare all signature data (main + joint) in one go
+      this.Rental.AccountType = RentalAccountTypeEnum.JOINT;
       const jointHirers = await this.Rental.getJointHirers(dbTransaction);
 
       // Main hirer signature
@@ -454,23 +455,32 @@ export class RentalHirerChangeRequest
       mainSignature.HirerType = HirerChangeRequestHirerRoleEnum.MAIN;
       mainSignature.Method = 'Upload';
 
-      // Joint hirer signatures
-      const jointSignaturePromises = jointHirers.map(async (jointHirer) => {
-        const signature = await HirerChangeRequestSignature.init();
-        signature.RequestId = this.RequestId;
-        signature.JointHirerId = jointHirer.HirerId;
-        signature.HirerType = HirerChangeRequestHirerRoleEnum.JOINT;
-        signature.Method = 'Upload';
-        return signature;
-      });
+      // Joint hirer signatures - only if there are joint hirers
+      let jointSignatures = [];
+      if (jointHirers.length > 0) {
+        const jointSignaturePromises = jointHirers.map(async (jointHirer) => {
+          const signature = await HirerChangeRequestSignature.init();
+          signature.RequestId = this.RequestId;
+          signature.JointHirerId = jointHirer.HirerId;
+          signature.HirerType = HirerChangeRequestHirerRoleEnum.JOINT;
+          signature.Method = 'Upload';
+          return signature;
+        });
 
-      const jointSignatures = await Promise.all(jointSignaturePromises);
+        jointSignatures = await Promise.all(jointSignaturePromises);
+      }
 
       // 3. Create all signatures in parallel
-      await Promise.all([
+      const signaturesToCreate = [
         mainSignature.create(loginUser, dbTransaction),
-        ...jointSignatures.map((sig) => sig.create(loginUser, dbTransaction)),
-      ]);
+      ];
+      if (jointSignatures.length > 0) {
+        signaturesToCreate.push(
+          ...jointSignatures.map((sig) => sig.create(loginUser, dbTransaction)),
+        );
+      }
+
+      await Promise.all(signaturesToCreate);
 
       this.Signatures = [mainSignature, ...jointSignatures];
     } catch (error) {