@tomei/finance 0.6.26 → 0.6.27

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomei/finance",
-  "version": "0.6.26",
+  "version": "0.6.27",
   "description": "NestJS package for finance module",
   "main": "dist/index.js",
   "scripts": {

package/src/finance-company/finance-company.ts

@@ -1784,7 +1784,7 @@ export default class FinanceCompany extends ObjectBase {
     dbTransaction: any,
     loginUser: LoginUserBase,
     payment: Payment,
-    creditTransactions: {
+    creditTransaction: {
       AccountNo: string;
       Currency: string;
       Amount: number;
@@ -1824,7 +1824,7 @@ export default class FinanceCompany extends ObjectBase {
       }
 
       //Make sure the payment items length is equal to creditTransactions length records.
-      if (paymentItems.length !== creditTransactions.length) {
+      if (paymentItems.length !== creditTransaction.length) {
         throw new Error(
           'Payment items length is not equal to creditTransaction length',
         );
@@ -1836,7 +1836,7 @@ export default class FinanceCompany extends ObjectBase {
         totalAmount += paymentItem.Amount;
       });
 
-      const totalCreditTransactionAmount = creditTransactions.reduce(
+      const totalCreditTransactionAmount = creditTransaction.reduce(
         (accumulator, currentValue) => {
           return accumulator + currentValue.Amount;
         },
@@ -1933,36 +1933,35 @@ export default class FinanceCompany extends ObjectBase {
 
       // For each Payment.PaymentPaidWith:
       for (const paymentPaidWithItem of paymentPaidWithItems) {
-        // check if its payment method type is valid.
-          const paymentMethodType = await PaymentMethodType.initMethodType(
-            dbTransaction,
-            paymentPaidWithItem.MethodTypeId,
-          );
+        const paymentMethodType = await PaymentMethodType.initMethodType(
+          dbTransaction,
+          paymentPaidWithItem.MethodTypeId,
+        );
 
-          //Initialise new Debit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method and set below attributes:
-          const debitLT = await journalEntry.newLedgerTransaction(
-            TransactionTypeOptions.DEBIT,
-          );
-          debitLT.AccountNo = paymentMethodType.AccountNo;
-          debitLT.Currency = paymentPaidWithItem.Currency;
-          debitLT.DebitAmount = paymentPaidWithItem.Amount;
-          debitLT.Date = transactionDate;
-          debitLT.Description = 'Payment Received';
-          debitLT.RelatedPaymentId = payment.PaymentId;
+        //Initialise new Debit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method and set below attributes:
+        const debitLT = await journalEntry.newLedgerTransaction(
+          TransactionTypeOptions.DEBIT,
+        );
+        debitLT.AccountNo = paymentMethodType.AccountNo;
+        debitLT.Currency = paymentPaidWithItem.Currency;
+        debitLT.DebitAmount = paymentPaidWithItem.Amount;
+        debitLT.Date = transactionDate;
+        debitLT.Description = 'Payment Received';
+        debitLT.RelatedPaymentId = payment.PaymentId;
       }
 
       //For each creditTransactions, Initialise new Credit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method
-      for (const creditTransaction of creditTransactions) {
+      for (const ct of creditTransaction) {
         const creditLT = await journalEntry.newLedgerTransaction(
           TransactionTypeOptions.CREDIT,
         );
-        creditLT.AccountNo = creditTransaction.AccountNo;
-        creditLT.Currency = creditTransaction.Currency;
-        creditLT.CreditAmount = creditTransaction.Amount;
+        creditLT.AccountNo = ct.AccountNo;
+        creditLT.Currency = ct.Currency;
+        creditLT.CreditAmount = ct.Amount;
         creditLT.Date = transactionDate;
         creditLT.Description = 'Payment Received';
         creditLT.RelatedPaymentId = payment.PaymentId;
-      };
+      }
 
       // Call this.postJournal()
       await this.postJournal(dbTransaction, journalEntry, loginUser);

package/src/journal-entry/journal-entry.ts

@@ -213,7 +213,6 @@ export default class JournalEntry extends AccountSystemEntity {
   /**
    * Create a new LedgerTransaction
    *
-   * @see {@link FinanceCompany.issueInvoice} - for implementation
    *
    * @param transactionType - Indicating the type of ledger transaction to create
    *