@tomei/finance 0.6.25 → 0.6.27

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomei/finance",
-  "version": "0.6.25",
+  "version": "0.6.27",
   "description": "NestJS package for finance module",
   "main": "dist/index.js",
   "scripts": {

package/src/finance-company/finance-company.ts

@@ -307,7 +307,7 @@ export default class FinanceCompany extends ObjectBase {
       // const customerId = await this.AccountingSystem.createCustomer({
       //   customer,
       // });
-      const customerId = "REF"
+      const customerId = 'REF';
 
       customer.CompanyId = this._CompanyId;
 
@@ -450,7 +450,7 @@ export default class FinanceCompany extends ObjectBase {
       //   createAccountPayload,
       // );
 
-      const accSystemAccountId = "REF"
+      const accSystemAccountId = 'REF';
 
       console.log(
         'Finance Company Create Account: After accSystemAccountId Create',
@@ -1932,48 +1932,39 @@ export default class FinanceCompany extends ObjectBase {
       const journalEntry = new JournalEntry(dbTransaction);
 
       // For each Payment.PaymentPaidWith:
-      paymentPaidWithItems.forEach(async (paymentPaidWithItem) => {
-        // check if its payment method type is valid.
-        try {
-          const paymentMethodType = await PaymentMethodType.initMethodType(
-            dbTransaction,
-            paymentPaidWithItem.MethodTypeId,
-          );
+      for (const paymentPaidWithItem of paymentPaidWithItems) {
+        const paymentMethodType = await PaymentMethodType.initMethodType(
+          dbTransaction,
+          paymentPaidWithItem.MethodTypeId,
+        );
 
-          //Initialise new Debit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method and set below attributes:
-          const debitLT = await journalEntry.newLedgerTransaction(
-            TransactionTypeOptions.DEBIT,
-          );
-          debitLT.AccountNo = paymentMethodType.AccountNo;
-          debitLT.Currency = paymentPaidWithItem.Currency;
-          debitLT.DebitAmount = paymentPaidWithItem.Amount;
-          debitLT.Date = transactionDate;
-          debitLT.Description = 'Payment Received';
-          debitLT.RelatedPaymentId = payment.PaymentId;
-        } catch (error) {
-          if (error instanceof RecordNotFoundError) {
-            throw new Error('Invalid Payment Method Type Id');
-          } else {
-            throw error;
-          }
-        }
-      });
+        //Initialise new Debit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method and set below attributes:
+        const debitLT = await journalEntry.newLedgerTransaction(
+          TransactionTypeOptions.DEBIT,
+        );
+        debitLT.AccountNo = paymentMethodType.AccountNo;
+        debitLT.Currency = paymentPaidWithItem.Currency;
+        debitLT.DebitAmount = paymentPaidWithItem.Amount;
+        debitLT.Date = transactionDate;
+        debitLT.Description = 'Payment Received';
+        debitLT.RelatedPaymentId = payment.PaymentId;
+      }
 
       //For each creditTransactions, Initialise new Credit LedgerTransaction by calling JournalEntry.newLedgerTransaction() method
-      creditTransaction.forEach(async (creditTransaction) => {
+      for (const ct of creditTransaction) {
         const creditLT = await journalEntry.newLedgerTransaction(
           TransactionTypeOptions.CREDIT,
         );
-        creditLT.AccountNo = creditTransaction.AccountNo;
-        creditLT.Currency = creditTransaction.Currency;
-        creditLT.CreditAmount = creditTransaction.Amount;
+        creditLT.AccountNo = ct.AccountNo;
+        creditLT.Currency = ct.Currency;
+        creditLT.CreditAmount = ct.Amount;
         creditLT.Date = transactionDate;
         creditLT.Description = 'Payment Received';
         creditLT.RelatedPaymentId = payment.PaymentId;
-      });
+      }
 
       // Call this.postJournal()
-      this.postJournal(dbTransaction, journalEntry, loginUser);
+      await this.postJournal(dbTransaction, journalEntry, loginUser);
 
       return payment;
     } catch (error) {

package/src/journal-entry/journal-entry.ts

@@ -213,7 +213,6 @@ export default class JournalEntry extends AccountSystemEntity {
   /**
    * Create a new LedgerTransaction
    *
-   * @see {@link FinanceCompany.issueInvoice} - for implementation
    *
    * @param transactionType - Indicating the type of ledger transaction to create
    *