@tomei/finance 0.3.57 → 0.3.58

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomei/finance",
-  "version": "0.3.57",
+  "version": "0.3.58",
   "description": "NestJS package for finance module",
   "main": "dist/index.js",
   "scripts": {

package/src/customer/customer.ts

@@ -19,6 +19,15 @@ export default abstract class FinanceCustomerBase
   extends AccountSystemEntity
   implements IPerson
 {
+  CustomerId = 'New';
+  CustSystemCode = '';
+  CustSystemRefId = '';
+
+  protected abstract ParentARAccountNo: string;
+  protected abstract ParentAPAccountNo: string;
+  protected abstract ARAccountNo: string;
+  protected abstract APAccountNo: string;
+
   abstract FullName: string;
   abstract IDNo: string;
   abstract IDType: string;
@@ -49,10 +58,6 @@ export default abstract class FinanceCustomerBase
   }
 
   protected static _FinanceCustomerRepository = new FinanceCustomerRepository();
-
-  CustomerId: string;
-  CustSystemCode: string;
-  CustSystemRefId: string;
   RepositoryBase: IRepositoryBase<any>;
 
   constructor(
@@ -140,8 +145,10 @@ export default abstract class FinanceCustomerBase
               this._AccountReceivable.OwnerId = accountData.OwnerId;
               this._AccountReceivable.OwnerType = accountData.OwnerType;
             } else {
-              this._AccountReceivable.AccountNo = `${this.CustSystemCode}-AR-123456789`;
-              this._AccountReceivable.ParentAccountNo = `${this.CustSystemCode}-AR`;
+              // this._AccountReceivable.AccountNo = `${this.CustSystemCode}-AR-123456789`;
+              // this._AccountReceivable.ParentAccountNo = `${this.CustSystemCode}-AR`;
+              this._AccountReceivable.AccountNo = this.ARAccountNo; //SystemInfo.SYSTEM_CODE + '-AR-' + '8 digit running no'
+              this._AccountReceivable.ParentAccountNo = this.ParentARAccountNo; //SystemInfo.SYSTEM_CODE + '-AR'
               this._AccountReceivable.AccountType = 'Account Receivable';
               this._AccountReceivable.OwnerId = this.CustomerId;
               this._AccountReceivable.OwnerType = type(this);
@@ -183,8 +190,10 @@ export default abstract class FinanceCustomerBase
               this._AccountPayable.OwnerId = accountData.OwnerId;
               this._AccountPayable.OwnerType = accountData.OwnerType;
             } else {
-              this._AccountPayable.AccountNo = `${this.CustSystemCode}-AP-123456789`;
-              this._AccountPayable.ParentAccountNo = `${this.CustSystemCode}-AP`;
+              // this._AccountPayable.AccountNo = `${this.CustSystemCode}-AP-123456789`;
+              // this._AccountPayable.ParentAccountNo = `${this.CustSystemCode}-AP`;
+              this._AccountPayable.AccountNo = this.APAccountNo; //SystemInfo.SYSTEM_CODE + '-AP-' + '8 digit running no'
+              this._AccountPayable.ParentAccountNo = this.ParentAPAccountNo; //SystemInfo.SYSTEM_CODE + '-AP'
               this._AccountPayable.AccountType = 'Account Payable';
               this._AccountPayable.OwnerId = this.CustomerId;
               this._AccountPayable.OwnerType = type(this);

package/src/document/document.ts

@@ -517,10 +517,15 @@ export default class Document extends AccountSystemEntity {
    *
    * @returns {DocumentItem}
    */
-  async newDocumentItem(documentItem?: any): Promise<DocumentItem> {
-    const di = new DocumentItem(this._DbTransaction, this);
+  async newDocumentItem(documentItem?: DocumentItem): Promise<DocumentItem> {
+    let di: DocumentItem;
+    if (documentItem) {
+      di = documentItem;
+    } else {
+      di = new DocumentItem(this._DbTransaction, this);
+    }
     di.DocNo = this.DocNo;
-    this._DocumentItems.push(documentItem);
+    this._DocumentItems.push(di);
     return documentItem;
   }
 

package/src/finance-company/finance-company.ts

@@ -567,6 +567,7 @@ export default class FinanceCompany extends ObjectBase {
       } else {
         /*todo: check config file to see which invoice template is to be used for specific project*/
         /*Generating invoice based on template*/
+        /*note: had to comment this due to unresolved */
         // invoice.generateInvoice(invoice.IssuedById);
       }
 

package/src/ledger-transaction/ledger-transaction.ts

@@ -9,6 +9,7 @@ export default class LedgerTransaction {
   JournalEntryId = '';
   AccountNo = '';
   Date = new Date();
+  Name = '';
   Description = '';
   Currency = 'MYR';
   DebitAmount = 0;

package/CHANGELOG.md

@@ -1 +0,0 @@
-RELEASE 1.0.0