@tomei/finance 0.3.22 → 0.3.24

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tomei/finance",
-  "version": "0.3.22",
+  "version": "0.3.24",
   "description": "NestJS package for finance module",
   "main": "dist/index.js",
   "scripts": {

package/src/finance-company/finance-company.ts

@@ -1034,6 +1034,11 @@ export default class FinanceCompany extends ObjectBase {
       });
 
       const journalEntry = new JournalEntry(dbTransaction);
+      //Temporary fix to successfully save journal entry in PostJournal
+      journalEntry.init({
+        CompanyId: this.CompanyId,
+        Name: 'Collect-payments for ' + payment.PaymentId,
+      });
       const transactionDate = new Date();
 
       const debitLT = await journalEntry.newLedgerTransaction(

package/src/journal-entry/interfaces/journal-entry-attr.interface.ts

@@ -1,11 +1,11 @@
 export interface IJournalEntryAttr {
-  CompanyId: string;
-  JournalEntryId: string;
+  CompanyId?: string;
+  JournalEntryId?: string;
   Date?: Date;
-  Name: string;
+  Name?: string;
   Description?: string;
   AccSystemRefId?: string;
-  PostedToAccSystemYN: string;
+  PostedToAccSystemYN?: string;
   PostedById?: string;
   PostedDateTime?: Date;
 }

package/src/journal-entry/journal-entry.ts

@@ -80,7 +80,7 @@ export default class JournalEntry extends AccountSystemEntity {
     } else {
       this.init({
         JournalEntryId: cuid(),
-        CompanyId: this.CompanyId,
+        CompanyId: '',
         Date: new Date(),
         Name: '',
         Description: '',
@@ -107,11 +107,11 @@ export default class JournalEntry extends AccountSystemEntity {
           })
           .then((debitTransactions) => {
             const debitTransactionObjects = debitTransactions.map(
-              (debitTransactionData) => new LedgerTransaction(
+              (debitTransactionData) =>
+                new LedgerTransaction(
                   this._DbTransaction,
                   debitTransactionData.TransactionId,
-                )
-              
+                ),
             );
             return Promise.all(debitTransactionObjects);
           })
@@ -142,12 +142,11 @@ export default class JournalEntry extends AccountSystemEntity {
           })
           .then((creditTransaction) => {
             const creditTransactionObjects = creditTransaction.map(
-              (creditTransactionData) => 
+              (creditTransactionData) =>
                 new LedgerTransaction(
                   this._DbTransaction,
                   creditTransactionData.TransactionId,
-                )
-              
+                ),
             );
             return Promise.all(creditTransactionObjects);
           })
@@ -214,13 +213,15 @@ export default class JournalEntry extends AccountSystemEntity {
   // }
 
   init(params: IJournalEntryAttr) {
-    this.JournalEntryId = params.JournalEntryId;
-    this.Date = params.Date;
-    this.Name = params.Name;
-    this.Description = params.Description;
-    this.PostedById = params.PostedById;
-    this.PostedToAccSystemYN = params.PostedToAccSystemYN;
-    this.PostedDateTime = params.PostedDateTime;
+    if (params.JournalEntryId) this.JournalEntryId = params.JournalEntryId;
+    if (params.CompanyId) this.CompanyId = params.CompanyId;
+    if (params.Date) this.Date = params.Date;
+    if (params.Name) this.Name = params.Name;
+    if (params.Description) this.Description = params.Description;
+    if (params.PostedById) this.PostedById = params.PostedById;
+    if (params.PostedToAccSystemYN)
+      this.PostedToAccSystemYN = params.PostedToAccSystemYN;
+    if (params.PostedDateTime) this.PostedDateTime = params.PostedDateTime;
   }
 
   getData() {
@@ -267,10 +268,7 @@ export default class JournalEntry extends AccountSystemEntity {
   async newLedgerTransaction(
     transactionType: TransactionTypeOptions,
   ): Promise<LedgerTransaction> {
-
-    const ledgerTransaction = new LedgerTransaction(
-      this._DbTransaction,
-    );
+    const ledgerTransaction = new LedgerTransaction(this._DbTransaction);
     ledgerTransaction.JournalEntryId = this.JournalEntryId;
 
     if (transactionType === TransactionTypeOptions.DEBIT) {