@tokenfactory/acc-runner 0.47.12 → 0.47.14

package/dist/task-runner.js

@@ -45,7 +45,7 @@ import { acquireTaskLock as defaultAcquireTaskLock, clearLocalTaskLock as defaul
 // RUNNER-HOOK-DIR-AND-LOCK-JANITOR-1: remove this task's commit-guard hooks dir
 // on every exit path (the janitor is the hourly backstop for leaks a crash left).
 import { removeTaskHookDir as defaultRemoveTaskHookDir } from "./runtime/janitor.js";
-import { prepareTaskWorktree as defaultPrepareTaskWorktree, WorktreeBranchTakenError, } from "./runtime/worktree.js";
+import { prepareTaskWorktree as defaultPrepareTaskWorktree, WorktreeBranchTakenError, findDanglingWarmCloneLinks, seedInstallSafeNodeModules, } from "./runtime/worktree.js";
 // v0.21 T-66-1: serialize the per-task worktree-provisioning critical section
 // against the shared clone so concurrent tasks can't collide on git's
 // repo-global locks (the T-65-2 race).
@@ -58,7 +58,7 @@ import { clonePathForRepo, ensureRepoClone, CloneFailedError, } from "./runtime/
 import { parseConflictMeta, resolveConflict, MAX_CONFLICT_ATTEMPTS, } from "./runtime/conflict-resolver.js";
 import { MAX_REWORK_CYCLES, parseReworkMeta, renderReworkPrompt, reconcileReworkBranch as defaultReconcileReworkBranch, fetchPrHeadRef as defaultFetchPrHeadRef, } from "./runtime/rework.js";
 import { assertResolutionIntegrity, isConflictResolutionTask, summariseFailures, } from "./runtime/resolution-integrity.js";
-import { depsMissingGateResult, depsStaleGateResult, gateFailureBlockReason, gateRunnerCrashResult, runPreprGate as defaultRunPreprGate, DEPS_MISSING_CLASSIFICATION, DEPS_STALE_CLASSIFICATION, GATE_TOOL_CRASHED_CLASSIFICATION, PREPR_GATE_FAILED_CLASSIFICATION, PREPR_GATES, } from "./prepr-gate.js";
+import { depsMissingGateResult, depsStaleGateResult, gateFailureBlockReason, gateRunnerCrashResult, runPreprGate as defaultRunPreprGate, classifyDanglingParentDeps, DEPS_MISSING_CLASSIFICATION, DEPS_STALE_CLASSIFICATION, GATE_TOOL_CRASHED_CLASSIFICATION, PREPR_GATE_FAILED_CLASSIFICATION, PREPR_GATES, } from "./prepr-gate.js";
 import { revalidateMigrationSeq as defaultRevalidateMigrationSeq, } from "./migration-seq-guard.js";
 import { readAppliedMigrationSeqs } from "./applied-seq-roster.js";
 import { commitGuardSkipRequested, gitConfigHooksEnv, installCommitGuardSync, } from "./commit-guard.js";
@@ -364,10 +364,13 @@ export async function ensureWorktreeNodeModules(workdir, repoPath, opts = {}) {
         try {
             if (!(await worktreePathExists(src)))
                 continue; // parent has no deps here
-            if (await worktreePathExists(dst))
+            // A resumed worktree seeded by an older runner holds ONE link to `src`: replace it.
+            const prior = await fs.promises.lstat(dst).catch(() => null);
+            if (prior && !prior.isSymbolicLink())
                 continue; // already present (resume/prior seed)
-            await fs.promises.mkdir(path.dirname(dst), { recursive: true });
-            await fs.promises.symlink(src, dst, "dir");
+            if (prior)
+                await fs.promises.unlink(dst);
+            await seedInstallSafeNodeModules(src, dst);
             linked.push(rel === "." ? "node_modules" : `${rel}/node_modules`);
         }
         catch (err) {
@@ -378,7 +381,7 @@ export async function ensureWorktreeNodeModules(workdir, repoPath, opts = {}) {
         linked,
         installed: false,
         detail: linked.length
-            ? `seeded ${linked.length} node_modules symlink(s) from warm clone`
+            ? `seeded ${linked.length} install-safe node_modules dir(s) from warm clone`
             : "worktree already provisioned; nothing to seed",
         depsMissing: false,
     };
@@ -429,7 +432,7 @@ export async function verifyWorktreeDepsFreshness(workdir, repoPath, opts = {})
         `node_modules were symlinked from`;
     const install = opts.install ?? defaultWorktreeInstall;
     try {
-        await install(workdir);
+        await install(workdir); // writes the worktree only: the seed is a real dir (LANE-WARM-CLONE-…-1)
         return {
             fresh: true, lockfileHash, parentLockfileHash, installed: true, depsMissing: false,
             detail: `${drift} — reinstalled in worktree`,
@@ -1981,6 +1984,15 @@ export function runTask(taskId, deps) {
              * with block_reason `gate_tool_crashed:<gate>`, which is still fail-CLOSED
              * because no PR is opened off a check that never ran.
              */
+            // LANE-WARM-CLONE-NODE-MODULES-REWRITE-1 (AC3): a module-resolution gate
+            // failure is a LANE fault (not a verdict on the diff) when the warm parent
+            // clone's node_modules links are dangling. Null → keep the code verdict.
+            const reclassifyDanglingParentDeps = async (fail) => {
+                if (fail.gate === "deps" || fail.gate === "deps-stale")
+                    return null;
+                const dangling = await findDanglingWarmCloneLinks(repoPath).catch(() => []);
+                return classifyDanglingParentDeps(fail, repoPath, dangling, deps.session.runnerId);
+            };
             const handleGateToolCrash = async (result, crash, rework) => {
                 // Advisory probe: a GitHub hiccup must never be what decides this, so an
                 // unreadable probe degrades to "no PR" — and that route is `blocked`,
@@ -3426,12 +3438,18 @@ export function runTask(taskId, deps) {
                         // WORKTREE-STALE-DEPS-1: `deps-stale` is the sibling environment
                         // fault (deps WERE seeded, the merge above left them stale) — kept
                         // out of the generic `rework_gate_failed` bucket for the same reason.
-                        const blockReason = gateFailureBlockReason(fail.gate);
-                        const errorClass = fail.gate === "deps"
-                            ? DEPS_MISSING_CLASSIFICATION
-                            : fail.gate === "deps-stale"
-                                ? DEPS_STALE_CLASSIFICATION
-                                : "rework_gate_failed";
+                        // LANE-WARM-CLONE-NODE-MODULES-REWRITE-1 (AC3): a dangling warm clone
+                        // is a lane fault here too — out of the `rework_gate_failed` bucket.
+                        const dangling = await reclassifyDanglingParentDeps(fail);
+                        const blockReason = dangling ? dangling.blockReason : gateFailureBlockReason(fail.gate);
+                        const errorClass = dangling
+                            ? dangling.errorClass
+                            : fail.gate === "deps"
+                                ? DEPS_MISSING_CLASSIFICATION
+                                : fail.gate === "deps-stale"
+                                    ? DEPS_STALE_CLASSIFICATION
+                                    : "rework_gate_failed";
+                        const stderrTail = dangling ? dangling.notice : fail.outputTail;
                         await appendEvent(deps.supabase, taskId, "rework_halt", {
                             phase: "prepr_gate",
                             pr_number: reworkMeta.pr_number,
@@ -3446,7 +3464,7 @@ export function runTask(taskId, deps) {
                             // it TIMED OUT, so a timeout halt is distinguishable from a genuine
                             // assertion halt without hand-querying stderr_tail.
                             ...gateFailureRecordFields(fail),
-                            stderr_tail: fail.outputTail,
+                            stderr_tail: stderrTail,
                             runner_id: deps.session.runnerId,
                         });
                         await emitGateTimeoutBreadcrumb(fail);
@@ -3459,7 +3477,7 @@ export function runTask(taskId, deps) {
                             error_class: errorClass,
                             block_reason: blockReason,
                             failed_gate: fail.gate,
-                            stderr_tail: fail.outputTail,
+                            stderr_tail: stderrTail,
                         });
                         await transitionBlocked(blockReason, {
                             phase: "prepr_gate",
@@ -3603,18 +3621,27 @@ export function runTask(taskId, deps) {
                     // a rework merge just left them stale — kept as its own class end-to-end
                     // so triage never conflates "no environment" with "stale environment".
                     const depsStale = fail.gate === "deps-stale";
-                    const envFault = depsMissing || depsStale;
-                    const blockReason = gateFailureBlockReason(fail.gate);
-                    const errorClass = depsMissing
-                        ? DEPS_MISSING_CLASSIFICATION
-                        : depsStale
-                            ? DEPS_STALE_CLASSIFICATION
-                            : PREPR_GATE_FAILED_CLASSIFICATION;
-                    const summary = depsMissing
-                        ? `pre-PR gate could not run: worktree has no node_modules (${blockReason}) — PR not opened`
-                        : depsStale
-                            ? `pre-PR gate could not run: worktree deps are stale vs the merged lockfile (${blockReason}) — PR not opened`
-                            : `pre-PR ${fail.gate} gate failed (${blockReason}, exit ${fail.exitCode ?? "signal"}) — PR not opened`;
+                    // LANE-WARM-CLONE-NODE-MODULES-REWRITE-1 (AC3): a module-resolution
+                    // failure over a DANGLING warm clone is a lane fault, parked (not a code
+                    // reject) so the sweep requeues it losslessly.
+                    const dangling = await reclassifyDanglingParentDeps(fail);
+                    const envFault = depsMissing || depsStale || dangling !== null;
+                    const blockReason = dangling ? dangling.blockReason : gateFailureBlockReason(fail.gate);
+                    const errorClass = dangling
+                        ? dangling.errorClass
+                        : depsMissing
+                            ? DEPS_MISSING_CLASSIFICATION
+                            : depsStale
+                                ? DEPS_STALE_CLASSIFICATION
+                                : PREPR_GATE_FAILED_CLASSIFICATION;
+                    const stderrTail = dangling ? dangling.notice : fail.outputTail;
+                    const summary = dangling
+                        ? `pre-PR ${fail.gate} gate could not run: the warm clone's node_modules dangle (${blockReason}) — lane fault, PR not opened`
+                        : depsMissing
+                            ? `pre-PR gate could not run: worktree has no node_modules (${blockReason}) — PR not opened`
+                            : depsStale
+                                ? `pre-PR gate could not run: worktree deps are stale vs the merged lockfile (${blockReason}) — PR not opened`
+                                : `pre-PR ${fail.gate} gate failed (${blockReason}, exit ${fail.exitCode ?? "signal"}) — PR not opened`;
                     await appendEvent(deps.supabase, taskId, "error", {
                         phase: "prepr_gate",
                         error_class: errorClass,
@@ -3626,7 +3653,7 @@ export function runTask(taskId, deps) {
                         // PREPR-GATE-TIMEOUT-VISIBILITY-1: same structured timeout/assertion
                         // fingerprint as the rework_halt path above.
                         ...gateFailureRecordFields(fail),
-                        stderr_tail: fail.outputTail,
+                        stderr_tail: stderrTail,
                         runner_id: deps.session.runnerId,
                     });
                     // RUNNER-TEST-HANG-SLOT-LEAK-1: a wall-clock test-gate timeout gets its
@@ -3641,7 +3668,7 @@ export function runTask(taskId, deps) {
                         error_class: errorClass,
                         block_reason: blockReason,
                         failed_gate: fail.gate,
-                        stderr_tail: fail.outputTail,
+                        stderr_tail: stderrTail,
                     });
                     if (envFault) {
                         // Park, never fail — same reasoning as a crashed gate tool