@tobyt/expo-pdf-markup 1.1.4 → 2.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (55) hide show
  1. package/CHANGELOG.md +22 -0
  2. package/README.md +18 -0
  3. package/android/build.gradle +3 -0
  4. package/android/src/main/java/dev/terhoeven/expopdfmarkup/BookPager.kt +66 -0
  5. package/android/src/main/java/dev/terhoeven/expopdfmarkup/BookTurnPolicy.kt +117 -0
  6. package/android/src/main/java/dev/terhoeven/expopdfmarkup/ContinuousPdfView.kt +370 -57
  7. package/android/src/main/java/dev/terhoeven/expopdfmarkup/ExpoPdfMarkupModule.kt +4 -0
  8. package/android/src/main/java/dev/terhoeven/expopdfmarkup/ExpoPdfMarkupView.kt +96 -5
  9. package/build/ExpoPdfMarkup.types.d.ts +19 -1
  10. package/build/ExpoPdfMarkup.types.d.ts.map +1 -1
  11. package/build/ExpoPdfMarkup.types.js.map +1 -1
  12. package/build/ExpoPdfMarkupView.web.d.ts.map +1 -1
  13. package/build/ExpoPdfMarkupView.web.js +396 -65
  14. package/build/ExpoPdfMarkupView.web.js.map +1 -1
  15. package/build/web/bookMode.d.ts +77 -0
  16. package/build/web/bookMode.d.ts.map +1 -0
  17. package/build/web/bookMode.js +169 -0
  18. package/build/web/bookMode.js.map +1 -0
  19. package/build/web/layout.d.ts +8 -0
  20. package/build/web/layout.d.ts.map +1 -0
  21. package/build/web/layout.js +22 -0
  22. package/build/web/layout.js.map +1 -0
  23. package/build/web/types.d.ts +2 -0
  24. package/build/web/types.d.ts.map +1 -1
  25. package/build/web/types.js.map +1 -1
  26. package/docs/agents/domain.md +51 -0
  27. package/docs/agents/issue-tracker.md +46 -0
  28. package/docs/agents/triage-labels.md +15 -0
  29. package/docs/annotation-coordinates.md +45 -0
  30. package/docs/annotation-validation.md +117 -0
  31. package/fixtures/annotations-v1.json +130 -0
  32. package/ios/AnnotationModels.swift +29 -30
  33. package/ios/AnnotationSerializer.swift +99 -12
  34. package/ios/ExpoPdfMarkupModule.swift +4 -0
  35. package/ios/ExpoPdfMarkupView+Book.swift +455 -0
  36. package/ios/ExpoPdfMarkupView+Ink.swift +13 -28
  37. package/ios/ExpoPdfMarkupView+Markup.swift +151 -0
  38. package/ios/ExpoPdfMarkupView+Move.swift +17 -6
  39. package/ios/ExpoPdfMarkupView.swift +76 -84
  40. package/ios/StampPDFAnnotation.swift +21 -3
  41. package/ios/Tests/AnnotationCoordinateTests.swift +337 -0
  42. package/ios/Tests/AnnotationSerializerTests.swift +43 -1
  43. package/ios/Tests/AreaMarkupTests.swift +279 -0
  44. package/ios/Tests/BookModeTests.swift +534 -0
  45. package/ios/Tests/ExpoPdfMarkupViewTests.swift +29 -0
  46. package/ios/Tests/RotatedAnnotationRenderingTests.swift +411 -0
  47. package/ios/Tests/book-sample.pdf +207 -0
  48. package/ios/Tests/single-page.pdf +52 -0
  49. package/package.json +3 -2
  50. package/src/ExpoPdfMarkup.types.ts +20 -1
  51. package/src/ExpoPdfMarkupView.web.tsx +471 -70
  52. package/src/web/bookMode.ts +186 -0
  53. package/src/web/layout.ts +30 -0
  54. package/src/web/types.ts +3 -0
  55. package/tsconfig.test.json +10 -0
@@ -0,0 +1,534 @@
1
+ @testable internal import ExpoPdfMarkup
2
+ import PDFKit
3
+ import XCTest
4
+
5
+ final class BookModeTests: XCTestCase {
6
+ var view: ExpoPdfMarkupView!
7
+ var reportedPages: [Int] = []
8
+
9
+ override func setUp() {
10
+ super.setUp()
11
+ view = ExpoPdfMarkupView(appContext: nil)
12
+ view.frame = CGRect(x: 0, y: 0, width: 400, height: 600)
13
+ view.layoutIfNeeded()
14
+ reportedPages = []
15
+ view.onPageChanged.onEventSent = { [weak self] payload in
16
+ if let page = payload["page"] as? Int {
17
+ self?.reportedPages.append(page)
18
+ }
19
+ }
20
+ }
21
+
22
+ override func tearDown() {
23
+ view = nil
24
+ super.tearDown()
25
+ }
26
+
27
+ private func fixturePath(_ name: String) throws -> String {
28
+ let url = Bundle(for: type(of: self)).url(forResource: name, withExtension: "pdf")
29
+ return try XCTUnwrap(url, "\(name).pdf missing from test bundle").path
30
+ }
31
+
32
+ private func loadBook(_ name: String = "book-sample", startPage: Int = 0) throws {
33
+ view.setDisplayMode("book")
34
+ try view.loadPdf(from: fixturePath(name))
35
+ view.layoutIfNeeded()
36
+ view.goToPage(startPage)
37
+ reportedPages = []
38
+ }
39
+
40
+ private var shownPage: Int? {
41
+ guard let document = view.pdfView.document, let page = view.pdfView.currentPage else { return nil }
42
+ return document.index(for: page)
43
+ }
44
+
45
+ // MARK: - Presentation
46
+
47
+ func testBookModeShowsOnePageAtATime() throws {
48
+ try loadBook()
49
+ XCTAssertEqual(view.pdfView.displayMode, .singlePage)
50
+ XCTAssertTrue(view.pdfView.autoScales)
51
+ }
52
+
53
+ func testSwitchingModesKeepsTheCurrentPage() throws {
54
+ try view.loadPdf(from: fixturePath("book-sample"))
55
+ view.layoutIfNeeded()
56
+ view.goToPage(3)
57
+ reportedPages = []
58
+
59
+ view.setDisplayMode("book")
60
+ XCTAssertEqual(shownPage, 3)
61
+ XCTAssertEqual(reportedPages, [], "switching mode is not a turn")
62
+
63
+ view.setDisplayMode("continuous")
64
+ XCTAssertEqual(shownPage, 3)
65
+ XCTAssertEqual(view.pdfView.displayMode, .singlePageContinuous)
66
+ }
67
+
68
+ func testContinuousModeIsLeftAsItWas() throws {
69
+ let gesturesBefore = view.pdfView.gestureRecognizers?.count ?? 0
70
+ view.setDisplayMode("book")
71
+ view.setDisplayMode("continuous")
72
+ try view.loadPdf(from: fixturePath("book-sample"))
73
+
74
+ XCTAssertEqual(view.pdfView.displayMode, .singlePageContinuous)
75
+ XCTAssertEqual(view.pdfView.displayDirection, .vertical)
76
+ XCTAssertEqual(view.pdfView.pageBreakMargins, UIEdgeInsets(top: 0, left: 0, bottom: 8, right: 0))
77
+ XCTAssertEqual(view.pdfView.gestureRecognizers?.count ?? 0, gesturesBefore)
78
+ }
79
+
80
+ func testRotatingOrResizingKeepsTheCurrentPage() throws {
81
+ try loadBook(startPage: 3)
82
+ view.frame = CGRect(x: 0, y: 0, width: 600, height: 400)
83
+ view.layoutIfNeeded()
84
+ XCTAssertEqual(shownPage, 3)
85
+ XCTAssertEqual(view.pdfView.frame, view.bounds)
86
+ XCTAssertEqual(reportedPages, [])
87
+ }
88
+
89
+ func testDisplayModeSetBeforeTheSourceStillAppliesBookMode() throws {
90
+ try loadBook()
91
+ XCTAssertEqual(shownPage, 0)
92
+ XCTAssertEqual(view.pdfView.displayMode, .singlePage)
93
+ }
94
+
95
+ // MARK: - Edge taps
96
+
97
+ func testTappingTheRightEdgeTurnsToTheNextPage() throws {
98
+ try loadBook(startPage: 2)
99
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
100
+ XCTAssertEqual(shownPage, 3)
101
+ XCTAssertEqual(reportedPages, [3])
102
+ }
103
+
104
+ func testTappingTheLeftEdgeTurnsToThePreviousPage() throws {
105
+ try loadBook(startPage: 2)
106
+ view.handleBookTap(at: CGPoint(x: 5, y: 300))
107
+ XCTAssertEqual(shownPage, 1)
108
+ XCTAssertEqual(reportedPages, [1])
109
+ }
110
+
111
+ func testEdgeZonesAreTheOuterQuarter() throws {
112
+ try loadBook(startPage: 2)
113
+ view.handleBookTap(at: CGPoint(x: 101, y: 300))
114
+ view.handleBookTap(at: CGPoint(x: 200, y: 300))
115
+ view.handleBookTap(at: CGPoint(x: 299, y: 300))
116
+ XCTAssertEqual(shownPage, 2, "a tap in the middle does nothing")
117
+ XCTAssertEqual(reportedPages, [])
118
+
119
+ view.handleBookTap(at: CGPoint(x: 99, y: 300))
120
+ XCTAssertEqual(shownPage, 1)
121
+ }
122
+
123
+ func testEdgeZonesAreAtLeast44PointsWide() throws {
124
+ view.frame = CGRect(x: 0, y: 0, width: 120, height: 400)
125
+ view.layoutIfNeeded()
126
+ try loadBook(startPage: 2)
127
+
128
+ view.handleBookTap(at: CGPoint(x: 42, y: 200))
129
+ XCTAssertEqual(shownPage, 1)
130
+ view.handleBookTap(at: CGPoint(x: 78, y: 200))
131
+ XCTAssertEqual(shownPage, 2)
132
+ view.handleBookTap(at: CGPoint(x: 60, y: 200))
133
+ XCTAssertEqual(shownPage, 2)
134
+ }
135
+
136
+ func testTheSecondTapOfADoubleTapOnAnEdgeDoesNotTurnAgain() throws {
137
+ try loadBook(startPage: 2)
138
+ view.handleBookTap(at: CGPoint(x: 395, y: 300), tapCount: 1)
139
+ view.handleBookTap(at: CGPoint(x: 395, y: 300), tapCount: 2)
140
+ XCTAssertEqual(shownPage, 3, "a double-tap on an edge turns once")
141
+ view.handleBookTap(at: CGPoint(x: 395, y: 300), tapCount: 3)
142
+ XCTAssertEqual(shownPage, 4, "a third quick tap starts a new pair, as on Android")
143
+ XCTAssertEqual(reportedPages, [3, 4])
144
+ }
145
+
146
+ func testDoubleTapZoomsOnlyInTheMiddleRegion() throws {
147
+ try loadBook(startPage: 2)
148
+ XCTAssertNotNil(view.bookEdgeTurn(at: CGPoint(x: 395, y: 300)), "an edge double-tap is held back from zooming")
149
+ XCTAssertNotNil(view.bookEdgeTurn(at: CGPoint(x: 5, y: 300)))
150
+ XCTAssertNil(view.bookEdgeTurn(at: CGPoint(x: 200, y: 300)), "a double-tap in the middle zooms")
151
+
152
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
153
+ XCTAssertNil(view.bookEdgeTurn(at: CGPoint(x: 395, y: 300)), "zoomed in, edges don't turn, so double-tap zooms out")
154
+ }
155
+
156
+ @MainActor func testPDFKitDoubleTapZoomWaitsForTheEdgeDoubleTap() throws {
157
+ let window = hostInWindow()
158
+ try loadBook()
159
+ let edgeDoubleTap = try XCTUnwrap(view.bookEdgeDoubleTapGesture)
160
+ XCTAssertEqual(edgeDoubleTap.numberOfTapsRequired, 2)
161
+ let pdfKitDoubleTap = try XCTUnwrap(
162
+ view.pdfView.gestureRecognizers?.compactMap { $0 as? UITapGestureRecognizer }
163
+ .first { $0 !== edgeDoubleTap && $0.numberOfTapsRequired == 2 },
164
+ "PDFView has its own double-tap zoom"
165
+ )
166
+ let delegate = try XCTUnwrap(edgeDoubleTap.delegate)
167
+ XCTAssertEqual(
168
+ delegate.gestureRecognizer?(edgeDoubleTap, shouldBeRequiredToFailBy: pdfKitDoubleTap),
169
+ true
170
+ )
171
+ XCTAssertNotEqual(
172
+ try delegate.gestureRecognizer?(edgeDoubleTap, shouldBeRequiredToFailBy: XCTUnwrap(view.bookTapGesture)),
173
+ true,
174
+ "single edge taps still turn straight away"
175
+ )
176
+
177
+ view.setDisplayMode("continuous")
178
+ XCTAssertNil(view.bookEdgeDoubleTapGesture)
179
+ window.isHidden = true
180
+ }
181
+
182
+ func testEdgeTapsDoNothingInContinuousMode() throws {
183
+ try view.loadPdf(from: fixturePath("book-sample"))
184
+ view.layoutIfNeeded()
185
+ view.goToPage(2)
186
+ reportedPages = []
187
+
188
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
189
+ XCTAssertEqual(shownPage, 2)
190
+ XCTAssertEqual(reportedPages, [])
191
+ }
192
+
193
+ // MARK: - Swipes
194
+
195
+ func testSwipingLeftTurnsToTheNextPage() throws {
196
+ try loadBook(startPage: 2)
197
+ view.endBookSwipe(translationX: -150, velocityX: -300)
198
+ XCTAssertEqual(shownPage, 3)
199
+ XCTAssertEqual(reportedPages, [3])
200
+ }
201
+
202
+ func testSwipingRightTurnsToThePreviousPage() throws {
203
+ try loadBook(startPage: 2)
204
+ view.endBookSwipe(translationX: 150, velocityX: 300)
205
+ XCTAssertEqual(shownPage, 1)
206
+ XCTAssertEqual(reportedPages, [1])
207
+ }
208
+
209
+ func testAFastFlickTurnsEvenOverAShortDistance() throws {
210
+ try loadBook(startPage: 2)
211
+ view.endBookSwipe(translationX: -30, velocityX: -900)
212
+ XCTAssertEqual(shownPage, 3)
213
+ }
214
+
215
+ func testAShortSlowDragSpringsBackWithoutTurning() throws {
216
+ try loadBook(startPage: 2)
217
+ view.endBookSwipe(translationX: -30, velocityX: -50)
218
+ XCTAssertEqual(shownPage, 2)
219
+ XCTAssertEqual(reportedPages, [])
220
+ }
221
+
222
+ func testSwipeLeftMeansNextInARightToLeftLayout() throws {
223
+ view.semanticContentAttribute = .forceRightToLeft
224
+ view.pdfView.semanticContentAttribute = .forceRightToLeft
225
+ try loadBook(startPage: 2)
226
+ view.endBookSwipe(translationX: -150, velocityX: -300)
227
+ XCTAssertEqual(shownPage, 3)
228
+ }
229
+
230
+ func testSwipesDoNotTurnWithAMarkupToolActive() throws {
231
+ try loadBook(startPage: 2)
232
+ view.setAnnotationMode("ink")
233
+ view.endBookSwipe(translationX: -150, velocityX: -300)
234
+ XCTAssertEqual(shownPage, 2)
235
+ XCTAssertEqual(reportedPages, [])
236
+ }
237
+
238
+ func testSwipesDoNotTurnWhileZoomedIn() throws {
239
+ try loadBook(startPage: 2)
240
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
241
+ view.endBookSwipe(translationX: -150, velocityX: -300)
242
+ XCTAssertEqual(shownPage, 2)
243
+ XCTAssertEqual(reportedPages, [])
244
+ }
245
+
246
+ func testSwipingPastTheLastPageBounces() throws {
247
+ try loadBook(startPage: 5)
248
+ view.endBookSwipe(translationX: -150, velocityX: -300)
249
+ XCTAssertEqual(shownPage, 5)
250
+ XCTAssertEqual(reportedPages, [])
251
+ }
252
+
253
+ // MARK: - Animation on screen
254
+
255
+ private func hostInWindow() -> UIWindow {
256
+ let window = UIWindow(frame: view.frame)
257
+ window.addSubview(view)
258
+ window.isHidden = false
259
+ view.layoutIfNeeded()
260
+ return window
261
+ }
262
+
263
+ private func waitForAnimations() {
264
+ let settled = expectation(description: "animations settle")
265
+ DispatchQueue.main.asyncAfter(deadline: .now() + 0.8) { settled.fulfill() }
266
+ wait(for: [settled], timeout: 2)
267
+ }
268
+
269
+ func testAnimatedTurnSlidesAndSettlesOnTheNewPage() throws {
270
+ let window = hostInWindow()
271
+ try loadBook(startPage: 2)
272
+ let subviewsBefore = view.subviews.count
273
+
274
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
275
+ XCTAssertEqual(shownPage, 3)
276
+ XCTAssertNotNil(view.pdfView.layer.animationKeys(), "the new page slides in")
277
+ XCTAssertEqual(view.subviews.count, subviewsBefore + 1, "the outgoing page slides out")
278
+
279
+ waitForAnimations()
280
+ XCTAssertEqual(view.pdfView.transform, .identity)
281
+ XCTAssertEqual(view.subviews.count, subviewsBefore, "the outgoing snapshot is removed")
282
+ XCTAssertEqual(reportedPages, [3])
283
+ window.isHidden = true
284
+ }
285
+
286
+ func testAnimatedBounceReturnsToRest() throws {
287
+ let window = hostInWindow()
288
+ try loadBook(startPage: 5)
289
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
290
+ waitForAnimations()
291
+ XCTAssertEqual(view.pdfView.transform, .identity)
292
+ XCTAssertEqual(shownPage, 5)
293
+ window.isHidden = true
294
+ }
295
+
296
+ // MARK: - Ends of the document
297
+
298
+ func testTurningBeforeTheFirstPageBouncesBack() throws {
299
+ try loadBook(startPage: 0)
300
+ view.handleBookTap(at: CGPoint(x: 5, y: 300))
301
+ XCTAssertEqual(shownPage, 0)
302
+ XCTAssertEqual(reportedPages, [])
303
+ }
304
+
305
+ func testTurningPastTheLastPageBouncesAndDoesNotWrap() throws {
306
+ try loadBook(startPage: 5)
307
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
308
+ XCTAssertEqual(shownPage, 5)
309
+ XCTAssertEqual(reportedPages, [])
310
+ }
311
+
312
+ func testAOnePageDocumentNeverTurns() throws {
313
+ try loadBook("single-page")
314
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
315
+ view.handleBookTap(at: CGPoint(x: 5, y: 300))
316
+ XCTAssertEqual(shownPage, 0)
317
+ XCTAssertEqual(reportedPages, [])
318
+ }
319
+
320
+ // MARK: - page prop and onPageChanged
321
+
322
+ func testPagePropJumpsInBookMode() throws {
323
+ try loadBook(startPage: 0)
324
+ view.goToPage(4)
325
+ XCTAssertEqual(shownPage, 4)
326
+ XCTAssertEqual(reportedPages, [4])
327
+ }
328
+
329
+ func testPagePropResetsTheNewPageToFit() throws {
330
+ try loadBook(startPage: 2)
331
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
332
+ view.goToPage(4)
333
+ XCTAssertEqual(shownPage, 4)
334
+ XCTAssertEqual(view.pdfView.scaleFactor, view.pdfView.scaleFactorForSizeToFit, accuracy: 0.001)
335
+ XCTAssertTrue(view.pdfView.autoScales)
336
+ XCTAssertEqual(reportedPages, [4], "a jump reports the new page once")
337
+ }
338
+
339
+ func testOnPageChangedFiresOncePerTurn() throws {
340
+ try loadBook(startPage: 0)
341
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
342
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
343
+ view.handleBookTap(at: CGPoint(x: 5, y: 300))
344
+ XCTAssertEqual(reportedPages, [1, 2, 1])
345
+ }
346
+
347
+ // MARK: - Turn policy
348
+
349
+ func testEdgeTapsDoNotTurnWithAnyMarkupToolActive() throws {
350
+ try loadBook(startPage: 2)
351
+ for mode in ["ink", "highlight", "underline", "text", "stamp", "move", "eraser"] {
352
+ view.setAnnotationMode(mode)
353
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
354
+ view.handleBookTap(at: CGPoint(x: 5, y: 300))
355
+ XCTAssertEqual(shownPage, 2, "\(mode) must block edge taps")
356
+ }
357
+ XCTAssertEqual(reportedPages, [])
358
+
359
+ view.setAnnotationMode("none")
360
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
361
+ XCTAssertEqual(shownPage, 3)
362
+ }
363
+
364
+ func testInkLandsOnThePageShownInBookMode() throws {
365
+ try loadBook(startPage: 3)
366
+ view.setAnnotationMode("ink")
367
+ let overlay = try XCTUnwrap(view.inkOverlayView)
368
+ overlay.onBegan?(CGPoint(x: 150, y: 250))
369
+ overlay.onMoved?(CGPoint(x: 200, y: 300))
370
+ overlay.onMoved?(CGPoint(x: 250, y: 350))
371
+ overlay.onEnded?()
372
+
373
+ XCTAssertEqual(shownPage, 3)
374
+ let data = try XCTUnwrap(AnnotationSerializer.deserialize(from: view.serializeCurrentAnnotations()))
375
+ XCTAssertEqual(data.annotations.map(\.page), [3])
376
+ }
377
+
378
+ func testEdgeTapsDoNotTurnWhileZoomedIn() throws {
379
+ try loadBook(startPage: 2)
380
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
381
+ view.handleBookTap(at: CGPoint(x: 395, y: 300))
382
+ XCTAssertEqual(shownPage, 2)
383
+ XCTAssertEqual(reportedPages, [])
384
+ }
385
+
386
+ func testTurningResetsTheNewPageToFit() throws {
387
+ try loadBook(startPage: 2)
388
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
389
+ XCTAssertTrue(view.turnBookPage(.next, from: .key))
390
+ XCTAssertEqual(shownPage, 3)
391
+ XCTAssertEqual(view.pdfView.scaleFactor, view.pdfView.scaleFactorForSizeToFit, accuracy: 0.001)
392
+ }
393
+
394
+ // MARK: - Hardware keys
395
+
396
+ private static let nextKeys = [UIKeyCommand.inputRightArrow, UIKeyCommand.inputDownArrow, UIKeyCommand.inputPageDown]
397
+ private static let previousKeys = [UIKeyCommand.inputLeftArrow, UIKeyCommand.inputUpArrow, UIKeyCommand.inputPageUp]
398
+
399
+ /// The key command the view offers UIKit for an unmodified `input`, if any.
400
+ private func keyCommand(_ input: String) -> UIKeyCommand? {
401
+ view.keyCommands?.first { $0.input == input && $0.modifierFlags.isEmpty }
402
+ }
403
+
404
+ /// Presses `input` the way UIKit delivers a hardware key: through the view's key command.
405
+ /// A key the view has no command for does nothing.
406
+ private func press(_ input: String) {
407
+ guard let command = keyCommand(input), let action = command.action else { return }
408
+ view.perform(action, with: command)
409
+ }
410
+
411
+ func testRightDownAndPageDownTurnToTheNextPage() throws {
412
+ for input in Self.nextKeys {
413
+ try loadBook(startPage: 2)
414
+ press(input)
415
+ XCTAssertEqual(shownPage, 3, "\(input) goes to the next page")
416
+ XCTAssertEqual(reportedPages, [3])
417
+ }
418
+ }
419
+
420
+ func testLeftUpAndPageUpTurnToThePreviousPage() throws {
421
+ for input in Self.previousKeys {
422
+ try loadBook(startPage: 2)
423
+ press(input)
424
+ XCTAssertEqual(shownPage, 1, "\(input) goes to the previous page")
425
+ XCTAssertEqual(reportedPages, [1])
426
+ }
427
+ }
428
+
429
+ func testArrowKeysTakePriorityOverSystemScrolling() throws {
430
+ try loadBook()
431
+ for input in Self.nextKeys + Self.previousKeys {
432
+ XCTAssertEqual(keyCommand(input)?.wantsPriorityOverSystemBehavior, true, input)
433
+ }
434
+ }
435
+
436
+ func testSpaceIsNotMapped() throws {
437
+ try loadBook(startPage: 2)
438
+ XCTAssertNil(keyCommand(" "))
439
+ press(" ")
440
+ XCTAssertEqual(shownPage, 2)
441
+ XCTAssertEqual(reportedPages, [])
442
+ }
443
+
444
+ func testContinuousModeRespondsToNoKeys() throws {
445
+ try view.loadPdf(from: fixturePath("book-sample"))
446
+ view.layoutIfNeeded()
447
+ view.goToPage(2)
448
+ reportedPages = []
449
+
450
+ XCTAssertTrue(view.keyCommands?.isEmpty ?? true)
451
+ XCTAssertFalse(view.canBecomeFirstResponder)
452
+ for input in Self.nextKeys + Self.previousKeys {
453
+ press(input)
454
+ }
455
+ XCTAssertEqual(reportedPages, [])
456
+ }
457
+
458
+ func testKeysTurnWhileZoomedInAndWithAMarkupToolActive() throws {
459
+ try loadBook(startPage: 2)
460
+ view.setAnnotationMode("ink")
461
+ view.pdfView.scaleFactor = view.pdfView.scaleFactorForSizeToFit * 2
462
+
463
+ press(UIKeyCommand.inputPageDown)
464
+ XCTAssertEqual(shownPage, 3)
465
+ for mode in ["highlight", "underline", "text", "stamp", "move", "eraser"] {
466
+ view.setAnnotationMode(mode)
467
+ press(UIKeyCommand.inputLeftArrow)
468
+ }
469
+ XCTAssertEqual(reportedPages, [3, 2, 1, 0])
470
+ }
471
+
472
+ func testKeyTurnsBounceAtBothEndsAndReportOncePerTurn() throws {
473
+ try loadBook(startPage: 0)
474
+ press(UIKeyCommand.inputLeftArrow)
475
+ XCTAssertEqual(shownPage, 0)
476
+ XCTAssertEqual(reportedPages, [])
477
+
478
+ for _ in 0 ..< 8 {
479
+ press(UIKeyCommand.inputPageDown)
480
+ }
481
+ XCTAssertEqual(shownPage, 5)
482
+ XCTAssertEqual(reportedPages, [1, 2, 3, 4, 5], "no wrap past the last page")
483
+ }
484
+
485
+ /// The responder UIKit asks first for an unmodified `input`: the nearest one up the responder
486
+ /// chain from the first responder that has a key command for it.
487
+ @MainActor private func responderAnswering(_ input: String) -> UIResponder? {
488
+ var responder = UIResponder.currentFirstResponder
489
+ while let current = responder {
490
+ if current.keyCommands?.contains(where: { $0.input == input && $0.modifierFlags.isEmpty }) == true {
491
+ return current
492
+ }
493
+ responder = current.next
494
+ }
495
+ return nil
496
+ }
497
+
498
+ @MainActor func testBookModeTakesKeyFocusOnScreen() throws {
499
+ let window = hostInWindow()
500
+ window.makeKey()
501
+ try loadBook()
502
+ // PDFKit's own views may hold first responder, but none of them claims these keys.
503
+ for input in Self.nextKeys + Self.previousKeys {
504
+ XCTAssertTrue(responderAnswering(input) === view, "\(input) reaches the view with no help from the host app")
505
+ }
506
+
507
+ view.setDisplayMode("continuous")
508
+ XCTAssertFalse(responderAnswering(UIKeyCommand.inputRightArrow) === view)
509
+ window.isHidden = true
510
+ }
511
+
512
+ func testKeysAreIgnoredWhileATextInputHasFocus() throws {
513
+ let window = hostInWindow()
514
+ window.makeKey()
515
+ try loadBook(startPage: 2)
516
+ let field = UITextField(frame: CGRect(x: 0, y: 0, width: 100, height: 30))
517
+ window.addSubview(field)
518
+ XCTAssertTrue(field.becomeFirstResponder())
519
+
520
+ view.setDisplayMode("continuous")
521
+ view.setDisplayMode("book")
522
+ XCTAssertTrue(field.isFirstResponder, "book mode never takes focus from a text input")
523
+ for input in Self.nextKeys + Self.previousKeys {
524
+ press(input)
525
+ }
526
+ XCTAssertEqual(shownPage, 2)
527
+ XCTAssertEqual(reportedPages, [])
528
+
529
+ field.resignFirstResponder()
530
+ press(UIKeyCommand.inputRightArrow)
531
+ XCTAssertEqual(reportedPages, [3])
532
+ window.isHidden = true
533
+ }
534
+ }
@@ -15,6 +15,35 @@ final class ExpoPdfMarkupViewTests: XCTestCase {
15
15
  super.tearDown()
16
16
  }
17
17
 
18
+ @MainActor func testCommittedInkOnCroppedPageStaysUnderInputAndSerializesVisibleCoordinates() throws {
19
+ let renderer = UIGraphicsPDFRenderer(bounds: CGRect(x: 0, y: 0, width: 800, height: 1000))
20
+ let document = try XCTUnwrap(PDFDocument(data: renderer.pdfData { context in context.beginPage() }))
21
+ let page = try XCTUnwrap(document.page(at: 0))
22
+ page.setBounds(CGRect(x: 100, y: 80, width: 600, height: 840), for: .cropBox)
23
+ let window = UIWindow(frame: CGRect(x: 0, y: 0, width: 400, height: 700))
24
+ let controller = UIViewController()
25
+ window.rootViewController = controller
26
+ window.makeKeyAndVisible()
27
+ view.frame = controller.view.bounds
28
+ controller.view.addSubview(view)
29
+ view.pdfView.document = document
30
+ view.layoutIfNeeded()
31
+ view.pdfView.layoutDocumentView()
32
+ view.setAnnotationMode("ink")
33
+ let overlay = try XCTUnwrap(view.inkOverlayView)
34
+ let first = view.convert(view.pdfView.convert(CGPoint(x: 180, y: 200), from: page), from: view.pdfView)
35
+ let last = view.convert(view.pdfView.convert(CGPoint(x: 280, y: 200), from: page), from: view.pdfView)
36
+ overlay.onBegan?(first)
37
+ overlay.onMoved?(last)
38
+ overlay.onEnded?()
39
+ let result = try XCTUnwrap(AnnotationSerializer.deserialize(from: view.serializeCurrentAnnotations()))
40
+ XCTAssertEqual(
41
+ result.annotations.first?.decodedPaths,
42
+ [[AnnotationPoint(x: 80, y: 120), AnnotationPoint(x: 180, y: 120)]]
43
+ )
44
+ window.isHidden = true
45
+ }
46
+
18
47
  // MARK: - Initial state
19
48
 
20
49
  func testInitialState() {