@toa.io/storages.mongodb 1.0.0-alpha.7 → 1.0.0-alpha.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toa.io/storages.mongodb",
-  "version": "1.0.0-alpha.7",
+  "version": "1.0.0-alpha.72",
   "description": "Toa MongoDB Storage Connector",
   "author": "temich <tema.gurtovoy@gmail.com>",
   "homepage": "https://github.com/toa-io/toa#readme",
@@ -19,13 +19,13 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@toa.io/console": "1.0.0-alpha.7",
-    "@toa.io/conveyor": "1.0.0-alpha.7",
-    "@toa.io/core": "1.0.0-alpha.7",
-    "@toa.io/generic": "1.0.0-alpha.7",
-    "@toa.io/pointer": "1.0.0-alpha.7",
-    "mongodb": "6.3.0",
+    "@toa.io/conveyor": "1.0.0-alpha.63",
+    "@toa.io/core": "1.0.0-alpha.67",
+    "@toa.io/generic": "1.0.0-alpha.63",
+    "@toa.io/pointer": "1.0.0-alpha.63",
+    "mongodb": "6.7.0",
+    "openspan": "1.0.0-alpha.67",
     "saslprep": "1.0.3"
   },
-  "gitHead": "4f5ac0bc342d4b7bd469fbe5c74266f050b55c9f"
+  "gitHead": "919b587dfcdfab40d18f0f8bd24b34d8107f811a"
 }

package/src/client.js

@@ -0,0 +1,160 @@
+'use strict'
+
+/**
+ * @typedef {import('mongodb').MongoClient} MongoClient
+ * @typedef {{ count: number, client: MongoClient }} Instance
+ * @typedef {import('@toa.io/core').Locator} Locator
+ */
+
+const { console } = require('openspan')
+const { Connector } = require('@toa.io/core')
+const { resolve } = require('@toa.io/pointer')
+const { ID } = require('./deployment')
+const { MongoClient } = require('mongodb')
+
+/**
+ * @type {Record<string, Promise<Instance>>}
+ */
+const INSTANCES = {}
+
+class Client extends Connector {
+  name
+
+  /**
+   * @public
+   * @type {import('mongodb').Collection}
+   */
+  collection
+
+  /**
+   * @private
+   * @type {Locator}
+   */
+  locator
+
+  /**
+   * @private
+   * @type {Instance}
+   */
+  instance
+
+  /**
+   * @private
+   * @type {string}
+   */
+  key
+
+  /**
+   * @param {Locator} locator
+   */
+  constructor (locator) {
+    super()
+
+    this.locator = locator
+  }
+
+  /**
+   * @protected
+   * @override
+   * @return {Promise<void>}
+   */
+  async open () {
+    const urls = await this.resolveURLs()
+    const dbname = this.resolveDB()
+
+    this.name = this.locator.lowercase
+    this.key = getKey(dbname, urls)
+
+    INSTANCES[this.key] ??= this.createInstance(urls)
+
+    this.instance = await INSTANCES[this.key]
+    this.instance.count++
+
+    const db = this.instance.client.db(dbname)
+
+    try {
+      this.collection = await db.createCollection(this.name)
+    } catch (e) {
+      if (e.code !== ALREADY_EXISTS) {
+        throw e
+      }
+
+      this.collection = db.collection(this.name)
+    }
+  }
+
+  /**
+   * @protected
+   * @override
+   * @return {Promise<void>}
+   */
+  async close () {
+    const instance = await INSTANCES[this.key]
+
+    instance.count--
+
+    if (instance.count === 0) {
+      await instance.client.close()
+      delete INSTANCES[this.key]
+    }
+  }
+
+  /**
+   * @private
+   * @param {string[]} urls
+   * @return {Promise<Instance>}
+   */
+  async createInstance (urls) {
+    const client = new MongoClient(urls.join(','), OPTIONS)
+    const hosts = urls.map((str) => new URL(str).host)
+
+    console.info('Connecting to MongoDB', { address: hosts.join(', ') })
+
+    await client.connect()
+
+    return {
+      count: 0,
+      client
+    }
+  }
+
+  /**
+   * @private
+   * @return {Promise<string[]>}
+   */
+  async resolveURLs () {
+    if (process.env.TOA_DEV === '1') {
+      return ['mongodb://developer:secret@localhost']
+    } else {
+      return await resolve(ID, this.locator.id)
+    }
+  }
+
+  /**
+   * @private
+   * @return {string}
+   */
+  resolveDB () {
+    if (process.env.TOA_CONTEXT !== undefined) {
+      return process.env.TOA_CONTEXT
+    }
+
+    if (process.env.TOA_DEV === '1') {
+      return 'toa-dev'
+    }
+
+    throw new Error('Environment variable TOA_CONTEXT is not defined')
+  }
+}
+
+function getKey (db, urls) {
+  return db + ':' + urls.sort().join(' ')
+}
+
+const OPTIONS = {
+  ignoreUndefined: true
+}
+
+const ALREADY_EXISTS = 48
+
+exports.Client = Client

package/src/factory.js

@@ -1,13 +1,13 @@
 'use strict'
 
-const { Connection } = require('./connection')
+const { Client } = require('./client')
 const { Storage } = require('./storage')
 
 class Factory {
-  storage (locator) {
-    const connection = new Connection(locator)
+  storage (locator, entity) {
+    const client = new Client(locator)
 
-    return new Storage(connection)
+    return new Storage(client, entity)
   }
 }
 

package/src/record.js

@@ -1,29 +1,16 @@
 'use strict'
 
-/**
- * @param {toa.core.storages.Record} entity
- * @returns {toa.mongodb.Record}
- */
-const to = (entity) => {
-  const {
-    id,
-    ...rest
-  } = entity
+function to (entity) {
+  const { id, ...rest } = entity
 
   return /** @type {toa.mongodb.Record} */ { _id: id, ...rest }
 }
 
-/**
- * @param {toa.mongodb.Record} record
- * @returns {toa.core.storages.Record}
- */
-const from = (record) => {
-  if (record === undefined || record === null) return null
+function from (record) {
+  if (record === undefined || record === null)
+    return null
 
-  const {
-    _id,
-    ...rest
-  } = record
+  const { _id, ...rest } = record
 
   return { id: _id, ...rest }
 }

package/src/storage.js

@@ -1,56 +1,69 @@
 'use strict'
 
-const { Connector } = require('@toa.io/core')
-
+const { Connector, exceptions } = require('@toa.io/core')
+const { console } = require('openspan')
 const { translate } = require('./translate')
-const {
-  to,
-  from
-} = require('./record')
-
-/**
- * @implements {toa.core.Storage}
- */
+const { to, from } = require('./record')
+const { ReturnDocument } = require('mongodb')
+
 class Storage extends Connector {
-  /** @type {toa.mongodb.Connection} */
-  #connection
+  #client
 
-  /**
-   * @param {toa.mongodb.Connection} connection
-   */
-  constructor (connection) {
+  /** @type {import('mongodb').Collection} */
+  #collection
+  #entity
+
+  constructor (client, entity) {
     super()
 
-    this.#connection = connection
+    this.#client = client
+    this.#entity = entity
+
+    this.depends(client)
+  }
+
+  async open () {
+    this.#collection = this.#client.collection
 
-    this.depends(connection)
+    await this.index()
   }
 
   async get (query) {
-    const {
-      criteria,
-      options
-    } = translate(query)
+    const { criteria, options } = translate(query)
 
-    const record = await this.#connection.get(criteria, options)
+    this.debug('findOne', { criteria, options })
+
+    const record = await this.#collection.findOne(criteria, options)
 
     return from(record)
   }
 
   async find (query) {
-    const {
-      criteria,
-      options
-    } = translate(query)
-    const recordset = await this.#connection.find(criteria, options)
+    const { criteria, options } = translate(query)
+
+    this.debug('find', { criteria, options })
+
+    const recordset = await this.#collection.find(criteria, options).toArray()
 
     return recordset.map((item) => from(item))
   }
 
+  async stream (query = undefined) {
+    const { criteria, options } = translate(query)
+
+    this.debug('find (stream)', { criteria, options })
+
+    return this.#collection.find(criteria, options).stream({ transform: from })
+  }
+
   async add (entity) {
     const record = to(entity)
 
-    return await this.#connection.add(record)
+    this.debug('insertOne', { record })
+
+    const result = await this.#collection.insertOne(record)
+
+    return result.acknowledged
   }
 
   async set (entity) {
@@ -58,50 +71,185 @@ class Storage extends Connector {
       _id: entity.id,
       _version: entity._version - 1
     }
-    const result = await this.#connection.replace(criteria, to(entity))
+
+    const record = to(entity)
+
+    this.debug('findOneAndReplace', { criteria, record })
+
+    const result = await this.#collection.findOneAndReplace(criteria, record)
 
     return result !== null
   }
 
-  async store (entity) {
-    if (entity._version === 1) {
-      return this.add(entity)
-    } else {
-      return this.set(entity)
+  async store (entity, attempt = 0) {
+    try {
+      if (entity._version === 1)
+        return await this.add(entity)
+      else
+        return await this.set(entity)
+    } catch (error) {
+      if (error.code === ERR_DUPLICATE_KEY) {
+        const id = error.keyPattern === undefined
+          ? error.message.includes(' index: _id_ ') // AWS DocumentDB
+          : error.keyPattern._id === 1
+
+        if (id)
+          return false
+        else
+          throw new exceptions.DuplicateException(this.#client.name, entity)
+      } else if (error.cause?.code === 'ECONNREFUSED') {
+        // This is temporary and should be replaced with a class decorator.
+        if (attempt > 10)
+          throw error
+
+        await new Promise((resolve) => setTimeout(resolve, 1000))
+
+        return this.store(entity)
+      } else
+        throw error
     }
   }
 
-  async upsert (query, changeset, insert) {
-    const {
-      criteria,
-      options
-    } = translate(query)
+  async upsert (query, changeset) {
+    const { criteria, options } = translate(query)
+
+    if (!('_deleted' in changeset) || changeset._deleted === null) {
+      delete criteria._deleted
+      changeset._deleted = null
+    }
 
     const update = {
       $set: { ...changeset },
       $inc: { _version: 1 }
     }
 
-    if (insert !== undefined) {
-      delete insert._version
+    options.returnDocument = ReturnDocument.AFTER
+
+    this.debug('findOneAndUpdate', { criteria, update, options })
+
+    const result = await this.#collection.findOneAndUpdate(criteria, update, options)
+
+    return from(result)
+  }
+
+  async ensure (query, properties, state) {
+    let { criteria, options } = translate(query)
+
+    if (query === undefined)
+      criteria = properties
+
+    const update = { $setOnInsert: to(state) }
+
+    options.upsert = true
+    options.returnDocument = ReturnDocument.AFTER
+
+    console.debug('Database query', { method: 'findOneAndUpdate', criteria, update, options })
+
+    const result = await this.#collection.findOneAndUpdate(criteria, update, options)
+
+    if (result._deleted !== undefined && result._deleted !== null)
+      return null
+    else
+      return from(result)
+  }
+
+  async index () {
+    const indexes = []
+
+    if (this.#entity.unique !== undefined) {
+      for (const [name, fields] of Object.entries(this.#entity.unique)) {
+        const sparse = this.checkFields(fields)
+        const unique = await this.uniqueIndex(name, fields, sparse)
+
+        indexes.push(unique)
+      }
+    }
+
+    if (this.#entity.index !== undefined) {
+      for (const [suffix, declaration] of Object.entries(this.#entity.index)) {
+        const name = 'index_' + suffix
+        const fields = Object.fromEntries(Object.entries(declaration)
+          .map(([name, type]) => [name, INDEX_TYPES[type]]))
 
-      options.upsert = true
+        const sparse = this.checkFields(Object.keys(fields))
 
-      if (criteria._id !== undefined) {
-        insert._id = criteria._id
-      } else {
-        return null
-      } // this shouldn't ever happen
+        await this.#collection.createIndex(fields, { name, sparse })
 
-      if (Object.keys(insert) > 0) update.$setOnInsert = insert
+        indexes.push(name)
+      }
     }
 
-    options.returnDocument = 'after'
+    await this.removeObsoleteIndexes(indexes)
+  }
+
+  async uniqueIndex (name, properties, sparse = false) {
+    const fields = properties.reduce((acc, property) => {
+      acc[property] = 1
+      return acc
+    }, {})
 
-    const result = await this.#connection.update(criteria, update, options)
+    name = 'unique_' + name
 
-    return from(result)
+    await this.#collection.createIndex(fields, { name, unique: true, sparse })
+
+    return name
+  }
+
+  async removeObsoleteIndexes (desired) {
+    const current = await this.getCurrentIndexes()
+    const obsolete = current.filter((name) => !desired.includes(name))
+
+    if (obsolete.length > 0) {
+      console.info('Removing obsolete indexes', { indexes: obsolete.join(', ') })
+
+      await Promise.all(obsolete.map((name) => this.#collection.dropIndex(name)))
+    }
   }
+
+  async getCurrentIndexes () {
+    try {
+      const array = await this.#collection.listIndexes().toArray()
+
+      return array.map(({ name }) => name).filter((name) => name !== '_id_')
+    } catch {
+      return []
+    }
+  }
+
+  checkFields (fields) {
+    const optional = []
+
+    for (const field of fields) {
+      if (!(field in this.#entity.schema.properties))
+        throw new Error(`Index field '${field}' is not defined.`)
+
+      if (!this.#entity.schema.required?.includes(field))
+        optional.push(field)
+    }
+
+    if (optional.length > 0) {
+      console.info('Index fields are optional, creating sparse index', { fields: optional.join(', ') })
+
+      return true
+    } else
+      return false
+  }
+
+  debug (method, attributes) {
+    console.debug('Database query', {
+      collection: this.#client.name,
+      method,
+      ...attributes
+    })
+  }
+}
+
+const INDEX_TYPES = {
+  'asc': 1,
+  'desc': -1,
+  'hash': 'hashed'
 }
 
+const ERR_DUPLICATE_KEY = 11000
+
 exports.Storage = Storage

package/src/translate.js

@@ -7,12 +7,20 @@ const parse = { ...require('./translate/criteria'), ...require('./translate/opti
  * @returns {{criteria: Object, options: Object}}
  */
 const translate = (query) => {
-  const result = { criteria: {}, options: {} }
+  const result = {
+    criteria: query?.criteria === undefined ? {} : parse.criteria(query.criteria),
+    options: query?.options === undefined ? {} : parse.options(query.options)
+  }
 
-  if (query.criteria !== undefined) result.criteria = parse.criteria(query.criteria)
-  if (query.options !== undefined) result.options = parse.options(query.options)
-  if (query.id !== undefined) result.criteria._id = query.id
-  if (query.version !== undefined) result.criteria._version = query.version
+  if (query?.id !== undefined) {
+    result.criteria._id = query.id
+  }
+
+  if (query?.version !== undefined) {
+    result.criteria._version = query.version
+  }
+
+  result.criteria._deleted = null
 
   return result
 }

package/test/record.test.js

@@ -47,19 +47,4 @@ describe('from', () => {
       _version: 0
     })
   })
-
-  it('should not modify argument', () => {
-    /** @type {toa.mongodb.Record} */
-    const record = {
-      _id: '1',
-      _version: 0
-    }
-
-    from(record)
-
-    expect(record).toStrictEqual({
-      _id: '1',
-      _version: 0
-    })
-  })
 })

package/src/connection.js

@@ -1,103 +0,0 @@
-// noinspection JSCheckFunctionSignatures
-
-'use strict'
-
-const { MongoClient } = require('mongodb')
-const { Connector } = require('@toa.io/core')
-const { resolve } = require('@toa.io/pointer')
-const { Conveyor } = require('@toa.io/conveyor')
-const { ID } = require('./deployment')
-
-class Connection extends Connector {
-  #locator
-  /** @type {import('mongodb').MongoClient} */
-  #client
-  /** @type {import('mongodb').Collection<toa.mongodb.Record>} */
-  #collection
-  /** @type {toa.conveyor.Conveyor<toa.core.storages.Record, boolean>} */
-  #conveyor
-
-  constructor (locator) {
-    super()
-
-    this.#locator = locator
-  }
-
-  async open () {
-    const urls = await this.#resolveURLs()
-    const db = this.#locator.namespace
-    const collection = this.#locator.name
-
-    this.#client = new MongoClient(urls[0], OPTIONS)
-
-    await this.#client.connect()
-
-    this.#collection = this.#client.db(db).collection(collection)
-    this.#conveyor = new Conveyor((objects) => this.addMany(objects))
-
-    console.info(`Storage Mongo '${this.#locator.id}' connected`)
-  }
-
-  async close () {
-    await this.#client?.close()
-
-    console.info(`Storage Mongo '${this.#locator.id}' disconnected`)
-  }
-
-  /** @hot */
-  async get (query, options) {
-    return /** @type {toa.mongodb.Record} */ this.#collection.findOne(query, options)
-  }
-
-  /** @hot */
-  async find (query, options) {
-    const cursor = this.#collection.find(query, options)
-
-    return cursor.toArray()
-  }
-
-  /** @hot */
-  async add (record) {
-    return this.#conveyor.process(record)
-  }
-
-  async addMany (records) {
-    let result
-
-    try {
-      const response = await this.#collection.insertMany(records, { ordered: false })
-
-      result = response.acknowledged
-    } catch (e) {
-      if (e.code === ERR_DUPLICATE_KEY) result = false
-      else throw e
-    }
-
-    return result
-  }
-
-  /** @hot */
-  async replace (query, record, options) {
-    return await this.#collection.findOneAndReplace(query, record, options)
-  }
-
-  /** @hot */
-  async update (query, update, options) {
-    return this.#collection.findOneAndUpdate(query, update, options)
-  }
-
-  async #resolveURLs () {
-    if (process.env.TOA_DEV === '1') return ['mongodb://developer:secret@localhost']
-    else return await resolve(ID, this.#locator.id)
-  }
-}
-
-const OPTIONS = {
-  ignoreUndefined: true,
-  connectTimeoutMS: 0,
-  serverSelectionTimeoutMS: 0
-}
-
-const ERR_DUPLICATE_KEY = 11000
-
-exports.Connection = Connection

package/test/connection.test.js

@@ -1,58 +0,0 @@
-'use strict'
-
-const insertManyMock = jest.fn(() => ({ acknowledged: true }))
-jest.mock('mongodb', () => ({
-  __esModule: true,
-  MongoClient: function () {
-    this.connect = () => {},
-    this.db = () => ({
-      collection: () => ({
-        insertMany: insertManyMock
-      })
-    })
-    return this
-  },
-}))
-jest.mock('@toa.io/pointer', () => ({
-  __esModule: true,
-  resolve: () => ['url'],
-}))
-const { generate } = require('randomstring')
-const { Connection } = require('../src/connection')
-
-
-let connection
-
-beforeEach(async () => {
-  jest.clearAllMocks()
-  connection = new Connection({ id: 1 })
-  await connection.open()
-})
-
-it('should be', () => {
-  expect(Connection).toBeDefined()
-})
-
-it('should insert', async () => {
-  const object = generate()
-
-  await connection.add(object)
-
-  expect(insertManyMock).toHaveBeenCalledWith([object], { ordered: false })
-})
-
-it('should batch insert', async () => {
-  const a = generate()
-  const b = generate()
-  const c = generate()
-
-  await Promise.all([
-    connection.add(a),
-    connection.add(b),
-    connection.add(c)
-  ])
-
-  expect(insertManyMock).toHaveBeenCalledTimes(2)
-  expect(insertManyMock).toHaveBeenNthCalledWith(1, [a], { ordered: false })
-  expect(insertManyMock).toHaveBeenNthCalledWith(2, [b, c], { ordered: false })
-})