@toa.io/storages.mongodb 1.0.0-alpha.324 → 1.0.0-alpha.325

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.0.0-alpha.325](https://github.com/toa-io/toa/compare/v1.0.0-alpha.324...v1.0.0-alpha.325) (2026-10-02)
+
+### Bug Fixes
+
+* **storages.mongodb:** kill the cursor of a stream's position whatever type its id comes as ([71c799e](https://github.com/toa-io/toa/commit/71c799ec3694a41cc32890d9e21bb42573b96395))
+
+
 # [1.0.0-alpha.324](https://github.com/toa-io/toa/compare/v1.0.0-alpha.323...v1.0.0-alpha.324) (2026-10-02)
 
 **Note:** Version bump only for package @toa.io/storages.mongodb

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toa.io/storages.mongodb",
-  "version": "1.0.0-alpha.324",
+  "version": "1.0.0-alpha.325",
   "type": "module",
   "description": "Toa MongoDB Storage Connector",
   "author": "temich <tema.gurtovoy@gmail.com>",
@@ -22,11 +22,11 @@
   "dependencies": {
     "@toa.io/conveyor": "1.0.0-alpha.311",
     "@toa.io/core": "1.0.0-alpha.323",
-    "@toa.io/definitions": "1.0.0-alpha.324",
+    "@toa.io/definitions": "1.0.0-alpha.325",
     "@toa.io/generic": "1.0.0-alpha.311",
     "@toa.io/pointer": "1.0.0-alpha.311",
     "mongodb": "7.6.0",
     "openspan": "1.0.0-alpha.323"
   },
-  "gitHead": "eedcbb7b90b3ea759f200b0d03c7ae13a8487b9d"
+  "gitHead": "95bc03e65c65f02d536da6ed027cf4f78f5cec74"
 }

package/src/streams.js

@@ -1,6 +1,6 @@
 import { createHash } from 'node:crypto'
 import { Readable } from 'node:stream'
-import { Timestamp } from 'mongodb'
+import { Long, Timestamp } from 'mongodb'
 import { exceptions, parts } from '@toa.io/core'
 import { match } from './match.js'
 
@@ -106,7 +106,10 @@ export class Streams {
       { session }
     )
 
-    const { id, postBatchResumeToken } = reply.cursor
+    const { postBatchResumeToken } = reply.cursor
+
+    // the driver gives an id that fits a number as a number, and `killCursors` takes a long
+    const id = Long.fromValue(reply.cursor.id)
 
     if (!id.isZero()) await db.command({ killCursors: name, cursors: [id] }, { session })
 

package/test/streams.test.js

@@ -0,0 +1,60 @@
+import { it } from 'node:test'
+import assert from 'node:assert/strict'
+import { Long, Timestamp } from 'mongodb'
+
+import { Streams } from '../src/streams.js'
+
+/**
+ * A first read takes the position of a change stream, and kills the cursor that took it. The
+ * driver gives a cursor id that fits a number as a number, and one that does not as a `Long`.
+ */
+function streams(id) {
+  const killed = []
+
+  const db = {
+    command: async (command) => {
+      if ('killCursors' in command) {
+        killed.push(...command.cursors)
+
+        return {}
+      }
+
+      return { cursor: { id, postBatchResumeToken: { _data: '82' } } }
+    }
+  }
+
+  const session = { operationTime: new Timestamp(1n), endSession: async () => undefined }
+  const cursor = {
+    hasNext: async () => false,
+    close: async () => undefined,
+    [Symbol.asyncIterator]: async function* () {}
+  }
+  const collection = { s: { db }, collectionName: 'test', find: () => cursor }
+  const client = () => ({ startSession: () => session })
+
+  return { streams: new Streams(collection, client, (record) => record, true), killed }
+}
+
+for (const [name, id] of [
+  ['a number', 7],
+  ['a Long', Long.fromString('9007199254740993')]
+])
+  it(`should kill the cursor of the position, whose id is ${name}`, async () => {
+    const { streams: read, killed } = streams(id)
+
+    await read.stream({ criteria: {}, options: {} })
+
+    assert.deepEqual(
+      killed.map((one) => Long.fromValue(one).toString()),
+      [Long.fromValue(id).toString()]
+    )
+    assert.ok(killed.every((one) => one instanceof Long))
+  })
+
+it('should kill no cursor that is closed already', async () => {
+  const { streams: read, killed } = streams(0)
+
+  await read.stream({ criteria: {}, options: {} })
+
+  assert.deepEqual(killed, [])
+})