@tmustier/pi-nes 0.2.6 → 0.2.8

package/AGENTS.md

@@ -23,7 +23,8 @@ pi-nes/
     ├── saves.ts              # SRAM persistence
     └── native/
         ├── nes-core/         # Rust NES emulator addon (required)
-        │   ├── Cargo.toml    # Dependencies: nes_rust, napi
+        │   ├── Cargo.toml    # Dependencies: vendored nes_rust, napi
+        │   ├── vendor/nes_rust/ # Patched nes_rust crate (SRAM helpers)
         │   ├── src/lib.rs    # Exposes NativeNes class via napi-rs
         │   └── index.node    # Compiled binary
         └── kitty-shm/        # Rust shared memory addon (optional)
@@ -33,7 +34,7 @@ pi-nes/
 
 ### Native Core
 
-The emulator uses the [`nes_rust`](https://crates.io/crates/nes_rust) crate with [napi-rs](https://napi.rs) bindings.
+The emulator uses the [`nes_rust`](https://crates.io/crates/nes_rust) crate (vendored + patched in `native/nes-core/vendor/nes_rust` for SRAM helpers) with [napi-rs](https://napi.rs) bindings.
 
 **API exposed to JavaScript:**
 - `new NativeNes()` - Create emulator instance
@@ -41,6 +42,9 @@ The emulator uses the [`nes_rust`](https://crates.io/crates/nes_rust) crate with
 - `bootup()` / `reset()` - Start/restart emulation
 - `stepFrame()` - Advance one frame (~60fps)
 - `pressButton(n)` / `releaseButton(n)` - Controller input (0=select, 1=start, 2=A, 3=B, 4-7=dpad)
+- `hasBatteryBackedRam()` - Whether the ROM supports battery SRAM
+- `getSram()` / `setSram(Uint8Array)` - Read/write SRAM
+- `isSramDirty()` / `markSramSaved()` - Dirty tracking for SRAM persistence
 - `getFramebuffer()` - Returns RGB pixel data (256×240×3 bytes, zero-copy via external buffer)
 
 ### Rendering Pipeline

package/README.md

@@ -86,9 +86,9 @@ Config is stored at `~/.pi/nes/config.json`. Use `/nes config` for guided setup.
 
 ## Terminal Support
 
-**Best experience:** [Kitty](https://sw.kovidgoyal.net/kitty/) terminal with image protocol support.
+**Best experience:** a Kitty-protocol terminal like Ghostty, Kitty, or WezTerm (image protocol + key-up events).
 
-- **Kitty** — Full graphics via image protocol (shared memory or file transport)
+- **Kitty-protocol terminals** — Full graphics via image protocol (shared memory or file transport)
 - **Other terminals** — Falls back to ANSI half-block characters (`▀▄`)
 
 Set `"renderer": "text"` if you prefer the ANSI renderer or have display issues.

package/extensions/nes/config.ts

@@ -17,13 +17,13 @@ export interface NesConfig {
 
 const DEFAULT_ROM_DIR = path.join(path.sep, "roms", "nes");
 
-function defaultSaveDir(romDir: string): string {
+export function getDefaultSaveDir(romDir: string): string {
 	return path.join(romDir, "saves");
 }
 
 export const DEFAULT_CONFIG: NesConfig = {
 	romDir: DEFAULT_ROM_DIR,
-	saveDir: defaultSaveDir(DEFAULT_ROM_DIR),
+	saveDir: getDefaultSaveDir(DEFAULT_ROM_DIR),
 	enableAudio: false,
 	renderer: "image",
 	pixelScale: 1.2,
@@ -49,7 +49,7 @@ export function normalizeConfig(raw: unknown): NesConfig {
 		typeof parsed.romDir === "string" && parsed.romDir.length > 0
 			? normalizePath(parsed.romDir, DEFAULT_CONFIG.romDir)
 			: DEFAULT_CONFIG.romDir;
-	const saveDirFallback = defaultSaveDir(romDir);
+	const saveDirFallback = getDefaultSaveDir(romDir);
 	const saveDir =
 		typeof parsed.saveDir === "string" && parsed.saveDir.length > 0
 			? normalizePath(parsed.saveDir, saveDirFallback)

package/extensions/nes/index.ts

@@ -8,6 +8,7 @@ import {
 	configExists,
 	formatConfig,
 	getConfigPath,
+	getDefaultSaveDir,
 	loadConfig,
 	normalizeConfig,
 	saveConfig,
@@ -139,17 +140,28 @@ async function configureWithWizard(
 	ctx: ExtensionCommandContext,
 	config: Awaited<ReturnType<typeof loadConfig>>,
 ): Promise<boolean> {
-	const romDirPlaceholder = displayPath(config.romDir);
-	const romDirInput = await ctx.ui.input(
-		"ROM directory (or wherever you want to keep your roms)",
-		romDirPlaceholder,
-	);
-	if (romDirInput === undefined) {
+	const romDirDisplay = displayPath(config.romDir);
+	const romDirDefaultLabel = config.romDir === DEFAULT_CONFIG.romDir ? "Use default" : "Use current";
+	const romDirOptions = [
+		`${romDirDefaultLabel} (${romDirDisplay})`,
+		"Enter a custom path",
+	];
+	const romDirChoice = await ctx.ui.select("ROM directory", romDirOptions);
+	if (!romDirChoice) {
 		return false;
 	}
-	const trimmedRomDir = romDirInput.trim();
+
 	let romDir = config.romDir;
-	if (trimmedRomDir) {
+	if (romDirChoice === romDirOptions[1]) {
+		const romDirInput = await ctx.ui.input("ROM directory", romDirDisplay);
+		if (romDirInput === undefined) {
+			return false;
+		}
+		const trimmedRomDir = romDirInput.trim();
+		if (!trimmedRomDir) {
+			ctx.ui.notify("ROM directory cannot be empty.", "error");
+			return false;
+		}
 		romDir = resolvePathInput(trimmedRomDir, ctx.cwd);
 		const valid = await validateRomDir(romDir, ctx);
 		if (!valid) {
@@ -192,9 +204,13 @@ async function configureWithWizard(
 		pixelScale = parsed;
 	}
 
+	const defaultSaveDir = getDefaultSaveDir(config.romDir);
+	const shouldSyncSaveDir = config.saveDir === defaultSaveDir;
+	const saveDir = shouldSyncSaveDir ? getDefaultSaveDir(romDir) : config.saveDir;
 	const normalized = normalizeConfig({
 		...config,
 		romDir,
+		saveDir,
 		pixelScale,
 	});
 	await saveConfig(normalized);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tmustier/pi-nes",
-  "version": "0.2.6",
+  "version": "0.2.8",
   "description": "NES emulator extension for pi",
   "keywords": [
     "pi-package",