@tmustier/pi-nes 0.2.34 → 0.2.35

package/README.md

@@ -52,11 +52,12 @@ On first run, you'll be prompted to set your ROM directory and display quality.
 | `/nes` | Pick a ROM or reattach to running session |
 | `/nes <path>` | Load a specific ROM file |
 | `/nes config` | Configure ROM directory and quality |
+| `/nes-config` | Toggle audio + access advanced config options |
 | `/nes debug` | Show FPS and memory stats |
 
 ## Configuration
 
-Config is stored at `~/.pi/nes/config.json`. Use `/nes config` for quick setup.
+Config is stored at `~/.pi/nes/config.json`. Use `/nes config` for quick setup, or `/nes-config` to toggle audio inline and access advanced options.
 
 ```json
 {
@@ -65,6 +66,7 @@ Config is stored at `~/.pi/nes/config.json`. Use `/nes config` for quick setup.
   "renderer": "image",
   "imageQuality": "balanced",
   "videoFilter": "ntsc-composite",
+  "enableAudio": false,
   "pixelScale": 1.0,
   "keybindings": {
     "up": ["up", "w"],
@@ -88,6 +90,7 @@ Config is stored at `~/.pi/nes/config.json`. Use `/nes config` for quick setup.
 | `renderer` | `"image"` | `"image"` (Kitty graphics) or `"text"` (ANSI) |
 | `imageQuality` | `"balanced"` | `"balanced"` (30 fps) or `"high"` (60 fps) |
 | `videoFilter` | `"ntsc-composite"` | `"off"`, `"ntsc-composite"`, `"ntsc-svideo"`, `"ntsc-rgb"` |
+| `enableAudio` | `false` | Enable audio output (requires native core built with `audio-cpal`) |
 | `pixelScale` | `1.0` | Display scale (0.5–4.0) |
 
 `videoFilter` applies a lightweight CRT/NTSC-inspired pass (horizontal bleed + scanlines). It runs in the native core and is optional.
@@ -109,8 +112,8 @@ Set `"renderer": "text"` if you prefer the ANSI renderer or have display issues.
 
 ## Limitations
 
-- **No audio** — Sound is not currently supported
-- **No save states** — Only battery-backed SRAM saves work
+- **Audio is opt-in** — Requires building the native core with `audio-cpal` and setting `enableAudio: true`
+- **No auto-save** — Save manually just like you would with the original NES (battery-backed SRAM)
 
 ## Vendored Dependencies
 
@@ -133,6 +136,9 @@ npm install
 cd extensions/nes/native/nes-core
 npm install && npm run build
 
+# Build the NES core with audio (optional)
+npm run build:audio
+
 # Build shared memory renderer (optional, faster on Kitty)
 cd ../kitty-shm
 npm install && npm run build

package/extensions/nes/index.ts

@@ -1,6 +1,8 @@
 import { promises as fs } from "node:fs";
 import path from "node:path";
-import type { ExtensionAPI, ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
+import type { ExtensionAPI, ExtensionCommandContext, Theme } from "@mariozechner/pi-coding-agent";
+import { DynamicBorder, getSettingsListTheme } from "@mariozechner/pi-coding-agent";
+import { Container, SettingsList, Spacer, Text, type SettingItem } from "@mariozechner/pi-tui";
 import { NesOverlayComponent } from "./nes-component.js";
 import { createNesCore } from "./nes-core.js";
 import {
@@ -12,6 +14,7 @@ import {
 	loadConfig,
 	normalizeConfig,
 	saveConfig,
+	type NesConfig,
 	type VideoFilter,
 } from "./config.js";
 import { displayPath, resolvePathInput } from "./paths.js";
@@ -203,12 +206,89 @@ async function configureWithWizard(
 	return true;
 }
 
+type ConfigMenuResult = "close" | "more";
+
+class NesConfigMenu extends Container {
+	private readonly settingsList: SettingsList;
+
+	constructor(
+		config: NesConfig,
+		theme: Theme,
+		onAudioChange: (enabled: boolean) => void,
+		onDone: (result: ConfigMenuResult) => void,
+	) {
+		super();
+		const audioValue = config.enableAudio ? "on" : "off (default)";
+		const items: SettingItem[] = [
+			{
+				id: "audio",
+				label: "Audio",
+				description: "Enable audio output (requires native core built with audio-cpal)",
+				currentValue: audioValue,
+				values: ["off (default)", "on"],
+			},
+			{
+				id: "more",
+				label: "More settings",
+				description: "Quick setup, advanced JSON, or reset defaults",
+				currentValue: "Open",
+				values: ["Open"],
+			},
+		];
+
+		this.settingsList = new SettingsList(
+			items,
+			6,
+			getSettingsListTheme(),
+			(id, value) => {
+				if (id === "audio") {
+					onAudioChange(value === "on");
+					return;
+				}
+				if (id === "more") {
+					onDone("more");
+				}
+			},
+			() => onDone("close"),
+		);
+
+		this.addChild(new DynamicBorder());
+		this.addChild(new Text(theme.bold(theme.fg("accent", "NES config")), 1, 0));
+		this.addChild(new Spacer(1));
+		this.addChild(this.settingsList);
+		this.addChild(new Spacer(1));
+		this.addChild(new DynamicBorder());
+	}
+
+	handleInput(data: string): void {
+		this.settingsList.handleInput(data);
+	}
+}
+
 async function editConfig(ctx: ExtensionCommandContext): Promise<void> {
 	if (!ctx.hasUI) {
 		ctx.ui.notify("NES config requires interactive mode", "error");
 		return;
 	}
 	const config = await loadConfig();
+	const action = await ctx.ui.custom<ConfigMenuResult>((_tui, theme, _keybindings, done) =>
+		new NesConfigMenu(
+			config,
+			theme,
+			(enabled) => {
+				void (async () => {
+					const normalized = normalizeConfig({ ...config, enableAudio: enabled });
+					await saveConfig(normalized);
+					config.enableAudio = normalized.enableAudio;
+					ctx.ui.notify(`Saved config to ${getConfigPath()}`, "info");
+				})();
+			},
+			done,
+		),
+	);
+	if (action !== "more") {
+		return;
+	}
 	const choice = await ctx.ui.select("NES configuration", [
 		"Quick setup",
 		"Advanced (edit config JSON)",