@tmustier/pi-files-widget 0.1.20 → 0.2.0

package/CHANGELOG.md

@@ -2,7 +2,22 @@
 
 All notable changes to this extension will be documented in this file.
 
-## [Unreleased]
+## [0.2.0] - 2026-07-04
+
+### Added
+- `/readfiles` now supports browsing outside the current working directory. Press `u` to re-root to the parent, `.` to jump back to where you started, or pass an explicit starting path (`/readfiles <path>` or `/readfiles ~/somewhere`). The browser header shows the current root so you always know where you are, and comments on files outside the project use absolute paths so the agent can still find them.
+
+### Fixed
+- Git status, diff stats, and untracked-file discovery now work when the browser root is a subdirectory of the git repository (e.g. after `u`, `.`, or `/readfiles <subdir>`, or when pi runs from a repo subdirectory). Previously repo-root-relative git paths were mixed with root-relative node keys, producing phantom tree entries, missing statuses, and unopenable nested paths.
+- Re-rooting the browser while a background directory scan or line-count batch is in flight no longer lets the stale batch mutate the new root's tree, node index, or scan state.
+- Use `where` instead of `which` on Windows to detect `bat`, `delta`, and `glow`, so the dependency check works when running from PowerShell or cmd.exe.
+
+## [0.1.21] - 2026-05-07
+
+### Changed
+- Declare `@earendil-works` Pi development dependencies used by runtime imports.
+- Update Pi extension imports and peer dependencies to the new `@earendil-works` namespace.
+
 
 ## [0.1.20] - 2026-04-24
 

package/README.md

@@ -81,7 +81,8 @@ The `/readfiles` browser requires these tools and will refuse to open until they
 
 ## Commands
 
-- `/readfiles` - open the file browser and viewer
+- `/readfiles` - open the file browser in the current directory
+- `/readfiles <path>` - open the file browser rooted at `<path>` (absolute, relative, or `~`-prefixed)
 
 Diff viewing is built into the file viewer: open a changed tracked file and press `d` to toggle the git diff view.
 
@@ -94,6 +95,8 @@ Diff viewing is built into the file viewer: open a changed tracked file and pres
 - `c`: toggle changed-only view
 - `]` / `[`: next/prev changed file
 - `/`: search (type to filter, `Esc` to exit)
+- `u`: go up one directory (re-root to parent)
+- `.`: jump back to the starting directory
 - `+` / `-`: increase/decrease browser height
 - `q`: close
 
@@ -118,6 +121,7 @@ Diff viewing is built into the file viewer: open a changed tracked file and pres
 
 - Untracked files show as `[UNTRACKED]` and open in normal view.
 - Searching in rendered Markdown switches to raw mode first, and selecting from rendered Markdown first switches you back to raw so line-based matches and comments stay aligned with the source file.
+- When you browse outside the current project directory, inline comments on those files use absolute paths so the agent can still locate them. Files inside the project continue to use project-relative paths.
 - Folder LOCs are shown only when the folder is collapsed (expanded folders would duplicate counts).
 - Line counts load asynchronously; the header shows activity while counts are computed.
 - Large non-git folders load progressively and may show `[partial]` while loading in safe mode.

package/TODO.md

@@ -17,6 +17,7 @@
 - [x] Collapse/expand directories
 - [x] Navigation with `j/k` and arrow keys
 - [x] Enter to expand dir or open file
+- [x] Browse outside the current working directory (`u` to go up, `.` to reset, `/readfiles <path>` to start elsewhere)
 
 ### Git Integration
 - [x] Parse `git status --porcelain` output

package/browser.ts

@@ -1,9 +1,9 @@
-import type { Theme } from "@mariozechner/pi-coding-agent";
-import { Key, matchesKey, truncateToWidth } from "@mariozechner/pi-tui";
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { Key, matchesKey, truncateToWidth } from "@earendil-works/pi-tui";
 import { lstatSync, realpathSync, statSync } from "node:fs";
 import { readdir, readFile, realpath, stat } from "node:fs/promises";
 import { homedir } from "node:os";
-import { basename, join, relative, resolve, sep } from "node:path";
+import { join, relative, resolve, sep } from "node:path";
 
 import {
   DEFAULT_BROWSER_HEIGHT,
@@ -98,13 +98,21 @@ function indexNodes(root: FileNode | null, map: Map<string, FileNode>): void {
   }
 }
 
-function getNodeDepth(node: FileNode, cwd: string): number {
-  if (node.path === cwd) return 0;
-  const rel = relative(cwd, node.path);
+function getNodeDepth(node: FileNode, root: string): number {
+  if (node.path === root) return 0;
+  const rel = relative(root, node.path);
   if (!rel) return 0;
   return rel.split(sep).length;
 }
 
+function formatRootPath(path: string): string {
+  const home = homedir();
+  if (!home) return path;
+  if (path === home) return "~";
+  if (path.startsWith(home + sep)) return "~" + path.slice(home.length);
+  return path;
+}
+
 function safeRealPathSync(path: string): string {
   try {
     return realpathSync(path);
@@ -150,8 +158,8 @@ function hasAncestorRealPath(node: FileNode | undefined, realPath: string): bool
   return false;
 }
 
-function shouldSafeMode(cwd: string): boolean {
-  const resolved = resolve(cwd);
+function shouldSafeMode(path: string): boolean {
+  const resolved = resolve(path);
   const home = resolve(homedir());
   const root = resolve(sep);
   return resolved === home || resolved === root;
@@ -256,48 +264,39 @@ function collapseAllExcept(node: FileNode, keep: Set<FileNode>): void {
 }
 
 export function createFileBrowser(
-  cwd: string,
+  initialPath: string,
   agentModifiedFiles: Set<string>,
   theme: Theme,
   onClose: () => void,
   requestComment: (payload: CommentPayload, comment: string) => void,
-  requestRender: () => void
+  requestRender: () => void,
+  projectCwd: string = initialPath
 ): BrowserController {
   const ignored = getIgnoredNames();
-  const repo = isGitRepo(cwd);
-  let gitStatus = repo ? getGitStatus(cwd) : new Map<string, string>();
-  let diffStats = repo ? getGitDiffStats(cwd) : new Map<string, DiffStats>();
-  const gitBranch = repo ? getGitBranch(cwd) : "";
 
-  const viewer = createViewer(cwd, theme, requestComment);
-  const textInput = createTextInputBuffer();
+  let rootPath = resolve(initialPath);
+  const initialRoot = rootPath;
+  let repo = false;
+  let gitStatus = new Map<string, string>();
+  let diffStats = new Map<string, DiffStats>();
+  let gitBranch = "";
 
-  const root = repo
-    ? buildFileTreeFromPaths(cwd, getGitFileList(cwd), gitStatus, diffStats, ignored, agentModifiedFiles)
-    : {
-      name: ".",
-      path: cwd,
-      isDirectory: true,
-      realPath: safeRealPathSync(cwd),
-      children: undefined,
-      expanded: true,
-      hasChangedChildren: false,
-    };
+  const viewer = createViewer({ getRoot: () => rootPath, projectCwd }, theme, requestComment);
+  const textInput = createTextInputBuffer();
 
-  const safeMode = !repo && shouldSafeMode(cwd);
   const scanState: ScanState = {
-    mode: repo ? "none" : safeMode ? "safe" : "full",
+    mode: "none",
     isScanning: false,
-    isPartial: safeMode,
+    isPartial: false,
     pending: 0,
     spinnerIndex: 0,
   };
 
   const browser: BrowserState = {
-    root,
+    root: null,
     flatList: [],
     fullList: [],
-    stats: getTreeStats(root),
+    stats: { totalLines: undefined, additions: 0, deletions: 0 },
     nodeByPath: new Map<string, FileNode>(),
     scanState,
     selectedIndex: 0,
@@ -308,10 +307,6 @@ export function createFileBrowser(
     lastPollTime: Date.now(),
   };
 
-  indexNodes(browser.root, browser.nodeByPath);
-  browser.flatList = browser.root ? flattenTree(browser.root) : [];
-  browser.fullList = browser.root ? flattenTree(browser.root, 0, true, true) : [];
-
   const lineCountCache = new Map<string, { size: number; mtimeMs: number; count: number }>();
   const lineCountQueue: FileNode[] = [];
   const lineCountPending = new Set<string>();
@@ -320,6 +315,10 @@ export function createFileBrowser(
   const scanQueue: Array<{ node: FileNode; depth: number }> = [];
   const scanQueued = new Set<string>();
   let scanTimer: ReturnType<typeof setTimeout> | null = null;
+  // Incremented on every (re-)root. In-flight async scan/line-count batches
+  // capture the value when they start and bail after each await if it changed,
+  // so work belonging to an old root can never mutate state for the new one.
+  let rootGeneration = 0;
 
   const normalizeGitPath = (path: string): string => path.split(sep).join("/");
 
@@ -381,15 +380,19 @@ export function createFileBrowser(
   async function processLineCountBatch(): Promise<void> {
     lineCountTimer = null;
     if (!browser.root) return;
+    const generation = rootGeneration;
     const batch = lineCountQueue.splice(0, LINE_COUNT_BATCH_SIZE);
     if (batch.length === 0) return;
 
     await Promise.all(
       batch.map(async node => {
         await updateLineCount(node);
-        lineCountPending.delete(node.path);
+        if (generation === rootGeneration) {
+          lineCountPending.delete(node.path);
+        }
       })
     );
+    if (generation !== rootGeneration) return;
 
     updateTreeStats(browser.root);
     browser.stats = getTreeStats(browser.root);
@@ -441,12 +444,13 @@ export function createFileBrowser(
     }
   }
 
-  async function scanDirectory(node: FileNode, depth: number): Promise<void> {
+  async function scanDirectory(node: FileNode, depth: number, generation: number): Promise<void> {
     try {
       const entries = await readdir(node.path, { withFileTypes: true });
+      if (generation !== rootGeneration) return;
       const sorted = [...entries].sort((a, b) => a.name.toLowerCase().localeCompare(b.name.toLowerCase()));
 
-      if (node.path === cwd && browser.scanState.mode === "full" && sorted.length >= SAFE_MODE_ENTRY_THRESHOLD) {
+      if (node.path === rootPath && browser.scanState.mode === "full" && sorted.length >= SAFE_MODE_ENTRY_THRESHOLD) {
         browser.scanState.mode = "safe";
         browser.scanState.isPartial = true;
         scanQueue.length = 0;
@@ -462,11 +466,13 @@ export function createFileBrowser(
         const childDepth = depth + 1;
 
         if (entry.isDirectory()) {
+          const dirRealPath = await realpath(fullPath).catch(() => resolve(fullPath));
+          if (generation !== rootGeneration) return;
           const dirNode: FileNode = {
             name: entry.name,
             path: fullPath,
             isDirectory: true,
-            realPath: await realpath(fullPath).catch(() => resolve(fullPath)),
+            realPath: dirRealPath,
             parent: node,
             children: undefined,
             expanded: childDepth < 1,
@@ -482,6 +488,7 @@ export function createFileBrowser(
 
         if (entry.isSymbolicLink()) {
           const pathInfo = await getPathInfo(fullPath, true);
+          if (generation !== rootGeneration) return;
           if (pathInfo.isDirectory) {
             const isCycle = pathInfo.realPath ? hasAncestorRealPath(node, pathInfo.realPath) : false;
             const dirNode: FileNode = {
@@ -531,16 +538,21 @@ export function createFileBrowser(
 
       node.children = [...dirs, ...files];
     } catch {
-      node.children = [];
+      if (generation === rootGeneration) {
+        node.children = [];
+      }
     } finally {
-      node.loading = false;
-      scanQueued.delete(node.path);
+      if (generation === rootGeneration) {
+        node.loading = false;
+        scanQueued.delete(node.path);
+      }
     }
   }
 
   async function processScanBatch(): Promise<void> {
     scanTimer = null;
     if (!browser.root) return;
+    const generation = rootGeneration;
     const batch = scanQueue.splice(0, getScanBatchSize());
     if (batch.length === 0) {
       browser.scanState.isScanning = false;
@@ -549,7 +561,8 @@ export function createFileBrowser(
     }
 
     for (const item of batch) {
-      await scanDirectory(item.node, item.depth);
+      await scanDirectory(item.node, item.depth, generation);
+      if (generation !== rootGeneration) return;
     }
 
     browser.scanState.pending = scanQueue.length;
@@ -586,7 +599,7 @@ export function createFileBrowser(
 
   function applyGitUpdates(): void {
     for (const node of browser.nodeByPath.values()) {
-      const relPath = normalizeGitPath(relative(cwd, node.path));
+      const relPath = normalizeGitPath(relative(rootPath, node.path));
       node.gitStatus = gitStatus.get(relPath);
       node.diffStats = diffStats.get(relPath);
     }
@@ -611,7 +624,7 @@ export function createFileBrowser(
       const part = parts[i];
       if (ignored.has(part) || part.startsWith(".")) return null;
       currentRel = currentRel ? `${currentRel}/${part}` : part;
-      const dirPath = join(cwd, currentRel);
+      const dirPath = join(rootPath, currentRel);
       let dirNode = browser.nodeByPath.get(dirPath);
       if (!dirNode) {
         const depth = i + 1;
@@ -636,7 +649,7 @@ export function createFileBrowser(
     const fileName = parts[parts.length - 1];
     if (ignored.has(fileName) || fileName.startsWith(".")) return null;
 
-    const filePath = join(cwd, normalized);
+    const filePath = join(rootPath, normalized);
     const existing = browser.nodeByPath.get(filePath);
     if (existing) return existing;
 
@@ -704,8 +717,8 @@ export function createFileBrowser(
     const viewingFilePath = viewingFile?.path;
 
     if (repo) {
-      gitStatus = getGitStatus(cwd);
-      diffStats = getGitDiffStats(cwd);
+      gitStatus = getGitStatus(rootPath);
+      diffStats = getGitDiffStats(rootPath);
       applyGitUpdates();
       addUntrackedNodes();
     }
@@ -736,12 +749,67 @@ export function createFileBrowser(
     }
   }
 
-  if (repo) {
-    queueLineCountsForTree(browser.root);
-  } else if (browser.root) {
-    enqueueScan(browser.root, 0, true);
+  function loadRoot(newRoot: string): void {
+    rootGeneration += 1;
+    rootPath = resolve(newRoot);
+
+    repo = isGitRepo(rootPath);
+    gitStatus = repo ? getGitStatus(rootPath) : new Map<string, string>();
+    diffStats = repo ? getGitDiffStats(rootPath) : new Map<string, DiffStats>();
+    gitBranch = repo ? getGitBranch(rootPath) : "";
+
+    const newRootNode: FileNode = repo
+      ? buildFileTreeFromPaths(rootPath, getGitFileList(rootPath), gitStatus, diffStats, ignored, agentModifiedFiles)
+      : {
+        name: ".",
+        path: rootPath,
+        isDirectory: true,
+        realPath: safeRealPathSync(rootPath),
+        children: undefined,
+        expanded: true,
+        hasChangedChildren: false,
+      };
+
+    browser.root = newRootNode;
+
+    const safeMode = !repo && shouldSafeMode(rootPath);
+    browser.scanState.mode = repo ? "none" : safeMode ? "safe" : "full";
+    browser.scanState.isScanning = false;
+    browser.scanState.isPartial = safeMode;
+    browser.scanState.pending = 0;
+
+    indexNodes(browser.root, browser.nodeByPath);
+    refreshLists();
+    browser.stats = getTreeStats(browser.root);
+
+    browser.selectedIndex = 0;
+    browser.searchQuery = "";
+    browser.searchMode = false;
+    textInput.reset();
+    browser.lastPollTime = Date.now();
+
+    if (repo) {
+      queueLineCountsForTree(browser.root);
+    } else if (browser.root) {
+      enqueueScan(browser.root, 0, true);
+    }
   }
 
+  function setRoot(newRoot: string): void {
+    if (viewer.isOpen()) {
+      viewer.close();
+    }
+    stopBackgroundTasks();
+    scanQueue.length = 0;
+    scanQueued.clear();
+    lineCountQueue.length = 0;
+    lineCountPending.clear();
+    loadRoot(newRoot);
+    requestRender();
+  }
+
+  loadRoot(initialRoot);
+
   function getDisplayList(): FlatNode[] {
     let list = browser.searchQuery ? browser.fullList : browser.flatList;
 
@@ -806,7 +874,7 @@ export function createFileBrowser(
     if (node.isDirectory) {
       node.expanded = !node.expanded;
       if (node.expanded && node.children === undefined) {
-        enqueueScan(node, getNodeDepth(node, cwd), true);
+        enqueueScan(node, getNodeDepth(node, rootPath), true);
       }
       refreshLists();
     }
@@ -818,7 +886,7 @@ export function createFileBrowser(
 
   function renderBrowser(width: number): string[] {
     const lines: string[] = [];
-    const pathDisplay = basename(cwd);
+    const pathDisplay = formatRootPath(rootPath);
     const branchDisplay = gitBranch ? theme.fg("accent", ` (${gitBranch})`) : "";
     const stats = browser.stats;
 
@@ -902,7 +970,7 @@ export function createFileBrowser(
     const changedIndicator = browser.showOnlyChanged ? theme.fg("warning", " [changed only]") : "";
     const help = browser.searchMode
       ? theme.fg("dim", "Type to search  ↑↓: nav  Enter: confirm  Esc: cancel")
-      : theme.fg("dim", "j/k: nav  []: next/prev change  c: toggle changed  /: search  q: close") + changedIndicator;
+      : theme.fg("dim", "j/k: nav  u: up  .: home  []: next/prev change  c: toggle changed  /: search  q: close") + changedIndicator;
     lines.push(truncateToWidth(help, width));
 
     return lines;
@@ -974,6 +1042,19 @@ export function createFileBrowser(
       }
       return;
     }
+    if (matchesKey(data, "u")) {
+      const parent = resolve(rootPath, "..");
+      if (parent !== rootPath) {
+        setRoot(parent);
+      }
+      return;
+    }
+    if (matchesKey(data, ".")) {
+      if (rootPath !== initialRoot) {
+        setRoot(initialRoot);
+      }
+      return;
+    }
     if (matchesKey(data, "j") || matchesKey(data, Key.down)) {
       browser.selectedIndex = Math.min(maxIndex, browser.selectedIndex + 1);
       return;