@tmustier/pi-agent-teams 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.5.3
+
+### Fixes
+
+- **Inherited parent-team attach warnings** — forked/branched child sessions now silently detach back to their own session team when they briefly inherit a parent team id without any attach claim. This removes the noisy warning seen in subagent-style flows while preserving normal `not_owner` warnings for real claim conflicts.
+
 ## 0.5.2
 
 ### Fixes

package/extensions/teams/leader.ts

@@ -33,6 +33,7 @@ import {
 } from "./hooks.js";
 import { handleTeamCommand } from "./leader-team-command.js";
 import { registerTeamsTool } from "./leader-teams-tool.js";
+import { getParentSessionId, shouldSilenceInheritedParentAttachClaimWarning } from "./session-parent.js";
 import type { ContextMode, SpawnTeammateFn, SpawnTeammateResult, WorkspaceMode } from "./spawn-types.js";
 
 function getTeamsExtensionEntryPath(): string | null {
@@ -155,6 +156,7 @@ export function runLeader(pi: ExtensionAPI): void {
 	let delegateMode = process.env.PI_TEAMS_DELEGATE_MODE === "1";
 	let style: TeamsStyle = getTeamsStyleFromEnv();
 	let lastAttachClaimHeartbeatMs = 0;
+	let inheritedParentTeamId: string | null = null;
 
 	const stopLoops = () => {
 		if (refreshTimer) clearInterval(refreshTimer);
@@ -180,13 +182,22 @@ export function runLeader(pi: ExtensionAPI): void {
 		const result = await heartbeatTeamAttachClaim(getTeamDir(currentTeamId), sessionTeamId);
 		if (result === "updated") return;
 
-		ctx.ui.notify(
-			`Attach claim for team ${currentTeamId} is no longer owned by this session; detaching to session team.`,
-			"warning",
-		);
+		const lostTeamId = currentTeamId;
+		const shouldSilenceWarning = shouldSilenceInheritedParentAttachClaimWarning({
+			currentTeamId: lostTeamId,
+			parentSessionId: inheritedParentTeamId,
+			result,
+		});
+		inheritedParentTeamId = null;
 		currentTeamId = sessionTeamId;
 		taskListId = sessionTeamId;
 		delegationTracker.clear();
+		if (!shouldSilenceWarning) {
+			ctx.ui.notify(
+				`Attach claim for team ${lostTeamId} is no longer owned by this session; detaching to session team.`,
+				"warning",
+			);
+		}
 		await refreshTasks();
 		renderWidget();
 	};
@@ -709,6 +720,7 @@ export function runLeader(pi: ExtensionAPI): void {
 	pi.on("session_start", async (_event, ctx) => {
 		currentCtx = ctx;
 		currentTeamId = currentCtx.sessionManager.getSessionId();
+		inheritedParentTeamId = getParentSessionId(currentCtx.sessionManager);
 		// Keep the task list aligned with the active session. If you want a shared namespace,
 		// use `/team task use <taskListId>` after switching.
 		taskListId = currentTeamId;
@@ -792,6 +804,7 @@ export function runLeader(pi: ExtensionAPI): void {
 
 		currentCtx = ctx;
 		currentTeamId = currentCtx.sessionManager.getSessionId();
+		inheritedParentTeamId = getParentSessionId(currentCtx.sessionManager);
 		// Keep the task list aligned with the active session. If you want a shared namespace,
 		// use `/team task use <taskListId>` after switching.
 		taskListId = currentTeamId;
@@ -1072,6 +1085,7 @@ export function runLeader(pi: ExtensionAPI): void {
 				getActiveTeamId: () => currentTeamId ?? ctx.sessionManager.getSessionId(),
 				setActiveTeamId: (teamId) => {
 					currentTeamId = teamId;
+					inheritedParentTeamId = null;
 					delegationTracker.clear();
 				},
 				pendingPlanApprovals,

package/extensions/teams/session-parent.ts

@@ -0,0 +1,24 @@
+import { SessionManager } from "@mariozechner/pi-coding-agent";
+import type { TeamAttachClaimHeartbeatResult } from "./team-attach-claim.js";
+
+interface SessionManagerWithHeader {
+	getHeader(): { parentSession?: string } | null;
+}
+
+export function getParentSessionId(sessionManager: SessionManagerWithHeader): string | null {
+	const parentSessionPath = sessionManager.getHeader()?.parentSession;
+	if (!parentSessionPath) return null;
+	try {
+		return SessionManager.open(parentSessionPath).getSessionId();
+	} catch {
+		return null;
+	}
+}
+
+export function shouldSilenceInheritedParentAttachClaimWarning(opts: {
+	currentTeamId: string;
+	parentSessionId: string | null;
+	result: TeamAttachClaimHeartbeatResult;
+}): boolean {
+	return opts.result === "missing" && opts.parentSessionId !== null && opts.currentTeamId === opts.parentSessionId;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tmustier/pi-agent-teams",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Claude Code agent teams style workflow for Pi.",
   "license": "MIT",
   "author": "Thomas Mustier",

package/scripts/smoke-test.mts

@@ -70,7 +70,9 @@ import {
 	isPlanRejectedMessage,
 } from "../extensions/teams/protocol.js";
 import { pollLeaderInbox } from "../extensions/teams/leader-inbox.js";
-import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { getParentSessionId, shouldSilenceInheritedParentAttachClaimWarning } from "../extensions/teams/session-parent.js";
+import { SessionManager, type ExtensionContext } from "@mariozechner/pi-coding-agent";
+import type { AssistantMessage } from "@mariozechner/pi-ai";
 
 // ── helpers ──────────────────────────────────────────────────────────
 let passed = 0;
@@ -845,6 +847,67 @@ console.log("\n10. team discovery + attach claims");
 	}
 }
 
+// ── 10b. branched sessions + inherited attach claims ────────────────
+console.log("\n10b. branched sessions + inherited attach claims");
+{
+	const sessionsDir = path.join(tmpRoot, "branch-session-test");
+	const parent = SessionManager.create(tmpRoot, sessionsDir);
+	const assistantMessage: AssistantMessage = {
+		role: "assistant",
+		content: [{ type: "text", text: "ok" }],
+		api: "test",
+		provider: "test",
+		model: "test",
+		usage: {
+			input: 0,
+			output: 0,
+			cacheRead: 0,
+			cacheWrite: 0,
+			totalTokens: 0,
+			cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 },
+		},
+		stopReason: "stop",
+		timestamp: Date.now(),
+	};
+	parent.appendMessage(assistantMessage);
+	const parentLeafId = parent.getLeafId();
+	const originalParentSessionId = parent.getSessionId();
+	assert(parentLeafId !== null, "branch test parent has a leaf entry");
+	if (parentLeafId) {
+		const branchedPath = parent.createBranchedSession(parentLeafId);
+		assert(branchedPath !== null, "createBranchedSession returns child session path");
+		if (branchedPath) {
+			const child = SessionManager.open(branchedPath, sessionsDir);
+			const parentSessionId = getParentSessionId(child);
+			assertEq(parentSessionId, originalParentSessionId, "getParentSessionId resolves branch parent session id");
+			assert(
+				shouldSilenceInheritedParentAttachClaimWarning({
+					currentTeamId: originalParentSessionId,
+					parentSessionId,
+					result: "missing",
+				}),
+				"silences missing inherited parent-team claim warnings",
+			);
+			assert(
+				!shouldSilenceInheritedParentAttachClaimWarning({
+					currentTeamId: originalParentSessionId,
+					parentSessionId,
+					result: "not_owner",
+				}),
+				"keeps non-owner inherited parent-team warnings visible",
+			);
+			assert(
+				!shouldSilenceInheritedParentAttachClaimWarning({
+					currentTeamId: child.getSessionId(),
+					parentSessionId,
+					result: "missing",
+				}),
+				"does not silence unrelated missing-claim warnings",
+			);
+		}
+	}
+}
+
 // ── 11. /team done (end-of-run cleanup) ──────────────────────────────
 console.log("\n11. /team done (end-of-run)");
 {