@tldraw/sync-core 5.3.0-internal.fba91ed55f6c → 5.3.0-next.4123e97459a9

package/dist-esm/lib/TLSyncRoom.mjs

@@ -111,41 +111,14 @@ class TLSyncRoom {
   storage;
   serializedSchema;
   documentTypes;
-  /**
-   * Record types served by the object-store lane. Object records ride the same wire messages
-   * as document records but are gated by the session's `objectAccess` instead of `isReadonly`,
-   * and are excluded from `documentTypes` so hosts can persist them in a separate lane.
-   */
-  objectTypes;
   presenceType;
   log;
   schema;
-  authorizeRecord;
   sessionIdleTimeout;
-  /**
-   * The authorizer registered for a record type, widened to the room's record union. Each entry in
-   * `authorizeRecord` is typed to its specific record; the cast here is the one place we can't
-   * statically correlate a runtime `typeName` with its record type, so it lives in the library
-   * rather than in every consumer.
-   */
-  authorizerFor(typeName) {
-    const authorize = this.authorizeRecord?.[typeName];
-    if (!authorize) return void 0;
-    return (args) => {
-      try {
-        return authorize(args);
-      } catch (e) {
-        this.log?.error?.("record authorizer threw; rejecting the write", e);
-        return null;
-      }
-    };
-  }
   constructor(opts) {
     this.schema = opts.schema;
     this.log = opts.log;
     this.onPresenceChange = opts.onPresenceChange;
-    this.onCommittedChanges = opts.onCommittedChanges;
-    this.authorizeRecord = opts.authorizeRecord;
     this.storage = opts.storage;
     this.sessionIdleTimeout = opts.clientTimeout ?? SESSION_IDLE_TIMEOUT;
     assert(
@@ -153,17 +126,8 @@ class TLSyncRoom {
       "TLSyncRoom is supposed to run either on Cloudflare Workersor on a 18+ version of Node.js, which both support the native structuredClone API"
     );
     this.serializedSchema = JSON.parse(JSON.stringify(this.schema.serialize()));
-    this.objectTypes = new Set(opts.objectTypes ?? []);
-    for (const typeName of this.objectTypes) {
-      const type = getOwnProperty(this.schema.types, typeName);
-      assert(type, `TLSyncRoom: object type '${typeName}' is not registered in the schema`);
-      assert(
-        type.scope === "document",
-        `TLSyncRoom: object type '${typeName}' must have scope 'document', got '${type.scope}'`
-      );
-    }
     this.documentTypes = new Set(
-      Object.values(this.schema.types).filter((t) => t.scope === "document" && !this.objectTypes.has(t.typeName)).map((t) => t.typeName)
+      Object.values(this.schema.types).filter((t) => t.scope === "document").map((t) => t.typeName)
     );
     const presenceTypes = new Set(
       Object.values(this.schema.types).filter((t) => t.scope === "presence")
@@ -174,12 +138,6 @@ class TLSyncRoom {
       );
     }
     this.presenceType = presenceTypes.values().next()?.value ?? null;
-    if (this.presenceType && this.authorizeRecord) {
-      assert(
-        !getOwnProperty(this.authorizeRecord, this.presenceType.typeName),
-        `TLSyncRoom: authorizeRecord['${this.presenceType.typeName}'] is a presence type; presence records are not authorized`
-      );
-    }
     const { documentClock } = this.storage.transaction((txn) => {
       this.schema.migrateStorage(txn);
     });
@@ -306,7 +264,6 @@ class TLSyncRoom {
       cancellationTime: Date.now(),
       meta: session.meta,
       isReadonly: session.isReadonly,
-      objectAccess: session.objectAccess,
       requiresLegacyRejection: session.requiresLegacyRejection,
       supportsStringAppend: session.supportsStringAppend
     });
@@ -398,7 +355,7 @@ class TLSyncRoom {
    * @internal
    */
   handleNewSession(opts) {
-    const { sessionId, socket, meta, isReadonly, objectAccess } = opts;
+    const { sessionId, socket, meta, isReadonly } = opts;
     const existing = this.sessions.get(sessionId);
     this.sessions.set(sessionId, {
       state: RoomSessionState.AwaitingConnectMessage,
@@ -408,7 +365,6 @@ class TLSyncRoom {
       sessionStartTime: Date.now(),
       meta,
       isReadonly: isReadonly ?? false,
-      objectAccess: objectAccess ?? "write",
       // this gets set later during handleConnectMessage
       requiresLegacyRejection: false,
       supportsStringAppend: true
@@ -428,7 +384,6 @@ class TLSyncRoom {
       socket,
       meta,
       isReadonly,
-      objectAccess,
       serializedSchema,
       presenceId,
       presenceRecord,
@@ -449,7 +404,6 @@ class TLSyncRoom {
       outstandingDataMessages: [],
       meta,
       isReadonly,
-      objectAccess: objectAccess ?? "write",
       requiresLegacyRejection,
       supportsStringAppend
     });
@@ -710,7 +664,6 @@ class TLSyncRoom {
         supportsStringAppend: session.supportsStringAppend,
         meta: session.meta,
         isReadonly: session.isReadonly,
-        objectAccess: session.objectAccess,
         requiresLegacyRejection: session.requiresLegacyRejection
       });
       this._unsafe_sendMessage(session.sessionId, msg);
@@ -755,8 +708,7 @@ class TLSyncRoom {
         schema: this.schema.serialize(),
         serverClock: txn.getClock(),
         diff: { ...presenceDiff.value, ...docDiff },
-        isReadonly: session.isReadonly,
-        objectAccess: session.objectAccess
+        isReadonly: session.isReadonly
       };
     });
     this.lastDocumentClock = documentClock;
@@ -790,18 +742,13 @@ class TLSyncRoom {
           exhaustiveSwitchError(op[0]);
       }
     };
-    const addDocument = (storage, changes2, id, _state, authorize) => {
+    const addDocument = (storage, changes2, id, _state) => {
       const res = session ? this.schema.migratePersistedRecord(_state, session.serializedSchema, "up") : { type: "success", value: _state };
       if (res.type === "error") {
         throw new TLSyncError(res.reason, TLSyncErrorCloseEventReason.CLIENT_TOO_OLD);
       }
-      let { value: state } = res;
+      const { value: state } = res;
       const doc = storage.get(id);
-      if (authorize) {
-        const result2 = authorize(doc ?? null, state);
-        if (!result2) return Result.ok(void 0);
-        if (!doc) state = result2;
-      }
       if (doc) {
         const recordType = assertExists(getOwnProperty(this.schema.types, doc.typeName));
         const diff = diffAndValidateRecord(doc, state, recordType);
@@ -817,7 +764,7 @@ class TLSyncRoom {
       }
       return Result.ok(void 0);
     };
-    const patchDocument = (storage, changes2, id, patch, authorize) => {
+    const patchDocument = (storage, changes2, id, patch) => {
       const doc = storage.get(id);
       if (!doc) return;
       const recordType = assertExists(getOwnProperty(this.schema.types, doc.typeName));
@@ -828,7 +775,6 @@ class TLSyncRoom {
       if (downgraded.value === doc) {
         const diff = applyAndDiffRecord(doc, patch, recordType, legacyAppendMode);
         if (diff) {
-          if (authorize && !authorize(doc, diff[1])) return;
           storage.set(id, diff[1]);
           propagateOp(changes2, id, [RecordOpType.Patch, diff[0]], doc, diff[1]);
         }
@@ -840,7 +786,6 @@ class TLSyncRoom {
         }
         const diff = diffAndValidateRecord(doc, upgraded.value, recordType, legacyAppendMode);
         if (diff) {
-          if (authorize && !authorize(doc, upgraded.value)) return;
           storage.set(id, upgraded.value);
           propagateOp(changes2, id, [RecordOpType.Patch, diff], doc, upgraded.value);
         }
@@ -875,89 +820,21 @@ class TLSyncRoom {
             }
           }
         }
-        const canWrite = (typeName) => !session || (this.objectTypes.has(typeName) ? session.objectAccess !== "read" : !session.isReadonly);
-        if (message.diff) {
+        if (message.diff && !session?.isReadonly) {
           for (const [id, op] of objectMapEntriesIterable(message.diff)) {
             switch (op[0]) {
               case RecordOpType.Put: {
-                if (!canWrite(op[1].typeName)) continue;
-                if (!this.documentTypes.has(op[1].typeName) && !this.objectTypes.has(op[1].typeName)) {
+                if (!this.documentTypes.has(op[1].typeName)) {
                   throw new TLSyncError(
                     "invalid record",
                     TLSyncErrorCloseEventReason.INVALID_RECORD
                   );
                 }
-                const record = op[1];
-                let authorize;
-                if (session && this.authorizeRecord) {
-                  const prev = txn.get(id) ?? null;
-                  if (prev && prev.typeName !== record.typeName) {
-                    this.log?.warn?.(
-                      "skipping put that changes typeName",
-                      `${prev.typeName} -> ${record.typeName}`,
-                      id,
-                      "session:",
-                      session.sessionId
-                    );
-                    continue;
-                  }
-                  const authorizePut = this.authorizerFor(record.typeName);
-                  if (authorizePut) {
-                    authorize = (prevRec, next) => {
-                      const result2 = authorizePut(
-                        prevRec ? {
-                          session: { sessionId: session.sessionId, meta: session.meta },
-                          type: "update",
-                          prev: prevRec,
-                          next
-                        } : {
-                          session: { sessionId: session.sessionId, meta: session.meta },
-                          type: "create",
-                          prev: null,
-                          next
-                        }
-                      );
-                      if (!result2) {
-                        this.log?.warn?.(
-                          "authorizer vetoed put",
-                          record.typeName,
-                          id,
-                          "session:",
-                          session.sessionId
-                        );
-                        return null;
-                      }
-                      return prevRec ? next : result2;
-                    };
-                  }
-                }
-                addDocument(txn, docChanges, id, record, authorize);
+                addDocument(txn, docChanges, id, op[1]);
                 break;
               }
               case RecordOpType.Patch: {
-                const doc = txn.get(id);
-                if (!doc) continue;
-                if (!canWrite(doc.typeName)) continue;
-                const authorizePatch = session && this.authorizerFor(doc.typeName);
-                const authorize = authorizePatch ? (prev, next) => {
-                  const result2 = authorizePatch({
-                    session: { sessionId: session.sessionId, meta: session.meta },
-                    type: "update",
-                    prev,
-                    next
-                  });
-                  if (!result2) {
-                    this.log?.warn?.(
-                      "authorizer vetoed patch",
-                      doc.typeName,
-                      id,
-                      "session:",
-                      session.sessionId
-                    );
-                  }
-                  return result2;
-                } : void 0;
-                patchDocument(txn, docChanges, id, op[1], authorize);
+                patchDocument(txn, docChanges, id, op[1]);
                 break;
               }
               case RecordOpType.Remove: {
@@ -965,23 +842,6 @@ class TLSyncRoom {
                 if (!doc) {
                   continue;
                 }
-                if (!canWrite(doc.typeName)) continue;
-                const authorizeRemove = session && this.authorizerFor(doc.typeName);
-                if (authorizeRemove && !authorizeRemove({
-                  session: { sessionId: session.sessionId, meta: session.meta },
-                  type: "delete",
-                  prev: doc,
-                  next: null
-                })) {
-                  this.log?.warn?.(
-                    "authorizer vetoed delete",
-                    doc.typeName,
-                    id,
-                    "session:",
-                    session.sessionId
-                  );
-                  continue;
-                }
                 txn.delete(id);
                 propagateOp(docChanges, id, op, doc, void 0);
                 break;
@@ -1056,16 +916,6 @@ class TLSyncRoom {
         this.onPresenceChange?.();
       });
     }
-    if (result.docChanges.diffs && this.onCommittedChanges) {
-      const diff = result.docChanges.diffs.diff;
-      queueMicrotask(() => {
-        try {
-          this.onCommittedChanges?.({ diff, documentClock });
-        } catch (e) {
-          this.log?.error?.("onCommittedChanges threw", e);
-        }
-      });
-    }
   }
   /**
    * Handle the event when a client disconnects. Cleans up the session and