@tldraw/editor 5.5.0-canary.277b26aa4b0a → 5.5.0-canary.2a22fdfebf61

package/dist-cjs/index.d.ts

@@ -3483,7 +3483,6 @@ export declare class Editor extends EventEmitter<TLEventMap> {
     deleteBindings(bindings: (TLBinding | TLBindingId)[], { isolateShapes }?: {
         isolateShapes?: boolean | undefined;
     }): this;
-    /* Excluded from this release type: _deleteBindings */
     /**
      * Delete a binding by its ID. If the binding doesn't exist, it's ignored.
      */

package/dist-cjs/index.js

@@ -392,7 +392,7 @@ var import_uniq = require("./lib/utils/uniq");
 var import_defaultThemes2 = require("./lib/editor/managers/ThemeManager/defaultThemes");
 (0, import_utils.registerTldrawLibraryVersion)(
   "@tldraw/editor",
-  "5.5.0-canary.277b26aa4b0a",
+  "5.5.0-canary.2a22fdfebf61",
   "cjs"
 );
 //# sourceMappingURL=index.js.map

package/dist-cjs/lib/editor/Editor.js

@@ -421,7 +421,7 @@ class Editor extends import_eventemitter3.default {
               }
             }
             if (deleteBindingIds.length) {
-              this.store.remove(deleteBindingIds);
+              this.deleteBindings(deleteBindingIds);
             }
           }
         },
@@ -1381,7 +1381,6 @@ class Editor extends import_eventemitter3.default {
    * @public
    **/
   updateDocumentSettings(settings) {
-    if (this.getIsReadonly()) return this;
     this.run(
       () => {
         this.store.put([{ ...this.getDocumentSettings(), ...settings }]);
@@ -4872,7 +4871,6 @@ class Editor extends import_eventemitter3.default {
    * binding, but the `type`, `toId`, and `fromId` must all be provided.
    */
   createBindings(partials) {
-    if (this.getIsReadonly()) return this;
     const bindings = [];
     for (const partial of partials) {
       const fromShape = this.getShape(partial.fromId);
@@ -4907,7 +4905,6 @@ class Editor extends import_eventemitter3.default {
    * binding is skipped. The changes from the partial are merged into the existing record.
    */
   updateBindings(partials) {
-    if (this.getIsReadonly()) return this;
     const updated = [];
     for (const partial of partials) {
       if (!partial) continue;
@@ -4936,16 +4933,6 @@ class Editor extends import_eventemitter3.default {
    * Delete several bindings by their IDs. If a binding ID doesn't exist, it's ignored.
    */
   deleteBindings(bindings, { isolateShapes = false } = {}) {
-    if (this.getIsReadonly()) return this;
-    return this._deleteBindings(bindings, { isolateShapes });
-  }
-  /**
-   * Unguarded so that withIsolatedShapes can transiently isolate shapes for copy and export in
-   * readonly mode; the public deleteBindings is what readonly blocks.
-   *
-   * @internal
-   */
-  _deleteBindings(bindings, { isolateShapes = false } = {}) {
     const ids = bindings.map((binding) => typeof binding === "string" ? binding : binding.id);
     if (isolateShapes) {
       this.store.atomic(() => {
@@ -6384,6 +6371,7 @@ class Editor extends import_eventemitter3.default {
     }
     if (this.getIsReadonly()) return this;
     const ids = typeof shapes[0] === "string" ? shapes : shapes.map((s) => s.id);
+    if (ids.length <= 1) return this;
     const shapesToGroup = (0, import_utils.compact)(
       (this._shouldIgnoreShapeLock ? ids : this._getUnlockedShapeIds(ids)).map(
         (id) => this.getShape(id)
@@ -6398,11 +6386,8 @@ class Editor extends import_eventemitter3.default {
     }
     const { x, y } = pageBounds.point;
     const parentId = this.findCommonAncestor(shapesToGroup) ?? this.getCurrentPageId();
-    if (!this.canCreateShapes([groupId])) {
-      alertMaxShapes(this);
-      return this;
-    }
-    if (this.isIn("select") && !this.isIn("select.idle")) {
+    if (this.getCurrentToolId() !== "select") return this;
+    if (!this.isIn("select.idle")) {
       this.cancel();
     }
     const shapesWithRootParent = shapesToGroup.filter((shape) => shape.parentId === parentId).sort(import_utils.sortByIndex);
@@ -6437,7 +6422,8 @@ class Editor extends import_eventemitter3.default {
       )
     );
     if (shapesToUngroup.length === 0) return this;
-    if (this.isIn("select") && !this.isIn("select.idle")) {
+    if (this.getCurrentToolId() !== "select") return this;
+    if (!this.isIn("select.idle")) {
       this.cancel();
     }
     const idsToSelect = /* @__PURE__ */ new Set();
@@ -6451,16 +6437,16 @@ class Editor extends import_eventemitter3.default {
     });
     if (groups.length === 0) return this;
     this.run(() => {
+      let group;
       for (let i = 0, n = groups.length; i < n; i++) {
-        const group = this.getShape(groups[i].id);
-        if (!group) continue;
+        group = groups[i];
         const childIds = this.getSortedChildIdsForParent(group.id);
         for (let j = 0, n2 = childIds.length; j < n2; j++) {
           idsToSelect.add(childIds[j]);
         }
         this.reparentShapes(childIds, group.parentId, group.index);
       }
-      this.deleteShapes(groups.map((group) => group.id));
+      this.deleteShapes(groups.map((group2) => group2.id));
       if (select) {
         this.select(...idsToSelect);
       }
@@ -8724,7 +8710,7 @@ function withIsolatedShapes(editor, shapeIds, callback) {
             }
           }
         }
-        editor._deleteBindings([...bindingsToRemove], { isolateShapes: true });
+        editor.deleteBindings([...bindingsToRemove], { isolateShapes: true });
         try {
           result = import_utils.Result.ok(callback(bindingsWithBoth));
         } catch (error) {