@tldraw/editor 3.15.0-canary.fc319eb96b77 → 3.15.0-next.032b45f439ca

package/src/lib/editor/Editor.test.ts

@@ -425,410 +425,3 @@ describe('getShapesAtPoint', () => {
 		expect(hollowShapesWithHitInside[0].id).toBe(ids.hollowShape)
 	})
 })
-
-describe('selectAll', () => {
-	const selectAllIds = {
-		pageShape1: createShapeId('pageShape1'),
-		pageShape2: createShapeId('pageShape2'),
-		pageShape3: createShapeId('pageShape3'),
-		container1: createShapeId('container1'),
-		containerChild1: createShapeId('containerChild1'),
-		containerChild2: createShapeId('containerChild2'),
-		containerChild3: createShapeId('containerChild3'),
-		containerGrandchild1: createShapeId('containerGrandchild1'),
-		container2: createShapeId('container2'),
-		container2Child1: createShapeId('container2Child1'),
-		container2Child2: createShapeId('container2Child2'),
-		container2Grandchild1: createShapeId('container2Grandchild1'),
-		lockedShape: createShapeId('lockedShape'),
-	}
-
-	beforeEach(() => {
-		// Clear any existing shapes
-		editor.selectAll().deleteShapes(editor.getSelectedShapeIds())
-
-		// Create shapes directly on the page (no parentId means they're children of the page)
-		editor.createShapes([
-			{
-				id: selectAllIds.pageShape1,
-				type: 'my-custom-shape',
-				x: 100,
-				y: 100,
-				props: { w: 100, h: 100 },
-			},
-			{
-				id: selectAllIds.pageShape2,
-				type: 'my-custom-shape',
-				x: 300,
-				y: 100,
-				props: { w: 100, h: 100 },
-			},
-			{
-				id: selectAllIds.pageShape3,
-				type: 'my-custom-shape',
-				x: 500,
-				y: 100,
-				props: { w: 100, h: 100 },
-			},
-			{
-				id: selectAllIds.lockedShape,
-				type: 'my-custom-shape',
-				x: 700,
-				y: 100,
-				props: { w: 100, h: 100 },
-				isLocked: true,
-			},
-		])
-
-		// Create a container shape (simulating a frame or group)
-		editor.createShape({
-			id: selectAllIds.container1,
-			type: 'my-custom-shape',
-			x: 100,
-			y: 300,
-			props: { w: 400, h: 200 },
-		})
-
-		// Create children inside the container (parentId set to container1)
-		editor.createShapes([
-			{
-				id: selectAllIds.containerChild1,
-				type: 'my-custom-shape',
-				parentId: selectAllIds.container1,
-				x: 120,
-				y: 320,
-				props: { w: 50, h: 50 },
-			},
-			{
-				id: selectAllIds.containerChild2,
-				type: 'my-custom-shape',
-				parentId: selectAllIds.container1,
-				x: 200,
-				y: 320,
-				props: { w: 50, h: 50 },
-			},
-			{
-				id: selectAllIds.containerChild3,
-				type: 'my-custom-shape',
-				parentId: selectAllIds.container1,
-				x: 280,
-				y: 320,
-				props: { w: 50, h: 50 },
-			},
-		])
-
-		// Create a grandchild inside one of the container children
-		editor.createShape({
-			id: selectAllIds.containerGrandchild1,
-			type: 'my-custom-shape',
-			parentId: selectAllIds.containerChild3,
-			x: 290,
-			y: 330,
-			props: { w: 30, h: 30 },
-		})
-
-		// Create a second container (simulating a group)
-		editor.createShape({
-			id: selectAllIds.container2,
-			type: 'my-custom-shape',
-			x: 600,
-			y: 300,
-			props: { w: 200, h: 200 },
-		})
-
-		// Create children inside the second container
-		editor.createShapes([
-			{
-				id: selectAllIds.container2Child1,
-				type: 'my-custom-shape',
-				parentId: selectAllIds.container2,
-				x: 620,
-				y: 320,
-				props: { w: 50, h: 50 },
-			},
-			{
-				id: selectAllIds.container2Child2,
-				type: 'my-custom-shape',
-				parentId: selectAllIds.container2,
-				x: 680,
-				y: 320,
-				props: { w: 50, h: 50 },
-			},
-		])
-
-		// Create a grandchild in the second container
-		editor.createShape({
-			id: selectAllIds.container2Grandchild1,
-			type: 'my-custom-shape',
-			parentId: selectAllIds.container2Child1,
-			x: 630,
-			y: 330,
-			props: { w: 30, h: 30 },
-		})
-
-		// Clear selection
-		editor.selectNone()
-	})
-
-	it('when no shapes are selected, selects all page-level shapes (excluding locked ones)', () => {
-		// Initially no shapes selected
-		expect(editor.getSelectedShapeIds()).toEqual([])
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Should select all page-level shapes (excluding locked ones)
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[
-				selectAllIds.pageShape1,
-				selectAllIds.pageShape2,
-				selectAllIds.pageShape3,
-				selectAllIds.container1,
-				selectAllIds.container2,
-			].sort()
-		)
-
-		// Should NOT include locked shape or children/grandchildren
-		expect(selectedIds).not.toContain(selectAllIds.lockedShape)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild1)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild2)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild3)
-		expect(selectedIds).not.toContain(selectAllIds.containerGrandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child2)
-		expect(selectedIds).not.toContain(selectAllIds.container2Grandchild1)
-	})
-
-	it('when shapes are selected only on the page, all children of the page should be selected (but not their descendants)', () => {
-		// Select some page-level shapes
-		editor.select(selectAllIds.pageShape1, selectAllIds.pageShape2)
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Should select all page-level shapes (excluding locked ones), but not descendants
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[
-				selectAllIds.pageShape1,
-				selectAllIds.pageShape2,
-				selectAllIds.pageShape3,
-				selectAllIds.container1,
-				selectAllIds.container2,
-			].sort()
-		)
-
-		// Should NOT include children or grandchildren or locked shapes
-		expect(selectedIds).not.toContain(selectAllIds.containerChild1)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild2)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild3)
-		expect(selectedIds).not.toContain(selectAllIds.containerGrandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child2)
-		expect(selectedIds).not.toContain(selectAllIds.container2Grandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.lockedShape)
-	})
-
-	it('when shapes are selected within a container, only children of the container should be selected (not their descendants)', () => {
-		// Select some container children
-		editor.select(selectAllIds.containerChild1, selectAllIds.containerChild2)
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Should select all container children (but not their descendants)
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[
-				selectAllIds.containerChild1,
-				selectAllIds.containerChild2,
-				selectAllIds.containerChild3,
-			].sort()
-		)
-
-		// Should NOT include page-level shapes or grandchildren
-		expect(selectedIds).not.toContain(selectAllIds.pageShape1)
-		expect(selectedIds).not.toContain(selectAllIds.pageShape2)
-		expect(selectedIds).not.toContain(selectAllIds.pageShape3)
-		expect(selectedIds).not.toContain(selectAllIds.container1)
-		expect(selectedIds).not.toContain(selectAllIds.container2)
-		expect(selectedIds).not.toContain(selectAllIds.containerGrandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child2)
-		expect(selectedIds).not.toContain(selectAllIds.container2Grandchild1)
-	})
-
-	it('when shapes are selected within a second container, only children of that container should be selected', () => {
-		// Select some second container children
-		editor.select(selectAllIds.container2Child1)
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Should select all second container children (but not their descendants)
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[selectAllIds.container2Child1, selectAllIds.container2Child2].sort()
-		)
-
-		// Should NOT include page-level shapes or other container's children or grandchildren
-		expect(selectedIds).not.toContain(selectAllIds.pageShape1)
-		expect(selectedIds).not.toContain(selectAllIds.pageShape2)
-		expect(selectedIds).not.toContain(selectAllIds.pageShape3)
-		expect(selectedIds).not.toContain(selectAllIds.container1)
-		expect(selectedIds).not.toContain(selectAllIds.container2)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild1)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild2)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild3)
-		expect(selectedIds).not.toContain(selectAllIds.containerGrandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Grandchild1)
-	})
-
-	it('when shapes are selected that belong to different parents, no change/history entry should be made', () => {
-		// Select shapes from different parents (page and container)
-		editor.select(selectAllIds.pageShape1, selectAllIds.containerChild1)
-
-		const initialSelectedIds = editor.getSelectedShapeIds()
-
-		// Spy on setSelectedShapes to verify it's not called
-		const setSelectedShapesSpy = jest.spyOn(editor, 'setSelectedShapes')
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Selection should remain unchanged
-		expect(editor.getSelectedShapeIds()).toEqual(initialSelectedIds)
-
-		// setSelectedShapes should not have been called (the method returns early)
-		expect(setSelectedShapesSpy).not.toHaveBeenCalled()
-
-		setSelectedShapesSpy.mockRestore()
-	})
-
-	it('when shapes are selected that belong to different containers, no change/history entry should be made', () => {
-		// Select shapes from different containers
-		editor.select(selectAllIds.containerChild1, selectAllIds.container2Child1)
-
-		const initialSelectedIds = editor.getSelectedShapeIds()
-
-		// Spy on setSelectedShapes to verify it's not called
-		const setSelectedShapesSpy = jest.spyOn(editor, 'setSelectedShapes')
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Selection should remain unchanged
-		expect(editor.getSelectedShapeIds()).toEqual(initialSelectedIds)
-
-		// setSelectedShapes should not have been called
-		expect(setSelectedShapesSpy).not.toHaveBeenCalled()
-
-		setSelectedShapesSpy.mockRestore()
-	})
-
-	it('should not select locked shapes', () => {
-		// Select a page-level shape
-		editor.select(selectAllIds.pageShape1)
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Should select all page-level shapes except locked ones
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(selectedIds).not.toContain(selectAllIds.lockedShape)
-		expect(selectedIds).toContain(selectAllIds.pageShape1)
-		expect(selectedIds).toContain(selectAllIds.pageShape2)
-		expect(selectedIds).toContain(selectAllIds.pageShape3)
-		expect(selectedIds).toContain(selectAllIds.container1)
-		expect(selectedIds).toContain(selectAllIds.container2)
-	})
-
-	it('should handle empty container by selecting all siblings at the same level', () => {
-		// Create an empty container
-		const emptyContainerId = createShapeId('emptyContainer')
-		editor.createShape({
-			id: emptyContainerId,
-			type: 'my-custom-shape',
-			x: 800,
-			y: 400,
-			props: { w: 100, h: 100 },
-		})
-
-		// Clear selection first
-		editor.selectNone()
-
-		// Select the empty container
-		editor.select(emptyContainerId)
-
-		// Call selectAll - since the empty container has no children, it should select all siblings (page-level shapes)
-		editor.selectAll()
-
-		// Should select all page-level shapes (including the empty container itself)
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[
-				selectAllIds.pageShape1,
-				selectAllIds.pageShape2,
-				selectAllIds.pageShape3,
-				selectAllIds.container1,
-				selectAllIds.container2,
-				emptyContainerId,
-			].sort()
-		)
-
-		// Should NOT include locked shapes or children/grandchildren
-		expect(selectedIds).not.toContain(selectAllIds.lockedShape)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild1)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild2)
-		expect(selectedIds).not.toContain(selectAllIds.containerChild3)
-		expect(selectedIds).not.toContain(selectAllIds.containerGrandchild1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child1)
-		expect(selectedIds).not.toContain(selectAllIds.container2Child2)
-		expect(selectedIds).not.toContain(selectAllIds.container2Grandchild1)
-	})
-
-	it('should work correctly when selecting all shapes of same parent type', () => {
-		// Select all container children
-		editor.select(
-			selectAllIds.containerChild1,
-			selectAllIds.containerChild2,
-			selectAllIds.containerChild3
-		)
-
-		// Call selectAll - should maintain the same selection since all children are already selected
-		editor.selectAll()
-
-		// Should still have all container children selected
-		const selectedIds = editor.getSelectedShapeIds()
-		expect(Array.from(selectedIds).sort()).toEqual(
-			[
-				selectAllIds.containerChild1,
-				selectAllIds.containerChild2,
-				selectAllIds.containerChild3,
-			].sort()
-		)
-	})
-
-	it('should handle mixed selection levels gracefully by doing nothing', () => {
-		// Select a mix: page shape (parent=page), container (parent=page), and container child (parent=container1)
-		// These all have different parent IDs so selectAll should do nothing
-		editor.select(selectAllIds.pageShape1, selectAllIds.containerChild1)
-
-		const initialSelectedIds = Array.from(editor.getSelectedShapeIds())
-
-		// Spy on setSelectedShapes to verify it's not called
-		const setSelectedShapesSpy = jest.spyOn(editor, 'setSelectedShapes')
-
-		// Call selectAll
-		editor.selectAll()
-
-		// Selection should remain unchanged since shapes have different parents
-		expect(Array.from(editor.getSelectedShapeIds())).toEqual(initialSelectedIds)
-
-		// setSelectedShapes should not have been called
-		expect(setSelectedShapesSpy).not.toHaveBeenCalled()
-
-		setSelectedShapesSpy.mockRestore()
-	})
-})

package/src/lib/editor/Editor.ts

@@ -1803,9 +1803,7 @@ export class Editor extends EventEmitter<TLEventMap> {
 	}
 
 	/**
-	 * Select all shapes. If the user has selected shapes that share a parent,
-	 * select all shapes within that parent. If the user has not selected any shapes,
-	 * or if the shapes shapes are only on select all shapes on the current page.
+	 * Select all direct children of the current page.
 	 *
 	 * @example
 	 * ```ts
@@ -1815,34 +1813,11 @@ export class Editor extends EventEmitter<TLEventMap> {
 	 * @public
 	 */
 	selectAll(): this {
-		let parentToSelectWithinId: TLParentId | null = null
-
-		const selectedShapeIds = this.getSelectedShapeIds()
-
-		// If we have selected shapes, try to find a parent to select within
-		if (selectedShapeIds.length > 0) {
-			for (const id of selectedShapeIds) {
-				const shape = this.getShape(id)
-				if (!shape) continue
-				if (parentToSelectWithinId === null) {
-					// If we haven't found a parent yet, set this parent as the parent to select within
-					parentToSelectWithinId = shape.parentId
-				} else if (parentToSelectWithinId !== shape.parentId) {
-					// If we've found two different parents, we can't select all, do nothing
-					return this
-				}
-			}
-		}
-
-		// If we haven't found a parent from our selected shapes, select the current page
-		if (!parentToSelectWithinId) {
-			parentToSelectWithinId = this.getCurrentPageId()
-		}
-
-		// Select all the unlocked shapes within the parent
-		const ids = this.getSortedChildIdsForParent(parentToSelectWithinId)
+		const ids = this.getSortedChildIdsForParent(this.getCurrentPageId())
+		// page might have no shapes
 		if (ids.length <= 0) return this
 		this.setSelectedShapes(this._getUnlockedShapeIds(ids))
+
 		return this
 	}
 

package/src/lib/primitives/geometry/Arc2d.ts

@@ -2,7 +2,7 @@ import { Vec, VecLike } from '../Vec'
 import { intersectLineSegmentCircle } from '../intersect'
 import { getArcMeasure, getPointInArcT, getPointOnCircle } from '../utils'
 import { Geometry2d, Geometry2dOptions } from './Geometry2d'
-import { getVerticesCountForArcLength } from './geometry-constants'
+import { getVerticesCountForLength } from './geometry-constants'
 
 /** @public */
 export class Arc2d extends Geometry2d {
@@ -94,7 +94,7 @@ export class Arc2d extends Geometry2d {
 	getVertices(): Vec[] {
 		const { _center, _measure: measure, length, _radius: radius, _angleStart: angleStart } = this
 		const vertices: Vec[] = []
-		for (let i = 0, n = getVerticesCountForArcLength(Math.abs(length)); i < n + 1; i++) {
+		for (let i = 0, n = getVerticesCountForLength(Math.abs(length)); i < n + 1; i++) {
 			const t = (i / n) * measure
 			const angle = angleStart + t
 			vertices.push(getPointOnCircle(_center, radius, angle))

package/src/lib/primitives/geometry/Circle2d.ts

@@ -3,7 +3,7 @@ import { Vec, VecLike } from '../Vec'
 import { intersectLineSegmentCircle } from '../intersect'
 import { PI2, getPointOnCircle } from '../utils'
 import { Geometry2d, Geometry2dOptions } from './Geometry2d'
-import { getVerticesCountForArcLength } from './geometry-constants'
+import { getVerticesCountForLength } from './geometry-constants'
 
 /** @public */
 export class Circle2d extends Geometry2d {
@@ -36,7 +36,7 @@ export class Circle2d extends Geometry2d {
 		const { _center, _radius: radius } = this
 		const perimeter = PI2 * radius
 		const vertices: Vec[] = []
-		for (let i = 0, n = getVerticesCountForArcLength(perimeter); i < n; i++) {
+		for (let i = 0, n = getVerticesCountForLength(perimeter); i < n; i++) {
 			const angle = (i / n) * PI2
 			vertices.push(getPointOnCircle(_center, radius, angle))
 		}

package/src/lib/primitives/geometry/CubicBezier2d.ts

@@ -8,7 +8,6 @@ export class CubicBezier2d extends Polyline2d {
 	private _b: Vec
 	private _c: Vec
 	private _d: Vec
-	private _resolution: number
 
 	constructor(
 		config: Omit<Geometry2dOptions, 'isFilled' | 'isClosed'> & {
@@ -16,7 +15,6 @@ export class CubicBezier2d extends Polyline2d {
 			cp1: Vec
 			cp2: Vec
 			end: Vec
-			resolution?: number
 		}
 	) {
 		const { start: a, cp1: b, cp2: c, end: d } = config
@@ -26,14 +24,13 @@ export class CubicBezier2d extends Polyline2d {
 		this._b = b
 		this._c = c
 		this._d = d
-		this._resolution = config.resolution ?? 10
 	}
 
 	override getVertices() {
 		const vertices = [] as Vec[]
 		const { _a: a, _b: b, _c: c, _d: d } = this
 		// we'll always use ten vertices for each bezier curve
-		for (let i = 0, n = this._resolution; i <= n; i++) {
+		for (let i = 0, n = 10; i <= n; i++) {
 			const t = i / n
 			vertices.push(
 				new Vec(

package/src/lib/primitives/geometry/Ellipse2d.ts

@@ -3,7 +3,7 @@ import { Vec, VecLike } from '../Vec'
 import { PI, PI2, clamp, perimeterOfEllipse } from '../utils'
 import { Edge2d } from './Edge2d'
 import { Geometry2d, Geometry2dOptions } from './Geometry2d'
-import { getVerticesCountForArcLength } from './geometry-constants'
+import { getVerticesCountForLength } from './geometry-constants'
 
 /** @public */
 export class Ellipse2d extends Geometry2d {
@@ -47,7 +47,7 @@ export class Ellipse2d extends Geometry2d {
 		const q = Math.pow(cx - cy, 2) / Math.pow(cx + cy, 2)
 		const p = PI * (cx + cy) * (1 + (3 * q) / (10 + Math.sqrt(4 - 3 * q)))
 		// Number of points
-		const len = getVerticesCountForArcLength(p)
+		const len = getVerticesCountForLength(p)
 		// Size of step
 		const step = PI2 / len
 

package/src/lib/primitives/geometry/geometry-constants.ts

@@ -1,7 +1,6 @@
 const SPACING = 20
 const MIN_COUNT = 8
 
-/** @internal */
-export function getVerticesCountForArcLength(length: number, spacing = SPACING) {
+export function getVerticesCountForLength(length: number, spacing = SPACING) {
 	return Math.max(MIN_COUNT, Math.ceil(length / spacing))
 }

package/src/version.ts

@@ -1,9 +1,9 @@
 // This file is automatically generated by internal/scripts/refresh-assets.ts.
 // Do not edit manually. Or do, I'm a comment, not a cop.
 
-export const version = '3.15.0-canary.fc319eb96b77'
+export const version = '3.15.0-next.032b45f439ca'
 export const publishDates = {
 	major: '2024-09-13T14:36:29.063Z',
-	minor: '2025-07-11T13:41:21.778Z',
-	patch: '2025-07-11T13:41:21.778Z',
+	minor: '2025-07-14T09:15:42.267Z',
+	patch: '2025-07-14T09:15:42.267Z',
 }