@tldraw/editor 3.14.0-canary.e989a4107be2 → 3.14.0-canary.ea2c4acfa022

package/src/lib/editor/Editor.ts

@@ -3662,7 +3662,7 @@ export class Editor extends EventEmitter<TLEventMap> {
 	 * @public
 	 */
 	updateViewportScreenBounds(screenBounds: Box | HTMLElement, center = false): this {
-		if (!(screenBounds instanceof Box)) {
+		if (screenBounds instanceof HTMLElement) {
 			const rect = screenBounds.getBoundingClientRect()
 			screenBounds = new Box(
 				rect.left || rect.x,
@@ -5528,7 +5528,7 @@ export class Editor extends EventEmitter<TLEventMap> {
 		if (!id) return undefined
 		const freshShape = this.getShape(id)
 		if (freshShape === undefined || !isShapeId(freshShape.parentId)) return undefined
-		return this.getShape(freshShape.parentId)
+		return this.store.get(freshShape.parentId)
 	}
 
 	/**
@@ -5711,10 +5711,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 					const newPoint = invertedParentTransform.applyToPoint(pagePoint)
 					const newRotation = pageTransform.rotation() - parentPageRotation
 
-					if (shape.id === parentId) {
-						throw Error('Attempted to reparent a shape to itself!')
-					}
-
 					changes.push({
 						id: shape.id,
 						type: shape.type,
@@ -5818,11 +5814,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 		return shapeIds
 	}
 
-	/** @deprecated Use {@link Editor.getDraggingOverShape} instead */
-	getDroppingOverShape(point: Vec, droppingShapes: TLShape[]): TLShape | undefined {
-		return this.getDraggingOverShape(point, droppingShapes)
-	}
-
 	/**
 	 * Get the shape that some shapes should be dropped on at a given point.
 	 *
@@ -5833,33 +5824,35 @@ export class Editor extends EventEmitter<TLEventMap> {
 	 *
 	 * @public
 	 */
-	getDraggingOverShape(point: Vec, droppingShapes: TLShape[]): TLShape | undefined {
-		// get fresh moving shapes
-		const draggingShapes = compact(droppingShapes.map((s) => this.getShape(s))).filter(
-			(s) => !s.isLocked && !this.isShapeHidden(s)
-		)
+	getDroppingOverShape(point: VecLike, droppingShapes: TLShape[] = []) {
+		// starting from the top...
+		const currentPageShapesSorted = this.getCurrentPageShapesSorted()
+		for (let i = currentPageShapesSorted.length - 1; i >= 0; i--) {
+			const shape = currentPageShapesSorted[i]
 
-		const maybeDraggingOverShapes = this.getShapesAtPoint(point, {
-			hitInside: true,
-			margin: 0,
-		}).filter(
-			(s) =>
-				!droppingShapes.includes(s) &&
-				!s.isLocked &&
-				!this.isShapeHidden(s) &&
-				!draggingShapes.includes(s)
-		)
+			if (
+				// ignore hidden shapes
+				this.isShapeHidden(shape) ||
+				// don't allow dropping on selected shapes
+				this.getSelectedShapeIds().includes(shape.id) ||
+				// only allow shapes that can receive children
+				!this.getShapeUtil(shape).canDropShapes(shape, droppingShapes) ||
+				// don't allow dropping a shape on itself or one of it's children
+				droppingShapes.find((s) => s.id === shape.id || this.hasAncestor(shape, s.id))
+			) {
+				continue
+			}
+
+			// Only allow dropping into the masked page bounds of the shape, e.g. when a frame is
+			// partially clipped by its own parent frame
+			const maskedPageBounds = this.getShapeMaskedPageBounds(shape.id)
 
-		for (const maybeDraggingOverShape of maybeDraggingOverShapes) {
-			const shapeUtil = this.getShapeUtil(maybeDraggingOverShape)
-			// Any shape that can handle any dragging interactions is a valid target
 			if (
-				shapeUtil.onDragShapesOver ||
-				shapeUtil.onDragShapesIn ||
-				shapeUtil.onDragShapesOut ||
-				shapeUtil.onDropShapesOver
+				maskedPageBounds &&
+				maskedPageBounds.containsPoint(point) &&
+				this.getShapeGeometry(shape).hitTestPoint(this.getPointInShapeSpace(shape, point), 0, true)
 			) {
-				return maybeDraggingOverShape
+				return shape
 			}
 		}
 	}
@@ -6218,12 +6211,11 @@ export class Editor extends EventEmitter<TLEventMap> {
 	 */
 	duplicateShapes(shapes: TLShapeId[] | TLShape[], offset?: VecLike): this {
 		this.run(() => {
-			const _ids =
+			const ids =
 				typeof shapes[0] === 'string'
 					? (shapes as TLShapeId[])
 					: (shapes as TLShape[]).map((s) => s.id)
 
-			const ids = this._shouldIgnoreShapeLock ? _ids : this._getUnlockedShapeIds(_ids)
 			if (ids.length <= 0) return this
 
 			const initialIds = new Set(ids)
@@ -6303,7 +6295,10 @@ export class Editor extends EventEmitter<TLEventMap> {
 			})
 			const shapesToCreate = shapesToCreateWithOriginals.map(({ shape }) => shape)
 
-			if (!this.canCreateShapes(shapesToCreate)) {
+			const maxShapesReached =
+				shapesToCreate.length + this.getCurrentPageShapeIds().size > this.options.maxShapesPerPage
+
+			if (maxShapesReached) {
 				alertMaxShapes(this)
 				return
 			}
@@ -7732,32 +7727,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 		return {}
 	}
 
-	/**
-	 * Get whether the provided shape can be created.
-	 *
-	 * @param shape - The shape or shape IDs to check.
-	 *
-	 * @public
-	 */
-	canCreateShape<T extends TLUnknownShape>(
-		shape: OptionalKeys<TLShapePartial<T>, 'id'> | T['id']
-	): boolean {
-		return this.canCreateShapes([shape])
-	}
-
-	/**
-	 * Get whether the provided shapes can be created.
-	 *
-	 * @param shapes - The shapes or shape IDs to create.
-	 *
-	 * @public
-	 */
-	canCreateShapes<T extends TLUnknownShape>(
-		shapes: (T['id'] | OptionalKeys<TLShapePartial<T>, 'id'>)[]
-	): boolean {
-		return shapes.length + this.getCurrentPageShapeIds().size <= this.options.maxShapesPerPage
-	}
-
 	/**
 	 * Create a single shape.
 	 *
@@ -7804,7 +7773,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 		if (maxShapesReached) {
 			// can't create more shapes than fit on the page
 			alertMaxShapes(this)
-			// todo: throw an error here? Otherwise we'll need to check every time whether the shapes were actually created
 			return this
 		}
 
@@ -7837,10 +7805,9 @@ export class Editor extends EventEmitter<TLEventMap> {
 
 					for (let i = currentPageShapesSorted.length - 1; i >= 0; i--) {
 						const parent = currentPageShapesSorted[i]
-						const util = this.getShapeUtil(parent)
 						if (
-							util.canReceiveNewChildrenOfType(parent, partial.type) &&
 							!this.isShapeHidden(parent) &&
+							this.getShapeUtil(parent).canReceiveNewChildrenOfType(parent, partial.type) &&
 							this.isPointInShape(
 								parent,
 								// If no parent is provided, then we can treat the
@@ -7859,7 +7826,7 @@ export class Editor extends EventEmitter<TLEventMap> {
 
 					const prevParentId = partial.parentId
 
-					// a shape cannot be its own parent. This was a rare issue with frames/groups in the syncFuzz tests.
+					// a shape cannot be it's own parent. This was a rare issue with frames/groups in the syncFuzz tests.
 					if (parentId === partial.id) {
 						parentId = focusedGroupId
 					}
@@ -7969,8 +7936,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 				}
 			})
 
-			this.emit('created-shapes', shapeRecordsToCreate)
-			this.emit('edit')
 			this.store.put(shapeRecordsToCreate)
 		})
 
@@ -8365,8 +8330,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 				updates.push(updated)
 			}
 
-			this.emit('edited-shapes', updates)
-			this.emit('edit')
 			this.store.put(updates)
 		})
 	}
@@ -8416,8 +8379,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 			})
 		}
 
-		this.emit('deleted-shapes', [...allShapeIdsToDelete])
-		this.emit('edit')
 		return this.run(() => this.store.remove([...allShapeIdsToDelete]))
 	}
 
@@ -9544,8 +9505,6 @@ export class Editor extends EventEmitter<TLEventMap> {
 			previousPagePoint,
 			currentScreenPoint,
 			currentPagePoint,
-			originScreenPoint,
-			originPagePoint,
 		} = this.inputs
 
 		const { screenBounds } = this.store.unsafeGetWithoutCapture(TLINSTANCE_ID)!
@@ -9574,8 +9533,8 @@ export class Editor extends EventEmitter<TLEventMap> {
 		// Reset velocity on pointer down, or when a pinch starts or ends
 		if (info.name === 'pointer_down' || this.inputs.isPinching) {
 			pointerVelocity.set(0, 0)
-			originScreenPoint.setTo(currentScreenPoint)
-			originPagePoint.setTo(currentPagePoint)
+			this.inputs.originScreenPoint.setTo(currentScreenPoint)
+			this.inputs.originPagePoint.setTo(currentPagePoint)
 		}
 
 		// todo: We only have to do this if there are multiple users in the document

package/src/lib/editor/managers/HistoryManager/HistoryManager.ts

@@ -241,9 +241,7 @@ export class HistoryManager<R extends UnknownRecord> {
 	}
 
 	bailToMark(id: string) {
-		if (id) {
-			this._undo({ pushToRedoStack: false, toMark: id })
-		}
+		this._undo({ pushToRedoStack: false, toMark: id })
 
 		return this
 	}

package/src/lib/editor/managers/TextManager/TextManager.ts

@@ -26,7 +26,6 @@ export interface TLMeasureTextOpts {
 	fontWeight: string
 	fontFamily: string
 	fontSize: number
-	/** This must be a number, e.g. 1.35, not a pixel value. */
 	lineHeight: number
 	/**
 	 * When maxWidth is a number, the text will be wrapped to that maxWidth. When maxWidth
@@ -76,7 +75,6 @@ export class TextManager {
 		// we need to save the default styles so that we can restore them when we're done
 		// these must be the css names, not the js names for the styles
 		this.defaultStyles = {
-			'overflow-wrap': 'break-word',
 			'word-break': 'auto',
 			width: null,
 			height: null,
@@ -125,7 +123,7 @@ export class TextManager {
 		elm.style.setProperty('font-style', opts.fontStyle)
 		elm.style.setProperty('font-weight', opts.fontWeight)
 		elm.style.setProperty('font-size', opts.fontSize + 'px')
-		elm.style.setProperty('line-height', opts.lineHeight.toString())
+		elm.style.setProperty('line-height', opts.lineHeight * opts.fontSize + 'px')
 		elm.style.setProperty('padding', opts.padding)
 
 		if (opts.maxWidth) {
@@ -289,7 +287,7 @@ export class TextManager {
 		elm.style.setProperty('font-style', opts.fontStyle)
 		elm.style.setProperty('font-weight', opts.fontWeight)
 		elm.style.setProperty('font-size', opts.fontSize + 'px')
-		elm.style.setProperty('line-height', opts.lineHeight.toString())
+		elm.style.setProperty('line-height', opts.lineHeight * opts.fontSize + 'px')
 
 		const elementWidth = Math.ceil(opts.width - opts.padding * 2)
 		elm.style.setProperty('width', `${elementWidth}px`)

package/src/lib/editor/shapes/ShapeUtil.ts

@@ -4,15 +4,12 @@ import { LegacyMigrations, MigrationSequence } from '@tldraw/store'
 import {
 	RecordProps,
 	TLHandle,
-	TLParentId,
 	TLPropsMigrations,
 	TLShape,
 	TLShapeCrop,
-	TLShapeId,
 	TLShapePartial,
 	TLUnknownShape,
 } from '@tldraw/tlschema'
-import { IndexKey } from '@tldraw/utils'
 import { ReactElement } from 'react'
 import { Box, SelectionHandle } from '../../primitives/Box'
 import { Vec } from '../../primitives/Vec'
@@ -390,6 +387,17 @@ export abstract class ShapeUtil<Shape extends TLUnknownShape = TLUnknownShape> {
 		return false
 	}
 
+	/**
+	 * Get whether the shape can receive children of a given type.
+	 *
+	 * @param shape - The shape type.
+	 * @param shapes - The shapes that are being dropped.
+	 * @public
+	 */
+	canDropShapes(_shape: Shape, _shapes: TLShape[]) {
+		return false
+	}
+
 	/**
 	 * Get the shape as an SVG object.
 	 *
@@ -509,16 +517,7 @@ export abstract class ShapeUtil<Shape extends TLUnknownShape = TLUnknownShape> {
 	): Omit<TLShapePartial<Shape>, 'id' | 'type'> | undefined | void
 
 	/**
-	 * A callback called when some other shapes are dragged into this one. This fires when the shapes are dragged over the shape for the first time.
-	 *
-	 * @param shape - The shape.
-	 * @param shapes - The shapes that are being dragged in.
-	 * @public
-	 */
-	onDragShapesIn?(shape: Shape, shapes: TLShape[], info: TLDragShapesInInfo): void
-
-	/**
-	 * A callback called when some other shapes are dragged over this one. This fires when the shapes are dragged over the shape for the first time (after the onDragShapesIn callback), and again on every update while the shapes are being dragged.
+	 * A callback called when some other shapes are dragged over this one.
 	 *
 	 * @example
 	 *
@@ -532,7 +531,7 @@ export abstract class ShapeUtil<Shape extends TLUnknownShape = TLUnknownShape> {
 	 * @param shapes - The shapes that are being dragged over this one.
 	 * @public
 	 */
-	onDragShapesOver?(shape: Shape, shapes: TLShape[], info: TLDragShapesOverInfo): void
+	onDragShapesOver?(shape: Shape, shapes: TLShape[]): void
 
 	/**
 	 * A callback called when some other shapes are dragged out of this one.
@@ -541,7 +540,7 @@ export abstract class ShapeUtil<Shape extends TLUnknownShape = TLUnknownShape> {
 	 * @param shapes - The shapes that are being dragged out.
 	 * @public
 	 */
-	onDragShapesOut?(shape: Shape, shapes: TLShape[], info: TLDragShapesOutInfo): void
+	onDragShapesOut?(shape: Shape, shapes: TLShape[]): void
 
 	/**
 	 * A callback called when some other shapes are dropped over this one.
@@ -550,7 +549,7 @@ export abstract class ShapeUtil<Shape extends TLUnknownShape = TLUnknownShape> {
 	 * @param shapes - The shapes that are being dropped over this one.
 	 * @public
 	 */
-	onDropShapesOver?(shape: Shape, shapes: TLShape[], info: TLDropShapesOverInfo): void
+	onDropShapesOver?(shape: Shape, shapes: TLShape[]): void
 
 	/**
 	 * A callback called when a shape starts being resized.
@@ -746,37 +745,6 @@ export interface TLCropInfo<T extends TLShape> {
 	crop: TLShapeCrop
 	uncroppedSize: { w: number; h: number }
 	initialShape: T
-	aspectRatioLocked?: boolean
-}
-
-/** @public */
-export interface TLDragShapesInInfo {
-	initialDraggingOverShapeId: TLShapeId | null
-	prevDraggingOverShapeId: TLShapeId | null
-	initialParentIds: Map<TLShapeId, TLParentId>
-	initialIndices: Map<TLShapeId, IndexKey>
-}
-
-/** @public */
-export interface TLDragShapesOverInfo {
-	initialDraggingOverShapeId: TLShapeId | null
-	initialParentIds: Map<TLShapeId, TLParentId>
-	initialIndices: Map<TLShapeId, IndexKey>
-}
-
-/** @public */
-export interface TLDragShapesOutInfo {
-	nextDraggingOverShapeId: TLShapeId | null
-	initialDraggingOverShapeId: TLShapeId | null
-	initialParentIds: Map<TLShapeId, TLParentId>
-	initialIndices: Map<TLShapeId, IndexKey>
-}
-
-/** @public */
-export interface TLDropShapesOverInfo {
-	initialDraggingOverShapeId: TLShapeId | null
-	initialParentIds: Map<TLShapeId, TLParentId>
-	initialIndices: Map<TLShapeId, IndexKey>
 }
 
 /**

package/src/lib/editor/tools/BaseBoxShapeTool/children/Pointing.ts

@@ -11,33 +11,29 @@ export class Pointing extends StateNode {
 	static override id = 'pointing'
 
 	override onPointerMove(info: TLPointerEventInfo) {
-		const { editor } = this
-		if (editor.inputs.isDragging) {
-			const { originPagePoint } = editor.inputs
+		if (this.editor.inputs.isDragging) {
+			const { originPagePoint } = this.editor.inputs
 
 			const shapeType = (this.parent as BaseBoxShapeTool)!.shapeType
 
 			const id = createShapeId()
 
-			const creatingMarkId = editor.markHistoryStoppingPoint(`creating_box:${id}`)
-			const newPoint = maybeSnapToGrid(originPagePoint, editor)
-
-			// Allow this to trigger the max shapes reached alert
-			this.editor.createShapes<TLBaseBoxShape>([
-				{
-					id,
-					type: shapeType,
-					x: newPoint.x,
-					y: newPoint.y,
-					props: {
-						w: 1,
-						h: 1,
+			const creatingMarkId = this.editor.markHistoryStoppingPoint(`creating_box:${id}`)
+			const newPoint = maybeSnapToGrid(originPagePoint, this.editor)
+			this.editor
+				.createShapes<TLBaseBoxShape>([
+					{
+						id,
+						type: shapeType,
+						x: newPoint.x,
+						y: newPoint.y,
+						props: {
+							w: 1,
+							h: 1,
+						},
 					},
-				},
-			])
-			const shape = editor.getShape(id)
-			if (!shape) this.cancel()
-			editor.select(id)
+				])
+				.select(id)
 
 			const parent = this.parent as BaseBoxShapeTool
 			this.editor.setCurrentTool(
@@ -83,7 +79,6 @@ export class Pointing extends StateNode {
 
 		this.editor.markHistoryStoppingPoint(`creating_box:${id}`)
 
-		// Allow this to trigger the max shapes reached alert
 		// todo: add scale here when dynamic size is enabled (is this still needed?)
 		this.editor.createShapes<TLBaseBoxShape>([
 			{

package/src/lib/editor/tools/StateNode.ts

@@ -206,15 +206,15 @@ export abstract class StateNode implements Partial<TLEventHandlers> {
 	}
 
 	// todo: move this logic into transition
-	exit(info: any, to: string) {
+	exit(info: any, from: string) {
 		if (debugFlags.measurePerformance.get() && this.performanceTracker.isStarted()) {
 			this.performanceTracker.stop()
 		}
 		this._isActive.set(false)
-		this.onExit?.(info, to)
+		this.onExit?.(info, from)
 
 		if (!this.getIsActive()) {
-			this.getCurrent()?.exit(info, to)
+			this.getCurrent()?.exit(info, from)
 		}
 	}
 

package/src/lib/editor/types/emit-types.ts

@@ -18,10 +18,6 @@ export interface TLEventMap {
 	frame: [number]
 	'select-all-text': [{ shapeId: TLShapeId }]
 	'place-caret': [{ shapeId: TLShapeId; point: { x: number; y: number } }]
-	'created-shapes': [TLRecord[]]
-	'edited-shapes': [TLRecord[]]
-	'deleted-shapes': [TLShapeId[]]
-	edit: []
 }
 
 /** @public */

package/src/lib/primitives/geometry/Geometry2d.ts

@@ -44,7 +44,6 @@ export const Geometry2dFilters: {
 /** @public */
 export interface TransformedGeometry2dOptions {
 	isLabel?: boolean
-	isEmptyLabel?: boolean
 	isInternal?: boolean
 	debugColor?: string
 	ignore?: boolean
@@ -58,24 +57,20 @@ export interface Geometry2dOptions extends TransformedGeometry2dOptions {
 
 /** @public */
 export abstract class Geometry2d {
-	// todo: consider making accessors for these too, so that they can be overridden in subclasses by geometries with more complex logic
 	isFilled = false
 	isClosed = true
 	isLabel = false
-	isEmptyLabel = false
 	isInternal = false
 	debugColor?: string
 	ignore?: boolean
 
 	constructor(opts: Geometry2dOptions) {
-		const { isLabel = false, isEmptyLabel = false, isInternal = false } = opts
 		this.isFilled = opts.isFilled
 		this.isClosed = opts.isClosed
+		this.isLabel = opts.isLabel ?? false
+		this.isInternal = opts.isInternal ?? false
 		this.debugColor = opts.debugColor
 		this.ignore = opts.ignore
-		this.isLabel = isLabel
-		this.isEmptyLabel = isEmptyLabel
-		this.isInternal = isInternal
 	}
 
 	isExcludedByFilter(filters?: Geometry2dFilters) {

package/src/lib/primitives/geometry/Group2d.ts

@@ -17,20 +17,14 @@ export class Group2d extends Geometry2d {
 	) {
 		super({ ...config, isClosed: true, isFilled: false })
 
-		const addChildren = (children: Geometry2d[]) => {
-			for (const child of children) {
-				if (child instanceof Group2d) {
-					addChildren(child.children)
-				} else if (child.ignore) {
-					this.ignoredChildren.push(child)
-				} else {
-					this.children.push(child)
-				}
+		for (const child of config.children) {
+			if (child.ignore) {
+				this.ignoredChildren.push(child)
+			} else {
+				this.children.push(child)
 			}
 		}
 
-		addChildren(config.children)
-
 		if (this.children.length === 0) throw Error('Group2d must have at least one child')
 	}
 

package/src/lib/utils/dom.ts

@@ -18,7 +18,7 @@ import { debugFlags, pointerCaptureTrackingObject } from './debug-flags'
 
 /** @public */
 export function loopToHtmlElement(elm: Element): HTMLElement {
-	if (elm.nodeType === Node.ELEMENT_NODE) return elm as HTMLElement
+	if (elm instanceof HTMLElement) return elm
 	if (elm.parentElement) return loopToHtmlElement(elm.parentElement)
 	else throw Error('Could not find a parent element of an HTML type!')
 }

package/src/version.ts

@@ -1,9 +1,9 @@
 // This file is automatically generated by internal/scripts/refresh-assets.ts.
 // Do not edit manually. Or do, I'm a comment, not a cop.
 
-export const version = '3.14.0-canary.e989a4107be2'
+export const version = '3.14.0-canary.ea2c4acfa022'
 export const publishDates = {
 	major: '2024-09-13T14:36:29.063Z',
-	minor: '2025-07-01T08:28:05.164Z',
-	patch: '2025-07-01T08:28:05.164Z',
+	minor: '2025-06-18T12:54:08.671Z',
+	patch: '2025-06-18T12:54:08.671Z',
 }