@tldiagram/core-ui 1.92.0 → 1.93.0

package/src/pages/ViewEditor/hooks/useViewData.ts

@@ -1,13 +1,13 @@
-import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
-import { MarkerType, type Edge as RFEdge, type Node as RFNode } from 'reactflow'
+import type { CSSProperties } from 'react'
+import { useCallback, useEffect, useMemo, useRef } from 'react'
+import { useQuery, useQueryClient } from '@tanstack/react-query'
+import { MarkerType } from 'reactflow'
 import { api } from '../../../api/client'
 import type {
   ViewTreeNode,
   PlacedElement,
   LibraryElement,
   Connector,
-  IncomingViewConnector,
-  ViewConnector,
   Tag,
 } from '../../../types'
 import {
@@ -17,6 +17,7 @@ import {
   getVisualHandleIdForGroup,
   getVisualHandleSlot,
 } from '../../../utils/edgeDistribution'
+import { buildViewContentLinks, useStore } from '../../../store/useStore'
 
 interface ViewDataOptions {
   viewId: number | null
@@ -47,6 +48,106 @@ function alphaColor(color: string, opacity: number): string {
   return `color-mix(in srgb, ${color} ${Math.round(opacity * 100)}%, transparent)`
 }
 
+// Stable style refs so unchanged nodes keep identical style references across renders,
+// letting structural-sharing fast-path bail out without rebuilding the node.
+const HIDDEN_STYLE: CSSProperties = { opacity: 0.1, pointerEvents: 'none' }
+const SOFT_FOCUS_STYLE: CSSProperties = { opacity: 0.2 }
+const EMPTY_ARRAY: readonly never[] = Object.freeze([])
+const EMPTY_NODE_CONNECTION_META = Object.freeze({
+  key: '',
+  connectedHandleIds: EMPTY_ARRAY as readonly string[],
+  selectedHandleIds: EMPTY_ARRAY as readonly string[],
+  reconnectCandidates: EMPTY_ARRAY as readonly NodeReconnectCandidate[],
+  isConnectorHighlighted: false,
+})
+
+type NodeReconnectCandidate = {
+  handleId: string
+  edgeId: string
+  endpoint: 'source' | 'target'
+  selected: boolean
+}
+
+type NodeConnectionMeta = {
+  key: string
+  connectedHandleIds: readonly string[]
+  selectedHandleIds: readonly string[]
+  reconnectCandidates: readonly NodeReconnectCandidate[]
+  isConnectorHighlighted: boolean
+}
+
+type ConnectorLayout = {
+  connector: Connector
+  sourceHandle: string
+  targetHandle: string
+  sourceGroupIndex: number
+  sourceGroupCount: number
+  targetGroupIndex: number
+  targetGroupCount: number
+  sourceHandleSide: string
+  targetHandleSide: string
+  sourceHandleSlot: number
+  targetHandleSlot: number
+}
+
+function buildConnectorLayouts(connectors: Connector[], elementMap: Map<number, PlacedElement>): ConnectorLayout[] {
+  const filtered = connectors.filter((connector) =>
+    elementMap.has(connector.source_element_id) && elementMap.has(connector.target_element_id),
+  )
+
+  const handleUsage: Record<string, { id: string; type: 'source' | 'target'; otherNodeCoord: number }[]> = {}
+  filtered.forEach((connector) => {
+    const srcNode = elementMap.get(connector.source_element_id)
+    const tgtNode = elementMap.get(connector.target_element_id)
+    if (!srcNode || !tgtNode) return
+
+    const sourceSide = getLogicalHandleId(connector.source_handle, DEFAULT_SOURCE_HANDLE_SIDE) ?? DEFAULT_SOURCE_HANDLE_SIDE
+    const targetSide = getLogicalHandleId(connector.target_handle, DEFAULT_TARGET_HANDLE_SIDE) ?? DEFAULT_TARGET_HANDLE_SIDE
+
+    const srcKey = `${connector.source_element_id}-${sourceSide}`
+    handleUsage[srcKey] ??= []
+    const srcCoord = (sourceSide === 'left' || sourceSide === 'right') ? (tgtNode.position_y ?? 0) : (tgtNode.position_x ?? 0)
+    handleUsage[srcKey].push({ id: String(connector.id), type: 'source', otherNodeCoord: srcCoord })
+
+    const tgtKey = `${connector.target_element_id}-${targetSide}`
+    handleUsage[tgtKey] ??= []
+    const tgtCoord = (targetSide === 'left' || targetSide === 'right') ? (srcNode.position_y ?? 0) : (srcNode.position_x ?? 0)
+    handleUsage[tgtKey].push({ id: String(connector.id), type: 'target', otherNodeCoord: tgtCoord })
+  })
+
+  Object.values(handleUsage).forEach((usages) => {
+    usages.sort((a, b) => a.otherNodeCoord - b.otherNodeCoord)
+  })
+
+  return filtered.map((connector) => {
+    const edgeId = String(connector.id)
+    const sourceSide = getLogicalHandleId(connector.source_handle, DEFAULT_SOURCE_HANDLE_SIDE) ?? DEFAULT_SOURCE_HANDLE_SIDE
+    const targetSide = getLogicalHandleId(connector.target_handle, DEFAULT_TARGET_HANDLE_SIDE) ?? DEFAULT_TARGET_HANDLE_SIDE
+    const srcGroup = handleUsage[`${connector.source_element_id}-${sourceSide}`] ?? []
+    const tgtGroup = handleUsage[`${connector.target_element_id}-${targetSide}`] ?? []
+    const sourceGroupIndex = srcGroup.findIndex((usage) => usage.id === edgeId && usage.type === 'source')
+    const targetGroupIndex = tgtGroup.findIndex((usage) => usage.id === edgeId && usage.type === 'target')
+    const sourceGroupCount = Math.max(srcGroup.length, 1)
+    const targetGroupCount = Math.max(tgtGroup.length, 1)
+    const sourceHandleSlot = getVisualHandleSlot(sourceGroupIndex, sourceGroupCount)
+    const targetHandleSlot = getVisualHandleSlot(targetGroupIndex, targetGroupCount)
+
+    return {
+      connector,
+      sourceHandle: getVisualHandleIdForGroup(sourceSide, sourceGroupIndex, sourceGroupCount),
+      targetHandle: getVisualHandleIdForGroup(targetSide, targetGroupIndex, targetGroupCount),
+      sourceGroupIndex,
+      sourceGroupCount: srcGroup.length,
+      targetGroupIndex,
+      targetGroupCount: tgtGroup.length,
+      sourceHandleSide: sourceSide,
+      targetHandleSide: targetSide,
+      sourceHandleSlot,
+      targetHandleSlot,
+    }
+  })
+}
+
 export function useViewData({
   viewId,
   interactionSourceId,
@@ -69,17 +170,32 @@ export function useViewData({
   stableOnHoverZoom,
   hoveredZoomRef,
 }: ViewDataOptions) {
-  const [view, setView] = useState<ViewTreeNode | null | undefined>(undefined)
-  const [viewElements, setViewElements] = useState<PlacedElement[]>([])
-  const [connectors, setConnectors] = useState<Connector[]>([])
-  const [rfNodes, setRfNodes] = useState<RFNode[]>([])
-  const [rfEdges, setRfEdges] = useState<RFEdge[]>([])
-  const [linksMap, setLinksMap] = useState<Record<number, ViewConnector[]>>({})
-  const [parentLinksMap, setParentLinksMap] = useState<Record<number, ViewConnector[]>>({})
-  const [incomingLinks, setIncomingLinks] = useState<IncomingViewConnector[]>([])
-  const [treeData, setTreeData] = useState<ViewTreeNode[]>([])
-  const [allElements, setAllElements] = useState<LibraryElement[]>([])
-  const [libraryRefresh, setLibraryRefresh] = useState(0)
+  const queryClient = useQueryClient()
+  const view = useStore((state) => state.view)
+  const setView = useStore((state) => state.setView)
+  const viewElements = useStore((state) => state.viewElements)
+  const setViewElements = useStore((state) => state.setViewElements)
+  const connectors = useStore((state) => state.connectors)
+  const setConnectors = useStore((state) => state.setConnectors)
+  const rfNodes = useStore((state) => state.nodes)
+  const setRfNodes = useStore((state) => state.setNodes)
+  const rfEdges = useStore((state) => state.edges)
+  const setRfEdges = useStore((state) => state.setEdges)
+  const linksMap = useStore((state) => state.linksMap)
+  const setLinksMap = useStore((state) => state.setLinksMap)
+  const parentLinksMap = useStore((state) => state.parentLinksMap)
+  const setParentLinksMap = useStore((state) => state.setParentLinksMap)
+  const incomingLinks = useStore((state) => state.incomingLinks)
+  const treeData = useStore((state) => state.treeData)
+  const allElements = useStore((state) => state.allElements)
+  const setAllElements = useStore((state) => state.setAllElements)
+  const libraryRefresh = useStore((state) => state.libraryRefresh)
+  const setLibraryRefresh = useStore((state) => state.setLibraryRefresh)
+  const hydrateViewContent = useStore((state) => state.hydrateViewContent)
+  const resetCanvas = useStore((state) => state.resetCanvas)
+  const removeElementPlacement = useStore((state) => state.removeElementPlacement)
+  const removeElementEverywhere = useStore((state) => state.removeElementEverywhere)
+  const mergeSavedElement = useStore((state) => state.mergeSavedElement)
 
   // Mutable refs for stable callbacks
   const viewElementsRef = useRef(viewElements)
@@ -101,158 +217,90 @@ export function useViewData({
 
   // ── Fetch tree ─────────────────────────────────────────────────────────────
   const refreshGrid = useCallback(async () => {
-    const tree = await api.workspace.views.tree().catch(() => null)
-    if (tree) setTreeData(tree)
-  }, [])
+    const tree = await queryClient.fetchQuery({
+      queryKey: ['workspace', 'views', 'tree'],
+      queryFn: () => api.workspace.views.tree(),
+      staleTime: 0,
+    }).catch(() => null)
+    if (tree) useStore.getState().setTreeData(tree)
+  }, [queryClient])
 
   // ── Fetch view content ──────────────────────────────────────────────────
+  const viewContentQuery = useQuery({
+    queryKey: ['workspace', 'views', viewId, 'editor-content'],
+    enabled: viewId !== null,
+    queryFn: async () => {
+      if (viewId === null) throw new Error('Missing view id')
+      const [diag, content, tree] = await Promise.all([
+        api.workspace.views.get(viewId),
+        api.workspace.views.content(viewId),
+        api.workspace.views.tree(),
+      ])
+      const viewElements = content.placements || []
+      const connectors = content.connectors || []
+      return {
+        view: diag,
+        viewElements,
+        connectors,
+        treeData: tree,
+        ...buildViewContentLinks(tree, viewId, viewElements),
+      }
+    },
+  })
+
   useEffect(() => {
     if (viewId === null) return
-    let active = true
-
-    const load = async () => {
-      try {
-        const [diag, content, tree] = await Promise.all([
-          api.workspace.views.get(viewId),
-          api.workspace.views.content(viewId),
-          api.workspace.views.tree(),
-        ])
-        if (!active) return
-
-        const safeObjs = content.placements || []
-        const safeConnectors = content.connectors || []
-
-        const linksObj: Record<number, ViewConnector[]> = {}
-        const parentLinksObj: Record<number, ViewConnector[]> = {}
-
-        // Helper: recursively find nodes in tree that are owned by elements on canvas (zoom-in)
-        // OR the parent view of the current view (zoom-out)
-        const findViewByOwner = (nodes: ViewTreeNode[], elementId: number): ViewTreeNode | null => {
-          for (const node of nodes) {
-            if (node.owner_element_id !== null && Number(node.owner_element_id) === Number(elementId)) return node
-            const found = findViewByOwner(node.children, elementId)
-            if (found) return found
-          }
-          return null
-        }
-
-        const findViewPath = (nodes: ViewTreeNode[], targetId: number, path: ViewTreeNode[] = []): ViewTreeNode[] | null => {
-          for (const node of nodes) {
-            if (node.id === targetId) return [...path, node]
-            const found = findViewPath(node.children, targetId, [...path, node])
-            if (found) return found
-          }
-          return null
-        }
+    if (viewContentQuery.data) hydrateViewContent(viewContentQuery.data)
+  }, [hydrateViewContent, viewContentQuery.data, viewId])
 
-        const viewPath = findViewPath(tree, viewId)
-        const parentView = viewPath && viewPath.length > 1 ? viewPath[viewPath.length - 2] : null
-        const currentViewInTree = viewPath ? viewPath[viewPath.length - 1] : null
-
-        const incoming: IncomingViewConnector[] = []
-        if (parentView && currentViewInTree?.owner_element_id) {
-          incoming.push({
-            id: 0,
-            element_id: currentViewInTree.owner_element_id,
-            element_name: 'Parent', // Optional: could find name in parentView.placements
-            from_view_id: parentView.id,
-            from_view_name: parentView.name,
-            to_view_id: viewId,
-          })
-        }
-
-        for (const obj of safeObjs) {
-          // Child Link: if there exists a view owned by this element
-          const childView = findViewByOwner(tree, obj.element_id)
-          if (childView) {
-            linksObj[obj.element_id] = [{
-              id: 0,
-              element_id: obj.element_id,
-              from_view_id: viewId,
-              to_view_id: childView.id,
-              to_view_name: childView.name,
-              relation_type: 'child',
-            }]
-          }
-
-          // Parent Link: all elements in a view can 'zoom out' to its structural parent
-          if (parentView) {
-            parentLinksObj[obj.element_id] = [{
-              id: 0,
-              element_id: obj.element_id,
-              from_view_id: parentView.id, // we go TO the parentView, coming FROM the parentView context?
-              to_view_id: parentView.id,
-              to_view_name: parentView.name,
-              relation_type: 'parent',
-            }]
-          }
-        }
-
-        setLinksMap(linksObj)
-        setParentLinksMap(parentLinksObj)
-        setConnectors(safeConnectors)
-        setViewElements(safeObjs)
-        setIncomingLinks(incoming)
-        setView(diag)
-        setTreeData(tree)
-      } catch (err) {
-        console.error('DIAGRAM EDITOR LOAD ERROR:', err)
-        if (active) setView(null)
-      }
+  useEffect(() => {
+    if (viewContentQuery.isError) {
+      console.error('DIAGRAM EDITOR LOAD ERROR:', viewContentQuery.error)
+      setView(null)
     }
-
-    load()
-    return () => { active = false }
-  }, [viewId])
+  }, [setView, viewContentQuery.error, viewContentQuery.isError])
 
   // ── Clear canvas on navigation ─────────────────────────────────────────────
   useEffect(() => {
-    setRfNodes([])
-    setRfEdges([])
-  }, [viewId])
+    resetCanvas()
+  }, [resetCanvas, viewId])
 
   // ── Keep all-org elements for inline adder ──────────────────────────────────
+  const allElementsQuery = useQuery({
+    queryKey: ['elements', 'list', libraryRefresh],
+    queryFn: () => api.elements.list(),
+  })
+
   useEffect(() => {
-    api.elements.list().then(setAllElements).catch(() => { /* intentionally empty */ })
-  }, [libraryRefresh])
+    if (allElementsQuery.data) setAllElements(allElementsQuery.data)
+  }, [allElementsQuery.data, setAllElements])
 
   // ── Refresh elements ────────────────────────────────────────────────────────
   const refreshElements = useCallback(async () => {
     if (viewId === null) return
-    const fresh = await api.workspace.views.content(viewId).catch(() => null)
-    if (fresh) setViewElements(fresh.placements)
-  }, [viewId])
+    const fresh = await queryClient.fetchQuery({
+      queryKey: ['workspace', 'views', viewId, 'content'],
+      queryFn: () => api.workspace.views.content(viewId),
+      staleTime: 0,
+    }).catch(() => null)
+    if (fresh) {
+      setViewElements(fresh.placements)
+      setConnectors(fresh.connectors)
+    }
+  }, [queryClient, setConnectors, setViewElements, viewId])
 
-  // ── CRDT-aware element mutation helpers ────────────────────────────────────
+  // ── Element mutation helpers ───────────────────────────────────────────────
   const handleElementDeleted = useCallback((deletedId: number) => {
-    setViewElements((prev) => prev.filter((o) => o.element_id !== deletedId))
-  }, [])
+    removeElementPlacement(deletedId)
+  }, [removeElementPlacement])
 
   const handleElementPermanentlyDeleted = useCallback((deletedId: number) => {
-    setViewElements((prev) => prev.filter((o) => o.element_id !== deletedId))
-    setLibraryRefresh((n) => n + 1)
-  }, [])
+    removeElementEverywhere(deletedId)
+  }, [removeElementEverywhere])
 
   const handleElementSaved = useCallback((saved: LibraryElement) => {
-    setLibraryRefresh((n) => n + 1)
-    setViewElements((prev) =>
-      prev.map((o) =>
-        o.element_id === saved.id
-          ? {
-            ...o,
-            name: saved.name,
-            description: saved.description,
-            kind: saved.kind,
-            technology: saved.technology,
-            url: saved.url,
-            logo_url: saved.logo_url,
-            technology_connectors: saved.technology_connectors,
-            tags: saved.tags,
-          }
-          : o,
-      ),
-    )
-  }, [])
+    mergeSavedElement(saved)
+  }, [mergeSavedElement])
 
   // ── Stable element ID set ───────────────────────────────────────────────────
   const existingElementIdsRef = useRef<Set<number>>(new Set())
@@ -268,51 +316,197 @@ export function useViewData({
     return nextIds
   }, [viewElements])
 
+  // Stable-ref fallback parent links: flatten only when the underlying map changes so
+  // nodes without their own parent link entry can still pass the data-equality fast path.
+  const viewParentLinks = useMemo(
+    () => Object.values(parentLinksMap).flat(),
+    [parentLinksMap],
+  )
+
+  const parentViewId = useMemo(() => {
+    const findInTreeById = (nodes: ViewTreeNode[], id: number): ViewTreeNode | null => {
+      for (const node of nodes) {
+        if (node.id === id) return node
+        const found = findInTreeById(node.children, id)
+        if (found) return found
+      }
+      return null
+    }
+    const currentView = findInTreeById(treeData, viewId || -1)
+    return currentView?.parent_view_id
+  }, [treeData, viewId])
+
+  const elementMap = useMemo(() => {
+    const next = new Map<number, PlacedElement>()
+    for (const element of viewElements) next.set(element.element_id, element)
+    return next
+  }, [viewElements])
+
+  const connectorLayouts = useMemo(
+    () => buildConnectorLayouts(connectors, elementMap),
+    [connectors, elementMap],
+  )
+
+  const connectionMetaCacheRef = useRef<Map<number, NodeConnectionMeta>>(new Map())
+  const nodeConnectionMetaByElementId = useMemo(() => {
+    const drafts = new Map<number, {
+      connected: Set<string>
+      selected: Set<string>
+      reconnect: NodeReconnectCandidate[]
+      highlighted: boolean
+    }>()
+
+    const draftFor = (elementId: number) => {
+      let draft = drafts.get(elementId)
+      if (!draft) {
+        draft = { connected: new Set(), selected: new Set(), reconnect: [], highlighted: false }
+        drafts.set(elementId, draft)
+      }
+      return draft
+    }
+
+    const selectedId = selectedEdgeId === null ? null : String(selectedEdgeId)
+    for (const layout of connectorLayouts) {
+      const connector = layout.connector
+      const edgeId = String(connector.id)
+      const isSelected = selectedId === edgeId
+      const sourceDraft = draftFor(connector.source_element_id)
+      const targetDraft = draftFor(connector.target_element_id)
+
+      sourceDraft.connected.add(layout.sourceHandle)
+      targetDraft.connected.add(layout.targetHandle)
+      sourceDraft.reconnect.push({ handleId: layout.sourceHandle, edgeId, endpoint: 'source', selected: isSelected })
+      targetDraft.reconnect.push({ handleId: layout.targetHandle, edgeId, endpoint: 'target', selected: isSelected })
+
+      if (isSelected) {
+        sourceDraft.selected.add(layout.sourceHandle)
+        targetDraft.selected.add(layout.targetHandle)
+        sourceDraft.highlighted = true
+        targetDraft.highlighted = true
+      }
+    }
+
+    const prev = connectionMetaCacheRef.current
+    const next = new Map<number, NodeConnectionMeta>()
+    for (const [elementId, draft] of drafts) {
+      const connectedHandleIds = Array.from(draft.connected).sort()
+      const selectedHandleIds = Array.from(draft.selected).sort()
+      const reconnectCandidates = draft.reconnect.sort((left, right) => {
+        if (left.handleId !== right.handleId) return left.handleId.localeCompare(right.handleId)
+        if (left.selected !== right.selected) return left.selected ? -1 : 1
+        return left.edgeId.localeCompare(right.edgeId)
+      })
+      const reconnectKey = reconnectCandidates
+        .map((candidate) => `${candidate.handleId}:${candidate.edgeId}:${candidate.endpoint}:${candidate.selected ? 1 : 0}`)
+        .join(',')
+      const key = [
+        connectedHandleIds.join('|'),
+        selectedHandleIds.join('|'),
+        reconnectKey,
+        draft.highlighted ? 1 : 0,
+      ].join('::')
+      const existing = prev.get(elementId)
+      next.set(elementId, existing?.key === key
+        ? existing
+        : {
+          key,
+          connectedHandleIds,
+          selectedHandleIds,
+          reconnectCandidates,
+          isConnectorHighlighted: draft.highlighted,
+        })
+    }
+    connectionMetaCacheRef.current = next
+    return next
+  }, [connectorLayouts, selectedEdgeId])
+
   // ── Derive RF nodes ────────────────────────────────────────────────────────
   useEffect(() => {
     setRfNodes((prevNodes) => {
-      // The structural parent of the current view is stored under the view's
-      // owner element ID which differs from the IDs of elements placed inside
-      // the view. Pre-compute it so every node in the view shows the correct
-      // zoom-out state even when their own element_id has no direct parent link.
-      const viewParentLinks = Object.values(parentLinksMap).flat()
-      const findInTreeById = (nodes: ViewTreeNode[], id: number): ViewTreeNode | null => {
-        for (const node of nodes) {
-          if (node.id === id) return node
-          const found = findInTreeById(node.children, id)
-          if (found) return found
-        }
-        return null
-      }
-      const currentView = findInTreeById(treeData, viewId || -1)
-      const parentViewId = currentView?.parent_view_id
-      
+
+      const prevNodeMap = new Map(prevNodes.map((n) => [n.id, n]))
+      const hiddenSet = hiddenLayerTags.length > 0 ? new Set(hiddenLayerTags) : null
+      const activeSet = activeTags.length > 0 ? new Set(activeTags) : null
+      const hoveredSet = hoveredLayerTags !== null ? new Set(hoveredLayerTags) : null
+      const isClickConnectMode = clickConnectMode !== null
+
       return viewElements.map((obj) => {
-        const existing = prevNodes.find((n) => n.id === String(obj.element_id))
+        const nodeId = String(obj.element_id)
+        const existing = prevNodeMap.get(nodeId)
         const objTags = obj.tags || []
-        const isHiddenByLayer = hiddenLayerTags.length > 0 && objTags.some((t) => hiddenLayerTags.includes(t))
-        const isInactive = isHiddenByLayer || (activeTags.length > 0 && !objTags.some((t) => activeTags.includes(t)))
-        const isLayerHighlighted = hoveredLayerTags !== null && objTags.some((t) => hoveredLayerTags.includes(t))
-        const isSoftFocused = hoveredLayerTags !== null && !isLayerHighlighted
+
+        const isHiddenByLayer = hiddenSet !== null && objTags.some((t) => hiddenSet.has(t))
+        const isInactive = isHiddenByLayer || (activeSet !== null && !objTags.some((t) => activeSet.has(t)))
+        const isLayerHighlighted = hoveredSet !== null && objTags.some((t) => hoveredSet.has(t))
+        const isSoftFocused = hoveredSet !== null && !isLayerHighlighted
+
+        const newZIndex = isLayerHighlighted ? 10 : interactionSourceId === obj.element_id ? 1000 : 0
+        const newStyle = isInactive
+          ? HIDDEN_STYLE
+          : isSoftFocused
+            ? SOFT_FOCUS_STYLE
+            : undefined
+        const layerHighlightColor = isLayerHighlighted ? (hoveredLayerColor ?? undefined) : undefined
+        const position = existing?.dragging ? existing.position : { x: obj.position_x ?? 0, y: obj.position_y ?? 0 }
+        const isZoomHovered = hoveredZoomRef.current?.elementId === obj.element_id ? hoveredZoomRef.current.type : null
+        const links = linksMap[obj.element_id] || EMPTY_ARRAY
+        const parentLinks = parentLinksMap[obj.element_id] || viewParentLinks
+        const connectionMeta = nodeConnectionMetaByElementId.get(obj.element_id) ?? EMPTY_NODE_CONNECTION_META
+
+        // Structural sharing: if every input that would produce the same output matches the
+        // previous node, return the previous reference so React Flow skips this node's work.
+        if (
+          existing &&
+          existing.style === newStyle &&
+          existing.zIndex === newZIndex &&
+          existing.position.x === position.x &&
+          existing.position.y === position.y &&
+          existing.data &&
+          existing.data.element_id === obj.element_id &&
+          existing.data.tags === obj.tags &&
+          existing.data.name === obj.name &&
+          existing.data.position_x === obj.position_x &&
+          existing.data.position_y === obj.position_y &&
+          existing.data.description === obj.description &&
+          existing.data.kind === obj.kind &&
+          existing.data.technology === obj.technology &&
+          existing.data.url === obj.url &&
+          existing.data.logo_url === obj.logo_url &&
+          existing.data.repo === obj.repo &&
+          existing.data.branch === obj.branch &&
+          existing.data.file_path === obj.file_path &&
+          existing.data.technology_connectors === obj.technology_connectors &&
+          existing.data.links === links &&
+          existing.data.parentLinks === parentLinks &&
+          existing.data.parentViewId === parentViewId &&
+          existing.data.interactionSourceId === interactionSourceId &&
+          existing.data.isClickConnectMode === isClickConnectMode &&
+          existing.data.tagColors === tagColors &&
+          existing.data.layerHighlightColor === layerHighlightColor &&
+          existing.data.forceShowTagPopup === isLayerHighlighted &&
+          existing.data.isZoomHovered === isZoomHovered &&
+          existing.data.connectedHandleIds === connectionMeta.connectedHandleIds &&
+          existing.data.selectedHandleIds === connectionMeta.selectedHandleIds &&
+          existing.data.reconnectCandidates === connectionMeta.reconnectCandidates &&
+          existing.data.isConnectorHighlighted === connectionMeta.isConnectorHighlighted
+        ) {
+          return existing
+        }
 
         return {
-          id: String(obj.element_id),
+          id: nodeId,
           type: 'elementNode',
-          position: existing?.dragging ? existing.position : { x: obj.position_x ?? 0, y: obj.position_y ?? 0 },
+          position,
           width: existing?.width,
           height: existing?.height,
           selected: existing?.selected,
           dragging: existing?.dragging,
-          zIndex: isLayerHighlighted ? 10 : interactionSourceId === obj.element_id ? 1000 : 0,
-          style: isInactive
-            ? { opacity: 0.1, pointerEvents: 'none' }
-            : isSoftFocused
-              ? { opacity: 0.2 }
-              : undefined,
+          zIndex: newZIndex,
+          style: newStyle,
           data: {
             ...obj,
-            links: linksMap[obj.element_id] || [],
-            parentLinks: parentLinksMap[obj.element_id] || viewParentLinks,
+            links,
+            parentLinks,
             parentViewId,
             onZoomIn: stableOnZoomIn,
             onZoomOut: stableOnZoomOut,
@@ -324,130 +518,138 @@ export function useViewData({
             onStartHandleReconnect: stableOnStartHandleReconnect,
             onRemove: stableOnRemoveElement,
             onHoverZoom: stableOnHoverZoom,
-            isZoomHovered: hoveredZoomRef.current?.elementId === obj.element_id ? hoveredZoomRef.current.type : null,
+            isZoomHovered,
             interactionSourceId,
-            isClickConnectMode: clickConnectMode !== null,
+            isClickConnectMode,
             tagColors,
-            layerHighlightColor: isLayerHighlighted ? (hoveredLayerColor ?? undefined) : undefined,
+            layerHighlightColor,
             forceShowTagPopup: isLayerHighlighted,
+            connectedHandleIds: connectionMeta.connectedHandleIds,
+            selectedHandleIds: connectionMeta.selectedHandleIds,
+            reconnectCandidates: connectionMeta.reconnectCandidates,
+            isConnectorHighlighted: connectionMeta.isConnectorHighlighted,
           },
         }
       })
     })
   }, [
-    viewElements, viewId, linksMap, parentLinksMap, treeData,
+    viewElements, linksMap, parentLinksMap, viewParentLinks, parentViewId,
     interactionSourceId, clickConnectMode,
     stableOnZoomIn, stableOnZoomOut, stableOnNavigateToView, stableOnSelect,
     stableOnInteractionStart, stableOnConnectTo, stableOnStartHandleReconnect, stableOnRemoveElement, stableOnHoverZoom,
     stableOnOpenCodePreview, hoveredZoomRef, activeTags, hiddenLayerTags, hoveredLayerTags, hoveredLayerColor, tagColors,
+    nodeConnectionMetaByElementId, setRfNodes,
   ])
 
   // ── Derive RF connectors ────────────────────────────────────────────────────────
   useEffect(() => {
-    const visibleElementIds = new Set(viewElements.map((element) => element.element_id))
-    const filtered = connectors.filter((connector) => visibleElementIds.has(connector.source_element_id) && visibleElementIds.has(connector.target_element_id))
-
-    const handleUsage: Record<string, { id: string; type: 'source' | 'target'; otherNodeCoord: number }[]> = {}
-    filtered.forEach((c) => {
-      const srcNode = viewElements.find((o) => o.element_id === c.source_element_id)
-      const tgtNode = viewElements.find((o) => o.element_id === c.target_element_id)
-      if (!srcNode || !tgtNode) return
-
-      const sourceSide = getLogicalHandleId(c.source_handle, DEFAULT_SOURCE_HANDLE_SIDE)
-      const targetSide = getLogicalHandleId(c.target_handle, DEFAULT_TARGET_HANDLE_SIDE)
-
-      const srcKey = `${c.source_element_id}-${sourceSide}`
-      handleUsage[srcKey] ??= []
-      const srcCoord = (sourceSide === 'left' || sourceSide === 'right') ? (tgtNode.position_y ?? 0) : (tgtNode.position_x ?? 0)
-      handleUsage[srcKey].push({ id: String(c.id), type: 'source', otherNodeCoord: srcCoord })
-
-      const tgtKey = `${c.target_element_id}-${targetSide}`
-      handleUsage[tgtKey] ??= []
-      const tgtCoord = (targetSide === 'left' || targetSide === 'right') ? (srcNode.position_y ?? 0) : (srcNode.position_x ?? 0)
-      handleUsage[tgtKey].push({ id: String(c.id), type: 'target', otherNodeCoord: tgtCoord })
-    })
-
-    Object.values(handleUsage).forEach((usages) => {
-      usages.sort((a, b) => a.otherNodeCoord - b.otherNodeCoord)
-    })
+    const hiddenSet = hiddenLayerTags.length > 0 ? new Set(hiddenLayerTags) : null
+    const activeSet = activeTags.length > 0 ? new Set(activeTags) : null
+    const hoveredSet = hoveredLayerTags !== null ? new Set(hoveredLayerTags) : null
 
+    setRfEdges((prevConnectors) => {
+      const prevEdgeMap = new Map(prevConnectors.map((e) => [e.id, e]))
 
-    setRfEdges((prevConnectors) =>
-      filtered.map((e) => {
-        const existing = prevConnectors.find((re) => re.id === String(e.id))
+      return connectorLayouts.map((layout) => {
+        const e = layout.connector
+        const edgeId = String(e.id)
+        const existing = prevEdgeMap.get(edgeId)
         const dir = e.direction ?? 'forward'
-        const arrowMarker = { type: MarkerType.ArrowClosed, width: 14, height: 14 }
 
-        const sourceObj = viewElements.find((o) => o.element_id === e.source_element_id)
-        const targetObj = viewElements.find((o) => o.element_id === e.target_element_id)
+        const sourceObj = elementMap.get(e.source_element_id)
+        const targetObj = elementMap.get(e.target_element_id)
         const srcTags = sourceObj?.tags || []
         const tgtTags = targetObj?.tags || []
-        const isInactiveByLayer = hiddenLayerTags.length > 0 && (
-          srcTags.some((t) => hiddenLayerTags.includes(t)) ||
-          tgtTags.some((t) => hiddenLayerTags.includes(t))
+        const isInactiveByLayer = hiddenSet !== null && (
+          srcTags.some((t) => hiddenSet.has(t)) ||
+          tgtTags.some((t) => hiddenSet.has(t))
         )
-        const isInactiveByFilter = activeTags.length > 0 && (
-          !srcTags.some((t) => activeTags.includes(t)) ||
-          !tgtTags.some((t) => activeTags.includes(t))
+        const isInactiveByFilter = activeSet !== null && (
+          !srcTags.some((t) => activeSet.has(t)) ||
+          !tgtTags.some((t) => activeSet.has(t))
         )
         const isInactive = isInactiveByLayer || isInactiveByFilter
-        const isSoftFocused = hoveredLayerTags !== null && (
-          !sourceObj?.tags?.some((t) => hoveredLayerTags.includes(t)) ||
-          !targetObj?.tags?.some((t) => hoveredLayerTags.includes(t))
+        const isSoftFocused = hoveredSet !== null && (
+          !srcTags.some((t) => hoveredSet.has(t)) ||
+          !tgtTags.some((t) => hoveredSet.has(t))
         )
         const edgeOpacity = isInactive ? 0.1 : isSoftFocused ? 0.2 : 0.8
         const markerOpacity = isInactive ? 0.1 : isSoftFocused ? 0.2 : 1
-        const sourceSide = getLogicalHandleId(e.source_handle, DEFAULT_SOURCE_HANDLE_SIDE) ?? DEFAULT_SOURCE_HANDLE_SIDE
-        const targetSide = getLogicalHandleId(e.target_handle, DEFAULT_TARGET_HANDLE_SIDE) ?? DEFAULT_TARGET_HANDLE_SIDE
-
-        const srcKey = `${e.source_element_id}-${sourceSide}`
-        const tgtKey = `${e.target_element_id}-${targetSide}`
-        const srcGroup = handleUsage[srcKey] ?? []
-        const tgtGroup = handleUsage[tgtKey] ?? []
-        const sourceGroupIndex = srcGroup.findIndex((u) => u.id === String(e.id) && u.type === 'source')
-        const targetGroupIndex = tgtGroup.findIndex((u) => u.id === String(e.id) && u.type === 'target')
-        const sourceHandleSlot = getVisualHandleSlot(sourceGroupIndex, Math.max(srcGroup.length, 1))
-        const targetHandleSlot = getVisualHandleSlot(targetGroupIndex, Math.max(tgtGroup.length, 1))
+        const newZIndex = selectedEdgeId !== null && edgeId === String(selectedEdgeId) ? 1000 : 100
+        const pointerEvents = (isInactive || isSoftFocused) ? 'none' : 'auto'
+        const labelBgOpacity = isInactive ? 0.1 : isSoftFocused ? 0.2 : 0.95
+
+        // Structural sharing: when all user-visible outputs match prev exactly, reuse prev ref.
+        // We match on the underlying connector ref plus every computed visibility/layout value.
+        if (
+          existing &&
+          existing.data &&
+          (existing.data as Connector & { __src?: unknown }).__src === e &&
+          existing.sourceHandle === layout.sourceHandle &&
+          existing.targetHandle === layout.targetHandle &&
+          existing.zIndex === newZIndex &&
+          (existing.style as CSSProperties | undefined)?.opacity === edgeOpacity &&
+          (existing.style as CSSProperties | undefined)?.pointerEvents === pointerEvents &&
+          (existing.labelStyle as CSSProperties | undefined)?.opacity === markerOpacity &&
+          (existing.labelBgStyle as CSSProperties | undefined)?.fillOpacity === labelBgOpacity &&
+          (existing.data as { sourceGroupIndex?: number }).sourceGroupIndex === layout.sourceGroupIndex &&
+          (existing.data as { targetGroupIndex?: number }).targetGroupIndex === layout.targetGroupIndex &&
+          (existing.data as { sourceGroupCount?: number }).sourceGroupCount === layout.sourceGroupCount &&
+          (existing.data as { targetGroupCount?: number }).targetGroupCount === layout.targetGroupCount
+        ) {
+          return existing
+        }
+
+        const arrowMarker = { type: MarkerType.ArrowClosed, width: 14, height: 14 }
 
         return {
-          id: String(e.id),
+          id: edgeId,
           source: String(e.source_element_id),
           target: String(e.target_element_id),
-          sourceHandle: getVisualHandleIdForGroup(sourceSide, sourceGroupIndex, Math.max(srcGroup.length, 1)),
-          targetHandle: getVisualHandleIdForGroup(targetSide, targetGroupIndex, Math.max(tgtGroup.length, 1)),
+          sourceHandle: layout.sourceHandle,
+          targetHandle: layout.targetHandle,
           type: e.style === 'bezier' ? 'default' : (e.style || 'default'),
           label: e.label ?? '',
           data: {
             ...e,
-            sourceGroupIndex,
-            sourceGroupCount: srcGroup.length,
-            targetGroupIndex,
-            targetGroupCount: tgtGroup.length,
-            sourceHandleSide: sourceSide,
-            targetHandleSide: targetSide,
-            sourceHandleSlot,
-            targetHandleSlot,
+            __src: e,
+            sourceGroupIndex: layout.sourceGroupIndex,
+            sourceGroupCount: layout.sourceGroupCount,
+            targetGroupIndex: layout.targetGroupIndex,
+            targetGroupCount: layout.targetGroupCount,
+            sourceHandleSide: layout.sourceHandleSide,
+            targetHandleSide: layout.targetHandleSide,
+            sourceHandleSlot: layout.sourceHandleSlot,
+            targetHandleSlot: layout.targetHandleSlot,
           },
 
-          style: { stroke: 'var(--accent)', strokeWidth: 2, opacity: edgeOpacity, pointerEvents: (isInactive || isSoftFocused) ? 'none' : 'auto' },
+          style: { stroke: 'var(--accent)', strokeWidth: 2, opacity: edgeOpacity, pointerEvents },
           labelStyle: { fontSize: 11, fill: 'var(--accent)', opacity: markerOpacity },
-          labelBgStyle: { fill: 'var(--chakra-colors-gray-900)', fillOpacity: isInactive ? 0.1 : isSoftFocused ? 0.2 : 0.95 },
+          labelBgStyle: { fill: 'var(--chakra-colors-gray-900)', fillOpacity: labelBgOpacity },
           markerEnd: (dir === 'forward' || dir === 'both') ? { ...arrowMarker, color: alphaColor('var(--accent)', markerOpacity) } : undefined,
           markerStart: (dir === 'backward' || dir === 'both') ? { ...arrowMarker, color: alphaColor('var(--accent)', markerOpacity) } : undefined,
           selected: existing?.selected,
-          zIndex: selectedEdgeId !== null && existing?.id === String(selectedEdgeId) ? 1000 : 100,
+          zIndex: newZIndex,
         }
-      }),
-    )
-  }, [connectors, selectedEdgeId, activeTags, hiddenLayerTags, hoveredLayerTags, viewElements])
+      })
+    })
+  }, [connectorLayouts, selectedEdgeId, activeTags, hiddenLayerTags, hoveredLayerTags, elementMap, setRfEdges])
 
 
   // ── Boost z-index of selected connector ────────────────────────────────────────
   useEffect(() => {
-    setRfEdges((prev) =>
-      prev.map((e) => ({ ...e, zIndex: selectedEdgeId !== null && e.id === String(selectedEdgeId) ? 1000 : 100 })),
-    )
-  }, [selectedEdgeId])
+    setRfEdges((prev) => {
+      let changed = false
+      const selectedId = selectedEdgeId !== null ? String(selectedEdgeId) : null
+      const next = prev.map((edge) => {
+        const nextZIndex = selectedId !== null && edge.id === selectedId ? 1000 : 100
+        if (edge.zIndex === nextZIndex) return edge
+        changed = true
+        return { ...edge, zIndex: nextZIndex }
+      })
+      return changed ? next : prev
+    })
+  }, [selectedEdgeId, setRfEdges])
 
   return {
     // State