@tishlang/tish-lint 2.12.0 → 2.35.0

package/crates/tish_runtime/src/timers.rs

@@ -14,6 +14,26 @@ fn next_id() -> u64 {
     NEXT_ID.fetch_add(1, Ordering::SeqCst)
 }
 
+/// Maximum number of LIVE (registered, not-yet-fired) timers per worker thread. A program that keeps
+/// scheduling `setTimeout`/`setInterval` without them draining would otherwise grow the registry (and
+/// its retained callbacks + closed-over data) without bound (#384). Past the cap a new timer is
+/// dropped rather than registered. Override with `TISH_MAX_TIMERS`; default 100k — far above any real
+/// timer workload, low enough to bound memory.
+fn max_live_timers() -> usize {
+    // Read per call (timer registration is not a hot path, and the cap exists precisely to bound the
+    // pathological caller): keeps the limit overridable per test without a process-global cache.
+    std::env::var("TISH_MAX_TIMERS")
+        .ok()
+        .and_then(|v| v.parse().ok())
+        .filter(|&n| n > 0)
+        .unwrap_or(100_000)
+}
+
+#[cfg(test)]
+fn registry_len() -> usize {
+    REGISTRY.with(|r| r.borrow().len())
+}
+
 struct TimerEntry {
     due: Instant,
     callback: Value,
@@ -114,7 +134,12 @@ pub fn set_timeout(args: &[Value]) -> Value {
     let id = next_id();
     let due = Instant::now() + Duration::from_millis(delay_ms);
     REGISTRY.with(|r| {
-        r.borrow_mut().insert(
+        let mut reg = r.borrow_mut();
+        // #384: bound the live-timer count so a runaway scheduler can't grow the registry unbounded.
+        if reg.len() >= max_live_timers() {
+            return;
+        }
+        reg.insert(
             id,
             TimerEntry {
                 due,
@@ -138,7 +163,12 @@ pub fn set_interval(args: &[Value]) -> Value {
     let id = next_id();
     let due = Instant::now() + Duration::from_millis(interval_ms);
     REGISTRY.with(|r| {
-        r.borrow_mut().insert(
+        let mut reg = r.borrow_mut();
+        // #384: bound the live-timer count (see set_timeout).
+        if reg.len() >= max_live_timers() {
+            return;
+        }
+        reg.insert(
             id,
             TimerEntry {
                 due,
@@ -170,3 +200,20 @@ pub fn clear_timeout(args: &[Value]) -> Value {
 pub fn clear_interval(args: &[Value]) -> Value {
     clear_timeout(args)
 }
+
+#[cfg(test)]
+mod timer_cap_tests_384 {
+    use super::*;
+
+    #[test]
+    fn set_timeout_is_bounded_by_max_timers() {
+        // Each `#[test]` runs on its own thread, so REGISTRY (thread_local) starts empty here.
+        std::env::set_var("TISH_MAX_TIMERS", "5");
+        let cb = tishlang_core::native_fn(|_| Value::Null);
+        for _ in 0..20 {
+            let _ = set_timeout(&[Value::Function(cb.clone()), Value::Number(10_000.0)]);
+        }
+        assert_eq!(registry_len(), 5, "live timers must be capped at TISH_MAX_TIMERS");
+        std::env::remove_var("TISH_MAX_TIMERS");
+    }
+}

package/crates/tish_ui/src/jsx.rs

@@ -188,7 +188,12 @@ fn collect_fun_decl_names_stmt(stmt: &Statement, names: &mut HashSet<String>) {
             }
             collect_fun_decl_names_stmt(body, names);
         }
-        Statement::ForOf { iterable, body, .. } => {
+        Statement::ForOf { iterable, body, .. }
+        | Statement::ForIn {
+            object: iterable,
+            body,
+            ..
+        } => {
             collect_fun_decl_names_expr(iterable, names);
             collect_fun_decl_names_stmt(body, names);
         }
@@ -240,6 +245,7 @@ fn collect_fun_decl_names_stmt(stmt: &Statement, names: &mut HashSet<String>) {
         Statement::Export { declaration, .. } => match declaration.as_ref() {
             ExportDeclaration::Named(inner) => collect_fun_decl_names_stmt(inner, names),
             ExportDeclaration::Default(e) => collect_fun_decl_names_expr(e, names),
+            ExportDeclaration::ReExport { .. } => {}
         },
         Statement::Import { .. }
         | Statement::Break { .. }
@@ -645,7 +651,12 @@ fn stmt_contains_jsx_fragment(stmt: &tishlang_ast::Statement) -> bool {
                 || update.as_ref().is_some_and(expr_contains_jsx_fragment)
                 || stmt_contains_jsx_fragment(body)
         }
-        Statement::ForOf { iterable, body, .. } => {
+        Statement::ForOf { iterable, body, .. }
+        | Statement::ForIn {
+            object: iterable,
+            body,
+            ..
+        } => {
             expr_contains_jsx_fragment(iterable) || stmt_contains_jsx_fragment(body)
         }
         Statement::Switch {
@@ -682,6 +693,7 @@ fn stmt_contains_jsx_fragment(stmt: &tishlang_ast::Statement) -> bool {
         Statement::Export { declaration, .. } => match declaration.as_ref() {
             ExportDeclaration::Named(inner) => stmt_contains_jsx_fragment(inner),
             ExportDeclaration::Default(e) => expr_contains_jsx_fragment(e),
+            ExportDeclaration::ReExport { .. } => false,
         },
         Statement::Import { .. }
         | Statement::Break { .. }
@@ -825,7 +837,12 @@ fn stmt_contains_jsx(stmt: &tishlang_ast::Statement) -> bool {
                 || update.as_ref().is_some_and(expr_contains_jsx)
                 || stmt_contains_jsx(body)
         }
-        Statement::ForOf { iterable, body, .. } => {
+        Statement::ForOf { iterable, body, .. }
+        | Statement::ForIn {
+            object: iterable,
+            body,
+            ..
+        } => {
             expr_contains_jsx(iterable) || stmt_contains_jsx(body)
         }
         Statement::Switch {
@@ -857,6 +874,7 @@ fn stmt_contains_jsx(stmt: &tishlang_ast::Statement) -> bool {
         Statement::Export { declaration, .. } => match declaration.as_ref() {
             ExportDeclaration::Named(inner) => stmt_contains_jsx(inner),
             ExportDeclaration::Default(e) => expr_contains_jsx(e),
+            ExportDeclaration::ReExport { .. } => false,
         },
         Statement::Import { .. }
         | Statement::Break { .. }