@tiptap/y-tiptap 3.0.0-beta.3 → 3.0.1

package/README.md

@@ -4,6 +4,14 @@
 
 This binding maps a Y.XmlFragment to the ProseMirror state.
 
+## Why was this package forked from [y-prosemirror](https://github.com/yjs/y-prosemirror)?
+
+We forked y-prosemirror to create a Tiptap-specific package with changes we needed for Tiptap-related features. These modifications were too specific to be merged upstream or would have added maintenance overhead for the y-prosemirror maintainers.
+
+Where feasible, we contribute improvements and fixes back to y-prosemirror to support the broader ecosystem.
+
+This package is designed for use with Tiptap and is not intended as a general-purpose Yjs binding for ProseMirror.
+
 ## Features
 
 * Sync ProseMirror state

package/dist/y-tiptap.cjs

@@ -330,7 +330,7 @@ const restoreRelativeSelection = (tr, relSel, binding) => {
         relSel.anchor,
         binding.mapping
       );
-      tr.setSelection(prosemirrorState.NodeSelection.create(tr.doc, anchor));
+      tr.setSelection(createSafeNodeSelection(tr, anchor));
     } else {
       const anchor = relativePositionToAbsolutePosition(
         binding.doc,
@@ -351,6 +351,23 @@ const restoreRelativeSelection = (tr, relSel, binding) => {
   }
 };
 
+/**
+ * @param {import('prosemirror-state').Transaction} tr
+ * @param {number} pos
+ * @returns {import('prosemirror-state').Selection}
+ *
+ * Creates a NodeSelection if the position points to a valid node, otherwise
+ * creates a TextSelection near the position.
+ */
+const createSafeNodeSelection = (tr, pos) => {
+  const $pos = tr.doc.resolve(pos);
+  if ($pos.nodeAfter) {
+    return prosemirrorState.NodeSelection.create(tr.doc, pos)
+  } else {
+    return prosemirrorState.TextSelection.near($pos)
+  }
+};
+
 /**
  * @param {ProsemirrorBinding} pmbinding
  * @param {import('prosemirror-state').EditorState} state
@@ -1033,9 +1050,18 @@ const equalYTextPText = (ytext, ptexts) => {
     delta.every(/** @type {(d:any,i:number) => boolean} */ (d, i) =>
       d.insert === /** @type {any} */ (ptexts[i]).text &&
       object__namespace.keys(d.attributes || {}).length === ptexts[i].marks.length &&
-      object__namespace.every(d.attributes, (attr, yattrname) => {
+      object__namespace.every(d.attributes, (attr, /** @type {string} */ yattrname) => {
         const markname = yattr2markname(yattrname);
         const pmarks = ptexts[i].marks;
+
+        const pmark = pmarks.find(/** @param {any} mark */ mark => mark.type.name === markname);
+
+        // Ensure the pmark is present in the ptexts before checking equality. When replacing a mark with another mark
+        // the pmark will be missing from the ptexts and the equalAttrs will throw an error.
+        if (!pmark) {
+          return false
+        }
+
         return equalAttrs(attr, pmarks.find(/** @param {any} mark */ mark => mark.type.name === markname)?.attrs)
       })
     )