@tiptap/core 2.7.2 → 2.7.4

package/dist/packages/core/src/ExtensionManager.d.ts

@@ -1,5 +1,6 @@
 import { Schema } from '@tiptap/pm/model';
 import { Plugin } from '@tiptap/pm/state';
+import { NodeViewConstructor } from '@tiptap/pm/view';
 import type { Editor } from './Editor.js';
 import { Extensions, RawCommands } from './types.js';
 export declare class ExtensionManager {
@@ -46,7 +47,7 @@ export declare class ExtensionManager {
      * Get all node views from the extensions.
      * @returns An object with all node views where the key is the node name and the value is the node view function
      */
-    get nodeViews(): any;
+    get nodeViews(): Record<string, NodeViewConstructor>;
     /**
      * Go through all extensions, create extension storages & setup marks
      * & bind editor event listener.

package/dist/packages/core/src/types.d.ts

@@ -189,18 +189,15 @@ export type ValuesOf<T> = T[keyof T];
 export type KeysWithTypeOf<T, Type> = {
     [P in keyof T]: T[P] extends Type ? P : never;
 }[keyof T];
-export type Simplify<T> = {
-    [KeyType in keyof T]: T[KeyType];
-} & {};
 export type DecorationWithType = Decoration & {
     type: NodeType;
 };
-export type NodeViewProps = Simplify<Omit<NodeViewRendererProps, 'decorations'> & {
+export interface NodeViewProps extends NodeViewRendererProps {
     decorations: readonly DecorationWithType[];
     selected: boolean;
     updateAttributes: (attributes: Record<string, any>) => void;
     deleteNode: () => void;
-}>;
+}
 export interface NodeViewRendererOptions {
     stopEvent: ((props: {
         event: Event;
@@ -213,7 +210,7 @@ export interface NodeViewRendererOptions {
     }) => boolean) | null;
     contentDOMElementTag: string;
 }
-export type NodeViewRendererProps = {
+export interface NodeViewRendererProps {
     node: Parameters<NodeViewConstructor>[0];
     view: Parameters<NodeViewConstructor>[1];
     getPos: () => number;
@@ -222,7 +219,7 @@ export type NodeViewRendererProps = {
     editor: Editor;
     extension: Node;
     HTMLAttributes: Record<string, any>;
-};
+}
 export type NodeViewRenderer = (props: NodeViewRendererProps) => NodeView;
 export type AnyCommands = Record<string, (...args: any[]) => Command>;
 export type UnionCommands<T = Command> = UnionToIntersection<ValuesOf<Pick<Commands<T>, KeysWithTypeOf<Commands<T>, {}>>>>;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiptap/core",
   "description": "headless rich text editor",
-  "version": "2.7.2",
+  "version": "2.7.4",
   "homepage": "https://tiptap.dev",
   "keywords": [
     "tiptap",
@@ -32,7 +32,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@tiptap/pm": "^2.7.2"
+    "@tiptap/pm": "^2.7.4"
   },
   "peerDependencies": {
     "@tiptap/pm": "^2.7.0"

package/src/Editor.ts

@@ -568,6 +568,13 @@ export class Editor extends EventEmitter<EditorEvents> {
     this.emit('destroy')
 
     if (this.view) {
+      // Cleanup our reference to prevent circular references which caused memory leaks
+      // @ts-ignore
+      const dom = this.view.dom as TiptapEditorHTMLElement
+
+      if (dom && dom.editor) {
+        delete dom.editor
+      }
       this.view.destroy()
     }
 

package/src/ExtensionManager.ts

@@ -260,7 +260,7 @@ export class ExtensionManager {
    * Get all node views from the extensions.
    * @returns An object with all node views where the key is the node name and the value is the node view function
    */
-  get nodeViews() {
+  get nodeViews(): Record<string, NodeViewConstructor> {
     const { editor } = this
     const { nodeExtensions } = splitExtensions(this.extensions)
 

package/src/helpers/getRenderedAttributes.ts

@@ -8,6 +8,9 @@ export function getRenderedAttributes(
   extensionAttributes: ExtensionAttribute[],
 ): Record<string, any> {
   return extensionAttributes
+    .filter(
+      attribute => attribute.type === nodeOrMark.type.name,
+    )
     .filter(item => item.attribute.rendered)
     .map(item => {
       if (!item.attribute.renderHTML) {

package/src/types.ts

@@ -101,7 +101,19 @@ export interface EditorOptions {
    *
    * @default true
    */
-  enableCoreExtensions?: boolean | Partial<Record<'editable' | 'clipboardTextSerializer' | 'commands' | 'focusEvents' | 'keymap' | 'tabindex', false>>;
+  enableCoreExtensions?:
+    | boolean
+    | Partial<
+        Record<
+          | 'editable'
+          | 'clipboardTextSerializer'
+          | 'commands'
+          | 'focusEvents'
+          | 'keymap'
+          | 'tabindex',
+          false
+        >
+      >;
   /**
    * If `true`, the editor will check the content for errors on initialization.
    * Emitting the `contentError` event if the content is invalid.
@@ -122,8 +134,8 @@ export interface EditorOptions {
   onFocus: (props: EditorEvents['focus']) => void;
   onBlur: (props: EditorEvents['blur']) => void;
   onDestroy: (props: EditorEvents['destroy']) => void;
-  onPaste: (e: ClipboardEvent, slice: Slice) => void
-  onDrop: (e: DragEvent, slice: Slice, moved: boolean) => void
+  onPaste: (e: ClipboardEvent, slice: Slice) => void;
+  onDrop: (e: DragEvent, slice: Slice, moved: boolean) => void;
 }
 
 export type HTMLContent = string;
@@ -208,21 +220,17 @@ export type ValuesOf<T> = T[keyof T];
 
 export type KeysWithTypeOf<T, Type> = { [P in keyof T]: T[P] extends Type ? P : never }[keyof T];
 
-export type Simplify<T> = { [KeyType in keyof T]: T[KeyType] } & {};
-
 export type DecorationWithType = Decoration & {
   type: NodeType;
 };
 
-export type NodeViewProps = Simplify<
-  Omit<NodeViewRendererProps, 'decorations'> & {
-    // TODO this type is not technically correct, but it's the best we can do for now since prosemirror doesn't expose the type of decorations
-    decorations: readonly DecorationWithType[];
-    selected: boolean;
-    updateAttributes: (attributes: Record<string, any>) => void;
-    deleteNode: () => void;
-  }
->;
+export interface NodeViewProps extends NodeViewRendererProps {
+  // TODO this type is not technically correct, but it's the best we can do for now since prosemirror doesn't expose the type of decorations
+  decorations: readonly DecorationWithType[];
+  selected: boolean;
+  updateAttributes: (attributes: Record<string, any>) => void;
+  deleteNode: () => void;
+}
 
 export interface NodeViewRendererOptions {
   stopEvent: ((props: { event: Event }) => boolean) | null;
@@ -232,7 +240,7 @@ export interface NodeViewRendererOptions {
   contentDOMElementTag: string;
 }
 
-export type NodeViewRendererProps = {
+export interface NodeViewRendererProps {
   // pass-through from prosemirror
   node: Parameters<NodeViewConstructor>[0];
   view: Parameters<NodeViewConstructor>[1];
@@ -243,7 +251,7 @@ export type NodeViewRendererProps = {
   editor: Editor;
   extension: Node;
   HTMLAttributes: Record<string, any>;
-};
+}
 
 export type NodeViewRenderer = (props: NodeViewRendererProps) => NodeView;