@tiptap/core 2.5.0-beta.4 → 2.5.0-beta.5

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiptap/core",
   "description": "headless rich text editor",
-  "version": "2.5.0-beta.4",
+  "version": "2.5.0-beta.5",
   "homepage": "https://tiptap.dev",
   "keywords": [
     "tiptap",
@@ -32,7 +32,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@tiptap/pm": "^2.5.0-beta.4"
+    "@tiptap/pm": "^2.5.0-beta.5"
   },
   "peerDependencies": {
     "@tiptap/pm": "^2.0.0"

package/src/commands/insertContentAt.ts

@@ -84,11 +84,6 @@ export const insertContentAt: RawCommands['insertContentAt'] = (position, value,
       return false
     }
 
-    // don’t dispatch an empty fragment because this can lead to strange errors
-    if (content.toString() === '<>') {
-      return true
-    }
-
     let { from, to } = typeof position === 'number' ? { from: position, to: position } : { from: position.from, to: position.to }
 
     let isOnlyTextContent = true

package/src/commands/setContent.ts

@@ -1,4 +1,4 @@
-import { Fragment, Node as ProseMirrorNode, ParseOptions } from '@tiptap/pm/model'
+import { ParseOptions } from '@tiptap/pm/model'
 
 import { createDocument } from '../helpers/createDocument.js'
 import { Content, RawCommands } from '../types.js'
@@ -44,22 +44,34 @@ declare module '@tiptap/core' {
   }
 }
 
-export const setContent: RawCommands['setContent'] = (content, emitUpdate = false, parseOptions = {}, options = {}) => ({ tr, editor, dispatch }) => {
+export const setContent: RawCommands['setContent'] = (content, emitUpdate = false, parseOptions = {}, options = {}) => ({
+  editor, tr, dispatch, commands,
+}) => {
   const { doc } = tr
 
-  let document: Fragment | ProseMirrorNode
-
-  try {
-    document = createDocument(content, editor.schema, parseOptions, {
+  // This is to keep backward compatibility with the previous behavior
+  // TODO remove this in the next major version
+  if (parseOptions.preserveWhitespace !== 'full') {
+    const document = createDocument(content, editor.schema, parseOptions, {
       errorOnInvalidContent: options.errorOnInvalidContent ?? editor.options.enableContentCheck,
     })
-  } catch (e) {
-    return false
+
+    if (dispatch) {
+      tr.replaceWith(0, doc.content.size, document).setMeta('preventUpdate', !emitUpdate)
+    }
+    return true
   }
 
   if (dispatch) {
-    tr.replaceWith(0, doc.content.size, document).setMeta('preventUpdate', !emitUpdate)
+    tr.setMeta('preventUpdate', !emitUpdate)
   }
 
-  return true
+  return commands.insertContentAt(
+    { from: 0, to: doc.content.size },
+    content,
+    {
+      parseOptions,
+      errorOnInvalidContent: options.errorOnInvalidContent ?? editor.options.enableContentCheck,
+    },
+  )
 }

package/src/commands/updateAttributes.ts

@@ -1,7 +1,4 @@
-import {
-  Mark, MarkType, Node, NodeType,
-} from '@tiptap/pm/model'
-import { SelectionRange } from '@tiptap/pm/state'
+import { MarkType, NodeType } from '@tiptap/pm/model'
 
 import { getMarkType } from '../helpers/getMarkType.js'
 import { getNodeType } from '../helpers/getNodeType.js'
@@ -54,49 +51,37 @@ export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, at
   }
 
   if (dispatch) {
-    let lastPos: number | undefined
-    let lastNode: Node | undefined
-    let trimmedFrom: number
-    let trimmedTo: number
-
-    tr.selection.ranges.forEach((range: SelectionRange) => {
+    tr.selection.ranges.forEach(range => {
       const from = range.$from.pos
       const to = range.$to.pos
 
-      state.doc.nodesBetween(from, to, (node: Node, pos: number) => {
+      state.doc.nodesBetween(from, to, (node, pos) => {
         if (nodeType && nodeType === node.type) {
-          trimmedFrom = Math.max(pos, from)
-          trimmedTo = Math.min(pos + node.nodeSize, to)
-          lastPos = pos
-          lastNode = node
+          tr.setNodeMarkup(pos, undefined, {
+            ...node.attrs,
+            ...attributes,
+          })
         }
-      })
-    })
-
-    if (lastNode) {
 
-      if (lastPos !== undefined) {
-        tr.setNodeMarkup(lastPos, undefined, {
-          ...lastNode.attrs,
-          ...attributes,
-        })
-      }
+        if (markType && node.marks.length) {
+          node.marks.forEach(mark => {
+            if (markType === mark.type) {
+              const trimmedFrom = Math.max(pos, from)
+              const trimmedTo = Math.min(pos + node.nodeSize, to)
 
-      if (markType && lastNode.marks.length) {
-        lastNode.marks.forEach((mark: Mark) => {
-          if (markType === mark.type) {
-            tr.addMark(
-              trimmedFrom,
-              trimmedTo,
-              markType.create({
-                ...mark.attrs,
-                ...attributes,
-              }),
-            )
-          }
-        })
-      }
-    }
+              tr.addMark(
+                trimmedFrom,
+                trimmedTo,
+                markType.create({
+                  ...mark.attrs,
+                  ...attributes,
+                }),
+              )
+            }
+          })
+        }
+      })
+    })
   }
 
   return true

package/src/helpers/createNodeFromContent.ts

@@ -60,6 +60,7 @@ export function createNodeFromContent(
   if (isTextContent) {
     let schemaToUse = schema
     let hasInvalidContent = false
+    let invalidContent = ''
 
     // Only ever check for invalid content if we're supposed to throw an error
     if (options.errorOnInvalidContent) {
@@ -75,9 +76,11 @@ export function createNodeFromContent(
             parseDOM: [
               {
                 tag: '*',
-                getAttrs: () => {
+                getAttrs: e => {
                   // If this is ever called, we know that the content has something that we don't know how to handle in the schema
                   hasInvalidContent = true
+                  // Try to stringify the element for a more helpful error message
+                  invalidContent = typeof e === 'string' ? e : e.outerHTML
                   return null
                 },
               },
@@ -94,7 +97,7 @@ export function createNodeFromContent(
       : parser.parse(elementFromString(content), options.parseOptions)
 
     if (options.errorOnInvalidContent && hasInvalidContent) {
-      throw new Error('[tiptap error]: Invalid HTML content')
+      throw new Error('[tiptap error]: Invalid HTML content', { cause: new Error(`Invalid element found: ${invalidContent}`) })
     }
 
     return response