@tiptap/core 2.5.0-beta.1 → 2.5.0-beta.3

package/dist/packages/core/src/utilities/objectIncludes.d.ts

@@ -1,8 +1,8 @@
-/**
- * Check if object1 includes object2
- * @param object1 Object
- * @param object2 Object
- */
-export declare function objectIncludes(object1: Record<string, any>, object2: Record<string, any>, options?: {
-    strict: boolean;
-}): boolean;
+/**
+ * Check if object1 includes object2
+ * @param object1 Object
+ * @param object2 Object
+ */
+export declare function objectIncludes(object1: Record<string, any>, object2: Record<string, any>, options?: {
+    strict: boolean;
+}): boolean;

package/dist/packages/core/src/utilities/removeDuplicates.d.ts

@@ -1,8 +1,8 @@
-/**
- * Removes duplicated values within an array.
- * Supports numbers, strings and objects.
- */
-export declare function removeDuplicates<T>(array: T[], by?: {
-    (value: any, replacer?: ((this: any, key: string, value: any) => any) | undefined, space?: string | number | undefined): string;
-    (value: any, replacer?: (string | number)[] | null | undefined, space?: string | number | undefined): string;
-}): T[];
+/**
+ * Removes duplicated values within an array.
+ * Supports numbers, strings and objects.
+ */
+export declare function removeDuplicates<T>(array: T[], by?: {
+    (value: any, replacer?: ((this: any, key: string, value: any) => any) | undefined, space?: string | number | undefined): string;
+    (value: any, replacer?: (string | number)[] | null | undefined, space?: string | number | undefined): string;
+}): T[];

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiptap/core",
   "description": "headless rich text editor",
-  "version": "2.5.0-beta.1",
+  "version": "2.5.0-beta.3",
   "homepage": "https://tiptap.dev",
   "keywords": [
     "tiptap",
@@ -32,7 +32,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@tiptap/pm": "^2.5.0-beta.1"
+    "@tiptap/pm": "^2.5.0-beta.3"
   },
   "peerDependencies": {
     "@tiptap/pm": "^2.0.0"

package/src/Extension.ts

@@ -20,6 +20,7 @@ import { mergeDeep } from './utilities/mergeDeep.js'
 
 declare module '@tiptap/core' {
   interface ExtensionConfig<Options = any, Storage = any> {
+    // @ts-ignore - this is a dynamic key
     [key: string]: any
 
     /**
@@ -108,8 +109,9 @@ declare module '@tiptap/core' {
       name: string
       options: Options
       storage: Storage
+      extensions: (Node | Mark)[]
       parent: ParentConfig<ExtensionConfig<Options, Storage>>['addGlobalAttributes']
-    }) => GlobalAttributes | {}
+    }) => GlobalAttributes
 
     /**
      * This function adds commands to the editor

package/src/ExtensionManager.ts

@@ -3,7 +3,7 @@ import { Node as ProsemirrorNode, Schema } from '@tiptap/pm/model'
 import { Plugin } from '@tiptap/pm/state'
 import { Decoration, EditorView } from '@tiptap/pm/view'
 
-import { Editor } from './Editor.js'
+import type { Editor } from './Editor.js'
 import { getAttributesFromExtensions } from './helpers/getAttributesFromExtensions.js'
 import { getExtensionField } from './helpers/getExtensionField.js'
 import { getNodeType } from './helpers/getNodeType.js'

package/src/Mark.ts

@@ -23,6 +23,7 @@ import { mergeDeep } from './utilities/mergeDeep.js'
 
 declare module '@tiptap/core' {
   export interface MarkConfig<Options = any, Storage = any> {
+    // @ts-ignore - this is a dynamic key
     [key: string]: any
 
     /**
@@ -111,8 +112,9 @@ declare module '@tiptap/core' {
       name: string
       options: Options
       storage: Storage
+      extensions: (Node | Mark)[]
       parent: ParentConfig<MarkConfig<Options, Storage>>['addGlobalAttributes']
-    }) => GlobalAttributes | {}
+    }) => GlobalAttributes
 
     /**
      * This function adds commands to the editor

package/src/Node.ts

@@ -7,6 +7,7 @@ import { Editor } from './Editor.js'
 import { getExtensionField } from './helpers/getExtensionField.js'
 import { NodeConfig } from './index.js'
 import { InputRule } from './InputRule.js'
+import { Mark } from './Mark.js'
 import { PasteRule } from './PasteRule.js'
 import {
   AnyConfig,
@@ -23,6 +24,7 @@ import { mergeDeep } from './utilities/mergeDeep.js'
 
 declare module '@tiptap/core' {
   interface NodeConfig<Options = any, Storage = any> {
+    // @ts-ignore - this is a dynamic key
     [key: string]: any
 
     /**
@@ -111,8 +113,9 @@ declare module '@tiptap/core' {
       name: string
       options: Options
       storage: Storage
+      extensions: (Node | Mark)[]
       parent: ParentConfig<NodeConfig<Options, Storage>>['addGlobalAttributes']
-    }) => GlobalAttributes | {}
+    }) => GlobalAttributes
 
     /**
      * This function adds commands to the editor

package/src/commands/insertContentAt.ts

@@ -57,7 +57,7 @@ declare module '@tiptap/core' {
 }
 
 const isFragment = (nodeOrFragment: ProseMirrorNode | Fragment): nodeOrFragment is Fragment => {
-  return nodeOrFragment.toString().startsWith('<')
+  return !('type' in nodeOrFragment)
 }
 
 export const insertContentAt: RawCommands['insertContentAt'] = (position, value, options) => ({ tr, dispatch, editor }) => {

package/src/commands/updateAttributes.ts

@@ -1,4 +1,7 @@
-import { MarkType, NodeType } from '@tiptap/pm/model'
+import {
+  Mark, MarkType, Node, NodeType,
+} from '@tiptap/pm/model'
+import { SelectionRange } from '@tiptap/pm/state'
 
 import { getMarkType } from '../helpers/getMarkType.js'
 import { getNodeType } from '../helpers/getNodeType.js'
@@ -51,37 +54,49 @@ export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, at
   }
 
   if (dispatch) {
-    tr.selection.ranges.forEach(range => {
+    let lastPos: number | undefined
+    let lastNode: Node | undefined
+    let trimmedFrom: number
+    let trimmedTo: number
+
+    tr.selection.ranges.forEach((range: SelectionRange) => {
       const from = range.$from.pos
       const to = range.$to.pos
 
-      state.doc.nodesBetween(from, to, (node, pos) => {
+      state.doc.nodesBetween(from, to, (node: Node, pos: number) => {
         if (nodeType && nodeType === node.type) {
-          tr.setNodeMarkup(pos, undefined, {
-            ...node.attrs,
-            ...attributes,
-          })
-        }
-
-        if (markType && node.marks.length) {
-          node.marks.forEach(mark => {
-            if (markType === mark.type) {
-              const trimmedFrom = Math.max(pos, from)
-              const trimmedTo = Math.min(pos + node.nodeSize, to)
-
-              tr.addMark(
-                trimmedFrom,
-                trimmedTo,
-                markType.create({
-                  ...mark.attrs,
-                  ...attributes,
-                }),
-              )
-            }
-          })
+          trimmedFrom = Math.max(pos, from)
+          trimmedTo = Math.min(pos + node.nodeSize, to)
+          lastPos = pos
+          lastNode = node
         }
       })
     })
+
+    if (lastNode) {
+
+      if (lastPos !== undefined) {
+        tr.setNodeMarkup(lastPos, undefined, {
+          ...lastNode.attrs,
+          ...attributes,
+        })
+      }
+
+      if (markType && lastNode.marks.length) {
+        lastNode.marks.forEach((mark: Mark) => {
+          if (markType === mark.type) {
+            tr.addMark(
+              trimmedFrom,
+              trimmedTo,
+              markType.create({
+                ...mark.attrs,
+                ...attributes,
+              }),
+            )
+          }
+        })
+      }
+    }
   }
 
   return true

package/src/helpers/getAttributesFromExtensions.ts

@@ -5,7 +5,6 @@ import {
   Attributes,
   ExtensionAttribute,
   Extensions,
-  GlobalAttributes,
 } from '../types.js'
 import { getExtensionField } from './getExtensionField.js'
 import { splitExtensions } from './splitExtensions.js'
@@ -32,6 +31,7 @@ export function getAttributesFromExtensions(extensions: Extensions): ExtensionAt
       name: extension.name,
       options: extension.options,
       storage: extension.storage,
+      extensions: nodeAndMarkExtensions,
     }
 
     const addGlobalAttributes = getExtensionField<AnyConfig['addGlobalAttributes']>(
@@ -44,8 +44,7 @@ export function getAttributesFromExtensions(extensions: Extensions): ExtensionAt
       return
     }
 
-    // TODO: remove `as GlobalAttributes`
-    const globalAttributes = addGlobalAttributes() as GlobalAttributes
+    const globalAttributes = addGlobalAttributes()
 
     globalAttributes.forEach(globalAttribute => {
       globalAttribute.types.forEach(type => {

package/src/helpers/getSchemaByResolvedExtensions.ts

@@ -1,4 +1,6 @@
-import { MarkSpec, NodeSpec, Schema } from '@tiptap/pm/model'
+import {
+  MarkSpec, NodeSpec, Schema, TagParseRule,
+} from '@tiptap/pm/model'
 
 import { Editor, MarkConfig, NodeConfig } from '../index.js'
 import { AnyConfig, Extensions } from '../types.js'
@@ -93,7 +95,7 @@ export function getSchemaByResolvedExtensions(extensions: Extensions, editor?: E
       )
 
       if (parseHTML) {
-        schema.parseDOM = parseHTML.map(parseRule => injectExtensionAttributesToParseRule(parseRule, extensionAttributes))
+        schema.parseDOM = parseHTML.map(parseRule => injectExtensionAttributesToParseRule(parseRule, extensionAttributes)) as TagParseRule[]
       }
 
       const renderHTML = getExtensionField<NodeConfig['renderHTML']>(

package/src/helpers/injectExtensionAttributesToParseRule.ts

@@ -13,13 +13,13 @@ export function injectExtensionAttributesToParseRule(
   parseRule: ParseRule,
   extensionAttributes: ExtensionAttribute[],
 ): ParseRule {
-  if (parseRule.style) {
+  if ('style' in parseRule) {
     return parseRule
   }
 
   return {
     ...parseRule,
-    getAttrs: node => {
+    getAttrs: (node: HTMLElement) => {
       const oldAttributes = parseRule.getAttrs ? parseRule.getAttrs(node) : parseRule.attrs
 
       if (oldAttributes === false) {
@@ -28,8 +28,8 @@ export function injectExtensionAttributesToParseRule(
 
       const newAttributes = extensionAttributes.reduce((items, item) => {
         const value = item.attribute.parseHTML
-          ? item.attribute.parseHTML(node as HTMLElement)
-          : fromString((node as HTMLElement).getAttribute(item.name))
+          ? item.attribute.parseHTML(node)
+          : fromString((node).getAttribute(item.name))
 
         if (value === null || value === undefined) {
           return items

package/src/helpers/isNodeEmpty.ts

@@ -1,8 +1,11 @@
 import { Node as ProseMirrorNode } from '@tiptap/pm/model'
 
 export function isNodeEmpty(node: ProseMirrorNode): boolean {
-  const defaultContent = node.type.createAndFill()?.toJSON()
-  const content = node.toJSON()
+  const defaultContent = node.type.createAndFill()
 
-  return JSON.stringify(defaultContent) === JSON.stringify(content)
+  if (!defaultContent) {
+    return false
+  }
+
+  return node.eq(defaultContent)
 }

package/src/types.ts

@@ -133,11 +133,11 @@ export type CommandSpec = (...args: any[]) => Command
 export type KeyboardShortcutCommand = (props: { editor: Editor }) => boolean
 
 export type Attribute = {
-  default: any
+  default?: any
   rendered?: boolean
   renderHTML?: ((attributes: Record<string, any>) => Record<string, any> | null) | null
   parseHTML?: ((element: HTMLElement) => any | null) | null
-  keepOnSplit: boolean
+  keepOnSplit?: boolean
   isRequired?: boolean
 }
 
@@ -152,7 +152,13 @@ export type ExtensionAttribute = {
 }
 
 export type GlobalAttributes = {
+  /**
+   * The node & mark types this attribute should be applied to.
+   */
   types: string[]
+  /**
+   * The attributes to add to the node or mark types.
+   */
   attributes: {
     [key: string]: Attribute
   }

package/src/utilities/mergeDeep.ts

@@ -5,14 +5,10 @@ export function mergeDeep(target: Record<string, any>, source: Record<string, an
 
   if (isPlainObject(target) && isPlainObject(source)) {
     Object.keys(source).forEach(key => {
-      if (isPlainObject(source[key])) {
-        if (!(key in target)) {
-          Object.assign(output, { [key]: source[key] })
-        } else {
-          output[key] = mergeDeep(target[key], source[key])
-        }
+      if (isPlainObject(source[key]) && isPlainObject(target[key])) {
+        output[key] = mergeDeep(target[key], source[key])
       } else {
-        Object.assign(output, { [key]: source[key] })
+        output[key] = source[key]
       }
     })
   }