@tiptap/core 2.5.0-beta.1 → 2.5.0-beta.2

package/dist/packages/core/src/types.d.ts

@@ -126,11 +126,11 @@ export declare type KeyboardShortcutCommand = (props: {
     editor: Editor;
 }) => boolean;
 export declare type Attribute = {
-    default: any;
+    default?: any;
     rendered?: boolean;
     renderHTML?: ((attributes: Record<string, any>) => Record<string, any> | null) | null;
     parseHTML?: ((element: HTMLElement) => any | null) | null;
-    keepOnSplit: boolean;
+    keepOnSplit?: boolean;
     isRequired?: boolean;
 };
 export declare type Attributes = {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiptap/core",
   "description": "headless rich text editor",
-  "version": "2.5.0-beta.1",
+  "version": "2.5.0-beta.2",
   "homepage": "https://tiptap.dev",
   "keywords": [
     "tiptap",
@@ -32,7 +32,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@tiptap/pm": "^2.5.0-beta.1"
+    "@tiptap/pm": "^2.5.0-beta.2"
   },
   "peerDependencies": {
     "@tiptap/pm": "^2.0.0"

package/src/commands/updateAttributes.ts

@@ -1,4 +1,7 @@
-import { MarkType, NodeType } from '@tiptap/pm/model'
+import {
+  Mark, MarkType, Node, NodeType,
+} from '@tiptap/pm/model'
+import { SelectionRange } from '@tiptap/pm/state'
 
 import { getMarkType } from '../helpers/getMarkType.js'
 import { getNodeType } from '../helpers/getNodeType.js'
@@ -51,37 +54,49 @@ export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, at
   }
 
   if (dispatch) {
-    tr.selection.ranges.forEach(range => {
+    let lastPos: number | undefined
+    let lastNode: Node | undefined
+    let trimmedFrom: number
+    let trimmedTo: number
+
+    tr.selection.ranges.forEach((range: SelectionRange) => {
       const from = range.$from.pos
       const to = range.$to.pos
 
-      state.doc.nodesBetween(from, to, (node, pos) => {
+      state.doc.nodesBetween(from, to, (node: Node, pos: number) => {
         if (nodeType && nodeType === node.type) {
-          tr.setNodeMarkup(pos, undefined, {
-            ...node.attrs,
-            ...attributes,
-          })
-        }
-
-        if (markType && node.marks.length) {
-          node.marks.forEach(mark => {
-            if (markType === mark.type) {
-              const trimmedFrom = Math.max(pos, from)
-              const trimmedTo = Math.min(pos + node.nodeSize, to)
-
-              tr.addMark(
-                trimmedFrom,
-                trimmedTo,
-                markType.create({
-                  ...mark.attrs,
-                  ...attributes,
-                }),
-              )
-            }
-          })
+          trimmedFrom = Math.max(pos, from)
+          trimmedTo = Math.min(pos + node.nodeSize, to)
+          lastPos = pos
+          lastNode = node
         }
       })
     })
+
+    if (lastNode) {
+
+      if (lastPos !== undefined) {
+        tr.setNodeMarkup(lastPos, undefined, {
+          ...lastNode.attrs,
+          ...attributes,
+        })
+      }
+
+      if (markType && lastNode.marks.length) {
+        lastNode.marks.forEach((mark: Mark) => {
+          if (markType === mark.type) {
+            tr.addMark(
+              trimmedFrom,
+              trimmedTo,
+              markType.create({
+                ...mark.attrs,
+                ...attributes,
+              }),
+            )
+          }
+        })
+      }
+    }
   }
 
   return true

package/src/types.ts

@@ -133,11 +133,11 @@ export type CommandSpec = (...args: any[]) => Command
 export type KeyboardShortcutCommand = (props: { editor: Editor }) => boolean
 
 export type Attribute = {
-  default: any
+  default?: any
   rendered?: boolean
   renderHTML?: ((attributes: Record<string, any>) => Record<string, any> | null) | null
   parseHTML?: ((element: HTMLElement) => any | null) | null
-  keepOnSplit: boolean
+  keepOnSplit?: boolean
   isRequired?: boolean
 }