@tiptap/core 2.0.0-beta.90 → 2.0.0-beta.94

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiptap/core",
   "description": "headless rich text editor",
-  "version": "2.0.0-beta.90",
+  "version": "2.0.0-beta.94",
   "homepage": "https://tiptap.dev",
   "keywords": [
     "tiptap",
@@ -45,5 +45,5 @@
     "url": "https://github.com/ueberdosis/tiptap",
     "directory": "packages/core"
   },
-  "gitHead": "c3d04cef604564c2159b0c28703bb0247d3d9bee"
+  "gitHead": "937f6a1682f586a2ee9761d1630acc90eb505a09"
 }

package/src/Editor.ts

@@ -132,7 +132,20 @@ export class Editor extends EventEmitter {
    * @param options A list of options
    */
   public setOptions(options: Partial<EditorOptions> = {}): void {
-    this.options = { ...this.options, ...options }
+    this.options = {
+      ...this.options,
+      ...options,
+    }
+
+    if (!this.view || !this.state || this.isDestroyed) {
+      return
+    }
+
+    if (this.options.editorProps) {
+      this.view.setProps(this.options.editorProps)
+    }
+
+    this.view.updateState(this.state)
   }
 
   /**
@@ -140,17 +153,18 @@ export class Editor extends EventEmitter {
    */
   public setEditable(editable: boolean): void {
     this.setOptions({ editable })
-
-    if (this.view && this.state && !this.isDestroyed) {
-      this.view.updateState(this.state)
-    }
   }
 
   /**
    * Returns whether the editor is editable.
    */
   public get isEditable(): boolean {
-    return this.view && this.view.editable
+    // since plugins are applied after creating the view
+    // `editable` is always `true` for one tick.
+    // that’s why we also have to check for `options.editable`
+    return this.options.editable
+      && this.view
+      && this.view.editable
   }
 
   /**

package/src/commands/insertContent.ts

@@ -1,3 +1,4 @@
+import { CreateNodeFromContentOptions } from '../helpers/createNodeFromContent'
 import { RawCommands, Content } from '../types'
 
 declare module '@tiptap/core' {
@@ -6,11 +7,11 @@ declare module '@tiptap/core' {
       /**
        * Insert a node or string of HTML at the current position.
        */
-      insertContent: (value: Content) => ReturnType,
+      insertContent: (value: Content, options?: CreateNodeFromContentOptions) => ReturnType,
     }
   }
 }
 
-export const insertContent: RawCommands['insertContent'] = value => ({ tr, commands }) => {
-  return commands.insertContentAt({ from: tr.selection.from, to: tr.selection.to }, value)
+export const insertContent: RawCommands['insertContent'] = (value, options) => ({ tr, commands }) => {
+  return commands.insertContentAt({ from: tr.selection.from, to: tr.selection.to }, value, options)
 }

package/src/commands/insertContentAt.ts

@@ -1,4 +1,4 @@
-import createNodeFromContent from '../helpers/createNodeFromContent'
+import createNodeFromContent, { CreateNodeFromContentOptions } from '../helpers/createNodeFromContent'
 import selectionToInsertionEnd from '../helpers/selectionToInsertionEnd'
 import {
   RawCommands,
@@ -12,17 +12,18 @@ declare module '@tiptap/core' {
       /**
        * Insert a node or string of HTML at a specific position.
        */
-      insertContentAt: (position: number | Range, value: Content) => ReturnType,
+      insertContentAt: (position: number | Range, value: Content, options?: CreateNodeFromContentOptions) => ReturnType,
     }
   }
 }
 
-export const insertContentAt: RawCommands['insertContentAt'] = (position, value) => ({ tr, dispatch, editor }) => {
+export const insertContentAt: RawCommands['insertContentAt'] = (position, value, options) => ({ tr, dispatch, editor }) => {
   if (dispatch) {
     const content = createNodeFromContent(value, editor.schema, {
       parseOptions: {
         preserveWhitespace: 'full',
       },
+      ...(options || {}),
     })
 
     // don’t dispatch an empty fragment because this can lead to strange errors

package/src/pasteRules/markPasteRule.ts

@@ -35,7 +35,7 @@ export default function (
               ? getAttributes(match)
               : getAttributes
 
-            if (!attrs) {
+            if (!attrs && attrs !== undefined) {
               continue
             }