@tiny-fish/cli 0.29.1-next.240 → 0.29.1-next.241

package/dist/lib/connect-all.js

@@ -26,6 +26,8 @@ const NO_BROWSER_REASONS = new Set([
     "harness_not_installed",
     "command_not_found",
 ]);
+// Naming a harness the user does not have is the noise PF-3708 cut.
+const HIDDEN_ONCE_SOMETHING_WORKED = new Set(["deselected", "not_detected", "not_installed"]);
 const STEP_INDENT = "  ";
 // Must undercut agent tool-call budgets (Claude Code Bash defaults to 120s).
 const OAUTH_SIGN_IN_TIMEOUT_MS = 90_000;
@@ -140,11 +142,11 @@ function uninstallHarness(harness, configPath) {
 async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliInstall, deferOutro) {
     const { harness, configPath, detected } = detection;
     const base = { harness, detected, configPath, installed: false };
-    if (!detected)
-        return { ...base, outcome: "not_detected" };
-    if (!opts.uninstall && isStaleConfig(detection)) {
-        return { ...base, outcome: "stale_config", fixCommand: `tinyfish connect ${harness}` };
-    }
+    const noWork = noWorkOutcome(detection, opts.uninstall);
+    if (noWork === "not_detected")
+        return { ...base, outcome: noWork };
+    if (noWork)
+        return { ...base, outcome: noWork, fixCommand: `tinyfish connect ${harness}` };
     // dryRun first: --dry-run --uninstall must plan, never reach removeCursorMcpServer().
     if (opts.dryRun) {
         const plan = opts.uninstall
@@ -212,7 +214,7 @@ async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliIn
         }
         // Detection saw a name on PATH; the probe proved nothing is behind it.
         if (e instanceof ConnectStepError && e.failureReason === "harness_not_installed") {
-            return { ...base, detected: false, outcome: "not_detected" };
+            return { ...base, detected: false, outcome: "not_installed" };
         }
         // Both reasons carry the same "flag not listed" message; the upgrade nudge is in it.
         if (e instanceof ConnectStepError && TOO_OLD_REASONS.has(e.failureReason)) {
@@ -249,6 +251,12 @@ async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliIn
 }
 function summaryLine(result, uninstall) {
     const name = DISPLAY_NAMES[result.harness];
+    if (result.outcome === "not_installed") {
+        const next = uninstall
+            ? "nothing to remove"
+            : `Install ${name}, then run: tinyfish connect ${result.harness}`;
+        return `- ${name} — not installed (\`${HARNESS_COMMANDS[result.harness]}\` is on PATH but does not run). ${next}`;
+    }
     if (!result.detected) {
         const next = uninstall
             ? "nothing to remove"
@@ -315,13 +323,21 @@ function renderSummary(results, uninstall) {
     // Ids, not display names: they double as the `connect` argument.
     const skipped = results.filter((r) => r.outcome === "deselected").map((r) => r.harness);
     const lines = results
-        .filter((r) => r.outcome !== "deselected" && r.outcome !== "not_detected")
+        .filter((r) => !HIDDEN_ONCE_SOMETHING_WORKED.has(r.outcome))
         .map((r) => summaryLine(r, uninstall));
     if (skipped.length === 0)
         return lines;
     lines.push("", `Skipped (not selected): ${skipped.join(", ")}`);
     return lines;
 }
+/** The states processHarness settles without work; stepTotal must agree with it. */
+function noWorkOutcome(d, uninstall) {
+    if (!d.detected)
+        return "not_detected";
+    if (!uninstall && isStaleConfig(d))
+        return "stale_config";
+    return undefined;
+}
 /** A config-writing connect needs no binary; every other harness spawns one. */
 function isStaleConfig(detection) {
     return (detection.detected &&
@@ -490,8 +506,8 @@ export async function runConnectAll(opts) {
     const outro = new Set();
     const results = [];
     const oauthBudget = { spent: false };
-    // Mirrors processHarness's own short-circuits: absent has no work, stale only when removing.
-    const stepped = (d) => !deselected.has(d.harness) && d.detected && (opts.uninstall || !isStaleConfig(d));
+    // Shares processHarness's no-work states so stepTotal cannot desync.
+    const stepped = (d) => !deselected.has(d.harness) && !noWorkOutcome(d, opts.uninstall);
     const stepTotal = detections.filter(stepped).length;
     let step = 0;
     for (const detection of detections) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiny-fish/cli",
-  "version": "0.29.1-next.240",
+  "version": "0.29.1-next.241",
   "description": "TinyFish CLI — run web automations from your terminal",
   "type": "module",
   "bin": {