@tiny-fish/cli 0.29.1-next.239 → 0.29.1-next.241

package/dist/lib/connect-all.js

@@ -26,6 +26,8 @@ const NO_BROWSER_REASONS = new Set([
     "harness_not_installed",
     "command_not_found",
 ]);
+// Naming a harness the user does not have is the noise PF-3708 cut.
+const HIDDEN_ONCE_SOMETHING_WORKED = new Set(["deselected", "not_detected", "not_installed"]);
 const STEP_INDENT = "  ";
 // Must undercut agent tool-call budgets (Claude Code Bash defaults to 120s).
 const OAUTH_SIGN_IN_TIMEOUT_MS = 90_000;
@@ -140,11 +142,11 @@ function uninstallHarness(harness, configPath) {
 async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliInstall, deferOutro) {
     const { harness, configPath, detected } = detection;
     const base = { harness, detected, configPath, installed: false };
-    if (!detected)
-        return { ...base, outcome: "not_detected" };
-    if (!opts.uninstall && isStaleConfig(detection)) {
-        return { ...base, outcome: "stale_config", fixCommand: `tinyfish connect ${harness}` };
-    }
+    const noWork = noWorkOutcome(detection, opts.uninstall);
+    if (noWork === "not_detected")
+        return { ...base, outcome: noWork };
+    if (noWork)
+        return { ...base, outcome: noWork, fixCommand: `tinyfish connect ${harness}` };
     // dryRun first: --dry-run --uninstall must plan, never reach removeCursorMcpServer().
     if (opts.dryRun) {
         const plan = opts.uninstall
@@ -210,6 +212,10 @@ async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliIn
         if (spentBrowserSlot && e instanceof ConnectStepError && NO_BROWSER_REASONS.has(e.failureReason)) {
             oauthBudget.spent = false;
         }
+        // Detection saw a name on PATH; the probe proved nothing is behind it.
+        if (e instanceof ConnectStepError && e.failureReason === "harness_not_installed") {
+            return { ...base, detected: false, outcome: "not_installed" };
+        }
         // Both reasons carry the same "flag not listed" message; the upgrade nudge is in it.
         if (e instanceof ConnectStepError && TOO_OLD_REASONS.has(e.failureReason)) {
             return {
@@ -245,6 +251,12 @@ async function processHarness(detection, opts, prompt, oauthBudget, hoistedCliIn
 }
 function summaryLine(result, uninstall) {
     const name = DISPLAY_NAMES[result.harness];
+    if (result.outcome === "not_installed") {
+        const next = uninstall
+            ? "nothing to remove"
+            : `Install ${name}, then run: tinyfish connect ${result.harness}`;
+        return `- ${name} — not installed (\`${HARNESS_COMMANDS[result.harness]}\` is on PATH but does not run). ${next}`;
+    }
     if (!result.detected) {
         const next = uninstall
             ? "nothing to remove"
@@ -268,9 +280,6 @@ function summaryLine(result, uninstall) {
             ? `… ${name} — ${result.errorMessage}. Finish it in a terminal: ${result.fixCommand}`
             : `… ${name} — needs a browser sign-in. Run in a terminal: ${result.fixCommand}`;
     }
-    if (result.outcome === "deselected") {
-        return `… ${name} — skipped, not selected. Fix: ${result.fixCommand}`;
-    }
     if (result.outcome === "uninstall_pointer") {
         return `… ${name} — not removed automatically (config is owned by ${name}). Run: ${result.fixCommand}`;
     }
@@ -307,6 +316,28 @@ function summaryLine(result, uninstall) {
     }
     return `✓ ${name} — installed, ${verifyLabel}`;
 }
+/** Absent and unpicked harnesses are noise once something real happened. */
+function renderSummary(results, uninstall) {
+    if (!results.some(actionable))
+        return results.map((r) => summaryLine(r, uninstall));
+    // Ids, not display names: they double as the `connect` argument.
+    const skipped = results.filter((r) => r.outcome === "deselected").map((r) => r.harness);
+    const lines = results
+        .filter((r) => !HIDDEN_ONCE_SOMETHING_WORKED.has(r.outcome))
+        .map((r) => summaryLine(r, uninstall));
+    if (skipped.length === 0)
+        return lines;
+    lines.push("", `Skipped (not selected): ${skipped.join(", ")}`);
+    return lines;
+}
+/** The states processHarness settles without work; stepTotal must agree with it. */
+function noWorkOutcome(d, uninstall) {
+    if (!d.detected)
+        return "not_detected";
+    if (!uninstall && isStaleConfig(d))
+        return "stale_config";
+    return undefined;
+}
 /** A config-writing connect needs no binary; every other harness spawns one. */
 function isStaleConfig(detection) {
     return (detection.detected &&
@@ -475,7 +506,9 @@ export async function runConnectAll(opts) {
     const outro = new Set();
     const results = [];
     const oauthBudget = { spent: false };
-    const stepTotal = detections.length - deselected.size;
+    // Shares processHarness's no-work states so stepTotal cannot desync.
+    const stepped = (d) => !deselected.has(d.harness) && !noWorkOutcome(d, opts.uninstall);
+    const stepTotal = detections.filter(stepped).length;
     let step = 0;
     for (const detection of detections) {
         const { harness } = detection;
@@ -488,6 +521,9 @@ export async function runConnectAll(opts) {
             });
             continue;
         }
+        // The pad loop below records these; announcing them is the noise this command had.
+        if (!stepped(detection))
+            continue;
         step += 1;
         errLine(`step ${step} of ${stepTotal} — ${DISPLAY_NAMES[harness]}`);
         let result;
@@ -533,8 +569,8 @@ export async function runConnectAll(opts) {
     }
     outLine("");
     outLine("TinyFish setup summary:");
-    for (const result of results)
-        outLine(summaryLine(result, opts.uninstall));
+    for (const line of renderSummary(results, opts.uninstall))
+        outLine(line);
     // Before the launch handover: anything printed after it is never seen.
     for (const line of outro)
         errLine(line);

package/dist/lib/connect-runtime.js

@@ -137,7 +137,8 @@ export function requireCommandSupport(client) {
         env: { ...process.env, FORCE_COLOR: "0", NO_COLOR: "1" },
         timeout: NON_INTERACTIVE_TIMEOUT_MS,
     });
-    if (commandNotFound(result.error)) {
+    // 127 is the shell's not-found code; a wrapper shim with no real binary behind it exits that.
+    if (commandNotFound(result.error) || result.status === 127) {
         throw new PrerequisiteError(`${client.displayName} is not installed or not available on PATH.`, "harness_not_installed", { cause: result.error });
     }
     if (result.error || result.status !== 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiny-fish/cli",
-  "version": "0.29.1-next.239",
+  "version": "0.29.1-next.241",
   "description": "TinyFish CLI — run web automations from your terminal",
   "type": "module",
   "bin": {