@tiny-fish/cli 0.25.0 → 0.25.1-next.216

package/dist/lib/connect-all.js

@@ -6,7 +6,7 @@ import { installTinyFishCli, } from "./cli-install.js";
 import { NATIVE_MCP_CLIENTS } from "./connect-clients.js";
 import { ensureCliAuthenticated, TINYFISH_CLI_NOT_FOUND_MESSAGE } from "./connect-auth.js";
 import { commandNotFound, ConnectInterruptedError, ConnectStepError, finishSetupCommand, throwIfInterrupted, } from "./connect-runtime.js";
-import { detectInstalledHarnesses, ALL_HARNESSES, } from "./harness-detect.js";
+import { commandOnPath, detectInstalledHarnesses, HARNESS_COMMANDS, ALL_HARNESSES, } from "./harness-detect.js";
 import { detectHumanInitiated } from "./harness.js";
 import { emitNotice } from "./notice.js";
 import { removeCursorMcpServer, planCursorWrite } from "./cursor-config.js";
@@ -145,11 +145,13 @@ function uninstallHarness(harness, configPath) {
     return { ...detection, outcome: "uninstalled" };
 }
 async function processHarness(detection, opts, prompt, hoistedCliInstall) {
-    const { harness, configPath } = detection;
-    if (!detection.detected) {
-        return { harness, detected: false, configPath, installed: false, outcome: "not_detected" };
+    const { harness, configPath, detected } = detection;
+    const base = { harness, detected, configPath, installed: false };
+    if (!detected)
+        return { ...base, outcome: "not_detected" };
+    if (!opts.uninstall && isStaleConfig(detection)) {
+        return { ...base, outcome: "stale_config", fixCommand: `tinyfish connect ${harness}` };
     }
-    const base = { harness, detected: true, configPath, installed: false };
     // dryRun first: --dry-run --uninstall must plan, never reach removeCursorMcpServer().
     if (opts.dryRun) {
         const plan = opts.uninstall
@@ -222,7 +224,10 @@ function summaryLine(result, uninstall) {
         const next = uninstall
             ? "nothing to remove"
             : `Install ${name}, then run: tinyfish connect ${result.harness}`;
-        return `- ${name} — not detected (searched ${result.configPath}). ${next}`;
+        return `- ${name} — not detected (no \`${HARNESS_COMMANDS[result.harness]}\` on PATH, no ${result.configPath}). ${next}`;
+    }
+    if (result.outcome === "stale_config") {
+        return `… ${name} — config at ${result.configPath} but no \`${HARNESS_COMMANDS[result.harness]}\` on PATH, skipped. Install ${name}, then run: ${result.fixCommand}`;
     }
     if (result.outcome === "not_reached") {
         return `… ${name} — not reached, the run stopped early. Fix: ${result.fixCommand}`;
@@ -269,8 +274,17 @@ function summaryLine(result, uninstall) {
     }
     return `✓ ${name} — installed, ${verifyLabel}`;
 }
+/** Cursor's connect writes its config file; every other harness spawns its binary. */
+// TODO(PF-3668): 4th cursor carve-out here; fold them into one harness capability table.
+function isStaleConfig(detection) {
+    return detection.detected && !detection.binaryOnPath && detection.harness !== "cursor";
+}
+/** A stale config dir is a detection signal with nothing behind it. */
+function actionable(result) {
+    return result.detected && result.outcome !== "stale_config";
+}
 function computeExitCode(results) {
-    const detected = results.filter((r) => r.detected);
+    const detected = results.filter(actionable);
     if (detected.length === 0)
         return 1;
     // Only real install attempts count toward the success/failure denominator.
@@ -376,7 +390,7 @@ export async function runConnectAll(opts) {
     // Machine-global, so once per invocation; cursor's connect never installs it.
     const cliNeeded = !opts.dryRun &&
         !opts.uninstall &&
-        detections.some((d) => d.detected && d.harness !== "cursor" && willAttempt(d.harness));
+        detections.some((d) => d.detected && d.binaryOnPath && d.harness !== "cursor" && willAttempt(d.harness));
     let takeHoistedCli;
     if (cliNeeded) {
         errLine("First: the TinyFish CLI, shared by every harness.");
@@ -422,10 +436,14 @@ export async function runConnectAll(opts) {
     for (const detection of detections) {
         if (results.some((r) => r.harness === detection.harness))
             continue;
+        const { harness, detected, configPath } = detection;
+        const staleConfig = isStaleConfig(detection);
         results.push({
-            ...detection,
+            harness,
+            detected,
+            configPath,
             installed: false,
-            outcome: detection.detected ? "not_reached" : "not_detected",
+            outcome: staleConfig ? "stale_config" : detected ? "not_reached" : "not_detected",
             fixCommand: `tinyfish connect ${detection.harness}`,
         });
     }
@@ -433,7 +451,7 @@ export async function runConnectAll(opts) {
     outLine("TinyFish setup summary:");
     for (const result of results)
         outLine(summaryLine(result, opts.uninstall));
-    if (results.every((r) => !r.detected)) {
+    if (!results.some(actionable)) {
         if (!opts.dryRun && !opts.uninstall) {
             try {
                 return await runCliFallback(opts, prompt);
@@ -446,8 +464,11 @@ export async function runConnectAll(opts) {
                 return 130;
             }
         }
+        const stale = results.filter((r) => r.outcome === "stale_config");
         outLine("");
-        outLine("No supported harness found. Install one of: " + ALL_HARNESSES.join(", "));
+        outLine(stale.length > 0
+            ? `No runnable harness found. Reinstall ${stale.map((r) => DISPLAY_NAMES[r.harness]).join(", ")}, or install one of: ${ALL_HARNESSES.join(", ")}`
+            : "No supported harness found. Install one of: " + ALL_HARNESSES.join(", "));
         if (!opts.uninstall)
             outLine("Then run: npx @tiny-fish/cli connect --all");
         return 1;
@@ -455,7 +476,9 @@ export async function runConnectAll(opts) {
     if (!opts.dryRun && !opts.uninstall) {
         const harnessTelemetry = results.map((r) => ({
             harness: r.harness,
-            detected: r.detected,
+            // TODO(PF-3668): send outcome per harness instead; the frontend strips
+            // unknown harness keys, so the CLI can ship it before the reader does.
+            detected: actionable(r),
             installed: r.installed,
             verify_depth: r.verifyDepth ?? null,
             verify_ok: r.verifyOk ?? null,
@@ -484,11 +507,12 @@ const FIRST_TASK_PROMPT = "My TinyFish setup just finished — verify it with a
     "me a two-line summary. Show which tools you call.";
 // Launchable seeded agents, best-first — cursor-agent shares ~/.cursor/mcp.json with the IDE.
 const LAUNCHERS = [
-    { harness: "cursor", command: "cursor-agent", args: [FIRST_TASK_PROMPT] },
-    { harness: "claude-code", command: "claude", args: [FIRST_TASK_PROMPT] },
+    { harness: "cursor", args: [FIRST_TASK_PROMPT] },
+    { harness: "claude-code", args: [FIRST_TASK_PROMPT] },
 ];
 async function launchFirstTask(results) {
-    const candidates = LAUNCHERS.filter((l) => results.some((r) => r.harness === l.harness && r.installed));
+    const candidates = LAUNCHERS.filter((l) => results.some((r) => r.harness === l.harness && r.installed) &&
+        commandOnPath(HARNESS_COMMANDS[l.harness]));
     if (candidates.length === 0)
         return false;
     // Several installs: ask rather than pick a favorite; plain enter skips.
@@ -514,6 +538,6 @@ async function launchFirstTask(results) {
     if (!chosen)
         return false;
     outLine(`Starting ${DISPLAY_NAMES[chosen.harness]} with your first TinyFish task...`);
-    const result = spawn.sync(chosen.command, chosen.args, { stdio: "inherit" });
+    const result = spawn.sync(HARNESS_COMMANDS[chosen.harness], chosen.args, { stdio: "inherit" });
     return !result.error;
 }

package/dist/lib/harness-detect.d.ts

@@ -10,6 +10,8 @@ export declare enum AuthMode {
     OAuth = "oauth",
     Unknown = "unknown"
 }
+export declare const HARNESS_COMMANDS: Record<Harness, string>;
+export declare function commandOnPath(command: string): boolean;
 export declare function harnessConfigPath(harness: Harness): string;
 /** For reason strings that name a location; keeps them in sync with the table above. */
 export declare function harnessDisplayPath(harness: Harness): string;
@@ -17,5 +19,7 @@ export interface HarnessDetection {
     harness: Harness;
     detected: boolean;
     configPath: string;
+    /** False with `detected` true means a stale config dir: nothing to run. */
+    binaryOnPath: boolean;
 }
 export declare function detectInstalledHarnesses(): HarnessDetection[];

package/dist/lib/harness-detect.js

@@ -1,6 +1,7 @@
 import * as fs from "fs";
 import * as os from "os";
 import * as path from "path";
+import which from "which";
 export const ALL_HARNESSES = [
     "claude-code",
     "codex",
@@ -23,7 +24,6 @@ export var AuthMode;
     AuthMode["OAuth"] = "oauth";
     AuthMode["Unknown"] = "unknown";
 })(AuthMode || (AuthMode = {}));
-// Presence detection only — dir existence means "installed", nothing more.
 const CONFIG_DIRS = {
     "claude-code": ".claude",
     codex: ".codex",
@@ -33,6 +33,26 @@ const CONFIG_DIRS = {
     openclaw: ".openclaw",
     opencode: ".config/opencode",
 };
+// Harness id is not the binary name (cursor-agent).
+// TODO(PF-3668): a same-named non-harness binary still reads as installed.
+export const HARNESS_COMMANDS = {
+    "claude-code": "claude",
+    codex: "codex",
+    cursor: "cursor-agent",
+    grok: "grok",
+    hermes: "hermes",
+    openclaw: "openclaw",
+    opencode: "opencode",
+};
+// cross-spawn resolves the same way, so detection cannot disagree with the spawn.
+export function commandOnPath(command) {
+    try {
+        return which.sync(command, { nothrow: true }) !== null;
+    }
+    catch {
+        return false;
+    }
+}
 export function harnessConfigPath(harness) {
     return path.join(os.homedir(), CONFIG_DIRS[harness]); // nosemgrep: path-join-resolve-traversal -- fixed dir names under os.homedir()
 }
@@ -43,13 +63,20 @@ export function harnessDisplayPath(harness) {
 export function detectInstalledHarnesses() {
     return ALL_HARNESSES.map((harness) => {
         const configPath = harnessConfigPath(harness);
-        let detected;
+        let configDirExists;
         try {
-            detected = fs.statSync(configPath).isDirectory();
+            configDirExists = fs.statSync(configPath).isDirectory();
         }
         catch {
-            detected = false;
+            configDirExists = false;
         }
-        return { harness, detected, configPath };
+        // Config dir means ran once; PATH means runnable now.
+        const binaryOnPath = commandOnPath(HARNESS_COMMANDS[harness]);
+        return {
+            harness,
+            detected: configDirExists || binaryOnPath,
+            configPath,
+            binaryOnPath,
+        };
     });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiny-fish/cli",
-  "version": "0.25.0",
+  "version": "0.25.1-next.216",
   "description": "TinyFish CLI — run web automations from your terminal",
   "type": "module",
   "bin": {
@@ -37,12 +37,14 @@
     "commander": "^12.0.0",
     "cross-spawn": "^7.0.6",
     "globals": "^17.4.0",
+    "which": "^2.0.2",
     "zod": "^4.3.6"
   },
   "devDependencies": {
     "@eslint/js": "^10.0.1",
     "@types/cross-spawn": "^6.0.6",
     "@types/node": "^20.0.0",
+    "@types/which": "^2.0.2",
     "@typescript-eslint/eslint-plugin": "^8.57.2",
     "@typescript-eslint/parser": "^8.57.2",
     "eslint": "^10.1.0",