@tinkoff/eslint-config 1.37.0 → 1.38.0

package/CHANGELOG.md

@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.38.0](https://github.com/TinkoffCreditSystems/linters/compare/v1.37.0...v1.38.0) (2022-10-25)
+
+
+### Features
+
+* **eslint-config:** set import/no-cycle to error ([#206](https://github.com/TinkoffCreditSystems/linters/issues/206)) ([afab74b](https://github.com/TinkoffCreditSystems/linters/commit/afab74b1ed5f3705d75a82135a1b9c95a8a56da6))
+
+
+
 ## [1.37.0](https://github.com/TinkoffCreditSystems/linters/compare/v1.36.2...v1.37.0) (2022-10-14)
 
 

package/internal/import.js

@@ -29,6 +29,6 @@ module.exports = {
     ],
     'import/order': ['warn', { groups: [['builtin', 'external', 'internal']] }],
     'import/no-extraneous-dependencies': 'off', // need fine tuning
-    'import/no-cycle': 'off',
+    'import/no-cycle': 'error',
   },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tinkoff/eslint-config",
-  "version": "1.37.0",
+  "version": "1.38.0",
   "description": "Tinkoff ESLint configs to rule them all",
   "license": "Apache-2.0",
   "keywords": [
@@ -39,5 +39,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "3a324b112d6ae0117a7fb4b5f2e6bc68ec409ac1"
+  "gitHead": "c5e1317c46b8be3f55023f7dcc1345577c03f339"
 }

package/test/import/__fixtures__/dep-a.js

@@ -0,0 +1 @@
+export function a() {}

package/test/import/__fixtures__/dep-b.js

@@ -0,0 +1,3 @@
+import './import-unhappy.fixture';
+
+export function b() {}

package/test/import/__fixtures__/import-happy.fixture.js

@@ -0,0 +1,3 @@
+import { a } from './dep-a';
+
+a();

package/test/import/__fixtures__/import-unhappy.fixture.js

@@ -0,0 +1,3 @@
+import { b } from './dep-b';
+
+b();

package/test/import/__snapshots__/import-happy.test.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`import / happy path happy 1`] = `""`;

package/test/import/__snapshots__/import-unhappy.test.js.snap

@@ -0,0 +1,13 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`import / unhappy path unhappy 1`] = `
+"error: Dependency cycle detected (import/no-cycle) at packages/eslint-config/test/import/__fixtures__/import-unhappy.fixture.js:1:1:
+> 1 | import { b } from './dep-b';
+    | ^
+  2 | 
+  3 | b();
+  4 | 
+
+
+1 error found."
+`;

package/test/import/import-happy.test.js

@@ -0,0 +1,27 @@
+import ESlint from 'eslint';
+import path from 'path';
+
+describe('import / happy path', () => {
+  const cli = new ESlint.CLIEngine({
+    cwd: path.join(__dirname, '..'),
+    useEslintrc: false,
+    baseConfig: {
+      extends: ['../internal/import'],
+      parserOptions: {
+        sourceType: 'module',
+      },
+      env: {
+        es6: true,
+      },
+    },
+  });
+
+  it('happy', () => {
+    const codeframe = cli.getFormatter('codeframe');
+    const report = cli.executeOnFiles([
+      path.join(__dirname, './__fixtures__/import-happy.fixture.js'),
+    ]);
+
+    expect(codeframe(report.results)).toMatchSnapshot();
+  });
+});

package/test/import/import-unhappy.test.js

@@ -0,0 +1,27 @@
+import ESlint from 'eslint';
+import path from 'path';
+
+describe('import / unhappy path', () => {
+  const cli = new ESlint.CLIEngine({
+    cwd: path.join(__dirname, '..'),
+    useEslintrc: false,
+    baseConfig: {
+      extends: ['../internal/import'],
+      parserOptions: {
+        sourceType: 'module',
+      },
+      env: {
+        es6: true,
+      },
+    },
+  });
+
+  it('unhappy', () => {
+    const codeframe = cli.getFormatter('codeframe');
+    const report = cli.executeOnFiles([
+      path.join(__dirname, './__fixtures__/import-unhappy.fixture.js'),
+    ]);
+
+    expect(codeframe(report.results)).toMatchSnapshot();
+  });
+});