@timurproko/a1 0.2.7-dev.1249 → 0.2.7-dev.1255

package/dist/features/owned-ui/settings-app.js

@@ -1,6 +1,7 @@
 import { DIALOG_BACK_SHORTCUT_HINT, DIALOG_CLOSE_SHORTCUT_HINT } from "../../contracts/presentation/index.js";
-import { GLOBAL_SCOPE, LineInput, PLAIN_THEME, ShortcutRegistry, assertNoShortcutConflicts, blockJumpTarget, configureDialogChoiceCapacity, configureDialogTextRows, configureDialogWidth, numericValues, RAIL_COLUMNS, renderCenteredDialogOverlay, renderDialogPanel, renderSteppedDialogPanel, renderEmptyState, renderGroupHeader, renderListRow, renderNote, renderShortcutHintsWithClose, menuRowAt, regionAt, renderValueMenu, withScrollbarRail, stepperEnds, steppedValue, truncateToWidth, valueColumnFor, valueMenuFrame, blockRowSpan, displayWidth, formatLocalTime, handleLineInputKey, humanizeLabel, humanizeTitle, indexOfKey, layoutList, moveSelection, rowKey, scrollForSelection, scrollForTrackPage, scrollbarGeometry, scrollbarPresentation, ScrollbarRails, scrollbarWheelRows, selectableIndexes, } from "../../ui/components/index.js";
-import { FlagToggleDialog, PLUS_MENU_SETTING_ID, PlusMenuDialog } from "./plus-menu-dialog.js";
+import { GLOBAL_SCOPE, LineInput, PLAIN_THEME, ShortcutRegistry, assertNoShortcutConflicts, blockJumpTarget, configureDialogChoiceCapacity, configureDialogTextRows, configureDialogWidth, numericValues, RAIL_COLUMNS, renderCenteredDialogOverlay, renderDialogPanel, renderSteppedDialogPanel, renderEmptyState, renderGroupHeader, renderListRow, renderNote, renderShortcutHintsWithClose, menuRowAt, regionAt, renderValueMenu, withScrollbarRail, stepperEnds, steppedValue, truncateToWidth, valueColumnFor, valueMenuFrame, blockRowSpan, displayWidth, handleLineInputKey, humanizeLabel, humanizeTitle, indexOfKey, layoutList, moveSelection, rowKey, scrollForSelection, scrollbarGeometry, scrollbarWheelRows, selectableIndexes, } from "../../ui/components/index.js";
+import { SettingsScrollRail } from "./settings-scroll-rail.js";
+import { SettingsEdits, changeFailure, replaceRecord, sameRecord, structuredValue } from "./settings-edits.js";
 import { SETTINGS_APP_ID } from "./settings-route.js";
 export { SETTINGS_APP_ID, SETTINGS_ROUTE } from "./settings-route.js";
 const SCOPE = SETTINGS_APP_ID;
@@ -15,14 +16,8 @@ const DIALOG_SCOPE = `${SETTINGS_APP_ID}-parts`;
 const MODEL_SCOPE = `${SETTINGS_APP_ID}-models`;
 const MODEL_LEVEL_SCOPE = `${SETTINGS_APP_ID}-model-levels`;
 const SCROLLBAR_TOP_INSET = 0;
-/** Identity of the settings list rail in the shared rail state. */
-const RAIL_KEY = "settings";
-// Compatibility: the transcript rail stays lit this long after a scroll, and repaints just after.
-const SCROLL_LINGER_MS = 900;
-const SCROLL_LINGER_REPAINT_MS = 925;
 /** What a structured value offers instead of printing itself. */
 const CONFIGURE = "configure";
-const TAB_BAR_RIGHT_ITEMS_SETTING_ID = "tabBarRightItems";
 export const SETTINGS_SHORTCUTS = new ShortcutRegistry();
 SETTINGS_SHORTCUTS.declare({ key: "edit", scope: SCOPE, description: "Search settings", section: "Change", hint: { keys: "Type", does: "search" } }, "edit-filter");
 SETTINGS_SHORTCUTS.declare({ key: "up", scope: SCOPE, description: "Previous setting", section: "Navigate", hint: { keys: "↑↓", does: "navigate" } }, "move-up");
@@ -98,12 +93,7 @@ export class SettingsApp {
     #menu = null;
     #structured = null;
     // Invariant: pending values remain visible until the source reflects them.
-    #pending = new Map();
-    #undoHistory = [];
-    #editSequence = 0;
-    #undoRequests = 0;
-    #undoActive = false;
-    #closed = false;
+    #edits;
     #bodyTopForFrame = SETTINGS_TOP_RULE_ROWS + SETTINGS_TITLE_ROWS;
     #bodyHeightForFrame = 0;
     #panelTopForFrame = 0;
@@ -112,23 +102,13 @@ export class SettingsApp {
     #frameRows = [];
     #menuFrame = null;
     // Invariant: rail hover and drag live in the shared keyed state, as the transcript's do.
-    #rails = new ScrollbarRails();
+    #rail = new SettingsScrollRail();
     // Rationale: the rail as drawn in the last frame, or null when nothing can be pointed at.
-    #railFrame = null;
-    // Invariant: a scroll lights the rail until this time; the timer repaints once it has passed.
-    #activeUntil = 0;
-    #activityTimer;
-    #renderedScroll;
     #options;
-    /**
-     * `pinned` presents the screen as a resident Settings tab, which offers no screen-level close;
-     * `configurePlusMenu` opens the tab bar's Plus Menu dialog in place of this screen's own.
-     */
     constructor(session, options) {
         this.#session = session;
+        this.#edits = new SettingsEdits(session, () => this.#structured);
         this.#options = {
-            pinned: options.pinned === true,
-            configurePlusMenu: options.configurePlusMenu ?? null,
             dialogPanel: options.dialogPanel ?? null,
         };
         this.#search = {
@@ -139,17 +119,14 @@ export class SettingsApp {
         };
     }
     onActivate(host) {
-        this.#closed = false;
+        this.#edits.open();
         void this.#session.load().then(() => host.requestRender());
     }
     onClose(_host) {
-        this.#closed = true;
-        this.#undoHistory.length = 0;
-        this.#undoRequests = 0;
+        this.#edits.close();
         this.#search.input?.setFocused(false);
         this.#search.input = null;
-        this.#clearActivityTimer();
-        this.#rails.clear();
+        this.#rail.dispose();
     }
     render(rect, host) {
         const theme = host.theme ?? PLAIN_THEME;
@@ -182,11 +159,7 @@ export class SettingsApp {
         this.#panelTopForFrame = topRows + contentHeight + dividerRows;
         this.#scroll = layout.scroll;
         const now = Date.now();
-        // Rationale: every way of scrolling ends in this frame, so a moved list is noticed here
-        // once rather than at each wheel, drag, key, and search branch.
-        if (this.#renderedScroll !== undefined && this.#renderedScroll !== layout.scroll)
-            this.#noteScrollActivity(host, now);
-        this.#renderedScroll = layout.scroll;
+        this.#rail.noteRenderedScroll(layout.scroll, now, () => host.requestRender());
         // Invariant: auto and always keep the rail columns while the list fits, so a revealed
         // rail never reflows the rows; hidden gives the columns back to the rows.
         const appearance = this.#scrollbarAppearance();
@@ -199,22 +172,10 @@ export class SettingsApp {
             scroll: layout.scroll,
             trackHeight: Math.max(0, titleRows + bodyHeight - SCROLLBAR_TOP_INSET),
         });
-        const presentation = scrollbarPresentation({
-            geometry,
-            appearance,
-            style: this.#scrollbarStyle(),
-            hovered: this.#rails.isHovered(RAIL_KEY),
-            dragging: this.#rails.isDragging(RAIL_KEY),
-            activeUntil: this.#activeUntil,
-            now,
-        });
-        this.#railFrame = reservesRail && geometry !== null
-            ? {
-                rail: { key: RAIL_KEY, column: rect.width, rowStart: topRows + SCROLLBAR_TOP_INSET, trackHeight: geometry.trackHeight },
-                geometry,
-                page: layout.visible,
-            }
-            : null;
+        const presentation = this.#rail.presentation({ geometry, appearance, style: this.#scrollbarStyle(), now });
+        this.#rail.setFrame(reservesRail && geometry !== null
+            ? { rail: { column: rect.width, rowStart: topRows + SCROLLBAR_TOP_INSET, trackHeight: geometry.trackHeight }, geometry, page: layout.visible }
+            : null);
         const body = [];
         this.#frameRows = [];
         if (rows.length === 0) {
@@ -275,8 +236,7 @@ export class SettingsApp {
         const selected = indexOfKey(rows, this.#selectedKey);
         switch (action) {
             case "close":
-                if (!this.#options.pinned)
-                    host.close();
+                host.close();
                 return { consumed: true };
             case "edit-filter":
                 return { consumed: false };
@@ -284,7 +244,7 @@ export class SettingsApp {
                 const row = rows[selected];
                 if (row?.kind === "element" && (row.value.structured || isDefaultModelEntry(row.value)))
                     this.#openStructured(row.value);
-                else if (row?.kind === "element" && typeof this.#shownValue(row.value) === "number")
+                else if (row?.kind === "element" && typeof this.#edits.shown(row.value) === "number")
                     this.#cycle(rows, selected, 1);
                 else
                     this.#openMenu(rows, selected, true);
@@ -322,7 +282,7 @@ export class SettingsApp {
                 this.#cycle(rows, selected, action === "next-value" ? 1 : -1);
                 return { consumed: true };
             case "undo":
-                this.#undo();
+                this.#edits.undo();
                 return { consumed: true };
             default:
                 return { consumed: false };
@@ -364,7 +324,7 @@ export class SettingsApp {
             const value = menu.choices[overRow];
             this.#closeMenu(menu);
             if (value !== undefined)
-                this.#apply(menu.entry, value);
+                this.#edits.apply(menu.entry, value);
             return { consumed: true };
         }
         if (event.kind === "wheel-up" || event.kind === "wheel-down") {
@@ -389,7 +349,14 @@ export class SettingsApp {
             // cannot change its selection or act on the Settings list behind it.
             return { consumed: true, render: false };
         }
-        const rail = this.#railPointer(event);
+        const rail = this.#rail.pointer(event, this.#scroll);
+        if (rail.scroll !== undefined)
+            this.#scroll = rail.scroll;
+        // Invariant: the rail is not a row: pointing at it lights nothing in the list.
+        if (rail.overRail) {
+            this.#hoverKey = null;
+            this.#hoverRegion = "label";
+        }
         if (rail.owned)
             return { consumed: true };
         const row = this.#frameRows.find(candidate => candidate.screenRow === event.row - 1);
@@ -419,52 +386,6 @@ export class SettingsApp {
         const changed = previousKey !== this.#hoverKey || previousRegion !== this.#hoverRegion || rail.changed;
         return { consumed: event.kind !== "motion", render: changed };
     }
-    // Rationale: the rail takes its share of a pointer report first: hover, a thumb drag, or a
-    // track page. Owned means the list must not see the report; changed means the rail looks different.
-    #railPointer(event) {
-        const frame = this.#railFrame;
-        const wasHovered = this.#rails.isHovered(RAIL_KEY);
-        if (frame === null) {
-            this.#rails.clear();
-            return { owned: false, changed: wasHovered };
-        }
-        const pointer = { column: event.column, row: event.row - 1 };
-        if (this.#rails.isDragging(RAIL_KEY)) {
-            // Invariant: a drag keeps the pointer wherever it goes until the button comes up.
-            if (event.kind === "release")
-                this.#rails.endDrag();
-            else {
-                const target = this.#rails.dragTo(frame.rail, frame.geometry, pointer);
-                if (target !== null)
-                    this.#scroll = target;
-            }
-            return { owned: true, changed: true };
-        }
-        const over = this.#rails.notePointer([frame.rail], pointer) !== null;
-        if (!over)
-            return { owned: false, changed: wasHovered };
-        // Invariant: the rail is not a row: pointing at it lights nothing in the list.
-        this.#hoverKey = null;
-        this.#hoverRegion = "label";
-        if (event.kind === "press" && !this.#rails.beginDrag(frame.rail, frame.geometry, pointer)) {
-            this.#scroll = scrollForTrackPage(frame.geometry, pointer.row - frame.rail.rowStart, this.#scroll, frame.page);
-        }
-        return { owned: true, changed: true };
-    }
-    #noteScrollActivity(host, now) {
-        this.#activeUntil = Math.max(this.#activeUntil, now + SCROLL_LINGER_MS);
-        this.#clearActivityTimer();
-        this.#activityTimer = setTimeout(() => {
-            this.#activityTimer = undefined;
-            host.requestRender();
-        }, SCROLL_LINGER_REPAINT_MS);
-        this.#activityTimer.unref?.();
-    }
-    #clearActivityTimer() {
-        if (this.#activityTimer !== undefined)
-            clearTimeout(this.#activityTimer);
-        this.#activityTimer = undefined;
-    }
     #openMenu(rows, selected, selectCurrent = false) {
         const row = rows[selected];
         if (row === undefined || row.kind !== "element")
@@ -474,7 +395,7 @@ export class SettingsApp {
             this.#openStructured(entry);
             return;
         }
-        const shown = this.#shownValue(entry);
+        const shown = this.#edits.shown(entry);
         // Rationale: a number is stepped, not picked from a list: it has its own two controls,
         // and pointing at it is not a request for anything else.
         if (typeof shown === "number")
@@ -517,9 +438,6 @@ export class SettingsApp {
         // selector may open empty so it can truthfully report that no authenticated models exist.
         if (entry.flags.length === 0 && modelDialog !== "default")
             return;
-        // Rationale: beside a tab bar, its own Plus Menu dialog configures `+`, so both ways look the same.
-        if (entry.backend === "a1" && entry.id === PLUS_MENU_SETTING_ID && this.#options.configurePlusMenu?.() === true)
-            return;
         const stored = typeof entry.rawValue === "object" && entry.rawValue !== null && !Array.isArray(entry.rawValue)
             ? entry.rawValue
             : {};
@@ -534,19 +452,12 @@ export class SettingsApp {
         // thing under the pointer, so it stops looking like it.
         this.#hoverKey = null;
         this.#hoverRegion = "label";
-        this.#rails.clear();
+        this.#rail.clear();
         const currentDefault = typeof entry.rawValue === "string" ? entry.rawValue : null;
         this.#structured = {
             entry,
             flags: entry.flags.map(flag => flag.key),
             modelDialog,
-            flagDialog: entry.backend !== "a1" ? null
-                : entry.id === PLUS_MENU_SETTING_ID ? new PlusMenuDialog(entry.flags)
-                    : entry.id === TAB_BAR_RIGHT_ITEMS_SETTING_ID ? new FlagToggleDialog(entry.flags, {
-                        title: "Widgets",
-                        description: "Choose which widgets the tab bar shows.",
-                        empty: "No items match",
-                    }) : null,
             filter: modelDialog === null ? null : new LineInput(""),
             step: "model",
             modelKey: null,
@@ -562,12 +473,6 @@ export class SettingsApp {
             return { consumed: false };
         if (open.modelDialog !== null)
             return this.#modelDialogKey(open, data);
-        if (open.flagDialog !== null) {
-            const outcome = open.flagDialog.handle(KEYS[data] ?? data, data, key => this.#toggleFlag(open.flags.indexOf(key)));
-            if (outcome === "close")
-                this.#structured = null;
-            return { consumed: true };
-        }
         switch (SETTINGS_SHORTCUTS.resolve(KEYS[data] ?? data, DIALOG_SCOPE)) {
             case "close":
                 this.#structured = null;
@@ -582,7 +487,7 @@ export class SettingsApp {
                 this.#toggleFlag(open.index);
                 return { consumed: true };
             case "undo":
-                this.#undo();
+                this.#edits.undo();
                 return { consumed: true };
             default:
                 return { consumed: true, render: false };
@@ -714,14 +619,8 @@ export class SettingsApp {
         this.#saveStructured(open, previous, forward);
     }
     #saveStructured(open, previous, forward) {
-        const sequence = ++this.#editSequence;
-        void this.#session.changeStructured(open.entry.backend, open.entry.id, structuredValue(open.entry, forward)).then(outcome => {
-            const failure = changeFailure(outcome);
-            if (failure === null) {
-                this.#recordUndo({ kind: "structured", sequence, entry: open.entry, previous, forward });
-                return;
-            }
-            // Concurrency: only roll back the dialog if no later press has moved the record on.
+        // Concurrency: only roll back the dialog if no later press has moved the record on.
+        this.#edits.saveStructured(open.entry, previous, forward, () => {
             if (this.#structured === open && sameRecord(open.record, forward))
                 replaceRecord(open.record, previous);
         });
@@ -733,7 +632,7 @@ export class SettingsApp {
         const key = KEYS[data] ?? data;
         if (SETTINGS_SHORTCUTS.resolve(key, SCOPE) === "undo") {
             this.#closeMenu(menu);
-            this.#undo();
+            this.#edits.undo();
             return { consumed: true };
         }
         if (key === "escape") {
@@ -750,7 +649,7 @@ export class SettingsApp {
             const value = menu.choices[menu.index];
             this.#closeMenu(menu);
             if (value !== undefined)
-                this.#apply(menu.entry, value);
+                this.#edits.apply(menu.entry, value);
         }
         return { consumed: true };
     }
@@ -810,13 +709,13 @@ export class SettingsApp {
         const entry = row.value;
         if (!entry.editable)
             return;
-        const shown = this.#shownValue(entry);
+        const shown = this.#edits.shown(entry);
         if (typeof shown === "number") {
             // Rationale: at the end of the range there is nothing to say: the arrow already reads
             // as unavailable, so a message would only repeat it.
             const next = steppedValue(rangeOf(entry), shown, delta);
             if (next !== null)
-                this.#apply(entry, next);
+                this.#edits.apply(entry, next);
             return;
         }
         const choices = entry.choices;
@@ -827,82 +726,7 @@ export class SettingsApp {
             ? (delta > 0 ? 0 : choices.length - 1)
             : (current + delta + choices.length) % choices.length];
         if (next !== undefined)
-            this.#apply(entry, next);
-    }
-    #apply(entry, value) {
-        const key = `${entry.backend}:${entry.id}`;
-        const previous = this.#shownValue(entry);
-        const sequence = ++this.#editSequence;
-        // Invariant: shown immediately so the row never lags a keypress, and so the next press
-        // steps from here rather than from a value the source has not caught up to.
-        this.#pending.set(key, value);
-        void this.#session.change(entry.backend, entry.id, value).then(outcome => {
-            const failure = changeFailure(outcome);
-            if (failure !== null) {
-                if (this.#pending.get(key) === value)
-                    this.#pending.delete(key);
-                return;
-            }
-            if (previous !== null && previous !== value)
-                this.#recordUndo({ kind: "scalar", sequence, entry, previous });
-            // Concurrency: a later press may have moved on; only the last request clears itself.
-            if (this.#pending.get(key) === value)
-                this.#pending.delete(key);
-        });
-    }
-    #shownValue(entry) {
-        return this.#pending.get(`${entry.backend}:${entry.id}`) ?? entry.value;
-    }
-    #recordUndo(record) {
-        if (this.#closed)
-            return;
-        const after = this.#undoHistory.findIndex(candidate => candidate.sequence > record.sequence);
-        if (after < 0)
-            this.#undoHistory.push(record);
-        else
-            this.#undoHistory.splice(after, 0, record);
-    }
-    #undo() {
-        this.#undoRequests++;
-        this.#drainUndo();
-    }
-    #drainUndo() {
-        if (this.#undoActive || this.#undoRequests === 0)
-            return;
-        const record = this.#undoHistory.pop();
-        if (record === undefined) {
-            this.#undoRequests = 0;
-            return;
-        }
-        this.#undoRequests--;
-        this.#undoActive = true;
-        if (record.kind === "scalar") {
-            const key = `${record.entry.backend}:${record.entry.id}`;
-            this.#pending.set(key, record.previous);
-            void this.#session.change(record.entry.backend, record.entry.id, record.previous).then(outcome => {
-                if (this.#pending.get(key) === record.previous)
-                    this.#pending.delete(key);
-                this.#finishUndo(record, outcome);
-            });
-            return;
-        }
-        const open = this.#structured;
-        if (open !== null && sameEntry(open.entry, record.entry))
-            replaceRecord(open.record, record.previous);
-        void this.#session.changeStructured(record.entry.backend, record.entry.id, structuredValue(record.entry, record.previous)).then(outcome => {
-            const failure = changeFailure(outcome);
-            if (failure !== null && this.#structured === open && open !== null && sameRecord(open.record, record.previous)) {
-                replaceRecord(open.record, record.forward);
-            }
-            this.#finishUndo(record, outcome);
-        });
-    }
-    #finishUndo(record, outcome) {
-        const failure = changeFailure(outcome);
-        if (failure !== null)
-            this.#recordUndo(record);
-        this.#undoActive = false;
-        this.#drainUndo();
+            this.#edits.apply(entry, next);
     }
     #scrollbarSpeed() {
         const value = this.#scrollSetting("scrollbarSpeed");
@@ -920,7 +744,7 @@ export class SettingsApp {
         const entry = this.#session.sections()
             .flatMap(section => section.entries)
             .find(candidate => candidate.backend === "a1" && candidate.id === id);
-        return entry === undefined ? this.#session.value(id) : this.#shownValue(entry);
+        return entry === undefined ? this.#session.value(id) : this.#edits.shown(entry);
     }
     #jump(rows, target) {
         this.#select(rows, target);
@@ -992,7 +816,7 @@ export class SettingsApp {
     }
     #viewRow(entry) {
         const key = `${entry.backend}:${entry.id}`;
-        const shown = this.#shownValue(entry);
+        const shown = this.#edits.shown(entry);
         const value = entry.structured || isDefaultModelEntry(entry)
             ? CONFIGURE
             : shown === null
@@ -1018,7 +842,7 @@ export class SettingsApp {
             ...(menu.entry.id === "accentColor" ? {
                 previews: menu.choices.map(choice => theme.accentPreview?.(String(choice), "■") ?? ""),
             } : {}),
-            current: this.#shownValue(menu.entry) === null ? null : displaySettingValue(menu.entry, this.#shownValue(menu.entry)),
+            current: this.#edits.shown(menu.entry) === null ? null : displaySettingValue(menu.entry, this.#edits.shown(menu.entry)),
             index: menu.index,
         };
         const frame = valueMenuFrame(state, {
@@ -1036,8 +860,6 @@ export class SettingsApp {
     #dialogLines(open, width, height, theme) {
         if (open.modelDialog !== null)
             return this.#modelDialogLines(open, width, height, theme);
-        if (open.flagDialog !== null)
-            return open.flagDialog.lines(open.record, width, theme);
         const rows = open.flags.map(key => {
             const declared = open.entry.flags.find(flag => flag.key === key);
             return {
@@ -1111,8 +933,7 @@ export class SettingsApp {
     #footerLines(width, theme) {
         // Rationale: standing guidance is more useful than transient feedback; failures still
         // roll back without displacing the Settings interaction contract.
-        const entries = SETTINGS_SHORTCUTS.hintEntries(SCOPE).filter(entry => !this.#options.pinned
-            || entry.key !== DIALOG_CLOSE_SHORTCUT_HINT.key || entry.action !== DIALOG_CLOSE_SHORTCUT_HINT.action);
+        const entries = SETTINGS_SHORTCUTS.hintEntries(SCOPE);
         const status = renderShortcutHintsWithClose(entries, theme, width, width > 0 ? 1 : 0);
         const input = this.#search.input;
         if (input === null)
@@ -1183,36 +1004,6 @@ function thinkingLevelDescription(level) {
         default: return "";
     }
 }
-function structuredValue(entry, record) {
-    // Invariant: a choice part at its fallback is unset, so the engine's default applies.
-    return Object.fromEntries(Object.entries(record).filter(([key, value]) => {
-        const part = entry.flags.find(candidate => candidate.key === key);
-        return part?.choices === undefined || value !== part.fallback;
-    }));
-}
-function sameEntry(left, right) {
-    return left.backend === right.backend && left.id === right.id;
-}
-function sameRecord(left, right) {
-    const leftEntries = Object.entries(left);
-    const rightEntries = Object.entries(right);
-    return leftEntries.length === rightEntries.length
-        && leftEntries.every(([key, value]) => right[key] === value);
-}
-function replaceRecord(target, source) {
-    for (const key of Object.keys(target))
-        delete target[key];
-    Object.assign(target, source);
-}
-function changeFailure(outcome) {
-    if (outcome.failure !== null)
-        return outcome.failure;
-    if (outcome.status === "failed")
-        return "the effect failed";
-    if (outcome.status === "unavailable")
-        return outcome.limitationReason ?? "the setting is unavailable";
-    return outcome.limitationReason;
-}
 function isDefaultModelEntry(entry) {
     return entry.backend === "agent" && entry.id === "defaultModel";
 }
@@ -1224,11 +1015,8 @@ function labelOf(entry) {
 function rangeOf(entry) {
     return { minimum: entry.minimum, maximum: entry.maximum, values: numericValues(entry.choices) };
 }
-/** Booleans read as yes and no; time-format choices preview the current local time. */
-function displaySettingValue(entry, value) {
-    if (entry.backend === "a1" && entry.id === "timeFormat" && (value === "20:00" || value === "8:00 PM")) {
-        return formatLocalTime(new Date(), value) ?? value;
-    }
+/** Booleans read as yes and no. */
+function displaySettingValue(_entry, value) {
     if (typeof value === "boolean")
         return value ? "yes" : "no";
     return String(value);

package/dist/features/owned-ui/settings-edits.d.ts

@@ -0,0 +1,31 @@
+import type { OwnedUiSettingValue, OwnedUiSettingsChangeOutcome, OwnedUiSettingsEntry, OwnedSettingsManager } from "../../ui/settings/index.js";
+type SettingsRecord = Record<string, boolean | string>;
+/** The structured dialog an undo may need to roll back in place; null when none is open. */
+export interface OpenStructuredRecord {
+    readonly entry: OwnedUiSettingsEntry;
+    readonly record: SettingsRecord;
+}
+/**
+ * The settings screen's edits: values shown ahead of the source, and an undo history ordered by edit
+ * sequence. Undo requests drain one at a time so each restores against the result of the one before.
+ */
+export declare class SettingsEdits {
+    #private;
+    constructor(session: Pick<OwnedSettingsManager, "change" | "changeStructured">, openStructured: () => OpenStructuredRecord | null);
+    /** The value a row shows: a pending edit, or the source's value. */
+    shown(entry: OwnedUiSettingsEntry): OwnedUiSettingValue | null;
+    apply(entry: OwnedUiSettingsEntry, value: OwnedUiSettingValue): void;
+    /** Saves a structured dialog's record; `rollback` runs when the change fails. */
+    saveStructured(entry: OwnedUiSettingsEntry, previous: Readonly<SettingsRecord>, forward: Readonly<SettingsRecord>, rollback: () => void): void;
+    undo(): void;
+    open(): void;
+    /** Drops the history and queued requests; late results no longer record undo steps. */
+    close(): void;
+}
+/** The record the engine stores: a choice part at its fallback is unset, so the engine's default applies. */
+export declare function structuredValue(entry: OwnedUiSettingsEntry, record: Readonly<SettingsRecord>): SettingsRecord;
+export declare function sameRecord(left: Readonly<SettingsRecord>, right: Readonly<SettingsRecord>): boolean;
+export declare function replaceRecord(target: SettingsRecord, source: Readonly<SettingsRecord>): void;
+/** Why a change did not take effect, or null when it did. */
+export declare function changeFailure(outcome: OwnedUiSettingsChangeOutcome): string | null;
+export {};