@timmy6942025/cli-timer 1.1.4 → 1.1.6

package/README.md

@@ -116,3 +116,7 @@ Controls in settings UI:
 - `Esc`/`q`: back/cancel
 
 Note for macOS: If system notifications are inconsistent with built-in AppleScript notifications, install `terminal-notifier` (`brew install terminal-notifier`) for improved reliability.
+
+Notification notes by platform:
+- Windows: notifications depend on OS notification permissions and whether your desktop session allows toasts/balloons.
+- Linux: notifications require a running desktop notification daemon (`notify-send` talks to that daemon over D-Bus).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@timmy6942025/cli-timer",
-  "version": "1.1.4",
+  "version": "1.1.6",
   "description": "Simple customizable terminal timer and stopwatch",
   "main": "src/index.js",
   "bin": {

package/src/index.js

@@ -497,6 +497,56 @@ function sleepSync(ms) {
   }
 }
 
+function readProcessCommand(pid) {
+  try {
+    const result = spawnSync("ps", ["-p", String(pid), "-o", "comm="], { encoding: "utf8", stdio: "pipe" });
+    if (result.error || result.status !== 0) {
+      return "";
+    }
+    return String(result.stdout || "").trim();
+  } catch (_error) {
+    return "";
+  }
+}
+
+function resolveMacNotificationSenderCandidates() {
+  const candidates = [];
+  const explicit = String(process.env.CLI_TIMER_NOTIFICATION_SENDER || "").trim();
+  if (explicit) {
+    candidates.push(explicit);
+  }
+
+  const termProgram = String(process.env.TERM_PROGRAM || "").toLowerCase();
+  if (termProgram === "apple_terminal") {
+    candidates.push("com.apple.Terminal");
+  } else if (termProgram === "iterm.app") {
+    candidates.push("com.googlecode.iterm2");
+  } else if (termProgram === "vscode") {
+    candidates.push("com.microsoft.VSCode");
+  } else if (termProgram === "warpterminal" || termProgram === "warp") {
+    candidates.push("dev.warp.Warp-Stable");
+  }
+
+  const parentCommand = readProcessCommand(process.ppid).toLowerCase();
+  if (parentCommand.includes("terminal.app")) {
+    candidates.push("com.apple.Terminal");
+  }
+  if (parentCommand.includes("iterm")) {
+    candidates.push("com.googlecode.iterm2");
+  }
+  if (parentCommand.includes("warp")) {
+    candidates.push("dev.warp.Warp-Stable");
+  }
+  if (parentCommand.includes("visual studio code") || parentCommand.includes("vscode")) {
+    candidates.push("com.microsoft.VSCode");
+  }
+  if (parentCommand.includes("codex.app")) {
+    candidates.push("com.openai.codex");
+  }
+
+  return [...new Set(candidates)].filter(Boolean);
+}
+
 function terminalNotifierDelivered(groupId) {
   try {
     for (let attempt = 0; attempt < MAC_NOTIFICATION_VERIFY_ATTEMPTS; attempt += 1) {
@@ -514,8 +564,6 @@ function terminalNotifierDelivered(groupId) {
     return false;
   } catch (_error) {
     return false;
-  } finally {
-    spawnOk("terminal-notifier", ["-remove", groupId]);
   }
 }
 
@@ -529,12 +577,27 @@ function sendSystemNotification({ title, message }) {
 
   try {
     if (process.platform === "darwin") {
-      const groupId = `cli-timer-${Date.now()}-${Math.floor(Math.random() * 1e9)}`;
-      if (
-        spawnOk("terminal-notifier", ["-title", safeTitle, "-message", safeMessage, "-group", groupId, "-ignoreDnD"])
-      ) {
-        if (terminalNotifierDelivered(groupId)) {
-          return true;
+      const senderCandidates = resolveMacNotificationSenderCandidates();
+      const senderArgsSets = senderCandidates.map((bundleId) => ["-sender", bundleId]);
+      senderArgsSets.push([]);
+
+      for (const senderArgs of senderArgsSets) {
+        const groupId = `cli-timer-${Date.now()}-${Math.floor(Math.random() * 1e9)}`;
+        if (
+          spawnOk("terminal-notifier", [
+            "-title",
+            safeTitle,
+            "-message",
+            safeMessage,
+            "-group",
+            groupId,
+            "-ignoreDnD",
+            ...senderArgs
+          ])
+        ) {
+          if (terminalNotifierDelivered(groupId)) {
+            return true;
+          }
         }
       }
       const script = `display notification "${escapeAppleScriptString(safeMessage)}" with title "${escapeAppleScriptString(safeTitle)}"`;
@@ -548,26 +611,6 @@ function sendSystemNotification({ title, message }) {
       const titlePs = escapePowerShellSingleQuotedString(safeTitle);
       const messagePs = escapePowerShellSingleQuotedString(safeMessage);
 
-      const ps = [
-        "$ErrorActionPreference = 'Stop'",
-        "try {",
-        "  [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime] > $null",
-        "  $template = [Windows.UI.Notifications.ToastTemplateType]::ToastText02",
-        "  $xml = [Windows.UI.Notifications.ToastNotificationManager]::GetTemplateContent($template)",
-        "  $txt = $xml.GetElementsByTagName('text')",
-        `  $txt.Item(0).AppendChild($xml.CreateTextNode('${titlePs}')) > $null`,
-        `  $txt.Item(1).AppendChild($xml.CreateTextNode('${messagePs}')) > $null`,
-        "  $toast = [Windows.UI.Notifications.ToastNotification]::new($xml)",
-        "  $notifier = [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier('cli-timer')",
-        "  $notifier.Show($toast)",
-        "} catch { exit 1 }"
-      ].join("; ");
-
-      const powershellArgs = ["-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Sta", "-Command", ps];
-      if (spawnOk("powershell", powershellArgs, { windowsHide: true })) {
-        return true;
-      }
-
       const balloon = [
         "$ErrorActionPreference = 'Stop'",
         "try {",
@@ -593,13 +636,47 @@ function sendSystemNotification({ title, message }) {
         "-Command",
         balloon
       ];
-      return spawnOk("powershell", balloonArgs, { windowsHide: true });
+      if (spawnOk("powershell", balloonArgs, { windowsHide: true })) {
+        return true;
+      }
+
+      const ps = [
+        "$ErrorActionPreference = 'Stop'",
+        "try {",
+        "  [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime] > $null",
+        "  $template = [Windows.UI.Notifications.ToastTemplateType]::ToastText02",
+        "  $xml = [Windows.UI.Notifications.ToastNotificationManager]::GetTemplateContent($template)",
+        "  $txt = $xml.GetElementsByTagName('text')",
+        `  $txt.Item(0).AppendChild($xml.CreateTextNode('${titlePs}')) > $null`,
+        `  $txt.Item(1).AppendChild($xml.CreateTextNode('${messagePs}')) > $null`,
+        "  $toast = [Windows.UI.Notifications.ToastNotification]::new($xml)",
+        "  $notifier = [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier('cli-timer')",
+        "  $notifier.Show($toast)",
+        "} catch { exit 1 }"
+      ].join("; ");
+
+      const powershellArgs = ["-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Sta", "-Command", ps];
+      if (spawnOk("powershell", powershellArgs, { windowsHide: true })) {
+        return true;
+      }
+      return false;
     }
 
     if (process.platform === "linux") {
       if (spawnOk("termux-notification", ["--title", safeTitle, "--content", safeMessage])) {
         return true;
       }
+      if (
+        spawnOk("notify-send", [
+          "--app-name=cli-timer",
+          "--urgency=critical",
+          "--icon=dialog-information",
+          safeTitle,
+          safeMessage
+        ])
+      ) {
+        return true;
+      }
       if (spawnOk("notify-send", [safeTitle, safeMessage])) {
         return true;
       }