@timmo001/oxlint-rules 0.6.0 → 0.6.2

package/README.md

@@ -137,8 +137,9 @@ they only run when the consumer enables `typeAware`.
 
 - `no-raw-gh`: reports the raw `execute`, `json` and `stream` methods called on
   a `yield* Gh` binding from `@timmo001/effect-gh`, `Api.raw` from that package,
-  and any call whose first argument is `"gh"` or an array starting with `"gh"`,
-  such as `executor.run("gh", ...)` or `Bun.spawn(["gh", ...])`. Use the
+  and calls that launch gh: `"gh"` followed by its arguments, such as
+  `executor.run("gh", ...)`, or an argument array starting with `"gh"` passed
+  to a spawn, exec, run or command function, such as `Bun.spawn(["gh", ...])`. Use the
   package's typed operations, and add one to effect-gh when a command has none.
   effect-gh's own relative imports are not reported.
 - `no-try-catch-in-effect-generators`: diagnoses synchronous `try/catch` owned

package/dist/cli.js

@@ -3004,13 +3004,20 @@ function isYieldGh(sourceCode, node) {
 function isGhBinding(sourceCode, identifier) {
   return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
 }
-function isGhArgument(node) {
-  if (node?.type === "Literal")
-    return node.value === "gh";
-  if (node?.type !== "ArrayExpression")
+var launcherName = /spawn|exec|run|command/i;
+function calleeName(callee) {
+  if (callee.type === "Identifier")
+    return callee.name;
+  return staticMemberName(callee);
+}
+function launchesGh(node) {
+  const [command, argv] = node.arguments;
+  if (command?.type === "Literal")
+    return command.value === "gh" && argv !== undefined;
+  if (command?.type !== "ArrayExpression")
     return false;
-  const first = node.elements[0];
-  return first?.type === "Literal" && first.value === "gh";
+  const first = command.elements[0];
+  return first?.type === "Literal" && first.value === "gh" && launcherName.test(calleeName(node.callee) ?? "");
 }
 var noRawGhRule = defineRule24({
   meta: {
@@ -3040,7 +3047,7 @@ var noRawGhRule = defineRule24({
             return;
           }
         }
-        if (isGhArgument(node.arguments[0]))
+        if (launchesGh(node))
           context.report({ node, messageId: "spawnGh" });
       }
     };

package/dist/configs/recommended-effect.js

@@ -55,13 +55,20 @@ function isYieldGh(sourceCode, node) {
 function isGhBinding(sourceCode, identifier) {
   return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
 }
-function isGhArgument(node) {
-  if (node?.type === "Literal")
-    return node.value === "gh";
-  if (node?.type !== "ArrayExpression")
+var launcherName = /spawn|exec|run|command/i;
+function calleeName(callee) {
+  if (callee.type === "Identifier")
+    return callee.name;
+  return staticMemberName(callee);
+}
+function launchesGh(node) {
+  const [command, argv] = node.arguments;
+  if (command?.type === "Literal")
+    return command.value === "gh" && argv !== undefined;
+  if (command?.type !== "ArrayExpression")
     return false;
-  const first = node.elements[0];
-  return first?.type === "Literal" && first.value === "gh";
+  const first = command.elements[0];
+  return first?.type === "Literal" && first.value === "gh" && launcherName.test(calleeName(node.callee) ?? "");
 }
 var noRawGhRule = defineRule({
   meta: {
@@ -91,7 +98,7 @@ var noRawGhRule = defineRule({
             return;
           }
         }
-        if (isGhArgument(node.arguments[0]))
+        if (launchesGh(node))
           context.report({ node, messageId: "spawnGh" });
       }
     };

package/dist/effect/index.js

@@ -50,13 +50,20 @@ function isYieldGh(sourceCode, node) {
 function isGhBinding(sourceCode, identifier) {
   return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
 }
-function isGhArgument(node) {
-  if (node?.type === "Literal")
-    return node.value === "gh";
-  if (node?.type !== "ArrayExpression")
+var launcherName = /spawn|exec|run|command/i;
+function calleeName(callee) {
+  if (callee.type === "Identifier")
+    return callee.name;
+  return staticMemberName(callee);
+}
+function launchesGh(node) {
+  const [command, argv] = node.arguments;
+  if (command?.type === "Literal")
+    return command.value === "gh" && argv !== undefined;
+  if (command?.type !== "ArrayExpression")
     return false;
-  const first = node.elements[0];
-  return first?.type === "Literal" && first.value === "gh";
+  const first = command.elements[0];
+  return first?.type === "Literal" && first.value === "gh" && launcherName.test(calleeName(node.callee) ?? "");
 }
 var noRawGhRule = defineRule({
   meta: {
@@ -86,7 +93,7 @@ var noRawGhRule = defineRule({
             return;
           }
         }
-        if (isGhArgument(node.arguments[0]))
+        if (launchesGh(node))
           context.report({ node, messageId: "spawnGh" });
       }
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@timmo001/oxlint-rules",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "Shared Oxlint plugins and configs with optional Effect rules.",
   "type": "module",
   "license": "Apache-2.0",

package/src/effect/rules/no-raw-gh.ts

@@ -61,13 +61,35 @@ function isGhBinding(
   );
 }
 
-function isGhArgument(node: ESTree.Node | undefined): boolean {
-  if (node?.type === "Literal") return node.value === "gh";
+/** Callee names that take an argv array to launch, such as `Bun.spawn` or `execFileSync`. */
+const launcherName = /spawn|exec|run|command/i;
 
-  if (node?.type !== "ArrayExpression") return false;
-  const first = node.elements[0];
+function calleeName(callee: ESTree.Expression): string | null {
+  if (callee.type === "Identifier") return callee.name;
 
-  return first?.type === "Literal" && first.value === "gh";
+  return staticMemberName(callee);
+}
+
+/**
+ * Whether a call launches gh: `"gh"` followed by its argv, as in
+ * `run("gh", args)`, or an argv array starting with `"gh"` passed to a
+ * spawn, exec, run or command function. Recording argv, as in
+ * `calls.push(["gh", ...args])`, is not launching it.
+ */
+function launchesGh(node: ESTree.CallExpression): boolean {
+  const [command, argv] = node.arguments;
+
+  if (command?.type === "Literal")
+    return command.value === "gh" && argv !== undefined;
+
+  if (command?.type !== "ArrayExpression") return false;
+  const first = command.elements[0];
+
+  return (
+    first?.type === "Literal" &&
+    first.value === "gh" &&
+    launcherName.test(calleeName(node.callee) ?? "")
+  );
 }
 
 /** Route gh through effect-gh's typed operations instead of raw argv or direct spawns. */
@@ -118,8 +140,7 @@ export const noRawGhRule = defineRule({
           }
         }
 
-        if (isGhArgument(node.arguments[0]))
-          context.report({ node, messageId: "spawnGh" });
+        if (launchesGh(node)) context.report({ node, messageId: "spawnGh" });
       },
     };
   },