@timmo001/oxlint-rules 0.5.0 → 0.6.0

package/README.md

@@ -69,6 +69,19 @@ the package configs to merge into the target Oxlint config. Effect settings
 remain opt-in. It excludes tests and repository metadata, and refuses to
 replace an existing destination unless `--force` is passed.
 
+## Skills
+
+[`install-timmo-oxlint-rules`](skills/install-timmo-oxlint-rules/SKILL.md)
+guides agents through installing or copying these rules:
+
+```sh
+npx skills add timmo001/oxlint-rules --skill install-timmo-oxlint-rules
+```
+
+[`add-oxlint-rule`](skills/add-oxlint-rule/SKILL.md) and
+[`release-oxlint-rules`](skills/release-oxlint-rules/SKILL.md) are for
+maintaining this package.
+
 ## Rules
 
 ### `anti-slop` and `anti-slop-effect`
@@ -122,6 +135,12 @@ they only run when the consumer enables `typeAware`.
 
 ### `timmo-effect`
 
+- `no-raw-gh`: reports the raw `execute`, `json` and `stream` methods called on
+  a `yield* Gh` binding from `@timmo001/effect-gh`, `Api.raw` from that package,
+  and any call whose first argument is `"gh"` or an array starting with `"gh"`,
+  such as `executor.run("gh", ...)` or `Bun.spawn(["gh", ...])`. Use the
+  package's typed operations, and add one to effect-gh when a command has none.
+  effect-gh's own relative imports are not reported.
 - `no-try-catch-in-effect-generators`: diagnoses synchronous `try/catch` owned
   by generators passed directly to `Effect.gen` or the curried `Effect.fn`
   form. It leaves ordinary async polling, nested callback boundaries,
@@ -139,8 +158,7 @@ Initialise the upstream source and run the package checks:
 
 ```sh
 git submodule update --init --recursive
-mise run check
-mise run build
+mise run check ::: build
 mise run test:package
 npm pack --dry-run
 bunx jsr@0.14.3 publish --dry-run --allow-dirty

package/dist/cli.js

@@ -2985,8 +2985,71 @@ var recommended_default = recommended;
 // src/effect/index.ts
 import { eslintCompatPlugin as eslintCompatPlugin3 } from "@oxlint/plugins";
 
-// src/effect/rules/no-try-catch-in-effect-generators.ts
+// src/effect/rules/no-raw-gh.ts
 import { defineRule as defineRule24 } from "@oxlint/plugins";
+var PACKAGE = "@timmo001/effect-gh";
+var rawMethods = new Set(["execute", "json", "stream"]);
+function isEffectGhImport(sourceCode, identifier, name) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => {
+    if (definition.type !== "ImportBinding" || definition.parent?.type !== "ImportDeclaration" || definition.parent.source.value !== PACKAGE || definition.node.type !== "ImportSpecifier") {
+      return false;
+    }
+    const imported = definition.node.imported;
+    return (imported.type === "Identifier" ? imported.name : imported.value) === name;
+  }) ?? false;
+}
+function isYieldGh(sourceCode, node) {
+  return node?.type === "YieldExpression" && node.delegate && node.argument?.type === "Identifier" && isEffectGhImport(sourceCode, node.argument, "Gh");
+}
+function isGhBinding(sourceCode, identifier) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
+}
+function isGhArgument(node) {
+  if (node?.type === "Literal")
+    return node.value === "gh";
+  if (node?.type !== "ArrayExpression")
+    return false;
+  const first = node.elements[0];
+  return first?.type === "Literal" && first.value === "gh";
+}
+var noRawGhRule = defineRule24({
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Use @timmo001/effect-gh typed operations instead of the raw Gh methods, Api.raw, or spawning gh directly."
+    },
+    messages: {
+      rawGh: "Use a typed effect-gh operation instead of `Gh.{{method}}` with raw argv. Add one to effect-gh if the command has none.",
+      rawApi: "Use `Api.json`, `Api.pages`, `Api.empty`, `Api.text` or `Api.headers` instead of `Api.raw`, so the response is typed.",
+      spawnGh: "Run gh through a typed @timmo001/effect-gh operation instead of spawning it directly."
+    }
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        const callee = node.callee;
+        const method = staticMemberName(callee);
+        if (callee.type === "MemberExpression" && method !== null) {
+          const object = callee.object;
+          if (rawMethods.has(method) && (isYieldGh(context.sourceCode, object) || object.type === "Identifier" && isGhBinding(context.sourceCode, object))) {
+            context.report({ node, messageId: "rawGh", data: { method } });
+            return;
+          }
+          if (method === "raw" && object.type === "Identifier" && isEffectGhImport(context.sourceCode, object, "Api")) {
+            context.report({ node, messageId: "rawApi" });
+            return;
+          }
+        }
+        if (isGhArgument(node.arguments[0]))
+          context.report({ node, messageId: "spawnGh" });
+      }
+    };
+  }
+});
+
+// src/effect/rules/no-try-catch-in-effect-generators.ts
+import { defineRule as defineRule25 } from "@oxlint/plugins";
+
 // src/shared/effect.ts
 function isEffectImport(sourceCode, identifier, namespace) {
   const variable = resolveVariable(sourceCode, identifier);
@@ -3033,7 +3096,7 @@ function isRecognisedEffectGenerator(sourceCode, owner) {
   const factoryCall = parent.callee;
   return factoryCall.type === "CallExpression" && isEffectMethod(sourceCode, factoryCall.callee, "fn");
 }
-var noTryCatchInEffectGeneratorsRule = defineRule24({
+var noTryCatchInEffectGeneratorsRule = defineRule25({
   meta: {
     type: "problem",
     docs: {
@@ -3059,7 +3122,7 @@ var noTryCatchInEffectGeneratorsRule = defineRule24({
 });
 
 // src/effect/rules/prefer-platform-services.ts
-import { defineRule as defineRule25 } from "@oxlint/plugins";
+import { defineRule as defineRule26 } from "@oxlint/plugins";
 var moduleServices = new Map([
   ["child_process", "childProcess"],
   ["fs", "fileSystem"],
@@ -3072,7 +3135,7 @@ var bunServices = new Map([
   ["spawnSync", "childProcess"],
   ["write", "fileSystem"]
 ]);
-var preferPlatformServicesRule = defineRule25({
+var preferPlatformServicesRule = defineRule26({
   meta: {
     type: "suggestion",
     docs: {
@@ -3135,6 +3198,7 @@ var preferPlatformServicesRule = defineRule25({
 var timmoEffectPlugin = eslintCompatPlugin3({
   meta: { name: "timmo-effect" },
   rules: {
+    "no-raw-gh": noRawGhRule,
     "no-try-catch-in-effect-generators": noTryCatchInEffectGeneratorsRule,
     "prefer-platform-services": preferPlatformServicesRule
   }
@@ -3145,7 +3209,7 @@ var effect_default = timmoEffectPlugin;
 import { eslintCompatPlugin as eslintCompatPlugin4 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/effect/rules/no-manual-effect-error-tag.ts
-import { defineRule as defineRule26 } from "@oxlint/plugins";
+import { defineRule as defineRule27 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/effect/shared/tagged-values.ts
 var equalityOperators = new Set(["==", "===", "!=", "!=="]);
@@ -3192,7 +3256,7 @@ var isMatchPatternObject = (node) => {
 };
 
 // vendor/anti-slop/src/effect/rules/no-manual-effect-error-tag.ts
-var noManualEffectErrorTagRule = defineRule26({
+var noManualEffectErrorTagRule = defineRule27({
   meta: {
     type: "problem",
     docs: {
@@ -3229,8 +3293,8 @@ var noManualEffectErrorTagRule = defineRule26({
 });
 
 // vendor/anti-slop/src/effect/rules/no-manual-tag-comparison.ts
-import { defineRule as defineRule27 } from "@oxlint/plugins";
-var noManualTagComparisonRule = defineRule27({
+import { defineRule as defineRule28 } from "@oxlint/plugins";
+var noManualTagComparisonRule = defineRule28({
   meta: {
     type: "problem",
     docs: {
@@ -3260,8 +3324,8 @@ var noManualTagComparisonRule = defineRule27({
 });
 
 // vendor/anti-slop/src/effect/rules/no-manual-tagged-construction.ts
-import { defineRule as defineRule28 } from "@oxlint/plugins";
-var noManualTaggedConstructionRule = defineRule28({
+import { defineRule as defineRule29 } from "@oxlint/plugins";
+var noManualTaggedConstructionRule = defineRule29({
   meta: {
     type: "problem",
     docs: {
@@ -3286,7 +3350,7 @@ var noManualTaggedConstructionRule = defineRule28({
 });
 
 // vendor/anti-slop/src/effect/rules/no-service-constructor-imports.ts
-import { defineRule as defineRule29 } from "@oxlint/plugins";
+import { defineRule as defineRule30 } from "@oxlint/plugins";
 var SERVICE_CONSTRUCTOR_NAME = /^make[A-Z]/u;
 var TEST_FILE = /\.(?:test|spec)\.[cm]?[jt]sx?$/u;
 function isProjectLocalImport(source) {
@@ -3297,7 +3361,7 @@ function getImportedName(specifier) {
     return specifier.imported.name;
   return specifier.imported.value;
 }
-var noServiceConstructorImportsRule = defineRule29({
+var noServiceConstructorImportsRule = defineRule30({
   meta: {
     type: "problem",
     docs: {
@@ -3331,9 +3395,9 @@ var noServiceConstructorImportsRule = defineRule29({
 });
 
 // vendor/anti-slop/src/effect/rules/prefer-effect-match.ts
-import { defineRule as defineRule30 } from "@oxlint/plugins";
+import { defineRule as defineRule31 } from "@oxlint/plugins";
 var equalityOperators2 = new Set(["==", "===", "!=", "!=="]);
-var preferEffectMatchRule = defineRule30({
+var preferEffectMatchRule = defineRule31({
   meta: {
     type: "problem",
     docs: {

package/dist/configs/recommended-effect.js

@@ -6,7 +6,7 @@ function defineConfig(config) {
 // src/effect/index.ts
 import { eslintCompatPlugin } from "@oxlint/plugins";
 
-// src/effect/rules/no-try-catch-in-effect-generators.ts
+// src/effect/rules/no-raw-gh.ts
 import { defineRule } from "@oxlint/plugins";
 
 // src/shared/ast.ts
@@ -37,6 +37,70 @@ function resolveVariable(sourceCode, identifier) {
   }
   return null;
 }
+// src/effect/rules/no-raw-gh.ts
+var PACKAGE = "@timmo001/effect-gh";
+var rawMethods = new Set(["execute", "json", "stream"]);
+function isEffectGhImport(sourceCode, identifier, name) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => {
+    if (definition.type !== "ImportBinding" || definition.parent?.type !== "ImportDeclaration" || definition.parent.source.value !== PACKAGE || definition.node.type !== "ImportSpecifier") {
+      return false;
+    }
+    const imported = definition.node.imported;
+    return (imported.type === "Identifier" ? imported.name : imported.value) === name;
+  }) ?? false;
+}
+function isYieldGh(sourceCode, node) {
+  return node?.type === "YieldExpression" && node.delegate && node.argument?.type === "Identifier" && isEffectGhImport(sourceCode, node.argument, "Gh");
+}
+function isGhBinding(sourceCode, identifier) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
+}
+function isGhArgument(node) {
+  if (node?.type === "Literal")
+    return node.value === "gh";
+  if (node?.type !== "ArrayExpression")
+    return false;
+  const first = node.elements[0];
+  return first?.type === "Literal" && first.value === "gh";
+}
+var noRawGhRule = defineRule({
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Use @timmo001/effect-gh typed operations instead of the raw Gh methods, Api.raw, or spawning gh directly."
+    },
+    messages: {
+      rawGh: "Use a typed effect-gh operation instead of `Gh.{{method}}` with raw argv. Add one to effect-gh if the command has none.",
+      rawApi: "Use `Api.json`, `Api.pages`, `Api.empty`, `Api.text` or `Api.headers` instead of `Api.raw`, so the response is typed.",
+      spawnGh: "Run gh through a typed @timmo001/effect-gh operation instead of spawning it directly."
+    }
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        const callee = node.callee;
+        const method = staticMemberName(callee);
+        if (callee.type === "MemberExpression" && method !== null) {
+          const object = callee.object;
+          if (rawMethods.has(method) && (isYieldGh(context.sourceCode, object) || object.type === "Identifier" && isGhBinding(context.sourceCode, object))) {
+            context.report({ node, messageId: "rawGh", data: { method } });
+            return;
+          }
+          if (method === "raw" && object.type === "Identifier" && isEffectGhImport(context.sourceCode, object, "Api")) {
+            context.report({ node, messageId: "rawApi" });
+            return;
+          }
+        }
+        if (isGhArgument(node.arguments[0]))
+          context.report({ node, messageId: "spawnGh" });
+      }
+    };
+  }
+});
+
+// src/effect/rules/no-try-catch-in-effect-generators.ts
+import { defineRule as defineRule2 } from "@oxlint/plugins";
+
 // src/shared/effect.ts
 function isEffectImport(sourceCode, identifier, namespace) {
   const variable = resolveVariable(sourceCode, identifier);
@@ -83,7 +147,7 @@ function isRecognisedEffectGenerator(sourceCode, owner) {
   const factoryCall = parent.callee;
   return factoryCall.type === "CallExpression" && isEffectMethod(sourceCode, factoryCall.callee, "fn");
 }
-var noTryCatchInEffectGeneratorsRule = defineRule({
+var noTryCatchInEffectGeneratorsRule = defineRule2({
   meta: {
     type: "problem",
     docs: {
@@ -109,7 +173,7 @@ var noTryCatchInEffectGeneratorsRule = defineRule({
 });
 
 // src/effect/rules/prefer-platform-services.ts
-import { defineRule as defineRule2 } from "@oxlint/plugins";
+import { defineRule as defineRule3 } from "@oxlint/plugins";
 var moduleServices = new Map([
   ["child_process", "childProcess"],
   ["fs", "fileSystem"],
@@ -122,7 +186,7 @@ var bunServices = new Map([
   ["spawnSync", "childProcess"],
   ["write", "fileSystem"]
 ]);
-var preferPlatformServicesRule = defineRule2({
+var preferPlatformServicesRule = defineRule3({
   meta: {
     type: "suggestion",
     docs: {
@@ -185,6 +249,7 @@ var preferPlatformServicesRule = defineRule2({
 var timmoEffectPlugin = eslintCompatPlugin({
   meta: { name: "timmo-effect" },
   rules: {
+    "no-raw-gh": noRawGhRule,
     "no-try-catch-in-effect-generators": noTryCatchInEffectGeneratorsRule,
     "prefer-platform-services": preferPlatformServicesRule
   }
@@ -195,7 +260,7 @@ var effect_default = timmoEffectPlugin;
 import { eslintCompatPlugin as eslintCompatPlugin2 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/effect/rules/no-manual-effect-error-tag.ts
-import { defineRule as defineRule3 } from "@oxlint/plugins";
+import { defineRule as defineRule4 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/effect/shared/tagged-values.ts
 var equalityOperators = new Set(["==", "===", "!=", "!=="]);
@@ -242,7 +307,7 @@ var isMatchPatternObject = (node) => {
 };
 
 // vendor/anti-slop/src/effect/rules/no-manual-effect-error-tag.ts
-var noManualEffectErrorTagRule = defineRule3({
+var noManualEffectErrorTagRule = defineRule4({
   meta: {
     type: "problem",
     docs: {
@@ -279,8 +344,8 @@ var noManualEffectErrorTagRule = defineRule3({
 });
 
 // vendor/anti-slop/src/effect/rules/no-manual-tag-comparison.ts
-import { defineRule as defineRule4 } from "@oxlint/plugins";
-var noManualTagComparisonRule = defineRule4({
+import { defineRule as defineRule5 } from "@oxlint/plugins";
+var noManualTagComparisonRule = defineRule5({
   meta: {
     type: "problem",
     docs: {
@@ -310,8 +375,8 @@ var noManualTagComparisonRule = defineRule4({
 });
 
 // vendor/anti-slop/src/effect/rules/no-manual-tagged-construction.ts
-import { defineRule as defineRule5 } from "@oxlint/plugins";
-var noManualTaggedConstructionRule = defineRule5({
+import { defineRule as defineRule6 } from "@oxlint/plugins";
+var noManualTaggedConstructionRule = defineRule6({
   meta: {
     type: "problem",
     docs: {
@@ -336,7 +401,7 @@ var noManualTaggedConstructionRule = defineRule5({
 });
 
 // vendor/anti-slop/src/effect/rules/no-service-constructor-imports.ts
-import { defineRule as defineRule6 } from "@oxlint/plugins";
+import { defineRule as defineRule7 } from "@oxlint/plugins";
 var SERVICE_CONSTRUCTOR_NAME = /^make[A-Z]/u;
 var TEST_FILE = /\.(?:test|spec)\.[cm]?[jt]sx?$/u;
 function isProjectLocalImport(source) {
@@ -347,7 +412,7 @@ function getImportedName(specifier) {
     return specifier.imported.name;
   return specifier.imported.value;
 }
-var noServiceConstructorImportsRule = defineRule6({
+var noServiceConstructorImportsRule = defineRule7({
   meta: {
     type: "problem",
     docs: {
@@ -381,9 +446,9 @@ var noServiceConstructorImportsRule = defineRule6({
 });
 
 // vendor/anti-slop/src/effect/rules/prefer-effect-match.ts
-import { defineRule as defineRule7 } from "@oxlint/plugins";
+import { defineRule as defineRule8 } from "@oxlint/plugins";
 var equalityOperators2 = new Set(["==", "===", "!=", "!=="]);
-var preferEffectMatchRule = defineRule7({
+var preferEffectMatchRule = defineRule8({
   meta: {
     type: "problem",
     docs: {
@@ -449,7 +514,7 @@ function enablePluginRules(namespace, plugin) {
 import { eslintCompatPlugin as eslintCompatPlugin3 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/rules/no-array-filter-map.ts
-import { defineRule as defineRule8 } from "@oxlint/plugins";
+import { defineRule as defineRule9 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/shared/array-method.ts
 function unwrapArrayExpression(node) {
@@ -524,7 +589,7 @@ function isKnownArrayExpression(sourceCode, node, visited = new Set) {
 }
 
 // vendor/anti-slop/src/rules/no-array-filter-map.ts
-var noArrayFilterMapRule = defineRule8({
+var noArrayFilterMapRule = defineRule9({
   meta: {
     type: "suggestion",
     docs: { description: "Disallow adjacent array filter/map passes in favor of lazy iterator helpers or a single transformation." },
@@ -553,7 +618,7 @@ var noArrayFilterMapRule = defineRule8({
 });
 
 // vendor/anti-slop/src/rules/no-reduce-accumulator-copy.ts
-import { defineRule as defineRule9 } from "@oxlint/plugins";
+import { defineRule as defineRule10 } from "@oxlint/plugins";
 function enclosingReducer(node) {
   let parent = node.parent;
   while (parent !== null) {
@@ -603,7 +668,7 @@ function isGlobalCopyOwner(sourceCode, node, name) {
   const variable = resolveArrayBinding(sourceCode, node);
   return variable === null || variable.defs.length === 0;
 }
-var noReduceAccumulatorCopyRule = defineRule9({
+var noReduceAccumulatorCopyRule = defineRule10({
   meta: {
     type: "problem",
     docs: { description: "Disallow copying growing reducer accumulators with Object.assign, Array.from, or array copy methods." },
@@ -644,7 +709,7 @@ var noReduceAccumulatorCopyRule = defineRule9({
 });
 
 // vendor/anti-slop/src/rules/no-chained-type-assertions.ts
-import { defineRule as defineRule10 } from "@oxlint/plugins";
+import { defineRule as defineRule11 } from "@oxlint/plugins";
 function isTypeAssertionExpression(node) {
   return node.type === "TSAsExpression" || node.type === "TSTypeAssertion";
 }
@@ -679,7 +744,7 @@ function isForbiddenAssertionChain(node) {
   }
   return assertionCount > 1 && hasNonConstAssertion;
 }
-var noChainedTypeAssertionsRule = defineRule10({
+var noChainedTypeAssertionsRule = defineRule11({
   meta: {
     type: "problem",
     docs: {
@@ -703,7 +768,7 @@ var noChainedTypeAssertionsRule = defineRule10({
 });
 
 // vendor/anti-slop/src/rules/no-conditional-empty-object-spread.ts
-import { defineRule as defineRule11 } from "@oxlint/plugins";
+import { defineRule as defineRule12 } from "@oxlint/plugins";
 function unwrapParentheses(node) {
   let current = node;
   while (current.type === "ParenthesizedExpression") {
@@ -718,7 +783,7 @@ function isConditionalEmptyObjectSpread(node) {
   const conditional = unwrapParentheses(node);
   return conditional.type === "ConditionalExpression" && (isEmptyObjectExpression(conditional.consequent) || isEmptyObjectExpression(conditional.alternate));
 }
-var noConditionalEmptyObjectSpreadRule = defineRule11({
+var noConditionalEmptyObjectSpreadRule = defineRule12({
   meta: {
     type: "suggestion",
     docs: {
@@ -742,7 +807,7 @@ var noConditionalEmptyObjectSpreadRule = defineRule11({
 });
 
 // vendor/anti-slop/src/rules/no-known-value-widening.ts
-import { defineRule as defineRule12 } from "@oxlint/plugins";
+import { defineRule as defineRule13 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/shared/lexical-type-parameters.ts
 function isNode(value) {
@@ -1431,7 +1496,7 @@ function isDictionaryAccumulatorTarget(destination) {
 function hasParentAssertion(node) {
   return node.parent?.type === "TSAsExpression" || node.parent?.type === "TSTypeAssertion";
 }
-var noKnownValueWideningRule = defineRule12({
+var noKnownValueWideningRule = defineRule13({
   meta: {
     type: "problem",
     docs: {
@@ -1544,7 +1609,7 @@ var noKnownValueWideningRule = defineRule12({
 });
 
 // vendor/anti-slop/src/rules/no-module-mocking.ts
-import { defineRule as defineRule13 } from "@oxlint/plugins";
+import { defineRule as defineRule14 } from "@oxlint/plugins";
 var moduleMockMethods = new Set(["doMock", "mock", "unstable_mockModule"]);
 function importedName(node) {
   if (node.type !== "ImportSpecifier")
@@ -1579,7 +1644,7 @@ function moduleMockCall(sourceCode, callee) {
   const method = callee.computed ? property.type === "Literal" && (property.value === "doMock" || property.value === "mock" || property.value === "unstable_mockModule") ? property.value : null : property.type === "Identifier" ? property.name : null;
   return method !== null && moduleMockMethods.has(method);
 }
-var noModuleMockingRule = defineRule13({
+var noModuleMockingRule = defineRule14({
   meta: {
     type: "problem",
     docs: {
@@ -1603,8 +1668,8 @@ var noModuleMockingRule = defineRule13({
 });
 
 // vendor/anti-slop/src/rules/no-object-parameters.ts
-import { defineRule as defineRule14 } from "@oxlint/plugins";
-var noObjectParametersRule = defineRule14({
+import { defineRule as defineRule15 } from "@oxlint/plugins";
+var noObjectParametersRule = defineRule15({
   meta: {
     type: "problem",
     docs: {
@@ -1657,7 +1722,7 @@ var noObjectParametersRule = defineRule14({
 });
 
 // vendor/anti-slop/src/rules/no-reflect-apply.ts
-import { defineRule as defineRule15 } from "@oxlint/plugins";
+import { defineRule as defineRule16 } from "@oxlint/plugins";
 
 // vendor/anti-slop/src/shared/reflect-method.ts
 function isGlobalReflect(sourceCode, expression) {
@@ -1678,7 +1743,7 @@ function isGlobalReflectMethodCall(sourceCode, callee, methodName) {
 }
 
 // vendor/anti-slop/src/rules/no-reflect-apply.ts
-var noReflectApplyRule = defineRule15({
+var noReflectApplyRule = defineRule16({
   meta: {
     type: "problem",
     docs: {
@@ -1702,8 +1767,8 @@ var noReflectApplyRule = defineRule15({
 });
 
 // vendor/anti-slop/src/rules/no-reflect-get.ts
-import { defineRule as defineRule16 } from "@oxlint/plugins";
-var noReflectGetRule = defineRule16({
+import { defineRule as defineRule17 } from "@oxlint/plugins";
+var noReflectGetRule = defineRule17({
   meta: {
     type: "problem",
     docs: {
@@ -1727,7 +1792,7 @@ var noReflectGetRule = defineRule16({
 });
 
 // vendor/anti-slop/src/rules/no-runtime-typeof.ts
-import { defineRule as defineRule17 } from "@oxlint/plugins";
+import { defineRule as defineRule18 } from "@oxlint/plugins";
 function isRuntimeFunction(node) {
   return node.type === "ArrowFunctionExpression" || node.type === "FunctionDeclaration" || node.type === "FunctionExpression";
 }
@@ -1750,7 +1815,7 @@ function isExistenceProbe(node) {
   const other = parent.left === node ? parent.right : parent.left;
   return other.type === "Literal" && other.value === "undefined";
 }
-var noRuntimeTypeofRule = defineRule17({
+var noRuntimeTypeofRule = defineRule18({
   meta: {
     type: "problem",
     docs: {
@@ -1784,7 +1849,7 @@ var noRuntimeTypeofRule = defineRule17({
 });
 
 // vendor/anti-slop/src/rules/no-shape-in-symbol-names.ts
-import { defineRule as defineRule18 } from "@oxlint/plugins";
+import { defineRule as defineRule19 } from "@oxlint/plugins";
 var FORBIDDEN_SYMBOL_NAME = "shape";
 function containsForbiddenSymbolName(name) {
   return name.toLowerCase().includes(FORBIDDEN_SYMBOL_NAME);
@@ -1795,7 +1860,7 @@ function isBorrowedMemberName(node) {
     return false;
   return parent.property === node && parent.computed === false;
 }
-var noForbiddenTermInSymbolNamesRule = defineRule18({
+var noForbiddenTermInSymbolNamesRule = defineRule19({
   meta: {
     type: "problem",
     docs: {
@@ -1824,12 +1889,12 @@ var noForbiddenTermInSymbolNamesRule = defineRule18({
 });
 
 // vendor/anti-slop/src/rules/no-unknown-parameters.ts
-import { defineRule as defineRule19 } from "@oxlint/plugins";
+import { defineRule as defineRule20 } from "@oxlint/plugins";
 function isTypePredicateSubject(owner, parameterName) {
   const predicate = owner.returnType?.typeAnnotation;
   return predicate?.type === "TSTypePredicate" && predicate.parameterName.type === "Identifier" && predicate.parameterName.name === parameterName;
 }
-var noUnknownParametersRule = defineRule19({
+var noUnknownParametersRule = defineRule20({
   meta: {
     type: "problem",
     docs: {
@@ -1873,8 +1938,8 @@ var noUnknownParametersRule = defineRule19({
 });
 
 // vendor/anti-slop/src/rules/no-unknown-returns.ts
-import { defineRule as defineRule20 } from "@oxlint/plugins";
-var noUnknownReturnsRule = defineRule20({
+import { defineRule as defineRule21 } from "@oxlint/plugins";
+var noUnknownReturnsRule = defineRule21({
   meta: {
     type: "problem",
     docs: {
@@ -1927,8 +1992,8 @@ var noUnknownReturnsRule = defineRule20({
 });
 
 // vendor/anti-slop/src/rules/no-unknown-type-aliases.ts
-import { defineRule as defineRule21 } from "@oxlint/plugins";
-var noUnknownTypeAliasesRule = defineRule21({
+import { defineRule as defineRule22 } from "@oxlint/plugins";
+var noUnknownTypeAliasesRule = defineRule22({
   meta: {
     type: "problem",
     docs: {
@@ -1966,7 +2031,7 @@ var noUnknownTypeAliasesRule = defineRule21({
 });
 
 // vendor/anti-slop/src/rules/no-unsafe-dictionary-type.ts
-import { defineRule as defineRule22 } from "@oxlint/plugins";
+import { defineRule as defineRule23 } from "@oxlint/plugins";
 var typeNodeKinds = new Set([
   "JSDocNonNullableType",
   "JSDocNullableType",
@@ -2053,7 +2118,7 @@ function shouldReportType(node, environment) {
   }
   return true;
 }
-var noUnsafeDictionaryTypeRule = defineRule22({
+var noUnsafeDictionaryTypeRule = defineRule23({
   meta: {
     type: "problem",
     docs: {
@@ -2095,7 +2160,7 @@ var noUnsafeDictionaryTypeRule = defineRule22({
 });
 
 // vendor/anti-slop/src/rules/no-widen-then-assert.ts
-import { defineRule as defineRule23 } from "@oxlint/plugins";
+import { defineRule as defineRule24 } from "@oxlint/plugins";
 var functionBoundaryTypes = new Set([
   "ArrowFunctionExpression",
   "FunctionDeclaration",
@@ -2291,7 +2356,7 @@ function assertionIsNarrower(sourceText, broadKind, evidence, assertedType) {
     return isDefinitelyObjectType(assertedType);
   return isDefinitelyNarrowerRecordType(assertedType);
 }
-var noWidenThenAssertRule = defineRule23({
+var noWidenThenAssertRule = defineRule24({
   meta: {
     type: "problem",
     docs: {
@@ -2853,7 +2918,7 @@ var requireReadableSpacingRule = {
 };
 
 // vendor/anti-slop/src/rules/require-safety-comment-for-type-assertion.ts
-import { defineRule as defineRule24 } from "@oxlint/plugins";
+import { defineRule as defineRule25 } from "@oxlint/plugins";
 var DEFAULT_SAFETY_MARKERS = ["SAFETY"];
 var commentOwnerKinds = new Set([
   "ExpressionStatement",
@@ -2896,7 +2961,7 @@ function hasSafetyComment(sourceCode, node, pattern) {
     current = current.parent;
   }
 }
-var requireSafetyCommentForTypeAssertionRule = defineRule24({
+var requireSafetyCommentForTypeAssertionRule = defineRule25({
   meta: {
     type: "problem",
     docs: {
@@ -2974,7 +3039,7 @@ var src_default = antiSlopPlugin;
 import { eslintCompatPlugin as eslintCompatPlugin4 } from "@oxlint/plugins";
 
 // src/generic/rules/no-explicit-inferable-type-predicate.ts
-import { defineRule as defineRule25 } from "@oxlint/plugins";
+import { defineRule as defineRule26 } from "@oxlint/plugins";
 function isNamed(node, name) {
   return node.type === "Identifier" && node.name === name;
 }
@@ -3014,7 +3079,7 @@ function isPublicSignature(owner) {
   }
   return parent.type === "VariableDeclarator" && parent.parent.parent?.type === "ExportNamedDeclaration";
 }
-var noExplicitInferableTypePredicateRule = defineRule25({
+var noExplicitInferableTypePredicateRule = defineRule26({
   meta: {
     type: "suggestion",
     docs: {
@@ -3050,7 +3115,7 @@ var noExplicitInferableTypePredicateRule = defineRule25({
 });
 
 // src/generic/rules/no-unchecked-query-selector-type.ts
-import { defineRule as defineRule26 } from "@oxlint/plugins";
+import { defineRule as defineRule27 } from "@oxlint/plugins";
 
 // src/shared/json.ts
 function jsonObject(value) {
@@ -3151,7 +3216,7 @@ function isLitRenderRootQuery(node, bases) {
 
 // src/generic/rules/no-unchecked-query-selector-type.ts
 var queryMethods = new Set(["closest", "querySelector", "querySelectorAll"]);
-var noUncheckedQuerySelectorTypeRule = defineRule26({
+var noUncheckedQuerySelectorTypeRule = defineRule27({
   meta: {
     type: "problem",
     docs: {
@@ -3180,8 +3245,8 @@ var noUncheckedQuerySelectorTypeRule = defineRule26({
 });
 
 // src/generic/rules/no-untyped-custom-event.ts
-import { defineRule as defineRule27 } from "@oxlint/plugins";
-var noUntypedCustomEventRule = defineRule27({
+import { defineRule as defineRule28 } from "@oxlint/plugins";
+var noUntypedCustomEventRule = defineRule28({
   meta: {
     type: "problem",
     docs: {
@@ -3204,7 +3269,7 @@ var noUntypedCustomEventRule = defineRule27({
 });
 
 // src/generic/rules/prefer-event-parameter-type.ts
-import { defineRule as defineRule28 } from "@oxlint/plugins";
+import { defineRule as defineRule29 } from "@oxlint/plugins";
 function staticMemberPath(node) {
   const path = [];
   let current = node.type === "ChainExpression" ? node.expression : node;
@@ -3236,7 +3301,7 @@ function assertedEventParameter(node) {
     property: member.path.join(".")
   };
 }
-var preferEventParameterTypeRule = defineRule28({
+var preferEventParameterTypeRule = defineRule29({
   meta: {
     type: "suggestion",
     docs: {
@@ -3265,14 +3330,14 @@ var preferEventParameterTypeRule = defineRule28({
 });
 
 // src/generic/rules/prefer-lit-query-decorators.ts
-import { defineRule as defineRule29 } from "@oxlint/plugins";
+import { defineRule as defineRule30 } from "@oxlint/plugins";
 var messageIds = {
   assignedElements: "preferQueryAssignedElements",
   assignedNodes: "preferQueryAssignedNodes",
   querySelector: "preferQuery",
   querySelectorAll: "preferQueryAll"
 };
-var preferLitQueryDecoratorsRule = defineRule29({
+var preferLitQueryDecoratorsRule = defineRule30({
   meta: {
     type: "suggestion",
     docs: {
@@ -3325,8 +3390,8 @@ var preferLitQueryDecoratorsRule = defineRule29({
 });
 
 // src/generic/rules/prefer-types-over-assertions.ts
-import { defineRule as defineRule30 } from "@oxlint/plugins";
-var preferTypesOverAssertionsRule = defineRule30({
+import { defineRule as defineRule31 } from "@oxlint/plugins";
+var preferTypesOverAssertionsRule = defineRule31({
   meta: {
     type: "problem",
     docs: {

package/dist/effect/index.js

@@ -1,7 +1,7 @@
 // src/effect/index.ts
 import { eslintCompatPlugin } from "@oxlint/plugins";
 
-// src/effect/rules/no-try-catch-in-effect-generators.ts
+// src/effect/rules/no-raw-gh.ts
 import { defineRule } from "@oxlint/plugins";
 
 // src/shared/ast.ts
@@ -32,6 +32,70 @@ function resolveVariable(sourceCode, identifier) {
   }
   return null;
 }
+// src/effect/rules/no-raw-gh.ts
+var PACKAGE = "@timmo001/effect-gh";
+var rawMethods = new Set(["execute", "json", "stream"]);
+function isEffectGhImport(sourceCode, identifier, name) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => {
+    if (definition.type !== "ImportBinding" || definition.parent?.type !== "ImportDeclaration" || definition.parent.source.value !== PACKAGE || definition.node.type !== "ImportSpecifier") {
+      return false;
+    }
+    const imported = definition.node.imported;
+    return (imported.type === "Identifier" ? imported.name : imported.value) === name;
+  }) ?? false;
+}
+function isYieldGh(sourceCode, node) {
+  return node?.type === "YieldExpression" && node.delegate && node.argument?.type === "Identifier" && isEffectGhImport(sourceCode, node.argument, "Gh");
+}
+function isGhBinding(sourceCode, identifier) {
+  return resolveVariable(sourceCode, identifier)?.defs.some((definition) => definition.type === "Variable" && definition.node.type === "VariableDeclarator" && isYieldGh(sourceCode, definition.node.init)) ?? false;
+}
+function isGhArgument(node) {
+  if (node?.type === "Literal")
+    return node.value === "gh";
+  if (node?.type !== "ArrayExpression")
+    return false;
+  const first = node.elements[0];
+  return first?.type === "Literal" && first.value === "gh";
+}
+var noRawGhRule = defineRule({
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Use @timmo001/effect-gh typed operations instead of the raw Gh methods, Api.raw, or spawning gh directly."
+    },
+    messages: {
+      rawGh: "Use a typed effect-gh operation instead of `Gh.{{method}}` with raw argv. Add one to effect-gh if the command has none.",
+      rawApi: "Use `Api.json`, `Api.pages`, `Api.empty`, `Api.text` or `Api.headers` instead of `Api.raw`, so the response is typed.",
+      spawnGh: "Run gh through a typed @timmo001/effect-gh operation instead of spawning it directly."
+    }
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        const callee = node.callee;
+        const method = staticMemberName(callee);
+        if (callee.type === "MemberExpression" && method !== null) {
+          const object = callee.object;
+          if (rawMethods.has(method) && (isYieldGh(context.sourceCode, object) || object.type === "Identifier" && isGhBinding(context.sourceCode, object))) {
+            context.report({ node, messageId: "rawGh", data: { method } });
+            return;
+          }
+          if (method === "raw" && object.type === "Identifier" && isEffectGhImport(context.sourceCode, object, "Api")) {
+            context.report({ node, messageId: "rawApi" });
+            return;
+          }
+        }
+        if (isGhArgument(node.arguments[0]))
+          context.report({ node, messageId: "spawnGh" });
+      }
+    };
+  }
+});
+
+// src/effect/rules/no-try-catch-in-effect-generators.ts
+import { defineRule as defineRule2 } from "@oxlint/plugins";
+
 // src/shared/effect.ts
 function isEffectImport(sourceCode, identifier, namespace) {
   const variable = resolveVariable(sourceCode, identifier);
@@ -78,7 +142,7 @@ function isRecognisedEffectGenerator(sourceCode, owner) {
   const factoryCall = parent.callee;
   return factoryCall.type === "CallExpression" && isEffectMethod(sourceCode, factoryCall.callee, "fn");
 }
-var noTryCatchInEffectGeneratorsRule = defineRule({
+var noTryCatchInEffectGeneratorsRule = defineRule2({
   meta: {
     type: "problem",
     docs: {
@@ -104,7 +168,7 @@ var noTryCatchInEffectGeneratorsRule = defineRule({
 });
 
 // src/effect/rules/prefer-platform-services.ts
-import { defineRule as defineRule2 } from "@oxlint/plugins";
+import { defineRule as defineRule3 } from "@oxlint/plugins";
 var moduleServices = new Map([
   ["child_process", "childProcess"],
   ["fs", "fileSystem"],
@@ -117,7 +181,7 @@ var bunServices = new Map([
   ["spawnSync", "childProcess"],
   ["write", "fileSystem"]
 ]);
-var preferPlatformServicesRule = defineRule2({
+var preferPlatformServicesRule = defineRule3({
   meta: {
     type: "suggestion",
     docs: {
@@ -180,6 +244,7 @@ var preferPlatformServicesRule = defineRule2({
 var timmoEffectPlugin = eslintCompatPlugin({
   meta: { name: "timmo-effect" },
   rules: {
+    "no-raw-gh": noRawGhRule,
     "no-try-catch-in-effect-generators": noTryCatchInEffectGeneratorsRule,
     "prefer-platform-services": preferPlatformServicesRule
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@timmo001/oxlint-rules",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "Shared Oxlint plugins and configs with optional Effect rules.",
   "type": "module",
   "license": "Apache-2.0",
@@ -38,24 +38,25 @@
   ],
   "scripts": {
     "build": "bun run scripts/build.ts",
-    "check": "bun run lint && bun run test && bun run typecheck && bun run format:check && bun run skills:validate",
+    "check": "bun run --parallel --no-exit-on-error lint test typecheck format:check skills:validate",
     "format": "prettier --write \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.ts\" \"*.md\" \"*.json\"",
     "format:check": "prettier --check \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.ts\" \"*.md\" \"*.json\"",
-    "lint": "bun run build && oxlint --disable-nested-config .",
-    "skills:validate": "bunx skills-ref validate skills/install-timmo-oxlint-rules && bunx skills-ref validate skills/add-oxlint-rule && bunx skills-ref validate skills/release-oxlint-rules",
+    "lint": "bun run build && bun run lint:oxlint",
+    "lint:oxlint": "oxlint --disable-nested-config .",
+    "skills:validate": "printf '%s\\n' skills/*/ | xargs -P 0 -n 1 skills-ref validate",
     "test": "node --experimental-strip-types scripts/test.ts",
     "test:package": "node --experimental-strip-types scripts/test-package.ts",
     "typecheck": "tsc --noEmit"
   },
   "peerDependencies": {
-    "@oxlint/plugins": "1.86.0",
-    "oxlint": "1.86.0"
+    "@oxlint/plugins": "1.87.0",
+    "oxlint": "1.87.0"
   },
   "devDependencies": {
-    "@oxlint/plugins": "1.86.0",
+    "@oxlint/plugins": "1.87.0",
     "@types/bun": "^1.3.14",
-    "oxlint": "1.86.0",
-    "oxlint-tsgolint": "7.0.2003",
+    "oxlint": "1.87.0",
+    "oxlint-tsgolint": "7.0.2004",
     "prettier": "^3.9.5",
     "skills-ref": "0.1.5",
     "typescript": "^7.0.0"

package/skills/install-timmo-oxlint-rules/SKILL.md

@@ -32,10 +32,8 @@ description: >-
    instead only when `effect` is a direct dependency or the user explicitly
    requests it.
 4. Keep dependency and config edits visible. Do not delegate them to a script.
-5. For type-aware linting, explicitly pin the latest `oxlint-tsgolint` that
-   satisfies Oxlint's peer requirement and was validated with the rules release.
-   Enable `options.typeAware` in the target config and verify type-aware linting
-   alongside the shared rules.
+5. Explicitly pin the latest `oxlint-tsgolint` that satisfies Oxlint's peer
+   requirement and was validated with the rules release.
 
 ## Copy rules
 
@@ -51,8 +49,23 @@ description: >-
    output as authoritative rather than maintaining plugin or rule inventories
    in this skill.
 
+## Strictness
+
+1. Start with every strictness option in the target config's `options`:
+   `typeAware: true`, `typeCheck: true`, and `maxWarnings: 0`. Keep them in the
+   config rather than as lint script flags, and remove any existing
+   `--type-aware`, `--type-check`, `--deny-warnings`, or `--max-warnings` flags
+   so the config is the single source.
+2. Run the target's lint command. If it passes, keep every option.
+3. If it fails, group the failures by cause and the option that raises them,
+   then ask one structured question: fix the failures, or drop the smallest set
+   of options that makes lint pass (`typeCheck` first, then `maxWarnings`, then
+   `typeAware`). Recommend the reduction that keeps the most strictness, and name
+   any shared cause, such as a missing declaration in an upstream package, that
+   a follow-up could fix for every consumer.
+
 Run the target repository's lint command to verify the configuration loads, plus
 any checks explicitly required by that repository. Run typechecks, tests, or a
 build only when code or dependencies changed in a way those checks cover. Report
 package-manager changes, preserved local configuration, enabled rule groups,
-and checks.
+strictness options kept or dropped, and checks.

package/src/effect/index.ts

@@ -1,11 +1,13 @@
 import { eslintCompatPlugin } from "@oxlint/plugins";
 
+import { noRawGhRule } from "./rules/no-raw-gh.ts";
 import { noTryCatchInEffectGeneratorsRule } from "./rules/no-try-catch-in-effect-generators.ts";
 import { preferPlatformServicesRule } from "./rules/prefer-platform-services.ts";
 
 const timmoEffectPlugin = eslintCompatPlugin({
   meta: { name: "timmo-effect" },
   rules: {
+    "no-raw-gh": noRawGhRule,
     "no-try-catch-in-effect-generators": noTryCatchInEffectGeneratorsRule,
     "prefer-platform-services": preferPlatformServicesRule,
   },

package/src/effect/rules/no-raw-gh.ts

@@ -0,0 +1,126 @@
+import { defineRule } from "@oxlint/plugins";
+
+import { staticMemberName } from "../../shared/ast.ts";
+import { resolveVariable } from "../../shared/scope.ts";
+
+import type { ESTree, SourceCode } from "@oxlint/plugins";
+
+const PACKAGE = "@timmo001/effect-gh";
+
+const rawMethods = new Set(["execute", "json", "stream"]);
+
+/** Whether an identifier is bound by a named import of `name` from effect-gh. */
+function isEffectGhImport(
+  sourceCode: SourceCode,
+  identifier: ESTree.IdentifierReference,
+  name: string,
+): boolean {
+  return (
+    resolveVariable(sourceCode, identifier)?.defs.some((definition) => {
+      if (
+        definition.type !== "ImportBinding" ||
+        definition.parent?.type !== "ImportDeclaration" ||
+        definition.parent.source.value !== PACKAGE ||
+        definition.node.type !== "ImportSpecifier"
+      ) {
+        return false;
+      }
+
+      const imported = definition.node.imported;
+
+      return (
+        (imported.type === "Identifier" ? imported.name : imported.value) ===
+        name
+      );
+    }) ?? false
+  );
+}
+
+/** Whether an expression is `yield* Gh` with Gh from effect-gh. */
+function isYieldGh(sourceCode: SourceCode, node: ESTree.Node | null): boolean {
+  return (
+    node?.type === "YieldExpression" &&
+    node.delegate &&
+    node.argument?.type === "Identifier" &&
+    isEffectGhImport(sourceCode, node.argument, "Gh")
+  );
+}
+
+/** Whether an identifier is a variable initialised with `yield* Gh`. */
+function isGhBinding(
+  sourceCode: SourceCode,
+  identifier: ESTree.IdentifierReference,
+): boolean {
+  return (
+    resolveVariable(sourceCode, identifier)?.defs.some(
+      (definition) =>
+        definition.type === "Variable" &&
+        definition.node.type === "VariableDeclarator" &&
+        isYieldGh(sourceCode, definition.node.init),
+    ) ?? false
+  );
+}
+
+function isGhArgument(node: ESTree.Node | undefined): boolean {
+  if (node?.type === "Literal") return node.value === "gh";
+
+  if (node?.type !== "ArrayExpression") return false;
+  const first = node.elements[0];
+
+  return first?.type === "Literal" && first.value === "gh";
+}
+
+/** Route gh through effect-gh's typed operations instead of raw argv or direct spawns. */
+export const noRawGhRule = defineRule({
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Use @timmo001/effect-gh typed operations instead of the raw Gh methods, Api.raw, or spawning gh directly.",
+    },
+    messages: {
+      rawGh:
+        "Use a typed effect-gh operation instead of `Gh.{{method}}` with raw argv. Add one to effect-gh if the command has none.",
+      rawApi:
+        "Use `Api.json`, `Api.pages`, `Api.empty`, `Api.text` or `Api.headers` instead of `Api.raw`, so the response is typed.",
+      spawnGh:
+        "Run gh through a typed @timmo001/effect-gh operation instead of spawning it directly.",
+    },
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        const callee = node.callee;
+        const method = staticMemberName(callee);
+
+        if (callee.type === "MemberExpression" && method !== null) {
+          const object = callee.object;
+
+          if (
+            rawMethods.has(method) &&
+            (isYieldGh(context.sourceCode, object) ||
+              (object.type === "Identifier" &&
+                isGhBinding(context.sourceCode, object)))
+          ) {
+            context.report({ node, messageId: "rawGh", data: { method } });
+
+            return;
+          }
+
+          if (
+            method === "raw" &&
+            object.type === "Identifier" &&
+            isEffectGhImport(context.sourceCode, object, "Api")
+          ) {
+            context.report({ node, messageId: "rawApi" });
+
+            return;
+          }
+        }
+
+        if (isGhArgument(node.arguments[0]))
+          context.report({ node, messageId: "spawnGh" });
+      },
+    };
+  },
+});