@timmo001/oxlint-rules 0.3.3 → 0.3.5

package/README.md

@@ -87,6 +87,17 @@ npm pack --dry-run
 bunx jsr publish --dry-run
 ```
 
+`bun run lint` builds the local plugins before linting all maintained code,
+including tests, tooling, the root config and packaged skill scripts. The root
+config extends the local `recommended-effect` source config, enabling every
+registered rule in `anti-slop`, `timmo`, `anti-slop-effect` and `timmo-effect`.
+Plugin imports resolve through this package's exports to the fresh `dist` build.
+
+Lint disables nested configs so the vendored submodule's config cannot override
+the root exclusions. Generated output, vendored source and agent directories
+remain excluded. RuleTester fixture strings retain their intentional violations;
+the surrounding test code is linted with the full rule set.
+
 Advance `vendor/anti-slop` only by updating its Git submodule commit. Keep its
 source and MIT licence unchanged, then run the full package checks so both
 upstream exports and composed configs are verified.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@timmo001/oxlint-rules",
-  "version": "0.3.3",
+  "version": "0.3.5",
   "description": "Shared Oxlint plugins and configs with optional Effect rules.",
   "type": "module",
   "license": "Apache-2.0",
@@ -36,22 +36,22 @@
   ],
   "scripts": {
     "build": "bun run scripts/build.ts",
-    "check": "bun run build && bun run test && bun run lint && bun run typecheck && bun run format:check && bun run skills:validate",
-    "format": "prettier --write \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.md\" \"*.json\"",
-    "format:check": "prettier --check \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.md\" \"*.json\"",
-    "lint": "oxlint src scripts",
+    "check": "bun run lint && bun run test && bun run typecheck && bun run format:check && bun run skills:validate",
+    "format": "prettier --write \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.ts\" \"*.md\" \"*.json\"",
+    "format:check": "prettier --check \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.ts\" \"*.md\" \"*.json\"",
+    "lint": "bun run build && oxlint --disable-nested-config .",
     "skills:validate": "bunx skills-ref validate skills/install-timmo-oxlint-rules && bunx skills-ref validate skills/add-oxlint-rule && bunx skills-ref validate skills/release-oxlint-rules",
     "test": "node --experimental-strip-types scripts/test.ts",
     "typecheck": "tsc --noEmit"
   },
   "peerDependencies": {
-    "@oxlint/plugins": "1.82.0",
-    "oxlint": "1.82.0"
+    "@oxlint/plugins": "1.83.0",
+    "oxlint": "1.83.0"
   },
   "devDependencies": {
-    "@oxlint/plugins": "1.82.0",
+    "@oxlint/plugins": "1.83.0",
     "@types/bun": "^1.3.14",
-    "oxlint": "1.82.0",
+    "oxlint": "1.83.0",
     "prettier": "^3.9.5",
     "skills-ref": "0.1.5",
     "typescript": "^7.0.0"

package/skills/install-timmo-oxlint-rules/SKILL.md

@@ -43,6 +43,8 @@ description: >-
    output as authoritative rather than maintaining plugin or rule inventories
    in this skill.
 
-Run the target repository's normal lint, typecheck, tests, and build. Report
+Run the target repository's lint command to verify the configuration loads, plus
+any checks explicitly required by that repository. Run typechecks, tests, or a
+build only when code or dependencies changed in a way those checks cover. Report
 package-manager changes, preserved local configuration, enabled rule groups,
 and checks.

package/skills/install-timmo-oxlint-rules/scripts/copy.mjs

@@ -2,7 +2,9 @@
 import { spawnSync } from "node:child_process";
 
 const [runner, ...copyArguments] = process.argv.slice(2);
+
 const packageName = "@timmo001/oxlint-rules";
+
 const commands = {
   bun: ["bunx", packageName, "copy", ...copyArguments],
   npm: [
@@ -20,11 +22,14 @@ const commands = {
 };
 
 const command = commands[runner];
+
 if (!command) {
   console.error("Usage: copy.mjs <bun|npm|pnpm|yarn> <destination> [--force]");
   process.exit(1);
 }
 
 const result = spawnSync(command[0], command.slice(1), { stdio: "inherit" });
+
 if (result.error) throw result.error;
+
 process.exit(result.status ?? 1);

package/src/effect/rules/no-try-catch-in-effect-generators.ts

@@ -9,16 +9,20 @@ function resolveVariable(
   identifier: ESTree.IdentifierReference,
 ): Variable | null {
   let scope: Scope | null = sourceCode.getScope(identifier);
+
   while (scope) {
     const variable = scope.set.get(identifier.name);
+
     if (variable) return variable;
     scope = scope.upper;
   }
+
   return null;
 }
 
 function nearestEnclosingFunction(node: ESTree.Node): FunctionNode | null {
   let current: ESTree.Node | null = node.parent;
+
   while (current) {
     if (
       current.type === "FunctionDeclaration" ||
@@ -27,13 +31,16 @@ function nearestEnclosingFunction(node: ESTree.Node): FunctionNode | null {
     ) {
       return current;
     }
+
     current = current.parent;
   }
+
   return null;
 }
 
 function staticMemberName(node: ESTree.Expression): string | null {
   if (node.type !== "MemberExpression" || node.computed) return null;
+
   return node.property.type === "Identifier" ? node.property.name : null;
 }
 
@@ -43,6 +50,7 @@ function isEffectImport(
   namespace: boolean,
 ): boolean {
   const variable = resolveVariable(sourceCode, identifier);
+
   return (
     variable?.defs.some((definition) => {
       if (
@@ -52,9 +60,12 @@ function isEffectImport(
       ) {
         return false;
       }
+
       if (namespace) return definition.node.type === "ImportNamespaceSpecifier";
+
       if (definition.node.type !== "ImportSpecifier") return false;
       const imported = definition.node.imported;
+
       return (
         (imported.type === "Identifier" ? imported.name : imported.value) ===
         "Effect"
@@ -71,10 +82,13 @@ function isEffectMethod(
   if (staticMemberName(node) !== method || node.type !== "MemberExpression") {
     return false;
   }
+
   const object = node.object;
+
   if (object.type === "Identifier") {
     return isEffectImport(sourceCode, object, false);
   }
+
   if (
     staticMemberName(object) !== "Effect" ||
     object.type !== "MemberExpression" ||
@@ -82,6 +96,7 @@ function isEffectMethod(
   ) {
     return false;
   }
+
   return isEffectImport(sourceCode, object.object, true);
 }
 
@@ -97,12 +112,15 @@ function isRecognisedEffectGenerator(
   owner: FunctionNode,
 ): boolean {
   const parent = owner.parent;
+
   if (parent.type !== "CallExpression" || !isDirectArgument(owner, parent)) {
     return false;
   }
+
   if (isEffectMethod(sourceCode, parent.callee, "gen")) return true;
 
   const factoryCall = parent.callee;
+
   return (
     factoryCall.type === "CallExpression" &&
     isEffectMethod(sourceCode, factoryCall.callee, "fn")
@@ -127,12 +145,14 @@ export const noTryCatchInEffectGeneratorsRule = defineRule({
       TryStatement(node) {
         if (!node.handler) return;
         const owner = nearestEnclosingFunction(node);
+
         if (
           !owner?.generator ||
           !isRecognisedEffectGenerator(context.sourceCode, owner)
         ) {
           return;
         }
+
         context.report({ node, messageId: "useEffectErrorChannel" });
       },
     };

package/src/generic/rules/prefer-event-parameter-type.ts

@@ -3,10 +3,12 @@ import { defineRule } from "@oxlint/plugins";
 import type { ESTree } from "@oxlint/plugins";
 
 type FunctionNode = ESTree.Function | ESTree.ArrowFunctionExpression;
+
 type TypeAssertion = ESTree.TSAsExpression | ESTree.TSTypeAssertion;
 
 function nearestEnclosingFunction(node: ESTree.Node): FunctionNode | null {
   let current: ESTree.Node | null = node.parent;
+
   while (current) {
     if (
       current.type === "FunctionDeclaration" ||
@@ -15,8 +17,10 @@ function nearestEnclosingFunction(node: ESTree.Node): FunctionNode | null {
     ) {
       return current;
     }
+
     current = current.parent;
   }
+
   return null;
 }
 
@@ -25,6 +29,7 @@ function assertedEventParameter(node: TypeAssertion): {
   readonly property: "currentTarget" | "target";
 } | null {
   const expression = node.expression;
+
   if (
     expression.type !== "MemberExpression" ||
     expression.computed ||
@@ -35,9 +40,11 @@ function assertedEventParameter(node: TypeAssertion): {
   ) {
     return null;
   }
+
   const parameterName = expression.object.name;
   const property = expression.property.name;
   const owner = nearestEnclosingFunction(node);
+
   if (
     !owner?.params.some(
       (parameter) =>
@@ -46,6 +53,7 @@ function assertedEventParameter(node: TypeAssertion): {
   ) {
     return null;
   }
+
   return {
     parameter: parameterName,
     property,
@@ -68,6 +76,7 @@ export const preferEventParameterTypeRule = defineRule({
   create(context) {
     const checkAssertion = (node: TypeAssertion) => {
       const eventParameter = assertedEventParameter(node);
+
       if (!eventParameter) return;
       context.report({
         node,
@@ -75,6 +84,7 @@ export const preferEventParameterTypeRule = defineRule({
         data: eventParameter,
       });
     };
+
     return {
       TSAsExpression: checkAssertion,
       TSTypeAssertion: checkAssertion,