@timmo001/oxlint-rules 0.1.2 → 0.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@timmo001/oxlint-rules",
-  "version": "0.1.2",
+  "version": "0.1.4",
   "description": "Shared Oxlint plugins and configs with optional Effect rules.",
   "type": "module",
   "license": "Apache-2.0",
@@ -20,11 +20,12 @@
   },
   "files": [
     "dist",
-    "src",
-    "!src/**/*.test.ts",
+    "src/effect",
+    "!src/effect/**/*.test.ts",
     "vendor/anti-slop/src",
     "vendor/anti-slop/LICENSE",
     "!vendor/anti-slop/src/**/*.test.ts",
+    "!vendor/anti-slop/README.md",
     "skills",
     "README.md",
     "THIRD_PARTY_NOTICES.md",
@@ -37,7 +38,7 @@
     "format:check": "prettier --check \"{src,scripts}/**/*.ts\" \"skills/**/*.{md,mjs}\" \"*.md\" \"*.json\"",
     "lint": "oxlint src scripts",
     "skills:validate": "bunx skills-ref validate skills/install-timmo-oxlint-rules && bunx skills-ref validate skills/add-oxlint-rule",
-    "test": "node --experimental-strip-types src/effect/rules/no-try-catch-in-effect-generators.test.ts && bun test src/install/copy.test.ts",
+    "test": "node --experimental-strip-types scripts/test.ts",
     "typecheck": "tsc --noEmit"
   },
   "peerDependencies": {

package/skills/add-oxlint-rule/SKILL.md

@@ -21,8 +21,9 @@ description: >-
 5. Put generic upstream-independent rules under the appropriate locally owned
    plugin. Never modify `vendor/anti-slop`; propose an upstream contribution
    separately when Dylan Mulroy's plugin should own the behaviour.
-6. Register the rule in its plugin and matching config, then update the README
-   rule list and behaviour description.
+6. Register the rule in its plugin. Verify the matching config and copy command
+   discover it from the plugin's `rules` map, then update the README rule list
+   and behaviour description. Do not add rule names to either skill.
 7. Run `mise run check`, `mise run build`, `npm pack --dry-run`, and
    `bunx jsr@0.14.3 publish --dry-run` in the central checkout.
 

package/skills/install-timmo-oxlint-rules/SKILL.md

@@ -37,8 +37,10 @@ description: >-
 3. Run `node scripts/copy.mjs <bun|npm|pnpm|yarn> <destination>`. Add `--force`
    only after explicit replacement approval.
 4. Register the three entry points printed by the command as `anti-slop`,
-   `anti-slop-effect`, and `timmo-effect`. Enable `timmo-effect` only for direct
-   Effect use or an explicit request.
+   `anti-slop-effect`, and `timmo-effect`. Merge every printed general rule
+   setting into the target config. Merge every printed Effect rule setting only
+   for direct Effect use or an explicit request. Do not maintain a rule list in
+   this skill.
 
 Run the target repository's normal lint, typecheck, tests, and build. Report
 package-manager changes, preserved local configuration, enabled rule groups,

package/src/cli.ts

@@ -1,35 +0,0 @@
-#!/usr/bin/env node
-import { resolve } from "node:path";
-
-import { copyRules, DEFAULT_COPY_DESTINATION } from "./install/copy.ts";
-
-function usage() {
-  return "Usage: oxlint-rules copy [destination] [--force]";
-}
-
-const [command, ...arguments_] = process.argv.slice(2);
-if (command === "--help" || command === "-h") {
-  console.log(usage());
-} else if (command !== "copy") {
-  console.error(usage());
-  process.exitCode = 1;
-} else {
-  const force = arguments_.includes("--force");
-  const positional = arguments_.filter((argument) => argument !== "--force");
-  if (positional.length > 1) {
-    console.error(usage());
-    process.exitCode = 1;
-  } else {
-    try {
-      const destination = resolve(positional[0] ?? DEFAULT_COPY_DESTINATION);
-      const entries = await copyRules(destination, { force });
-      console.log("Copied Oxlint plugins:");
-      console.log(`  anti-slop: ${entries.antiSlop}`);
-      console.log(`  anti-slop-effect: ${entries.antiSlopEffect}`);
-      console.log(`  timmo-effect: ${entries.timmoEffect}`);
-    } catch (error) {
-      console.error(error instanceof Error ? error.message : String(error));
-      process.exitCode = 1;
-    }
-  }
-}

package/src/configs/effect.ts

@@ -1,20 +0,0 @@
-import { defineConfig } from "oxlint";
-
-import recommended from "./recommended.ts";
-
-const effect = defineConfig({
-  extends: [recommended],
-  jsPlugins: [
-    {
-      name: "anti-slop-effect",
-      specifier: "@timmo001/oxlint-rules/upstream/effect",
-    },
-    { name: "timmo-effect", specifier: "@timmo001/oxlint-rules/effect" },
-  ],
-  rules: {
-    "anti-slop-effect/no-service-constructor-imports": "error",
-    "timmo-effect/no-try-catch-in-effect-generators": "error",
-  },
-});
-
-export default effect;

package/src/configs/recommended.ts

@@ -1,29 +0,0 @@
-import { defineConfig } from "oxlint";
-
-const recommended = defineConfig({
-  jsPlugins: [
-    {
-      name: "anti-slop",
-      specifier: "@timmo001/oxlint-rules/upstream/anti-slop",
-    },
-  ],
-  rules: {
-    "anti-slop/no-chained-type-assertions": "error",
-    "anti-slop/no-conditional-empty-object-spread": "error",
-    "anti-slop/no-known-value-widening": "error",
-    "anti-slop/no-module-mocking": "error",
-    "anti-slop/no-object-parameters": "error",
-    "anti-slop/no-reflect-apply": "error",
-    "anti-slop/no-reflect-get": "error",
-    "anti-slop/no-runtime-typeof": "error",
-    "anti-slop/no-shape-in-symbol-names": "error",
-    "anti-slop/no-unknown-parameters": "error",
-    "anti-slop/no-unknown-returns": "error",
-    "anti-slop/no-unknown-type-aliases": "error",
-    "anti-slop/no-unsafe-dictionary-type": "error",
-    "anti-slop/no-widen-then-assert": "error",
-    "anti-slop/require-safety-comment-for-type-assertion": "error",
-  },
-});
-
-export default recommended;

package/src/install/copy.ts

@@ -1,77 +0,0 @@
-import { cp, mkdir, readdir, rm } from "node:fs/promises";
-import { dirname, join, relative, resolve, sep } from "node:path";
-import { fileURLToPath } from "node:url";
-
-export const DEFAULT_COPY_DESTINATION = "tools/oxlint/timmo-rules";
-
-export interface CopyRulesOptions {
-  readonly force?: boolean;
-  readonly sourceRoot?: string;
-}
-
-export interface CopiedRuleEntryPoints {
-  readonly antiSlop: string;
-  readonly antiSlopEffect: string;
-  readonly timmoEffect: string;
-}
-
-function packageRoot() {
-  const current = dirname(fileURLToPath(import.meta.url));
-  return current.endsWith(join("src", "install"))
-    ? resolve(current, "../..")
-    : resolve(current, "..");
-}
-
-async function copyTree(source: string, destination: string) {
-  await cp(source, destination, {
-    recursive: true,
-    filter: (path) =>
-      !path.endsWith(".test.ts") && !path.includes(`${join("", ".git")}`),
-  });
-}
-
-export async function copyRules(
-  destination: string,
-  options: CopyRulesOptions = {},
-): Promise<CopiedRuleEntryPoints> {
-  const target = resolve(destination);
-  const entries = await readdir(dirname(target), { withFileTypes: true }).catch(
-    () => [],
-  );
-  if (entries.some((entry) => entry.name === target.split(/[\\/]/u).at(-1))) {
-    if (!options.force) {
-      throw new Error(
-        `Destination already exists: ${target}. Pass --force to replace it.`,
-      );
-    }
-    await rm(target, { force: true, recursive: true });
-  }
-
-  const root = options.sourceRoot ?? packageRoot();
-  await mkdir(join(target, "upstream"), { recursive: true });
-  await copyTree(
-    join(root, "vendor/anti-slop/src"),
-    join(target, "upstream/anti-slop"),
-  );
-  await cp(
-    join(root, "vendor/anti-slop/LICENSE"),
-    join(target, "upstream/anti-slop/LICENSE"),
-  );
-  await rm(join(target, "upstream/anti-slop/effect"), {
-    force: true,
-    recursive: true,
-  });
-  await copyTree(
-    join(root, "vendor/anti-slop/src/effect"),
-    join(target, "upstream/effect"),
-  );
-  await copyTree(join(root, "src/effect"), join(target, "effect"));
-
-  const displayRoot = relative(process.cwd(), target) || ".";
-  const entryPoint = (path: string) => `./${path.split(sep).join("/")}`;
-  return {
-    antiSlop: entryPoint(join(displayRoot, "upstream/anti-slop/index.ts")),
-    antiSlopEffect: entryPoint(join(displayRoot, "upstream/effect/index.ts")),
-    timmoEffect: entryPoint(join(displayRoot, "effect/index.ts")),
-  };
-}

package/src/jsr/effect-config.ts

@@ -1,7 +0,0 @@
-import type { OxlintConfig } from "oxlint";
-
-import bundledConfig from "../../dist/configs/effect.js";
-
-const config: OxlintConfig = bundledConfig;
-
-export default config;

package/src/jsr/effect.ts

@@ -1,7 +0,0 @@
-import type { Plugin } from "@oxlint/plugins";
-
-import bundledPlugin from "../../dist/effect/index.js";
-
-const plugin: Plugin = bundledPlugin;
-
-export default plugin;

package/src/jsr/recommended.ts

@@ -1,7 +0,0 @@
-import type { OxlintConfig } from "oxlint";
-
-import bundledConfig from "../../dist/configs/recommended.js";
-
-const config: OxlintConfig = bundledConfig;
-
-export default config;

package/src/jsr/upstream-anti-slop.ts

@@ -1,7 +0,0 @@
-import type { Plugin } from "@oxlint/plugins";
-
-import bundledPlugin from "../../dist/upstream/anti-slop.js";
-
-const plugin: Plugin = bundledPlugin;
-
-export default plugin;

package/src/jsr/upstream-effect.ts

@@ -1,7 +0,0 @@
-import type { Plugin } from "@oxlint/plugins";
-
-import bundledPlugin from "../../dist/upstream/effect.js";
-
-const plugin: Plugin = bundledPlugin;
-
-export default plugin;

package/src/upstream/anti-slop.ts

@@ -1 +0,0 @@
-export { default } from "../../vendor/anti-slop/src/index.ts";

package/src/upstream/effect.ts

@@ -1 +0,0 @@
-export { default } from "../../vendor/anti-slop/src/effect/index.ts";