@timekast/factory 1.23.1 → 1.25.0

package/dist/commands/doctor.js

@@ -12,15 +12,26 @@
  *     `src/` + boilerplate deps are the derived project's responsibility
  *     post-bootstrap, and that the patch channel for `src/` is EPIC 2 (agentic
  *     update, not yet available).
+ *   - MISSING INITIAL MIGRATION: a derivative that ships a Drizzle schema and no
+ *     generated `.sql`, so its `vercel-build` (`pnpm db:migrate && pnpm build`)
+ *     would migrate an empty database. INFORMATIONAL — see below.
  *
  * No lockfile (pre-CLI repo) → delegate to the "run factory:update" advice, exit
  * 0, never abort (same pattern as `status` / the §8 edge case).
+ *
+ * 🔴 EVERY CHECK HERE IS ADVISORY. `runDoctor` always exits 0 by contract; the
+ * sibling entrypoint {@link runLauncherDoctor} is the one that throws `CLIError(1)`
+ * on any `status: 'fail'`. A report-only finding therefore belongs in
+ * `computeDoctor`/`renderDoctor` and NOWHERE ELSE — moving it to the launcher would
+ * turn a notice into a blocked command through the back door. If it ever has to
+ * live there, it goes as `warn` (`LauncherCheckStatus`), which never trips the exit.
  */
 import { existsSync, readFileSync, statSync } from 'node:fs';
 import path from 'node:path';
 import { CLIError } from '../lib/cli-error.js';
 import { collectClaudePaths } from '../lib/claude-paths.js';
 import { CLAUDE_MD_FILE } from '../lib/constants.js';
+import { MIGRATIONS_DIR, SCHEMA_DIR, needsInitialMigration, readMigrationFacts, } from '../lib/initial-migration.js';
 import { hasLockfile, normalizeThenHash, readLockfile } from '../lib/lockfile.js';
 import { runLauncherPreflight, } from '../lib/preflight.js';
 import { detectRepo } from '../lib/repo-detection.js';
@@ -46,6 +57,18 @@ export const A1_WARNING = 'Aviso de seguridad (A1): el boilerplate `src/` y sus
     'dependencia) NO llega por este canal. El canal de parches de `src/` es EPIC 2 ' +
     '(update agentico con merge inteligente), aún no disponible. Mantén `src/` y tus ' +
     'dependencias al día por tu cuenta mientras tanto.';
+/**
+ * The literal notice for a derivative whose schema has no generated migration.
+ * Named constant (never an inline string — CODING.md §5) and built from the SAME
+ * directory constants the provision step uses, so a path can never drift between
+ * what `provision` writes and what `doctor` reports. Exported for the tests.
+ */
+export const MISSING_INITIAL_MIGRATION_NOTICE = `⚠ Falta la migración inicial: hay schema en \`${SCHEMA_DIR}/\` y ningún \`.sql\` en ` +
+    `\`${MIGRATIONS_DIR}/\`.\n` +
+    '  El deploy corre `pnpm db:migrate && pnpm build`, así que el primer build migraría una ' +
+    'base vacía. Genera la migración con `pnpm db:generate` y commitéala antes del próximo ' +
+    'deploy.\n' +
+    '  (Aviso informativo: `factory doctor` no bloquea — sale con éxito de todos modos.)';
 /** Parse `doctor`'s argv slice into flags. Unknown flags are ignored. */
 export function parseDoctorFlags(argv) {
     return {
@@ -114,6 +137,10 @@ export function computeDoctor(deps = {}) {
     // `doctor` from a subdir of a managed repo reports the real state instead of
     // "no lockfile" (consistency with `add`/`update`). Tests inject `rootDir`.
     const rootDir = deps.rootDir ?? detectRepo(process.cwd()).repoRoot ?? process.cwd();
+    // Initial-migration gap (GAP-002). Delegated WHOLE to the provision predicate —
+    // facts read from disk, decision (Factory exception included) taken there. Doctor
+    // does not re-derive "is this the Factory": one copy of that rule, in one place.
+    const missingInitialMigration = needsInitialMigration(readMigrationFacts(rootDir));
     if (!hasLockfile(rootDir)) {
         return {
             orphans: [],
@@ -121,6 +148,9 @@ export function computeDoctor(deps = {}) {
             unimportedRules: [],
             claudeMdMissing: false,
             a1Warning: A1_WARNING,
+            // Always false on this branch, and by the predicate rather than by a literal:
+            // no lockfile IS the Factory signal, which `needsInitialMigration` short-circuits.
+            missingInitialMigration,
             noLockfile: true,
             beta: false,
         };
@@ -174,6 +204,7 @@ export function computeDoctor(deps = {}) {
         unimportedRules,
         claudeMdMissing,
         a1Warning: A1_WARNING,
+        missingInitialMigration,
         noLockfile: false,
         beta,
     };
@@ -181,6 +212,8 @@ export function computeDoctor(deps = {}) {
 /** Render the doctor result to the console. The A1 notice is ALWAYS last. */
 function renderDoctor(result) {
     if (result.noLockfile) {
+        // Nothing to say about migrations here: no lockfile IS the Factory signal, so
+        // `missingInitialMigration` is false by construction on this branch.
         console.log('Sin lockfile detectado.');
         console.log('Ejecuta `factory:update` para inicializar el tracking de versión.');
         // The A1 notice is emitted even without a lockfile (always present).
@@ -223,6 +256,12 @@ function renderDoctor(result) {
             }
         }
     }
+    // Initial-migration gap (GAP-002): reported, never enforced. It sits outside the
+    // orphans/conflicts block because it is about the derivative's `src/`, not about
+    // brain drift — a repo with a spotless brain can still be missing its `0000`.
+    if (result.missingInitialMigration) {
+        console.log(`\n${MISSING_INITIAL_MIGRATION_NOTICE}`);
+    }
     // The A1 security notice is always emitted at the end (design §1 + §11).
     console.log(`\n${result.a1Warning}`);
 }