@timber-js/app 0.2.0-alpha.19 → 0.2.0-alpha.191

package/src/client/params-context.ts

@@ -0,0 +1,192 @@
+/**
+ * Segment params context — the one channel params use to reach the browser.
+ *
+ * Params ride the RSC payload's root row as a sibling of the tree
+ * (`{ tree, params, slotParams }`), rather than in four side channels that
+ * raced to seed them: a response header, an inline script, and two build-time
+ * manifest fields all previously carried the same record, each with its own
+ * `JSON.stringify` (TIM-1294).
+ *
+ * Riding the payload is what makes them *typed*. `defineSchema` takes any
+ * `Codec<T>`, so a coerced param is whatever the codec returned — a `Date`, a
+ * `bigint` — and `JSON.stringify` either flattened it to a string or threw
+ * mid-response. React Flight carries those values natively, so the client
+ * reads the value the server produced instead of a lossy copy of it. See
+ * design/41-global-params.md §"Transport".
+ *
+ * **The client owns the provider.** There is exactly one `ParamsProvider` in
+ * the browser's tree, rendered by `PayloadRoot` above the point where a
+ * partial navigation splices the new payload into the retained tree. It has to
+ * be there and it has to be alone: a provider *inside* the payload lands below
+ * the retained region, whose own root is the departing route's provider, so
+ * every reader in a skipped layout resolves to the departing record and no
+ * amount of wrapping above it helps (TIM-1297).
+ *
+ * Ordering still holds without a bootstrap contract, for the same reason it
+ * did when the provider was in the tree: a provider renders before its own
+ * descendants by construction, so `useSegmentParams()` is correct during
+ * hydration without anything having to run before `hydrateRoot()`.
+ */
+
+'use client';
+
+import React, { createElement, useMemo, use } from 'react';
+import { _setCurrentParams, _setCurrentSlotParams } from './state.js';
+import { toNullProtoRecord, type CoercedParams } from '../shared/param-value.js';
+import { readPublishedParams, type PublishedParams } from '../shared/payload-root.js';
+import type { SlotParamsRecord } from '../shared/slot-params.js';
+
+// ─── Types ───────────────────────────────────────────────────────
+
+export type ParamsContextValue = PublishedParams;
+
+// ─── Context ─────────────────────────────────────────────────────
+
+/**
+ * SINGLETON GUARANTEE: globalThis + `Symbol.for`, the same pattern as
+ * `NavigationContext` and `SegmentUpdateContext`.
+ *
+ * The RSC client bundler can duplicate a module across chunks, and with ESM
+ * output each chunk gets its own module scope — so a bare `createContext` at
+ * module level yields one context per chunk. This module is now reached from
+ * *both* graphs: `PayloadRoot` is imported by the browser entry, while
+ * `useParamsContext()` arrives through the client-reference graph with the
+ * app's own components. A duplicate would put the provider on instance A and
+ * every reader on instance B, so `useContext` returns `null` and every
+ * `useSegmentParams()` call silently falls back to the module snapshot.
+ *
+ * This module was the one client context without the guard — harmless while
+ * the provider travelled inside the payload, in the same graph as its readers,
+ * and load-bearing the moment the client started rendering it (TIM-1297).
+ *
+ * The React APIs are reached through the namespace rather than named imports,
+ * for the same reason `segment-update-context.ts` and `navigation-context.ts`
+ * do it: React's `react-server` export provides neither `createContext` nor
+ * `useContext`, and a *named* ESM import of a missing export fails at module
+ * instantiation — before any feature check could run. This module is reachable
+ * from every entry a Server Component imports, so the named form crashed
+ * those entries outright (codex, PR #992; originally reproduced against
+ * `@timber-js/app/segment-params`, an entry point since deleted by TIM-1342 —
+ * the hazard is unchanged for the entries that remain).
+ *
+ * See design/19-client-navigation.md §"Singleton Guarantee via globalThis"
+ */
+const PARAMS_CTX_KEY = Symbol.for('__timber_params_ctx');
+
+function getOrCreateContext(): React.Context<ParamsContextValue | null> {
+  const store = globalThis as Record<symbol, unknown>;
+  const existing = store[PARAMS_CTX_KEY] as React.Context<ParamsContextValue | null> | undefined;
+  if (existing !== undefined) return existing;
+  if (typeof React.createContext !== 'function') {
+    // RSC environment — no contexts here. Nothing in this module runs on that
+    // side; it only has to import cleanly.
+    return undefined as unknown as React.Context<ParamsContextValue | null>;
+  }
+  const ctx = React.createContext<ParamsContextValue | null>(null);
+  store[PARAMS_CTX_KEY] = ctx;
+  return ctx;
+}
+
+const ParamsContext = getOrCreateContext();
+
+/**
+ * Read the params provided by the tree. Returns null when no provider is
+ * above the caller — a component rendered outside a timber route, a
+ * `useSegmentParams()` call from outside React entirely, or any component
+ * during SSR (where the params reach the hook through the ALS-backed SSR data
+ * context instead, and there is no client-owned tree to hold a provider).
+ */
+export function useParamsContext(): ParamsContextValue | null {
+  return React.useContext(ParamsContext);
+}
+
+// ─── Provider ────────────────────────────────────────────────────
+
+interface ParamsProviderProps {
+  params: CoercedParams;
+  slotParams: SlotParamsRecord | null;
+  children?: React.ReactNode;
+}
+
+/**
+ * Provides the current navigation's params to everything below it.
+ *
+ * Rendered only by `PayloadRoot`. Not exported: a second provider anywhere in
+ * the tree would shadow this one for the region below it, which is precisely
+ * the defect TIM-1297 fixed.
+ *
+ * The module-level snapshot in `state.ts` is written during render rather
+ * than in an effect. It is the fallback path for `useSegmentParams()` called
+ * outside a component (tests, module scope), and an effect would leave that
+ * path reading the *previous* route's params for the whole commit — the
+ * window in which a navigation's components actually run. Writing during
+ * render is safe here because the value is derived entirely from props: a
+ * double-invoked render in StrictMode writes the same record twice.
+ */
+function ParamsProvider({ params, slotParams, children }: ParamsProviderProps) {
+  // Restore the null prototype the wire could not carry. Flight rejects a
+  // null-prototype object, so `withPublishedParams` flattens the records;
+  // rebuilding them here is what keeps `params.constructor` returning
+  // `undefined` instead of a function for a param the route does not define
+  // (design/13-security.md #36c). Memoized on the props so a re-render with
+  // the same records does not rebuild — the identity of what the hook returns
+  // is load-bearing for `useEffect` dependencies (TIM-1285).
+  const value = useMemo(
+    () => ({
+      params: toNullProtoRecord(params),
+      slotParams: toNullProtoRecord(slotParams),
+    }),
+    [params, slotParams]
+  );
+
+  // Keep the out-of-component fallback in step with the tree being rendered.
+  _setCurrentParams(value.params);
+  _setCurrentSlotParams(value.slotParams);
+
+  return createElement(ParamsContext.Provider, { value }, children);
+}
+
+// ─── Payload root ────────────────────────────────────────────────
+
+/**
+ * The client's root: publishes a payload's params over the tree being shown.
+ *
+ * Rendered at the same position in the wrapper chain on **every** render path
+ * — hydration, full navigation, partial navigation, popstate replay, shallow
+ * search sync, and revalidation from a server action. Being unconditional is
+ * load-bearing twice over: an element type that appears on one render and not
+ * the next remounts everything below it, destroying exactly the layout state a
+ * partial navigation exists to preserve; and a reader in a skipped layout has
+ * to have *some* provider above it on every path or it falls back to the
+ * module-level snapshot.
+ *
+ * `children` is the tree to display, which is not always `source`'s tree:
+ *
+ * - Full navigation, hydration, replay — `source` is the payload being shown,
+ *   and `children` is its own tree.
+ * - **Partial navigation** — `children` is the *retained* tree and `source` is
+ *   the *incoming* payload. This is the case the whole design exists for: the
+ *   retained tree is not re-rendered, so the destination's params can only
+ *   reach it from above, and this provider is above it.
+ *
+ * `source` may be a thenable, in which case this suspends on the payload's
+ * root row. That happens on the hydration path only, where the payload
+ * promise was going to be rendered at this position anyway. Every other path
+ * resolves the row in the router — inside the navigation transition — and
+ * hands over a settled value, so a decode rejection surfaces where React
+ * renders the tree and is caught by the error boundary *around* it, rather
+ * than here, above every boundary the app has.
+ */
+export function PayloadRoot({ source, children }: { source: unknown; children?: React.ReactNode }) {
+  const resolved = isThenable(source) ? use(source) : source;
+  const { params, slotParams } = readPublishedParams(resolved);
+  return createElement(ParamsProvider, { params, slotParams }, children);
+}
+
+function isThenable(value: unknown): value is Promise<unknown> {
+  return (
+    typeof value === 'object' &&
+    value !== null &&
+    typeof (value as { then?: unknown }).then === 'function'
+  );
+}

package/src/client/router-effects.ts

@@ -0,0 +1,231 @@
+/**
+ * Router Effects — full-page navigation and post-paint scroll.
+ *
+ * The two things the router does *to the document* rather than to its own
+ * state: leaving the SPA entirely, and moving the scroll position once React
+ * has committed. Extracted from `router.ts` to keep that file focused on
+ * navigation state (see design/18-build-system.md §"No file >500 lines").
+ *
+ * See design/19-client-navigation.md §"Scroll Restoration"
+ */
+
+import { setHardNavigating } from './navigation-root.js';
+import { RedirectError, ServerErrorResponse, NonRscResponse } from './rsc-fetch.js';
+import { recordSkew } from './router-skew.js';
+
+/** The subset of `RouterDeps` the post-paint scroll effects need. */
+export interface ScrollEffectDeps {
+  scrollTo: (x: number, y: number) => void;
+  afterPaint?: (callback: () => void) => void;
+  scrollToHash?: (hash: string) => boolean;
+}
+
+export interface ScrollEffects {
+  /**
+   * Schedule scroll restoration after the next paint and fire the
+   * scroll-restored event. Used by navigate, popstate, and refresh.
+   */
+  restoreScrollAfterPaint: (scrollY: number) => void;
+  /**
+   * Scroll to the element matching the URL #fragment after paint, falling
+   * back to scroll-to-top when no element matches (matching full-page-load
+   * behavior for an unknown fragment). Used by forward navigation to a
+   * hash-bearing URL (TIM-1035).
+   */
+  scrollToHashAfterPaint: (hash: string) => void;
+}
+
+export function createScrollEffects(deps: ScrollEffectDeps): ScrollEffects {
+  /** Run a callback after the next paint (after React commit). */
+  function afterPaint(callback: () => void): void {
+    if (deps.afterPaint) {
+      deps.afterPaint(callback);
+    } else {
+      callback();
+    }
+  }
+
+  function restoreScrollAfterPaint(scrollY: number): void {
+    afterPaint(() => {
+      deps.scrollTo(0, scrollY);
+      window.dispatchEvent(new Event('timber:scroll-restored'));
+    });
+  }
+
+  function scrollToHashAfterPaint(hash: string): void {
+    afterPaint(() => {
+      if (deps.scrollToHash?.(hash) !== true) {
+        deps.scrollTo(0, 0);
+      }
+      window.dispatchEvent(new Event('timber:scroll-restored'));
+    });
+  }
+
+  return { restoreScrollAfterPaint, scrollToHashAfterPaint };
+}
+
+/**
+ * Leave the SPA and never come back.
+ *
+ * Every router path that gives up on client-side navigation does the same
+ * three things: flag the hard navigation so the Navigation API and React stop
+ * acting on a dying document, perform the document load, then block forever so
+ * the caller cannot carry on rendering into it. The returned promise is
+ * deliberately unresolvable — `location` assignment does not stop this turn of
+ * the event loop.
+ *
+ * Callers: server error, non-RSC response, and every version skew path
+ * ([33-version-skew.md](../../../../design/33-version-skew.md)).
+ */
+export function leaveSpa(url: string, fromUrl: string): Promise<never> {
+  setHardNavigating(true);
+  hardNavigate(url, fromUrl);
+  return new Promise<never>(() => {});
+}
+
+export interface SpaExitDeps {
+  /** The controller that owns the router right now, or null when idle. */
+  currentNavAbort: () => AbortController | null;
+  /** Supersede whatever is in flight and take ownership. */
+  supersede: () => void;
+}
+
+export interface SpaExits {
+  /**
+   * Leave the SPA — but only if `navAbort` still owns the router. Every
+   * failure a navigation can end on (a server error, a non-RSC response, a
+   * version skew) can surface long after the user has clicked something else:
+   * a fetch that was never cancellable, a Flight thenable that rejects late.
+   * Hard navigating to the abandoned URL would undo that click, so a
+   * navigation that no longer owns the router does nothing and lets the one
+   * that does drive. Never resolves when it does navigate.
+   *
+   * Must be called from inside the `runNavigation()` callback. That function's
+   * `finally` clears the current controller, so an ownership check downstream
+   * of it compares against `null` and never leaves at all.
+   */
+  leaveSpaIfOwned: (navAbort: AbortController, url: string, fromUrl: string) => Promise<void>;
+
+  /**
+   * Leave the SPA from a path that never entered `runNavigation()` — the
+   * stale-client short circuits, which decide before any fetch is attempted.
+   *
+   * Supersedes first. Nothing else on those paths takes ownership, so without
+   * it an in-flight navigation keeps the router: when its fetch or decode
+   * fails a moment later it still passes its own ownership check and hard
+   * navigates to *its* URL, overwriting the document load started here.
+   */
+  leaveSpaSuperseding: (url: string, fromUrl: string) => Promise<never>;
+}
+
+/**
+ * The two ownership-aware ways out of the SPA.
+ *
+ * Both wrap {@link leaveSpa} with the question "is this navigation still the
+ * one the user is waiting for?" — asked before leaving on a failure, answered
+ * by force on a path that decided before any navigation began. They live
+ * together because every caller of `leaveSpa()` needs one or the other, and
+ * an unguarded call is the bug (TIM-1275, TIM-1276).
+ */
+export function createSpaExits({ currentNavAbort, supersede }: SpaExitDeps): SpaExits {
+  async function leaveSpaIfOwned(
+    navAbort: AbortController,
+    url: string,
+    fromUrl: string
+  ): Promise<void> {
+    if (currentNavAbort() !== navAbort) return;
+    await leaveSpa(url, fromUrl);
+  }
+
+  function leaveSpaSuperseding(url: string, fromUrl: string): Promise<never> {
+    supersede();
+    return leaveSpa(url, fromUrl);
+  }
+
+  return { leaveSpaIfOwned, leaveSpaSuperseding };
+}
+
+export interface NavigationRecoveryDeps {
+  /** The controller that owns the router right now, or null when idle. */
+  currentNavAbort: () => AbortController | null;
+  leaveSpaIfOwned: SpaExits['leaveSpaIfOwned'];
+  /** Replace the current entry with `url` — the router's own `navigate()`. */
+  navigate: (url: string) => Promise<void>;
+}
+
+/**
+ * Answer the failures an RSC fetch can end on, or report that this one is not
+ * ours to answer.
+ *
+ * Returns `true` when the error was handled; the caller rethrows on `false`.
+ * Handling a failure by leaving the SPA never resolves at all — the document
+ * is going away and the caller must not carry on rendering into it.
+ *
+ * There is exactly one family of these and one response to it, so it lives in
+ * one function rather than once per fetch path. `navigate()`, `refresh()` and
+ * an uncached traversal all reach it: the latter two used to rethrow instead,
+ * and since nobody awaits a traversal that meant pressing Back on a 500 left
+ * the user on the old document with an unhandled rejection (TIM-1277).
+ *
+ * Order matters in exactly one way: `recordSkew()` ends in error-*text*
+ * matching, so it goes last and can never pre-empt a framework control-flow
+ * signal whose message happens to read like a stale bundle. The class checks
+ * above it are mutually exclusive, so their order is free.
+ *
+ * Must be called from inside the `runNavigation()` callback — see
+ * {@link SpaExits.leaveSpaIfOwned}.
+ */
+export function createNavigationRecovery({
+  currentNavAbort,
+  leaveSpaIfOwned,
+  navigate,
+}: NavigationRecoveryDeps) {
+  return async function recoverFromNavigationError(
+    error: unknown,
+    navAbort: AbortController,
+    url: string,
+    fromUrl: string
+  ): Promise<boolean> {
+    if (error instanceof RedirectError) {
+      // Same ownership rule as leaving the SPA: a superseded navigation must
+      // not steer the document to the destination it was abandoned for.
+      if (currentNavAbort() !== navAbort) return true;
+      await navigate(error.redirectUrl);
+      return true;
+    }
+    // A server error, a non-RSC response and a version skew all end the same
+    // way: hand `url` back to the server as a document load, so it can render
+    // the outcome as HTML (design/10-error-handling.md §"Error Page Rendering
+    // for Client Navigation").
+    if (
+      error instanceof ServerErrorResponse ||
+      error instanceof NonRscResponse ||
+      recordSkew(error)
+    ) {
+      await leaveSpaIfOwned(navAbort, url, fromUrl);
+      return true;
+    }
+    return false;
+  };
+}
+
+/**
+ * Perform the full document load.
+ *
+ * `fromUrl` is the URL the navigation departed from, passed explicitly
+ * because the address bar may have already been updated.
+ *
+ * When the target differs from the departure point only by #fragment,
+ * assigning `href` is a hash change, not a load — so assign first (to update
+ * the address bar) and then reload (TIM-1235).
+ */
+export function hardNavigate(url: string, fromUrl: string): void {
+  const current = new URL(fromUrl, window.location.origin);
+  const target = new URL(url, window.location.origin);
+  if (target.pathname === current.pathname && target.search === current.search) {
+    window.location.href = url;
+    window.location.reload();
+  } else {
+    window.location.href = url;
+  }
+}