@timber-js/app 0.2.0-alpha.163 → 0.2.0-alpha.164

package/src/plugins/cache.ts

@@ -55,7 +55,6 @@
 
 import { relative } from 'node:path';
 import MagicString from 'magic-string';
-import { parseAst } from 'vite';
 import type { Plugin } from 'vite';
 import type { PluginContext } from '../plugin-context.js';
 import {
@@ -147,7 +146,7 @@ export function timberCacheTransform(ctx: PluginContext): Plugin {
 
       let program: ProgramNode;
       try {
-        program = parseAst(code, { lang: 'tsx' }) as unknown as ProgramNode;
+        program = ctx.parseCached!.parse(code);
       } catch {
         return;
       }

package/src/plugins/client-chunks.ts

@@ -48,6 +48,47 @@ function findAppBoundary(
   return { inApp: true, segment: null };
 }
 
+/**
+ * Check if a string is a bare import specifier (package name, not a path).
+ * Bare specifiers don't start with `.`, `/`, or contain `:/`.
+ */
+function isBareSpecifier(id: string): boolean {
+  return !id.startsWith('.') && !id.startsWith('/') && !id.includes(':/');
+}
+
+/**
+ * Look up facade ancestors for a module ID, handling bare package specifiers.
+ *
+ * The facade ancestry map is keyed by absolute resolved paths (from Rollup's
+ * moduleIds), but the RSC plugin passes bare package names (e.g. 'streamdown')
+ * as meta.id for npm package client references (TIM-1108). When a direct
+ * lookup misses and the id is a bare specifier, scan map keys for a matching
+ * node_modules path.
+ */
+function lookupFacades(
+  id: string,
+  sharedModuleFacades: Map<string, string[]>
+): string[] | undefined {
+  const direct = sharedModuleFacades.get(id);
+  if (direct) return direct;
+
+  if (!isBareSpecifier(id)) return undefined;
+
+  // Bare specifier: match against node_modules/<name>/ in map keys.
+  // Scoped packages use @scope/name, unscoped use just name.
+  // A package may have multiple module IDs in the RSC bundle (e.g. main
+  // entry + re-exported submodules), so aggregate facades from all matches.
+  const needle = `/node_modules/${id}/`;
+  let merged: string[] | undefined;
+  for (const [key, facades] of sharedModuleFacades) {
+    if (key.includes(needle)) {
+      if (!merged) merged = [...facades];
+      else merged.push(...facades);
+    }
+  }
+  return merged;
+}
+
 /**
  * For a `shared:` client reference, check the facade ancestry map to
  * see if all consuming facades belong to the same route boundary.
@@ -60,7 +101,7 @@ function reclassifySharedModule(
   root: string,
   sharedModuleFacades: Map<string, string[]>
 ): string | null {
-  const facades = sharedModuleFacades.get(meta.id);
+  const facades = lookupFacades(meta.id, sharedModuleFacades);
   if (!facades || facades.length === 0) return null;
 
   const boundaries = new Set<string>();

package/src/plugins/dev-server.ts

@@ -17,6 +17,7 @@ import type { IncomingMessage, ServerResponse } from 'node:http';
 import type { TLSSocket } from 'node:tls';
 import { existsSync, statSync } from 'node:fs';
 import { join } from 'node:path';
+import { sendNodeResponse } from 'srvx/node';
 import type { PluginContext } from '../plugin-context.js';
 import {
   sendErrorToOverlay,
@@ -298,8 +299,17 @@ function createTimberMiddleware(server: ViteDevServer, ctx: PluginContext) {
       // See design/25-production-deployments.md.
       const finalResponse = compressResponse(webRequest, webResponse);
 
-      // Convert Web Response → Node ServerResponse
-      await sendWebResponse(res, finalResponse);
+      // Flush headers eagerly so streaming responses (SSE, long-polling)
+      // reach the client before the first body chunk. Node.js buffers
+      // headers until write()/end() otherwise, which stalls EventSource
+      // clients that wait for the response to open. srvx's writeHead
+      // skips if headersSent is already true, so pre-flushing is safe.
+      res.writeHead(finalResponse.status, [...finalResponse.headers].flat());
+      res.flushHeaders();
+
+      // Stream the body with backpressure and disconnect handling.
+      // srvx skips its own writeHead since headers are already sent.
+      await sendNodeResponse(res, finalResponse);
     } catch (error) {
       // Pipeline error — classify the phase, send to overlay, respond 500.
       // The dev server remains running for recovery on file fix + HMR.
@@ -448,73 +458,6 @@ function nodeReadableToWebStream(nodeStream: IncomingMessage): ReadableStream<Ui
   });
 }
 
-/**
- * Write a Web Response to a Node ServerResponse.
- *
- * Copies status code, headers, and streams the body.
- */
-async function sendWebResponse(nodeRes: ServerResponse, webResponse: Response): Promise<void> {
-  nodeRes.statusCode = webResponse.status;
-
-  // Copy headers. Set-Cookie needs special handling: Headers.forEach()
-  // joins multiple Set-Cookie values with ", " into one entry, but each
-  // cookie must be its own header per RFC 6265 §4.1. Use getSetCookie()
-  // to preserve individual Set-Cookie headers.
-  webResponse.headers.forEach((value, key) => {
-    if (key.toLowerCase() !== 'set-cookie') {
-      nodeRes.setHeader(key, value);
-    }
-  });
-  const setCookies = webResponse.headers.getSetCookie();
-  if (setCookies.length > 0) {
-    nodeRes.setHeader('Set-Cookie', setCookies);
-  }
-
-  // Stream the body
-  if (!webResponse.body) {
-    nodeRes.end();
-    return;
-  }
-
-  // Flush headers immediately so the client can start processing
-  // the response (critical for SSE and other streaming responses).
-  nodeRes.flushHeaders();
-
-  const reader = webResponse.body.getReader();
-
-  // Cancel the reader when the client disconnects. This causes any pending
-  // reader.read() to reject, breaking the pump loop. Critical for SSE and
-  // other infinite streams — without this, disconnected clients leak readers.
-  let clientDisconnected = false;
-  const onClose = () => {
-    clientDisconnected = true;
-    reader.cancel('Client disconnected').catch(() => {});
-  };
-  nodeRes.on('close', onClose);
-
-  try {
-    while (true) {
-      const { done, value } = await reader.read();
-      if (done) break;
-      // write() returns false when the kernel buffer is full, but we
-      // don't need back-pressure here — just keep pushing chunks.
-      nodeRes.write(value);
-    }
-  } catch (err) {
-    // reader.cancel() from the close handler causes read() to reject.
-    // This is expected on client disconnect — not an error.
-    if (!clientDisconnected) {
-      throw err;
-    }
-  } finally {
-    nodeRes.off('close', onClose);
-    reader.releaseLock();
-    if (!nodeRes.writableEnded) {
-      nodeRes.end();
-    }
-  }
-}
-
 // ─── URL Classification ──────────────────────────────────────────────────
 
 /**

package/src/plugins/prebuilt-options-analysis.ts

@@ -0,0 +1,175 @@
+/**
+ * Static analysis of `cache.component(fn, options)` option literals for
+ * the timber-prebuilt transform: can this call site's options put the
+ * component in the prerender tier?
+ *
+ * Runtime-tier call sites must do NO build work — recording them would
+ * make the post-build hook import the built RSC entry (running production
+ * startup) and load route modules for routes that have nothing to
+ * prerender (codex P2 on PR #836). The analysis is conservative in one
+ * direction only: over-inclusion costs a wasted entry load (the capture
+ * pass re-checks the real options at runtime and skips), under-inclusion
+ * would silently skip prerendering.
+ */
+
+import type { CallExpressionNode, PositionedNode } from './callsite-ast.js';
+
+const EXPRESSION_WRAPPER_TYPES = new Set([
+  'TSAsExpression',
+  'TSSatisfiesExpression',
+  'TSNonNullExpression',
+  'ParenthesizedExpression',
+]);
+
+/** Unwrap TS expression wrappers (`as`, `satisfies`, `!`, parens). */
+export function unwrapExpression(node: PositionedNode): PositionedNode {
+  let current = node;
+  while (EXPRESSION_WRAPPER_TYPES.has(current.type) && current.expression) {
+    current = current.expression as PositionedNode;
+  }
+  return current;
+}
+
+interface ObjectPropertyNode extends PositionedNode {
+  type: 'Property';
+  computed?: boolean;
+  key: PositionedNode & { name?: string; value?: unknown };
+  value: PositionedNode & { value?: unknown };
+}
+
+/** Three-state static knowledge about a property's runtime effect. */
+type Tri = 'yes' | 'no' | 'unknown';
+
+/**
+ * Statically classify a `slots` value node against resolveSlotNames'
+ * runtime rules (server/prebuilt/slots.ts):
+ *
+ * - `yes` — certainly an ACTIVE shape: dense, non-empty array literal of
+ *   non-empty string literals.
+ * - `no` — certainly NOT active (absent/empty/malformed): registration
+ *   falls back to non-slot semantics with `prerender` preserved.
+ * - `unknown` — identifiers, spreads, holes, non-literal elements.
+ */
+function classifySlotsValue(node: PositionedNode): Tri {
+  const value = unwrapExpression(node);
+  if (value.type === 'ArrayExpression') {
+    const elements = ((value as unknown as { elements: (PositionedNode | null)[] }).elements ??
+      []) as (PositionedNode | null)[];
+    if (elements.length === 0) return 'no'; // empty → kind 'none'
+    let allValidStrings = true;
+    for (const el of elements) {
+      if (el === null) return 'no'; // hole → sparse → malformed at runtime
+      if (el.type === 'SpreadElement') return 'unknown';
+      const entry = unwrapExpression(el) as { type: string; value?: unknown };
+      if (entry.type !== 'Literal') {
+        allValidStrings = false; // could still be a valid string at runtime
+        continue;
+      }
+      if (typeof entry.value !== 'string' || entry.value.length === 0) {
+        return 'no'; // a non-string/empty literal is malformed regardless of the rest
+      }
+    }
+    return allValidStrings ? 'yes' : 'unknown';
+  }
+  if (value.type === 'Literal') return 'no'; // null / primitive → malformed → disabled
+  if (value.type === 'Identifier' && (value as { name?: string }).name === 'undefined') {
+    return 'no'; // absent
+  }
+  return 'unknown';
+}
+
+/** Statically classify whether a `ttl` value gives a runtime lifetime (`ttl !== undefined`). */
+function classifyTtlValue(node: PositionedNode): Tri {
+  const value = unwrapExpression(node);
+  if (value.type === 'Literal') return 'yes'; // any literal (number, null, …) !== undefined
+  if (value.type === 'Identifier' && (value as { name?: string }).name === 'undefined') return 'no';
+  return 'unknown';
+}
+
+/** Statically classify whether a `tags` value gives a runtime lifetime (`tags != null`). */
+function classifyTagsValue(node: PositionedNode): Tri {
+  const value = unwrapExpression(node);
+  if (value.type === 'ArrayExpression') return 'yes';
+  if (value.type === 'ArrowFunctionExpression' || value.type === 'FunctionExpression') return 'yes';
+  if (value.type === 'Literal') {
+    return (value as { value?: unknown }).value === null ? 'no' : 'yes';
+  }
+  if (value.type === 'Identifier' && (value as { name?: string }).name === 'undefined') return 'no';
+  return 'unknown';
+}
+
+/**
+ * Can this call site's options put the component in the prerender tier?
+ * The answer is static only when the options argument is an object
+ * literal:
+ *
+ *   - literal with `prerender: true`            → yes
+ *   - literal with `prerender: false`/absent    → no  (spread-free)
+ *   - literal with statically ACTIVE `slots` + certain runtime lifetime
+ *     → no — registration strips `prerender` for active slot components
+ *       (TIM-1173), so attributing the callsite would make the post-build
+ *       hook import the RSC entry and enumerate route params for entries
+ *       the capture pass then skips (codex P2 on PR #890)
+ *   - anything else (identifier, spread, non-literal values)
+ *     → conservatively yes — the capture pass re-checks at runtime
+ *
+ * Properties walk in source order with last-write-wins, mirroring
+ * object-literal evaluation: `{ prerender: false, ...opts }` may end up
+ * prerenderable (the spread can override), while `{ ...opts,
+ * prerender: false }` is statically false (codex P2 on PR #836).
+ * Computed keys are treated like spreads — they may evaluate to any of
+ * the tracked names.
+ */
+export function mayPrerender(call: CallExpressionNode): boolean {
+  if (call.arguments.length < 2) return false; // no options → no lifetime → never prerender
+  const options = unwrapExpression(call.arguments[1] as PositionedNode);
+  if (options.type !== 'ObjectExpression') return true;
+  const properties = (options as unknown as { properties: PositionedNode[] }).properties ?? [];
+
+  type Verdict = 'absent' | 'true' | 'false' | 'unknown';
+  let verdict: Verdict = 'absent';
+  let slotsActive: Tri = 'no'; // absent slots are certainly not active
+  let ttl: Tri = 'no';
+  let tags: Tri = 'no';
+
+  for (const prop of properties) {
+    if (prop.type === 'SpreadElement' || (prop as ObjectPropertyNode).computed) {
+      // A spread/computed key may write ANY of the tracked options.
+      verdict = 'unknown';
+      slotsActive = 'unknown';
+      ttl = 'unknown';
+      tags = 'unknown';
+      continue;
+    }
+    if (prop.type !== 'Property') continue;
+    const property = prop as ObjectPropertyNode;
+    const keyName =
+      property.key.type === 'Identifier'
+        ? property.key.name
+        : property.key.type === 'Literal'
+          ? String(property.key.value)
+          : undefined;
+    if (keyName === 'prerender') {
+      const value = unwrapExpression(property.value);
+      if (value.type === 'Literal') {
+        verdict = (value as { value?: unknown }).value === true ? 'true' : 'false';
+      } else {
+        verdict = 'unknown'; // `prerender: flag` — not statically known
+      }
+    } else if (keyName === 'slots') {
+      slotsActive = classifySlotsValue(property.value);
+    } else if (keyName === 'ttl') {
+      ttl = classifyTtlValue(property.value);
+    } else if (keyName === 'tags') {
+      tags = classifyTagsValue(property.value);
+    }
+  }
+
+  if (verdict !== 'true' && verdict !== 'unknown') return false;
+  // Active slots + certain runtime lifetime → registration strips
+  // prerender, so the callsite is certainly runtime-tier. Any uncertainty
+  // (slots or lifetime not statically known) keeps the conservative
+  // attribution.
+  if (slotsActive === 'yes' && (ttl === 'yes' || tags === 'yes')) return false;
+  return true;
+}