@tillhub/schemas 6.465.0 → 6.465.1

package/lib/v0/tags/create.js

@@ -9,7 +9,16 @@ module.exports.request = {
   required: [
     'name'
   ],
-  properties: base
+  properties: {
+    ...base,
+    name: {
+      type: 'string',
+      minLength: 1,
+      not: {
+        pattern: '^\\s|\\s$'
+      }
+    }
+  }
 }
 
 module.exports.response = {

package/lib/v0/tags/update.js

@@ -7,7 +7,16 @@ module.exports.request = {
   additionalProperties: false,
   type: 'object',
   required: [],
-  properties: base
+  properties: {
+    ...base,
+    name: {
+      type: 'string',
+      minLength: 1,
+      not: {
+        pattern: '^\\s|\\s$'
+      }
+    }
+  }
 }
 
 module.exports.response = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tillhub/schemas",
-  "version": "6.465.0",
+  "version": "6.465.1",
   "private": false,
   "description": "All Tillhub API OpenAPI 3 compatible JSON Schemas.",
   "main": "./lib/index.js",

package/test/tags/tags.v0.spec.js

@@ -0,0 +1,42 @@
+const test = require('tape')
+const Ajv = require('ajv')
+const validate = require('../helpers/validate-schema')
+const tags = require('../../lib/v0/tags')
+
+test('Tags: create schema validation', function (t) {
+  t.plan(2)
+  const createRequest = require('../../lib/v0/tags').create.request
+  const { valid, error } = validate(createRequest)
+  t.ok(valid, 'create schema is valid')
+  t.error(error, 'should not get any error')
+  t.end()
+})
+
+test('Tags: update schema validation', function (t) {
+  t.plan(2)
+  const updateRequest = require('../../lib/v0/tags').update.request
+  const { valid, error } = validate(updateRequest)
+  t.ok(valid, 'update schema is valid')
+  t.error(error, 'should not get any error')
+  t.end()
+})
+
+for (const operation of ['create', 'update']) {
+  test(`Tags: ${operation} rejects empty names and surrounding whitespace`, function (t) {
+    const validateRequest = new Ajv().compile(tags[operation].request)
+
+    for (const name of [
+      '', ' ', '\t\n', null, 42,
+      ' green', 'green ', ' green ',
+      '\tgreen', 'green\t', 'green\n', 'green\r\n',
+      '\u00a0green', 'green\u00a0', '\ufeffgreen', 'green\ufeff'
+    ]) {
+      t.notOk(validateRequest({ name }), `rejects name ${JSON.stringify(name)}`)
+    }
+    for (const name of ['g', 'green', 'Grüner Tee', 'Grüner  Tee', '🟢']) {
+      t.ok(validateRequest({ name }), `accepts name ${JSON.stringify(name)}`)
+    }
+    t.equal(validateRequest({ deleted: true }), operation === 'update', 'only updates may omit the name')
+    t.end()
+  })
+}

package/test/tags/tags.v0.specs.js

@@ -1,20 +0,0 @@
-const test = require('tape')
-const validate = require('../helpers/validate-schema')
-
-test('Tags: create schema validation', function (t) {
-  t.plan(2)
-  const createRequest = require('../../lib/v0/tags').create.request
-  const { valid, error } = validate(createRequest)
-  t.ok(valid, 'create schema is valid')
-  t.error(error, 'should not get any error')
-  t.end()
-})
-
-test('Tags: update schema validation', function (t) {
-  t.plan(2)
-  const updateRequest = require('../../lib/v0/tags').update.request
-  const { valid, error } = validate(updateRequest)
-  t.ok(valid, 'update schema is valid')
-  t.error(error, 'should not get any error')
-  t.end()
-})