@tiledesk/tiledesk-tybot-connector 2.0.36-rc12 → 2.0.37

package/CHANGELOG.md

@@ -5,6 +5,9 @@
 available on:
  ▶️ https://www.npmjs.com/package/@tiledesk/tiledesk-tybot-connector
 
+# 2.0.36
+- changed: minimist-string package (ssh problem) in favour of minimist and string-argv packages
+
 # 2.0.29
 - added: support for reranking in DirAskKBV2
 

package/engine/TiledeskChatbot.js

@@ -43,60 +43,48 @@ class TiledeskChatbot {
   }
 
   async replyToMessage(message, callback) {
-    console.log(`(GAB) TiledeskChatbot replyToMessage start -->  at : ${new Date().getTime()} for message.sender: ${message.sender} with text: ${message.text}`)
     return new Promise( async (resolve, reject) => {
       let lead = null;
       if (message.request) {
         this.request = message.request;
       }
       
-
-      let start00 = new Date();
+      // reset lockedIntent on direct user invocation ( /intent or action => this only?)
       if (message.sender != "_tdinternal") {
         try {
-          winston.verbose("(TiledeskChatbot) External user message, running reset operations…");
-          const ops = [];
-
-          // --- Action/intent reset ---
-          // reset lockedIntent on direct user invocation ( /intent or action => this only?)
-          if (message.attributes?.action) {
-            winston.debug("(TiledeskChatbot) Message has action: " + message.attributes.action);
-            ops.push(this.unlockIntent(this.requestId), this.unlockAction(this.requestId));
-            winston.debug("(TiledeskChatbot) Reset locked intent. Intent was explicitly invoked with an action: " + message.attributes.action);
+          winston.verbose("(TiledeskChatbot) Checking locked intent reset on action invocation")
+          if (message.attributes && message.attributes.action) {
+            winston.debug("(TiledeskChatbot) Message has action: " + message.attributes.action)
+            await this.unlockIntent(this.requestId);
+            await this.unlockAction(this.requestId);
+            winston.debug("(TiledeskChatbot) Reset locked intent. Intent was explicitly invoked with an action: " + message.attributes.action)
           }
+        } catch(error) {
+          winston.error("(TiledeskChatbot) Error resetting locked intent: ", error)
+        }
+      }
 
-          // --- Steps reset ---
-          // any external invocation restarts the steps counter
+      // any external invocation restarts the steps counter
+      try {
+        if (message.sender != "_tdinternal") {
           winston.verbose("(TiledeskChatbot) Resetting current step by request message: " + message.text);
-          ops.push(
-            TiledeskChatbot.resetStep(this.tdcache, this.requestId),
-            TiledeskChatbot.resetStarted(this.tdcache, this.requestId)
-          );
+          await TiledeskChatbot.resetStep(this.tdcache, this.requestId);
+          await TiledeskChatbot.resetStarted(this.tdcache, this.requestId);
 
-          await Promise.all(ops);
-
-          // --- Debug final state ---
           if (this.tdcache) {
-            const currentStep = await TiledeskChatbot.currentStep(this.tdcache, this.requestId);
+            let currentStep = 
+            await TiledeskChatbot.currentStep(this.tdcache, this.requestId);
             winston.verbose("(TiledeskChatbot) After reset currentStep:" + currentStep);
           }
-
-        } catch (error) {
-          winston.error("(TiledeskChatbot) Error resetting locked intent: ", error)
+          
         }
+      } catch(error) {
+        winston.error("(TiledeskChatbot) Error resetting locked intent: ", error);
       }
-      let end00 = new Date()
-      console.log(`(GAB) TiledeskChatbot replyToMessage 00--> after reset lockedIntent at :  ${end00.getTime()}, diff: ${end00-start00}[ms]`)
-       
-
 
       // Checking locked intent (for non-internal intents)
       // internal intents always "skip" the locked intent
-      let start0 = new Date()
       const locked_intent = await this.currentLockedIntent(this.requestId);
-      let end0 = new Date()
-      console.log(`(GAB) TiledeskChatbot replyToMessage 0--> after currentLockedIntent at :  ${end0.getTime()}, diff: ${end0-start0}[ms]`)
-        
       winston.verbose("(TiledeskChatbot) Got locked intent: -" + locked_intent + "-");
       if (locked_intent) {
         // const tdclient = new TiledeskClient({
@@ -107,18 +95,11 @@ class TiledeskChatbot {
         // });
         // it only gets the locked_intent
         // const faq = await this.botsDataSource.getByIntentDisplayName(this.botId, locked_intent);
-        let start0 = new Date()
         const faq = await this.botsDataSource.getByIntentDisplayNameCache(this.botId, locked_intent, this.tdcache);
-        let end0 = new Date()
-        console.log(`(GAB) TiledeskChatbot replyToMessage 1-> after botsDataSource.getByIntentDisplayNameCache at :  ${end0.getTime()}, diff: ${end0-start0}[ms]`)
         winston.debug("(TiledeskChatbot) Locked intent. Got faqs: ", faq);
         let reply;
         if (faq) {
-          let start1 = new Date()
           reply = await this.execIntent(faq, message, lead);//, bot);
-          let end1 = new Date()
-          console.log(`(GAB) TiledeskChatbot replyToMessage 1--> after execIntent at :  ${end1.getTime()}, diff: ${end1-start1}[ms]`)
-        
         }
         else {
           reply = {
@@ -167,10 +148,7 @@ class TiledeskChatbot {
         }
         else {
           winston.verbose("(TiledeskChatbot) Processing intent:", explicit_intent_name)
-          let start2 = new Date()
           let faq = await this.botsDataSource.getByIntentDisplayNameCache(this.botId, intent.name, this.tdcache);
-          let end2 = new Date()
-          console.log(`(GAB) TiledeskChatbot replyToMessage 2--> after botsDataSource.getByIntentDisplayNameCache at :  ${end2.getTime()}, diff: ${end2-start2}[ms]`)
           if (faq) {
             winston.verbose("(TiledeskChatbot) Got a reply (faq) by Intent name:", faq)
             try {
@@ -180,11 +158,7 @@ class TiledeskChatbot {
                   this.addParameter(key, value);                  
                 }
               }
-              let start2 = new Date();
               reply = await this.execIntent(faq, message, lead);
-              let end2 = new Date()
-              console.log(`(GAB) TiledeskChatbot replyToMessage 2--> after execIntent at :  ${end2.getTime()}, diff: ${end2-start2}[ms]`)
-        
               resolve(reply);
               return;
             }
@@ -215,11 +189,7 @@ class TiledeskChatbot {
         let reply;
         const faq = faqs[0];
         try {
-          let start3 = new Date();
           reply = await this.execIntent(faq, message, lead);//, bot);
-          let end3 = new Date()
-          console.log(`(GAB) TiledeskChatbot replyToMessage 3--> after execIntent at :  ${end3.getTime()}, diff: ${end3-start3}[ms]`)
-        
         }
         catch(error) {
           winston.error("(TiledeskChatbot) An error occured during exact match execIntent(): ", error);
@@ -247,18 +217,10 @@ class TiledeskChatbot {
         }
         winston.debug("(TiledeskChatbot) NLP intents found: ", intents);
         if (intents && intents.length > 0) {
-          let start2 = new Date();
           let faq = await this.botsDataSource.getByIntentDisplayNameCache(this.botId, intents[0].intent_display_name, this.tdcache);
-          let end2 = new Date()
-          console.log(`(GAB) TiledeskChatbot replyToMessage 4--> after botsDataSource.getByIntentDisplayNameCache in if at :  ${end2.getTime()}, diff: ${end2-start2}[ms]`)
-        
           let reply;
           try {
-            let start3 = new Date();
             reply = await this.execIntent(faq, message, lead);//, bot);
-            let end3 = new Date()
-            console.log(`(GAB) TiledeskChatbot replyToMessage 4--> after execIntent in if at :  ${end3.getTime()}, diff: ${end3-start3}[ms]`)
-        
           }
           catch(error) {
             winston.error("(TiledeskChatbot) An error occurred during NLP decoding: ", error);
@@ -269,11 +231,7 @@ class TiledeskChatbot {
           return;
         }
         else {
-          let start4 = new Date();
           let fallbackIntent = await this.botsDataSource.getByIntentDisplayNameCache(this.botId, "defaultFallback", this.tdcache);
-          let end4 = new Date()
-          console.log(`(GAB) TiledeskChatbot replyToMessage 5--> after execIntent in else at :  ${end4.getTime()}, diff: ${end4-start4}[ms]`)
-        
           if (!fallbackIntent) {
             resolve(null);
             return;
@@ -281,11 +239,7 @@ class TiledeskChatbot {
           else {
             let reply;
             try {
-              let start5 = new Date()
               reply = await this.execIntent(fallbackIntent, message, lead);//, bot);
-              let end5 = new Date()
-              console.log(`(GAB) TiledeskChatbot replyToMessage 5--> after execIntent  at :  ${end5.getTime()}, diff: ${end5-start5}[ms]`)
-        
             }
             catch(error) {
               winston.error("(TiledeskChatbot) An error occurred during defaultFallback: ", error);

package/engine/TiledeskChatbotConst.js

@@ -40,8 +40,6 @@ class TiledeskChatbotConst {
     static REQ_LAST_USER_IMAGE_HEIGHT = 'lastUserImageHeight';
     static REQ_LAST_USER_IMAGE_TYPE = 'lastUserImageType';
     static REQ_LAST_USER_DOCUMENT_URL = 'lastUserDocumentURL';
-    static REQ_LAST_USER_DOCUMENT_AS_ATTACHMENT_URL = 'lastUserDocumentAsAttachmentURL';
-    static REQ_LAST_USER_DOCUMENT_AS_INLINE_URL = 'lastUserDocumentAsInlineURL';
     static REQ_LAST_USER_DOCUMENT_NAME = 'lastUserDocumentName';
     static REQ_LAST_USER_DOCUMENT_TYPE = 'lastUserDocumentType';
     static REQ_EMAIL_ATTACHMENTS_LINK = 'link';

package/index.js

@@ -43,7 +43,6 @@ let staticBots;
 
 router.post('/ext/:botid', async (req, res) => {
   const botId = req.params.botid;
-  console.log(`(GAB) /ext/${botId} 0--> called at : ${new Date().getTime()}`)
   winston.verbose("(tybotRoute) POST /ext/:botid called: " + botId)
   if(!botId || botId === "null" || botId === "undefined"){
     return res.status(400).send({"success": false, error: "Required parameters botid not found. Value is 'null' or 'undefined'"})
@@ -91,7 +90,6 @@ router.post('/ext/:botid', async (req, res) => {
     {EX: 604800} // 7 days
   );
 
-  let start0 = new Date()
   let botsDS;
   if (!staticBots) {
     botsDS = new MongodbBotsDataSource({projectId: projectId, botId: botId});
@@ -100,20 +98,13 @@ router.post('/ext/:botid', async (req, res) => {
   else {
     botsDS = new MockBotsDataSource(staticBots);
   }
-  let end0 = new Date()
-  console.log(`(GAB) /ext/${botId} 1--> after get MongodbBotsDataSource at :  ${end0.getTime()}, diff: ${end0-start0}[ms]`)
-  
   
   // get the bot metadata
-  let start1 = new Date()
   let bot = await botsDS.getBotByIdCache(botId, tdcache).catch((err)=> {
     Promise.reject(err);
     return;
   });
-  let end1 = new Date()
-  console.log(`(GAB) /ext/${botId} 2--> after get botsDS.getBotByIdCache at :  ${end1.getTime()}, diff: ${end1-start1}[ms]`)
   
-  let start2 = new Date()
   let intentsMachine;
   let backupMachine;
   if (!staticBots) {
@@ -124,8 +115,6 @@ router.post('/ext/:botid', async (req, res) => {
   else {
     intentsMachine = {}
   }
-  let end2 = new Date()
-  console.log(`(GAB) /ext/${botId} 3--> after get IntentsMachineFactory.getMachine at :  ${end2.getTime()}, diff: ${end2-start2}[ms]`)
 
   const chatbot = new TiledeskChatbot({
     botsDataSource: botsDS,
@@ -144,23 +133,14 @@ router.post('/ext/:botid', async (req, res) => {
   });
   winston.verbose("(tybotRoute) Message text: " + message.text)
   
-  let start3 = new Date()
   await TiledeskChatbotUtil.updateRequestAttributes(chatbot, token, message, projectId, requestId);
-  let end3 = new Date()
-  console.log(`(GAB) /ext/${botId} 4--> after get TiledeskChatbotUtil.updateRequestAttributes at :  ${end3.getTime()}, diff: ${end3-start3}[ms]`)
   if (requestId.startsWith("support-group-")) {
     await TiledeskChatbotUtil.updateConversationTranscript(chatbot, message);
   }
-  let end4 = new Date()
-  console.log(`(GAB) /ext/${botId} 5--> after get TiledeskChatbotUtil.updateConversationTranscript at :  ${end4.getTime()}, diff: ${end4-end3}[ms]`)
-  
 
   let reply = null;
   try {
-    let start5 = new Date()
     reply = await chatbot.replyToMessage(message);
-    let end5 = new Date()
-    console.log(`(GAB) /ext/${botId} 6--> after chatbot.replyToMessage at :  ${end5.getTime()}, diff: ${end5-start5}[ms]`)
   }
   catch(err) {
     winston.error("(tybotRoute) An error occurred replying to message: ", err);
@@ -171,16 +151,11 @@ router.post('/ext/:botid', async (req, res) => {
     return;
   }
   
-  
   if (reply.actions && reply.actions.length > 0) { // structured actions (coming from chatbot designer)
     try {
-      let start6 = new Date()
       winston.debug("(tybotRoute) Reply actions: ", reply.actions)
       let directives = TiledeskChatbotUtil.actionsToDirectives(reply.actions);
       winston.debug("(tybotRoute) the directives:", directives)
-      let end6 = new Date()
-      console.log(`(GAB) /ext/${botId} 7--> after TiledeskChatbotUtil.actionsToDirectives at :  ${end6.getTime()}, diff: ${end6-start6}[ms]`)
-  
       let directivesPlug = new DirectivesChatbotPlug(
         {
           message: message,
@@ -195,7 +170,6 @@ router.post('/ext/:botid', async (req, res) => {
           cache: tdcache
         }
       );
-      console.log(`(GAB) /ext/${botId} 8--> directivesPlug.processDirectives at :  ${end6.getTime()}`)
       directivesPlug.processDirectives( () => {
         winston.verbose("(tybotRoute) Actions - Directives executed.");
       });